)]}'
{"watcher/decision_engine/strategy/strategies/workload_stabilization.py":[{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"e6242da6ad8687388e519a9928cc9d3f356970f8","unresolved":false,"context_lines":[{"line_number":410,"context_line":"            c_nodes.remove(src_host)"},{"line_number":411,"context_line":"            node_list \u003d yield_nodes(c_nodes)"},{"line_number":412,"context_line":"            for instance in self.compute_model.get_node_instances(src_node):"},{"line_number":413,"context_line":"                min_sd_case \u003d {\u0027value\u0027: self.get_current_weighted_sd(hosts)}"},{"line_number":414,"context_line":"                if instance.state not in [element.InstanceState.ACTIVE.value,"},{"line_number":415,"context_line":"                                          element.InstanceState.PAUSED.value]:"},{"line_number":416,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf8cb3f7_b381474d","line":413,"range":{"start_line":413,"start_character":40,"end_line":413,"end_character":75},"updated":"2017-12-25 12:21:58.000000000","message":"Shouldn\u0027t we get it outside of for loop? hosts dict won\u0027t be changed, so get_current_weighted_sd should return the same value every time.","commit_id":"358c5ee2056701be8888314438decb7c36130834"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"b9d925d21c1160caca66214795dd0cc6544a3e3d","unresolved":false,"context_lines":[{"line_number":410,"context_line":"            c_nodes.remove(src_host)"},{"line_number":411,"context_line":"            node_list \u003d yield_nodes(c_nodes)"},{"line_number":412,"context_line":"            for instance in self.compute_model.get_node_instances(src_node):"},{"line_number":413,"context_line":"                min_sd_case \u003d {\u0027value\u0027: self.get_current_weighted_sd(hosts)}"},{"line_number":414,"context_line":"                if instance.state not in [element.InstanceState.ACTIVE.value,"},{"line_number":415,"context_line":"                                          element.InstanceState.PAUSED.value]:"},{"line_number":416,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf8cb3f7_643a1735","line":413,"range":{"start_line":413,"start_character":40,"end_line":413,"end_character":75},"in_reply_to":"bf8cb3f7_b381474d","updated":"2017-12-26 02:03:14.000000000","message":"yes, you are right.","commit_id":"358c5ee2056701be8888314438decb7c36130834"}]}
