)]}'
{"watcher/api/controllers/v1/action_plan.py":[{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"20ef35e4f2d89839bfe743665d690cda28c49b38","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                                     sort_key, sort_dir, expand\u003dFalse,"},{"line_number":334,"context_line":"                                     resource_url\u003dNone, audit_uuid\u003dNone,"},{"line_number":335,"context_line":"                                     strategy\u003dNone):"},{"line_number":336,"context_line":"        additional_fields \u003d [\u0027audit_uuid\u0027, \u0027strategy_uuid\u0027, \u0027strategy_name\u0027]"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        api_utils.validate_sort_key("},{"line_number":339,"context_line":"            sort_key, list(objects.ActionPlan.fields) + additional_fields)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_cdca5b19","line":336,"range":{"start_line":336,"start_character":44,"end_line":336,"end_character":57},"updated":"2018-03-19 02:56:14.000000000","message":"It isn\u0027t in list fileds.","commit_id":"71e10fe446695197696c4604ddc4d34841a607ea"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"88680eeff97ee167cfa8be4d45722cc329be7531","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                                     sort_key, sort_dir, expand\u003dFalse,"},{"line_number":334,"context_line":"                                     resource_url\u003dNone, audit_uuid\u003dNone,"},{"line_number":335,"context_line":"                                     strategy\u003dNone):"},{"line_number":336,"context_line":"        additional_fields \u003d [\u0027audit_uuid\u0027, \u0027strategy_uuid\u0027, \u0027strategy_name\u0027]"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        api_utils.validate_sort_key("},{"line_number":339,"context_line":"            sort_key, list(objects.ActionPlan.fields) + additional_fields)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_c29e8153","line":336,"range":{"start_line":336,"start_character":44,"end_line":336,"end_character":57},"in_reply_to":"df7087c5_cdca5b19","updated":"2018-03-20 09:34:37.000000000","message":"These fields exist on API side. This patch allows to sort by these fields along with object ones.","commit_id":"71e10fe446695197696c4604ddc4d34841a607ea"},{"author":{"_account_id":27947,"name":"Egor Panfilov","email":"edpanfilov@sbcloud.ru","username":"erakli"},"change_message_id":"07570096ed2933e6eca07787a6a8fa304c6ae7fa","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                                     sort_key, sort_dir, expand\u003dFalse,"},{"line_number":334,"context_line":"                                     resource_url\u003dNone, audit_uuid\u003dNone,"},{"line_number":335,"context_line":"                                     strategy\u003dNone):"},{"line_number":336,"context_line":"        additional_fields \u003d [\u0027audit_uuid\u0027, \u0027strategy_uuid\u0027, \u0027strategy_name\u0027]"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        api_utils.validate_sort_key("},{"line_number":339,"context_line":"            sort_key, list(objects.ActionPlan.fields) + additional_fields)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_9102153e","line":336,"range":{"start_line":336,"start_character":44,"end_line":336,"end_character":57},"in_reply_to":"df7087c5_cdca5b19","updated":"2018-03-20 13:28:17.000000000","message":"This field exists in ActionPlan(base.APIBase) class","commit_id":"71e10fe446695197696c4604ddc4d34841a607ea"}],"watcher/api/controllers/v1/audit.py":[{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"20ef35e4f2d89839bfe743665d690cda28c49b38","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                               sort_key, sort_dir, expand\u003dFalse,"},{"line_number":417,"context_line":"                               resource_url\u003dNone, goal\u003dNone,"},{"line_number":418,"context_line":"                               strategy\u003dNone):"},{"line_number":419,"context_line":"        additional_fields \u003d [\"goal_uuid\", \"goal_name\", \"strategy_uuid\","},{"line_number":420,"context_line":"                             \"strategy_name\"]"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        api_utils.validate_sort_key("},{"line_number":423,"context_line":"            sort_key, list(objects.Audit.fields) + additional_fields)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_6d5a2f84","line":420,"range":{"start_line":419,"start_character":29,"end_line":420,"end_character":44},"updated":"2018-03-19 02:56:14.000000000","message":"\u0027goal_uuid\u0027 and \u0027stratgy_uuid\u0027 aren\u0027t in list fields, refer to https://github.com/openstack/python-watcherclient/blob/master/watcherclient/v1/resource_fields.py#L33\nSo they will never appear, I think they should be removed.\nIf running \u0027watcher audit list --sort-key goal_uuid\u0027\nthere are error log:\n\u0027goal_uuid is an invalid field for sorting, valid values for --sort-key are:\u0027","commit_id":"71e10fe446695197696c4604ddc4d34841a607ea"},{"author":{"_account_id":27947,"name":"Egor Panfilov","email":"edpanfilov@sbcloud.ru","username":"erakli"},"change_message_id":"07570096ed2933e6eca07787a6a8fa304c6ae7fa","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                               sort_key, sort_dir, expand\u003dFalse,"},{"line_number":417,"context_line":"                               resource_url\u003dNone, goal\u003dNone,"},{"line_number":418,"context_line":"                               strategy\u003dNone):"},{"line_number":419,"context_line":"        additional_fields \u003d [\"goal_uuid\", \"goal_name\", \"strategy_uuid\","},{"line_number":420,"context_line":"                             \"strategy_name\"]"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        api_utils.validate_sort_key("},{"line_number":423,"context_line":"            sort_key, list(objects.Audit.fields) + additional_fields)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_61276e66","line":420,"range":{"start_line":419,"start_character":29,"end_line":420,"end_character":44},"in_reply_to":"df7087c5_6d5a2f84","updated":"2018-03-20 13:28:17.000000000","message":"All these fields present on API side so this function should consider them too.","commit_id":"71e10fe446695197696c4604ddc4d34841a607ea"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"88680eeff97ee167cfa8be4d45722cc329be7531","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                               sort_key, sort_dir, expand\u003dFalse,"},{"line_number":417,"context_line":"                               resource_url\u003dNone, goal\u003dNone,"},{"line_number":418,"context_line":"                               strategy\u003dNone):"},{"line_number":419,"context_line":"        additional_fields \u003d [\"goal_uuid\", \"goal_name\", \"strategy_uuid\","},{"line_number":420,"context_line":"                             \"strategy_name\"]"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        api_utils.validate_sort_key("},{"line_number":423,"context_line":"            sort_key, list(objects.Audit.fields) + additional_fields)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_22897d25","line":420,"range":{"start_line":419,"start_character":29,"end_line":420,"end_character":44},"in_reply_to":"df7087c5_6d5a2f84","updated":"2018-03-20 09:34:37.000000000","message":"goal_uuid and strategy_uuid returns in API request and cut off on client side. Here is the example of returned audit (via \"watcher audit list --debug\"):\n{\n\t\"interval\": null,\n\t\"next_run_time\": null,\n\t\"strategy_uuid\": \"2bc05523-0b2e-4f29-9930-af71f9a93228\",\n\t\"goal_uuid\": \"87d52927-47af-4ce2-8d49-34236702a3f7\",\n\t\"scope\": [],\n\t\"audit_type\": \"ONESHOT\",\n\t\"goal_name\": \"workload_balancing\",\n\t\"state\": \"CANCELLED\",\n\t\"links\": [{\n\t\t\"rel\": \"self\",\n\t\t\"href\": \"http://controller:9322/v1/audits/37c37384-4967-4539-8ab0-63d2aaf8567c\"\n\t}, {\n\t\t\"rel\": \"bookmark\",\n\t\t\"href\": \"http://controller:9322/audits/37c37384-4967-4539-8ab0-63d2aaf8567c\"\n\t}],\n\t\"uuid\": \"37c37384-4967-4539-8ab0-63d2aaf8567c\",\n\t\"auto_trigger\": false,\n\t\"name\": \"workload_stabilization-2018-02-28T10:46:29.201241\",\n\t\"strategy_name\": \"workload_stabilization\"\n}","commit_id":"71e10fe446695197696c4604ddc4d34841a607ea"}],"watcher/api/controllers/v1/audit_template.py":[{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"20ef35e4f2d89839bfe743665d690cda28c49b38","unresolved":false,"context_lines":[{"line_number":474,"context_line":"    def _get_audit_templates_collection(self, filters, marker, limit,"},{"line_number":475,"context_line":"                                        sort_key, sort_dir, expand\u003dFalse,"},{"line_number":476,"context_line":"                                        resource_url\u003dNone):"},{"line_number":477,"context_line":"        additional_fields \u003d [\"goal_uuid\", \"goal_name\", \"strategy_uuid\","},{"line_number":478,"context_line":"                             \"strategy_name\"]"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"        api_utils.validate_sort_key("},{"line_number":481,"context_line":"            sort_key, list(objects.AuditTemplate.fields) + additional_fields)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_ad612714","line":478,"range":{"start_line":477,"start_character":29,"end_line":478,"end_character":44},"updated":"2018-03-19 02:56:14.000000000","message":"ditto","commit_id":"71e10fe446695197696c4604ddc4d34841a607ea"},{"author":{"_account_id":27947,"name":"Egor Panfilov","email":"edpanfilov@sbcloud.ru","username":"erakli"},"change_message_id":"07570096ed2933e6eca07787a6a8fa304c6ae7fa","unresolved":false,"context_lines":[{"line_number":474,"context_line":"    def _get_audit_templates_collection(self, filters, marker, limit,"},{"line_number":475,"context_line":"                                        sort_key, sort_dir, expand\u003dFalse,"},{"line_number":476,"context_line":"                                        resource_url\u003dNone):"},{"line_number":477,"context_line":"        additional_fields \u003d [\"goal_uuid\", \"goal_name\", \"strategy_uuid\","},{"line_number":478,"context_line":"                             \"strategy_name\"]"},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"        api_utils.validate_sort_key("},{"line_number":481,"context_line":"            sort_key, list(objects.AuditTemplate.fields) + additional_fields)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_c1d51a1d","line":478,"range":{"start_line":477,"start_character":29,"end_line":478,"end_character":44},"in_reply_to":"df7087c5_ad612714","updated":"2018-03-20 13:28:17.000000000","message":"Same applies here","commit_id":"71e10fe446695197696c4604ddc4d34841a607ea"}],"watcher/api/controllers/v1/utils.py":[{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"05675251629a65f3cd9fa8bd90f6eb97a24a9d8d","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def validate_sort_key(sort_key, allowed_fields):"},{"line_number":60,"context_line":"    # Very lightweight validation for now"},{"line_number":61,"context_line":"    # todo: improve this (e.g. https://www.parse.com/docs/rest/guide/#queries)"},{"line_number":62,"context_line":"    if sort_key not in allowed_fields:"},{"line_number":63,"context_line":"        raise wsme.exc.ClientSideError("},{"line_number":64,"context_line":"            _(\"Invalid sort key: %s\") % sort_key)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_62c45541","line":61,"range":{"start_line":61,"start_character":6,"end_line":61,"end_character":10},"updated":"2018-03-20 09:48:46.000000000","message":"TODO(your_name): ...","commit_id":"71e10fe446695197696c4604ddc4d34841a607ea"},{"author":{"_account_id":27947,"name":"Egor Panfilov","email":"edpanfilov@sbcloud.ru","username":"erakli"},"change_message_id":"07570096ed2933e6eca07787a6a8fa304c6ae7fa","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def validate_sort_key(sort_key, allowed_fields):"},{"line_number":60,"context_line":"    # Very lightweight validation for now"},{"line_number":61,"context_line":"    # todo: improve this (e.g. https://www.parse.com/docs/rest/guide/#queries)"},{"line_number":62,"context_line":"    if sort_key not in allowed_fields:"},{"line_number":63,"context_line":"        raise wsme.exc.ClientSideError("},{"line_number":64,"context_line":"            _(\"Invalid sort key: %s\") % sort_key)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_014f9234","line":61,"range":{"start_line":61,"start_character":6,"end_line":61,"end_character":10},"in_reply_to":"df7087c5_62c45541","updated":"2018-03-20 13:28:17.000000000","message":"Removed, because it\u0027s copypaste","commit_id":"71e10fe446695197696c4604ddc4d34841a607ea"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"05675251629a65f3cd9fa8bd90f6eb97a24a9d8d","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def make_api_sort(sorting_list, sort_key, sort_dir):"},{"line_number":81,"context_line":"    # First sort by id field, than sort by sort_key"},{"line_number":82,"context_line":"    # sorted() guarantees to do stable sort, so we could"},{"line_number":83,"context_line":"    # make lexicographical sort"},{"line_number":84,"context_line":"    reverse_direction \u003d (sort_dir \u003d\u003d \u0027desc\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_4266f153","line":81,"range":{"start_line":81,"start_character":20,"end_line":81,"end_character":22},"updated":"2018-03-20 09:48:46.000000000","message":"s/id/uuid","commit_id":"71e10fe446695197696c4604ddc4d34841a607ea"},{"author":{"_account_id":27947,"name":"Egor Panfilov","email":"edpanfilov@sbcloud.ru","username":"erakli"},"change_message_id":"07570096ed2933e6eca07787a6a8fa304c6ae7fa","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def make_api_sort(sorting_list, sort_key, sort_dir):"},{"line_number":81,"context_line":"    # First sort by id field, than sort by sort_key"},{"line_number":82,"context_line":"    # sorted() guarantees to do stable sort, so we could"},{"line_number":83,"context_line":"    # make lexicographical sort"},{"line_number":84,"context_line":"    reverse_direction \u003d (sort_dir \u003d\u003d \u0027desc\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_a15fc6e3","line":81,"range":{"start_line":81,"start_character":20,"end_line":81,"end_character":22},"in_reply_to":"df7087c5_4266f153","updated":"2018-03-20 13:28:17.000000000","message":"Done","commit_id":"71e10fe446695197696c4604ddc4d34841a607ea"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"05675251629a65f3cd9fa8bd90f6eb97a24a9d8d","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def make_api_sort(sorting_list, sort_key, sort_dir):"},{"line_number":81,"context_line":"    # First sort by id field, than sort by sort_key"},{"line_number":82,"context_line":"    # sorted() guarantees to do stable sort, so we could"},{"line_number":83,"context_line":"    # make lexicographical sort"},{"line_number":84,"context_line":"    reverse_direction \u003d (sort_dir \u003d\u003d \u0027desc\u0027)"},{"line_number":85,"context_line":"    sorting_list.sort(key\u003dattrgetter(\u0027uuid\u0027), reverse\u003dreverse_direction)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_423591f6","line":82,"range":{"start_line":82,"start_character":15,"end_line":82,"end_character":43},"updated":"2018-03-20 09:48:46.000000000","message":"Wouldn\u0027t it be better to use \"ensures stable sorting\"?","commit_id":"71e10fe446695197696c4604ddc4d34841a607ea"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"05675251629a65f3cd9fa8bd90f6eb97a24a9d8d","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def make_api_sort(sorting_list, sort_key, sort_dir):"},{"line_number":81,"context_line":"    # First sort by id field, than sort by sort_key"},{"line_number":82,"context_line":"    # sorted() guarantees to do stable sort, so we could"},{"line_number":83,"context_line":"    # make lexicographical sort"},{"line_number":84,"context_line":"    reverse_direction \u003d (sort_dir \u003d\u003d \u0027desc\u0027)"},{"line_number":85,"context_line":"    sorting_list.sort(key\u003dattrgetter(\u0027uuid\u0027), reverse\u003dreverse_direction)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_22ef3d88","line":82,"range":{"start_line":82,"start_character":6,"end_line":82,"end_character":12},"updated":"2018-03-20 09:48:46.000000000","message":"s/sorted/sort","commit_id":"71e10fe446695197696c4604ddc4d34841a607ea"},{"author":{"_account_id":27947,"name":"Egor Panfilov","email":"edpanfilov@sbcloud.ru","username":"erakli"},"change_message_id":"07570096ed2933e6eca07787a6a8fa304c6ae7fa","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def make_api_sort(sorting_list, sort_key, sort_dir):"},{"line_number":81,"context_line":"    # First sort by id field, than sort by sort_key"},{"line_number":82,"context_line":"    # sorted() guarantees to do stable sort, so we could"},{"line_number":83,"context_line":"    # make lexicographical sort"},{"line_number":84,"context_line":"    reverse_direction \u003d (sort_dir \u003d\u003d \u0027desc\u0027)"},{"line_number":85,"context_line":"    sorting_list.sort(key\u003dattrgetter(\u0027uuid\u0027), reverse\u003dreverse_direction)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_6159aefc","line":82,"range":{"start_line":82,"start_character":6,"end_line":82,"end_character":12},"in_reply_to":"df7087c5_22ef3d88","updated":"2018-03-20 13:28:17.000000000","message":"Done","commit_id":"71e10fe446695197696c4604ddc4d34841a607ea"},{"author":{"_account_id":27947,"name":"Egor Panfilov","email":"edpanfilov@sbcloud.ru","username":"erakli"},"change_message_id":"07570096ed2933e6eca07787a6a8fa304c6ae7fa","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def make_api_sort(sorting_list, sort_key, sort_dir):"},{"line_number":81,"context_line":"    # First sort by id field, than sort by sort_key"},{"line_number":82,"context_line":"    # sorted() guarantees to do stable sort, so we could"},{"line_number":83,"context_line":"    # make lexicographical sort"},{"line_number":84,"context_line":"    reverse_direction \u003d (sort_dir \u003d\u003d \u0027desc\u0027)"},{"line_number":85,"context_line":"    sorting_list.sort(key\u003dattrgetter(\u0027uuid\u0027), reverse\u003dreverse_direction)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_0130f2e7","line":82,"range":{"start_line":82,"start_character":15,"end_line":82,"end_character":43},"in_reply_to":"df7087c5_423591f6","updated":"2018-03-20 13:28:17.000000000","message":"Yeah, it would","commit_id":"71e10fe446695197696c4604ddc4d34841a607ea"}]}
