)]}'
{"watcher/applier/actions/migration.py":[{"author":{"_account_id":27947,"name":"Egor Panfilov","email":"edpanfilov@sbcloud.ru","username":"erakli"},"change_message_id":"f66b5596584e12fb07491a420f55d36a3b7abad3","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    source and the destination compute hostname (list of available compute"},{"line_number":51,"context_line":"    hosts is returned by this command: ``nova service-list --binary"},{"line_number":52,"context_line":"    nova-compute``)."},{"line_number":53,"context_line":"    Nova API version must be 2.56 or above if `destination_node` parameter"},{"line_number":54,"context_line":"    given."},{"line_number":55,"context_line":"    \"\"\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    # input parameters constants"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_4c69c6f5","line":54,"range":{"start_line":53,"start_character":4,"end_line":54,"end_character":10},"updated":"2018-04-12 17:57:19.000000000","message":"If it is the only place where we warn user about API version it need to be placed in \".. note::\" section.","commit_id":"683840ad8b23f3974ba520666ad0c1caa7e45d33"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"01ba172a89f944fe4a258a1010628c78c7a3ac37","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    source and the destination compute hostname (list of available compute"},{"line_number":51,"context_line":"    hosts is returned by this command: ``nova service-list --binary"},{"line_number":52,"context_line":"    nova-compute``)."},{"line_number":53,"context_line":"    Nova API version must be 2.56 or above if `destination_node` parameter"},{"line_number":54,"context_line":"    given."},{"line_number":55,"context_line":"    \"\"\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    # input parameters constants"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_f0817dfc","line":54,"range":{"start_line":53,"start_character":4,"end_line":54,"end_character":10},"in_reply_to":"bf659307_4c69c6f5","updated":"2018-04-13 03:27:55.000000000","message":"Done","commit_id":"683840ad8b23f3974ba520666ad0c1caa7e45d33"}],"watcher/common/nova_helper.py":[{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"da4f656bf1e343689e4d5d50a01e06c2fa63dfd8","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                                          retry\u003d120):"},{"line_number":136,"context_line":"        \"\"\"This method migrates a given instance"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        This method uses the Nova built-in migrate()"},{"line_number":139,"context_line":"        action to do a migration of a given instance."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        It returns True if the migration was successful,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_d1af02e1","line":138,"range":{"start_line":138,"start_character":25,"end_line":138,"end_character":52},"updated":"2018-03-28 03:06:18.000000000","message":"It\u0027s better to add a tip about nova api version.\nand now the default nova api version is 2.53 in conf/nova_client.py. I propose to update to 2.56","commit_id":"7914f97a08cf3158517ea6ae3133a387a65841f2"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"ce3685e5dc3df4c2969620840e2e3b89512d27c3","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                                          retry\u003d120):"},{"line_number":136,"context_line":"        \"\"\"This method migrates a given instance"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        This method uses the Nova built-in migrate()"},{"line_number":139,"context_line":"        action to do a migration of a given instance."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        It returns True if the migration was successful,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_cdaa02d1","line":138,"range":{"start_line":138,"start_character":25,"end_line":138,"end_character":52},"in_reply_to":"bf659307_d1af02e1","updated":"2018-03-28 08:42:41.000000000","message":"I agreed to add a comment about nova api version. I will update.\nThis patch includes updating Nova API version to 2.56 in conf/nova_client.py","commit_id":"7914f97a08cf3158517ea6ae3133a387a65841f2"}],"watcher/tests/common/test_nova_helper.py":[{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"27424275456d38a92107de11b3b825c17e2c8fd8","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        self.assertFalse(is_success)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, mock.Mock())"},{"line_number":214,"context_line":"    def test_watcher_non_live_migrate_instance_volume("},{"line_number":215,"context_line":"            self, mock_glance, mock_cinder, mock_neutron, mock_nova):"},{"line_number":216,"context_line":"        nova_util \u003d nova_helper.NovaHelper()"},{"line_number":217,"context_line":"        nova_servers \u003d nova_util.nova.servers"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_68102158","side":"PARENT","line":214,"range":{"start_line":214,"start_character":8,"end_line":214,"end_character":37},"updated":"2018-04-03 02:04:33.000000000","message":"There are no unittests for watcher_non_live_migrate_instance.\nIt\u0027s better to add new unittests.","commit_id":"b0bdeea7cf4cda15aa003bee3c23b69c3cf2e8fa"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"c0320697f7c0444b1b941d0ec959cd8064076515","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        self.assertFalse(is_success)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, mock.Mock())"},{"line_number":214,"context_line":"    def test_watcher_non_live_migrate_instance_volume("},{"line_number":215,"context_line":"            self, mock_glance, mock_cinder, mock_neutron, mock_nova):"},{"line_number":216,"context_line":"        nova_util \u003d nova_helper.NovaHelper()"},{"line_number":217,"context_line":"        nova_servers \u003d nova_util.nova.servers"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_8b3ecfb5","side":"PARENT","line":214,"range":{"start_line":214,"start_character":8,"end_line":214,"end_character":37},"in_reply_to":"bf659307_68102158","updated":"2018-04-03 02:14:22.000000000","message":"No, we still have two unittests.\n\n1. test_watcher_non_live_migrate_instance_not_found\nhttps://github.com/openstack/watcher/blob/master/watcher/tests/common/test_nova_helper.py#L202\n\n2. test_non_live_migrate_instance_no_destination_node\nhttps://github.com/openstack/watcher/blob/master/watcher/tests/common/test_nova_helper.py#L290","commit_id":"b0bdeea7cf4cda15aa003bee3c23b69c3cf2e8fa"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"8c987e4d568d61d47c20368b3920820678a364bd","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        self.assertFalse(is_success)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, mock.Mock())"},{"line_number":214,"context_line":"    def test_watcher_non_live_migrate_instance_volume("},{"line_number":215,"context_line":"            self, mock_glance, mock_cinder, mock_neutron, mock_nova):"},{"line_number":216,"context_line":"        nova_util \u003d nova_helper.NovaHelper()"},{"line_number":217,"context_line":"        nova_servers \u003d nova_util.nova.servers"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_71cd6883","side":"PARENT","line":214,"range":{"start_line":214,"start_character":8,"end_line":214,"end_character":37},"in_reply_to":"bf659307_8b3ecfb5","updated":"2018-04-03 05:41:31.000000000","message":"Thanks! I didn\u0027t notice.","commit_id":"b0bdeea7cf4cda15aa003bee3c23b69c3cf2e8fa"}]}