)]}'
{"releasenotes/notes/bp-audit-scope-exclude-project-511a7720aac00dff.yaml":[{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"62155b3ccb1a8683ee3c4188b971a579e5f5f751","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Feature to exclude instances from audit scope based on project_id is added."},{"line_number":5,"context_line":"    Now instances from particular tenant in openstack can be excluded from audit "},{"line_number":6,"context_line":"    defining scope in audit templates."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f6a8fd7_dcd19859","line":5,"range":{"start_line":5,"start_character":34,"end_line":5,"end_character":40},"updated":"2018-04-17 07:05:43.000000000","message":"\"project\" is the proper name in OpenStack.","commit_id":"62ee4977ee84255e50ed435fd5d897c493dd8b9d"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"62155b3ccb1a8683ee3c4188b971a579e5f5f751","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Feature to exclude instances from audit scope based on project_id is added."},{"line_number":5,"context_line":"    Now instances from particular tenant in openstack can be excluded from audit "},{"line_number":6,"context_line":"    defining scope in audit templates."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f6a8fd7_bc45c419","line":5,"range":{"start_line":5,"start_character":44,"end_line":5,"end_character":53},"updated":"2018-04-17 07:05:43.000000000","message":"OpenStack is not openstack.\nhttps://docs.openstack.org/doc-contrib-guide/writing-style/word-choice.html","commit_id":"62ee4977ee84255e50ed435fd5d897c493dd8b9d"},{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"62155b3ccb1a8683ee3c4188b971a579e5f5f751","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Feature to exclude instances from audit scope based on project_id is added."},{"line_number":5,"context_line":"    Now instances from particular tenant in openstack can be excluded from audit "},{"line_number":6,"context_line":"    defining scope in audit templates."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f6a8fd7_1ce63046","line":5,"range":{"start_line":5,"start_character":80,"end_line":5,"end_character":81},"updated":"2018-04-17 07:05:43.000000000","message":"Remove this whitespace.","commit_id":"62ee4977ee84255e50ed435fd5d897c493dd8b9d"}],"watcher/decision_engine/model/element/instance.py":[{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"62155b3ccb1a8683ee3c4188b971a579e5f5f751","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        \"disk_capacity\": wfields.NonNegativeIntegerField(),"},{"line_number":53,"context_line":"        \"vcpus\": wfields.NonNegativeIntegerField(),"},{"line_number":54,"context_line":"        \"metadata\": wfields.JsonField(),"},{"line_number":55,"context_line":"        \"project_id\": wfields.StringField(),"},{"line_number":56,"context_line":"    }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def accept(self, visitor):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_5c21084d","line":55,"range":{"start_line":55,"start_character":30,"end_line":55,"end_character":41},"updated":"2018-04-17 07:05:43.000000000","message":"volume.py uses UUIDfield. Why not use UUIDfield?\nhttps://github.com/openstack/watcher/blob/master/watcher/decision_engine/model/element/volume.py#L50","commit_id":"62ee4977ee84255e50ed435fd5d897c493dd8b9d"}],"watcher/decision_engine/model/notification/nova.py":[{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"8043c5979057d0a38780cffd4adedf9c397ed873","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            \u0027disk\u0027: disk_gb,"},{"line_number":77,"context_line":"            \u0027disk_capacity\u0027: disk_gb,"},{"line_number":78,"context_line":"            \u0027metadata\u0027: instance_metadata,"},{"line_number":79,"context_line":"            \u0027tenant_id\u0027: instance_data[\u0027tenant_id\u0027]"},{"line_number":80,"context_line":"        })"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_20f0b190","line":79,"range":{"start_line":79,"start_character":12,"end_line":79,"end_character":23},"updated":"2018-05-04 09:48:12.000000000","message":"why do you use tenant_id instead of project_id here?","commit_id":"fc388d829232cd95251ac487b56d2b1945081b62"},{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"6c34ae602300ef8255d36149e514a2718b9759ac","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            \u0027disk\u0027: disk_gb,"},{"line_number":77,"context_line":"            \u0027disk_capacity\u0027: disk_gb,"},{"line_number":78,"context_line":"            \u0027metadata\u0027: instance_metadata,"},{"line_number":79,"context_line":"            \u0027tenant_id\u0027: instance_data[\u0027tenant_id\u0027]"},{"line_number":80,"context_line":"        })"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_405fed40","line":79,"range":{"start_line":79,"start_character":12,"end_line":79,"end_character":23},"in_reply_to":"5f7c97a3_20f0b190","updated":"2018-05-04 09:51:26.000000000","message":"nova uses tenant_id, when we fetch instance details from nova, it has associated tenant_id with instance","commit_id":"fc388d829232cd95251ac487b56d2b1945081b62"}],"watcher/decision_engine/scope/compute.py":[{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"fc41770867b5652aba6c9b763923c971465c95a7","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    def exclude_instances_with_given_project("},{"line_number":152,"context_line":"            self, projects_to_exclude, cluster_model, instances_to_exclude):"},{"line_number":153,"context_line":"        all_instances \u003d cluster_model.get_all_instances()"},{"line_number":154,"context_line":"        for uuid in all_instances:"},{"line_number":155,"context_line":"            instance \u003d all_instances.get(uuid)"},{"line_number":156,"context_line":"            if instance.project_id in projects_to_exclude:"},{"line_number":157,"context_line":"                instances_to_exclude.add(uuid)"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_53f47ccf","line":155,"range":{"start_line":154,"start_character":0,"end_line":155,"end_character":46},"updated":"2018-04-18 02:12:59.000000000","message":"Why not \u0027for uuid, instance in all_instances.items():\u0027?","commit_id":"d2bc66d82b55dfd7d0a5dc5c6803665558856d81"},{"author":{"_account_id":19457,"name":"aditi sharma","email":"adi.sky17@gmail.com","username":"aditi"},"change_message_id":"31d0a4ec26fad7b6afee932c73e8383d3193fbec","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    def exclude_instances_with_given_project("},{"line_number":152,"context_line":"            self, projects_to_exclude, cluster_model, instances_to_exclude):"},{"line_number":153,"context_line":"        all_instances \u003d cluster_model.get_all_instances()"},{"line_number":154,"context_line":"        for uuid in all_instances:"},{"line_number":155,"context_line":"            instance \u003d all_instances.get(uuid)"},{"line_number":156,"context_line":"            if instance.project_id in projects_to_exclude:"},{"line_number":157,"context_line":"                instances_to_exclude.add(uuid)"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_c65e4775","line":155,"range":{"start_line":154,"start_character":0,"end_line":155,"end_character":46},"in_reply_to":"9f6a8fd7_53f47ccf","updated":"2018-04-20 10:56:59.000000000","message":"Done","commit_id":"d2bc66d82b55dfd7d0a5dc5c6803665558856d81"}],"watcher/decision_engine/strategy/strategies/dummy_strategy.py":[{"author":{"_account_id":13111,"name":"Hidekazu Nakamura","email":"hidekazuna@gmail.com","username":"hid-nakamura"},"change_message_id":"62155b3ccb1a8683ee3c4188b971a579e5f5f751","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    SLEEP \u003d \"sleep\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def pre_execute(self):"},{"line_number":52,"context_line":"        # if not self.compute_model:"},{"line_number":53,"context_line":"        #    raise exception.ClusterStateNotDefined()"},{"line_number":54,"context_line":"        # LOG.debug(self.compute_model.to_string())"},{"line_number":55,"context_line":"        pass"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def do_execute(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_1cf070c9","line":54,"range":{"start_line":52,"start_character":8,"end_line":54,"end_character":51},"updated":"2018-04-17 07:05:43.000000000","message":"Please remove debug comments.","commit_id":"62ee4977ee84255e50ed435fd5d897c493dd8b9d"}],"watcher/tests/decision_engine/cluster/test_nova_cdmc.py":[{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"8043c5979057d0a38780cffd4adedf9c397ed873","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            human_id\u003d\u0027fake_instance\u0027,"},{"line_number":61,"context_line":"            flavor\u003d{\u0027ram\u0027: 333, \u0027disk\u0027: 222, \u0027vcpus\u0027: 4, \u0027id\u0027: 1},"},{"line_number":62,"context_line":"            metadata\u003d{\u0027hi\u0027: \u0027hello\u0027},"},{"line_number":63,"context_line":"            tenant_id\u003d\u0027ff560f7e-dbc8-771f-960c-164482fce21b\u0027,"},{"line_number":64,"context_line":"        )"},{"line_number":65,"context_line":"        setattr(fake_instance, \u0027OS-EXT-STS:vm_state\u0027, \u0027VM_STATE\u0027)"},{"line_number":66,"context_line":"        setattr(fake_instance, \u0027OS-EXT-SRV-ATTR:host\u0027, \u0027test_hostname\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_40884dc5","line":63,"range":{"start_line":63,"start_character":12,"end_line":63,"end_character":21},"updated":"2018-05-04 09:48:12.000000000","message":"same question","commit_id":"fc388d829232cd95251ac487b56d2b1945081b62"}],"watcher/tests/decision_engine/model/data/scenario_9_with_3_active_plus_1_disabled_nodes.xml":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"0cbc963ed10836f4ccaf7b92f3a3c35194886d32","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cModelRoot\u003e"},{"line_number":2,"context_line":"  \u003cComputeNode hostname\u003d\"hostname_0\" uuid\u003d\"Node_0\" id\u003d\"0\" state\u003d\"up\" human_id\u003d\"\" status\u003d\"enabled\" vcpus\u003d\"16\" disk\u003d\"250\" disk_capacity\u003d\"250\" memory\u003d\"64\"\u003e"},{"line_number":3,"context_line":"    \u003cInstance  watcher_exclude\u003d\"False\" human_id\u003d\"\" state\u003d\"active\" uuid\u003d\"INSTANCE_0\" vcpus\u003d\"2\" disk\u003d\"20\" disk_capacity\u003d\"20\" memory\u003d\"2\" metadata\u003d\u0027{\"optimize\": true,\"top\": \"floor\", \"nested\": {\"x\": \"y\"}}\u0027 project_id\u003d\"project_0\"/\u003e"},{"line_number":4,"context_line":"    \u003cInstance watcher_exclude\u003d\"False\" human_id\u003d\"\" state\u003d\"active\" uuid\u003d\"INSTANCE_1\" vcpus\u003d\"2\" disk\u003d\"20\" disk_capacity\u003d\"20\" memory\u003d\"2\" metadata\u003d\u0027{\"optimize\": true,\"top\": \"floor\", \"nested\": {\"x\": \"y\"}}\u0027 project_id\u003d\"project_1\"/\u003e"},{"line_number":5,"context_line":"    \u003cInstance watcher_exclude\u003d\"False\" human_id\u003d\"\" state\u003d\"active\" uuid\u003d\"INSTANCE_2\" vcpus\u003d\"2\" disk\u003d\"20\" disk_capacity\u003d\"20\" memory\u003d\"2\" metadata\u003d\u0027{\"optimize\": true,\"top\": \"floor\", \"nested\": {\"x\": \"y\"}}\u0027 project_id\u003d\"project_2\"/\u003e"},{"line_number":6,"context_line":"  \u003c/ComputeNode\u003e"}],"source_content_type":"application/xml","patch_set":3,"id":"9f6a8fd7_7ccdec5b","line":3,"range":{"start_line":3,"start_character":14,"end_line":3,"end_character":15},"updated":"2018-04-17 07:09:44.000000000","message":"nit: redundant space","commit_id":"62ee4977ee84255e50ed435fd5d897c493dd8b9d"}]}