)]}'
{"watcher/decision_engine/scope/compute.py":[{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"c28af00dc335e6602141321aff496687edd24767","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        instances_to_exclude \u003d set(instances_to_exclude)"},{"line_number":199,"context_line":"        if allowed_nodes:"},{"line_number":200,"context_line":"            nodes_to_remove \u003d set(model_hosts) - set(allowed_nodes)"},{"line_number":201,"context_line":"        elif allowed_flag:"},{"line_number":202,"context_line":"            nodes_to_remove \u003d set(model_hosts)"},{"line_number":203,"context_line":"        nodes_to_remove.update(nodes_to_exclude)"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_2efe316b","line":201,"range":{"start_line":201,"start_character":8,"end_line":201,"end_character":25},"updated":"2018-08-31 09:27:33.000000000","message":"I\u0027d like to ask you of adding comments here to describe this special context","commit_id":"53104b7fcdce8aca7c35671a0624a52051904f12"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"7f021a592652616130e54b22ce8480cbec33d204","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        instances_to_exclude \u003d set(instances_to_exclude)"},{"line_number":199,"context_line":"        if allowed_nodes:"},{"line_number":200,"context_line":"            nodes_to_remove \u003d set(model_hosts) - set(allowed_nodes)"},{"line_number":201,"context_line":"        elif allowed_flag:"},{"line_number":202,"context_line":"            nodes_to_remove \u003d set(model_hosts)"},{"line_number":203,"context_line":"        nodes_to_remove.update(nodes_to_exclude)"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_380733cc","line":201,"range":{"start_line":201,"start_character":8,"end_line":201,"end_character":25},"in_reply_to":"3f79a3b5_2efe316b","updated":"2018-09-03 01:49:52.000000000","message":"remove if allowed_nodes clause,it\u0027s simple","commit_id":"53104b7fcdce8aca7c35671a0624a52051904f12"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"8b463a4c85efde97fb641318648011dcf6dfee0b","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        instances_to_exclude \u003d set(instances_to_exclude)"},{"line_number":199,"context_line":"        if allowed_nodes:"},{"line_number":200,"context_line":"            nodes_to_remove \u003d set(model_hosts) - set(allowed_nodes)"},{"line_number":201,"context_line":"        elif allowed_flag:"},{"line_number":202,"context_line":"            nodes_to_remove \u003d set(model_hosts)"},{"line_number":203,"context_line":"        nodes_to_remove.update(nodes_to_exclude)"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_18a037a5","line":201,"range":{"start_line":201,"start_character":8,"end_line":201,"end_character":25},"in_reply_to":"3f79a3b5_380733cc","updated":"2018-09-03 02:14:07.000000000","message":"It\u0027s wrong if only exclude in scope.\nso I still add allowed flag and comments","commit_id":"53104b7fcdce8aca7c35671a0624a52051904f12"},{"author":{"_account_id":19055,"name":"Alexander Chadin","email":"joker946@gmail.com","username":"joker946"},"change_message_id":"dfb95e3645ad41c45b7048a572c81262e4d4cda6","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            if \u0027host_aggregates\u0027 in rule:"},{"line_number":184,"context_line":"                self._collect_aggregates(rule[\u0027host_aggregates\u0027],"},{"line_number":185,"context_line":"                                         allowed_nodes)"},{"line_number":186,"context_line":"                allowed_flag \u003d True"},{"line_number":187,"context_line":"            elif \u0027availability_zones\u0027 in rule:"},{"line_number":188,"context_line":"                self._collect_zones(rule[\u0027availability_zones\u0027],"},{"line_number":189,"context_line":"                                    allowed_nodes)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_0cd1d957","line":186,"range":{"start_line":186,"start_character":16,"end_line":186,"end_character":28},"updated":"2018-09-03 09:23:17.000000000","message":"shouldn\u0027t we use \u0027found_nothing_flag\u0027 name? what do you think of it?","commit_id":"93626716f486eac0ce9f6824ecb2e2daec104180"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"0f30322849844f0862f392bd0166e2dab1d73dd1","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            if \u0027host_aggregates\u0027 in rule:"},{"line_number":184,"context_line":"                self._collect_aggregates(rule[\u0027host_aggregates\u0027],"},{"line_number":185,"context_line":"                                         allowed_nodes)"},{"line_number":186,"context_line":"                allowed_flag \u003d True"},{"line_number":187,"context_line":"            elif \u0027availability_zones\u0027 in rule:"},{"line_number":188,"context_line":"                self._collect_zones(rule[\u0027availability_zones\u0027],"},{"line_number":189,"context_line":"                                    allowed_nodes)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_87b13804","line":186,"range":{"start_line":186,"start_character":16,"end_line":186,"end_character":28},"in_reply_to":"3f79a3b5_0cd1d957","updated":"2018-09-04 01:30:13.000000000","message":"good!","commit_id":"93626716f486eac0ce9f6824ecb2e2daec104180"}]}