)]}'
{"id":"openstack%2Fwatcher~656457","triplet_id":"openstack%2Fwatcher~master~If09544e96ef23a6c52bde1f7211bf323d9609f63","project":"openstack/watcher","branch":"master","topic":"tempest_voting","hashtags":[],"change_id":"If09544e96ef23a6c52bde1f7211bf323d9609f63","subject":"Add tempest voting","status":"MERGED","created":"2019-04-30 08:13:12.000000000","updated":"2019-05-10 13:17:16.000000000","submitted":"2019-05-10 07:15:28.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"656457-1557472528968-121c7fd4","meta_rev_id":"8132f50acca21f208e8295183134737cac0b269a","_number":656457,"virtual_id_number":656457,"owner":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"date":"2019-05-07 18:58:42.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"date":"2019-05-09 05:44:24.000000000","_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":2,"date":"2019-05-10 07:15:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"all":[{"value":2,"date":"2019-05-09 13:16:37.000000000","_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-05-05 06:13:51.000000000","_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"all":[{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":1,"date":"2019-05-10 06:32:49.000000000","_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-07 18:58:42.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-05-09 13:16:37.000000000","updated_by":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"reviewer":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"state":"REVIEWER"},{"updated":"2019-05-10 06:32:49.000000000","updated_by":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"reviewer":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"state":"REVIEWER"},{"updated":"2019-05-10 07:15:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d097c76b9abc4b409aafca64e41c1545b2971f6d","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-04-30 08:13:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"66bac89f3d2dd37866cbfabae1aadc31b35d654f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-30 09:12:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/57/656457/1/check/openstack-tox-cover/3ae8ba1/cover/ : SUCCESS in 7m 14s\n- openstack-tox-lower-constraints http://logs.openstack.org/57/656457/1/check/openstack-tox-lower-constraints/38f8900/ : SUCCESS in 7m 02s\n- openstack-tox-pep8 http://logs.openstack.org/57/656457/1/check/openstack-tox-pep8/5cb1733/ : SUCCESS in 5m 16s\n- openstack-tox-py27 http://logs.openstack.org/57/656457/1/check/openstack-tox-py27/4574cba/ : SUCCESS in 5m 27s\n- openstack-tox-py36 http://logs.openstack.org/57/656457/1/check/openstack-tox-py36/a5d20da/ : SUCCESS in 5m 42s\n- openstack-tox-py37 http://logs.openstack.org/57/656457/1/check/openstack-tox-py37/2d8aca0/ : SUCCESS in 5m 59s\n- openstack-tox-docs http://logs.openstack.org/57/656457/1/check/openstack-tox-docs/e76cc08/html/ : SUCCESS in 5m 47s\n- watcher-tempest-functional http://logs.openstack.org/57/656457/1/check/watcher-tempest-functional/d8ea259/ : SUCCESS in 30m 35s\n- watcher-grenade http://logs.openstack.org/57/656457/1/check/watcher-grenade/7bc09c4/ : SUCCESS in 46m 55s\n- watcher-tempest-dummy_optim http://logs.openstack.org/57/656457/1/check/watcher-tempest-dummy_optim/5c3ae8a/ : SUCCESS in 47m 13s\n- watcher-tempest-actuator http://logs.openstack.org/57/656457/1/check/watcher-tempest-actuator/7b5c342/ : SUCCESS in 51m 33s\n- watcher-tempest-basic_optim http://logs.openstack.org/57/656457/1/check/watcher-tempest-basic_optim/0a721bb/ : SUCCESS in 45m 55s\n- watcher-tempest-vm_workload_consolidation http://logs.openstack.org/57/656457/1/check/watcher-tempest-vm_workload_consolidation/faae639/ : SUCCESS in 49m 07s\n- watcher-tempest-workload_balancing http://logs.openstack.org/57/656457/1/check/watcher-tempest-workload_balancing/d8b629f/ : SUCCESS in 52m 57s\n- watcherclient-tempest-functional http://logs.openstack.org/57/656457/1/check/watcherclient-tempest-functional/14a47c0/ : SUCCESS in 36m 09s\n- watcher-tempest-zone_migration http://logs.openstack.org/57/656457/1/check/watcher-tempest-zone_migration/393676f/ : SUCCESS in 47m 29s\n- watcher-tempest-host_maintenance http://logs.openstack.org/57/656457/1/check/watcher-tempest-host_maintenance/89f6a2e/ : SUCCESS in 47m 25s\n- watcher-tempest-storage_balance http://logs.openstack.org/57/656457/1/check/watcher-tempest-storage_balance/561a2b6/ : SUCCESS in 46m 41s\n- watcher-tls-test http://logs.openstack.org/57/656457/1/check/watcher-tls-test/f653549/ : SUCCESS in 48m 48s","accounts_in_message":[],"_revision_number":1},{"id":"4d4feed6003018b8494b4d7846d92af1e7a0bccb","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-04-30 14:39:07.000000000","message":"Patch Set 1: Code-Review+1\n\nI think having tempest as voting is good but we should try to improve watcher-tempest plugin documentation as for example I have no idea how to setup and debug with tempest.","accounts_in_message":[],"_revision_number":1},{"id":"fd8407f8edc166aeaa7288853648026c5b0832c2","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-05-05 06:13:51.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"0b0f32af2d57f39d2e89fa790aa212539c3fd779","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-07 18:57:40.000000000","message":"Patch Set 1:\n\nI\u0027m new here and this isn\u0027t really a comment on whether or not the tempest jobs should be voting or not (my philosophy is if you\u0027re going to run jobs on changes, they should be voting and gating otherwise what\u0027s the point since people won\u0027t notice the failures until it blocks their patch). But something I did notice is you have several devstack+tempest jobs which take around 40-55 minutes to run.\n\nLooking at one of these jobs:\n\nhttp://logs.openstack.org/57/656457/1/check/watcher-tempest-basic_optim/0a721bb/ara-report/reports/e975551e-a058-489d-9d97-9bfb35e5dc74.html\n\nI noticed that simply setting up devstack takes the vast majority of the time, e.g. stack took 0:24:02 minutes while tempest itself actually took 0:01:41 to run the one test. This seems like a big waste.\n\nI wonder if it would be possible to have a single job which runs through and reconfigures the watcher service between tempest runs so you only have to setup devstack once. That should be possible (and easier) now with zuul v3 and ansible in the job definitions.","accounts_in_message":[],"_revision_number":1},{"id":"45538f47f67d823cbbac7e800709f9e72b7c159e","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-07 18:58:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"801cdf7852eaf531d4a3fb51ce749a6b2f4e193e","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-05-09 05:44:24.000000000","message":"Patch Set 1:\n\n(1 comment)\n\n\u003e I\u0027m new here and this isn\u0027t really a comment on whether or not the\n \u003e tempest jobs should be voting or not (my philosophy is if you\u0027re\n \u003e going to run jobs on changes, they should be voting and gating\n \u003e otherwise what\u0027s the point since people won\u0027t notice the failures\n \u003e until it blocks their patch). But something I did notice is you\n \u003e have several devstack+tempest jobs which take around 40-55 minutes\n \u003e to run.\n \u003e \n \u003e Looking at one of these jobs:\n \u003e \n \u003e http://logs.openstack.org/57/656457/1/check/watcher-tempest-basic_optim/0a721bb/ara-report/reports/e975551e-a058-489d-9d97-9bfb35e5dc74.html\n \u003e \n \u003e I noticed that simply setting up devstack takes the vast majority\n \u003e of the time, e.g. stack took 0:24:02 minutes while tempest itself\n \u003e actually took 0:01:41 to run the one test. This seems like a big\n \u003e waste.\n \u003e \n \u003e I wonder if it would be possible to have a single job which runs\n \u003e through and reconfigures the watcher service between tempest runs\n \u003e so you only have to setup devstack once. That should be possible\n \u003e (and easier) now with zuul v3 and ansible in the job definitions.\nThank you Matt, There are many historical reasons. The previous watcher\u0027s tempest is very unstable and often goes failure.\nSome tests can be merged into one job, we plan to do that.","accounts_in_message":[],"_revision_number":1},{"id":"d2dc12296d0952202d1c163f72b0ea3ae17ad74b","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-05-09 13:16:37.000000000","message":"Patch Set 1: Code-Review+2\n\nFor now voting is fine once we have combined the tempest jobs and are able to cut the time down we can add gating,","accounts_in_message":[],"_revision_number":1},{"id":"724078eac6d2c8f3a7d140b9762c53dddc20a8a6","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-05-10 06:32:49.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"105c0ca112970f63bbf096dfba03f065ae0f6d3f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-10 06:33:05.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"af82dc635c8a01f51085117c1ae643f2411415d1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-10 07:15:28.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/57/656457/1/gate/openstack-tox-lower-constraints/79c50f9/ : SUCCESS in 7m 16s\n- openstack-tox-pep8 http://logs.openstack.org/57/656457/1/gate/openstack-tox-pep8/1bb1573/ : SUCCESS in 7m 03s\n- openstack-tox-py27 http://logs.openstack.org/57/656457/1/gate/openstack-tox-py27/b102465/ : SUCCESS in 6m 58s\n- openstack-tox-py36 http://logs.openstack.org/57/656457/1/gate/openstack-tox-py36/8b87866/ : SUCCESS in 7m 45s\n- openstack-tox-py37 http://logs.openstack.org/57/656457/1/gate/openstack-tox-py37/ae2936b/ : SUCCESS in 7m 00s\n- openstack-tox-docs http://logs.openstack.org/57/656457/1/gate/openstack-tox-docs/f63d7fa/html/ : SUCCESS in 7m 54s\n- watcher-tempest-functional http://logs.openstack.org/57/656457/1/gate/watcher-tempest-functional/3524550/ : SUCCESS in 30m 20s","accounts_in_message":[],"_revision_number":1},{"id":"7afe636a54da6c2ffba345bbbf41aad1d66e386c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-10 07:15:28.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"82b955d9ba967fa29485a7f3844a0a39ab4e1bbe","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-10 13:17:16.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c99e051a141561265ef7685548f65f23cef50801","revisions":{"c99e051a141561265ef7685548f65f23cef50801":{"kind":"REWORK","_number":1,"created":"2019-04-30 08:13:12.000000000","uploader":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"ref":"refs/changes/57/656457/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/57/656457/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/57/656457/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/57/656457/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/57/656457/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/57/656457/1"}}},"commit":{"parents":[{"commit":"647b5e948326613e89a5a0d61efdd2f6b36538d0","subject":"Drop use of git.openstack.org","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/647b5e948326613e89a5a0d61efdd2f6b36538d0"}]}],"author":{"name":"licanwei","email":"li.canwei2@zte.com.cn","date":"2019-04-30 08:02:32.000000000","tz":480},"committer":{"name":"licanwei","email":"li.canwei2@zte.com.cn","date":"2019-04-30 08:02:32.000000000","tz":480},"subject":"Add tempest voting","message":"Add tempest voting\n\nChange-Id: If09544e96ef23a6c52bde1f7211bf323d9609f63\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/c99e051a141561265ef7685548f65f23cef50801"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/c99e051a141561265ef7685548f65f23cef50801"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}