)]}'
{"id":"openstack%2Fwatcher~658237","triplet_id":"openstack%2Fwatcher~master~Ibfb7362f4b5df0775e8215b6e0bd83f9bd784244","project":"openstack/watcher","branch":"master","topic":"api_version","hashtags":[],"change_id":"Ibfb7362f4b5df0775e8215b6e0bd83f9bd784244","subject":"Fix API version header","status":"MERGED","created":"2019-05-10 01:52:55.000000000","updated":"2019-05-16 08:54:58.000000000","submitted":"2019-05-16 08:54:58.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"658237-1557996898780-21522369","meta_rev_id":"d77bf4673f94d9f0c19c6d22a5962c4520c73107","_number":658237,"virtual_id_number":658237,"owner":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"date":"2019-05-11 23:12:53.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":2,"date":"2019-05-16 08:54:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"all":[{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-05-15 05:26:49.000000000","_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"all":[{"value":0,"date":"2019-05-15 12:48:28.000000000","_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":1,"date":"2019-05-16 08:18:58.000000000","_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-11 23:12:53.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-05-15 05:26:49.000000000","updated_by":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"reviewer":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"state":"REVIEWER"},{"updated":"2019-05-15 12:48:28.000000000","updated_by":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"reviewer":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"state":"REVIEWER"},{"updated":"2019-05-16 08:54:58.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e42fe781ea8898d3cdd75c4569304704282eee5f","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-05-10 01:52:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9f50a35f883ef56bd7c06884e0ad44706f9a0ea9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-10 02:50:44.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover http://logs.openstack.org/37/658237/1/check/openstack-tox-cover/7f153e3/cover/ : SUCCESS in 5m 59s\n- openstack-tox-lower-constraints http://logs.openstack.org/37/658237/1/check/openstack-tox-lower-constraints/7596238/ : SUCCESS in 5m 23s\n- openstack-tox-pep8 http://logs.openstack.org/37/658237/1/check/openstack-tox-pep8/82990bb/ : FAILURE in 5m 19s\n- openstack-tox-py27 http://logs.openstack.org/37/658237/1/check/openstack-tox-py27/48784ec/ : SUCCESS in 5m 13s\n- openstack-tox-py36 http://logs.openstack.org/37/658237/1/check/openstack-tox-py36/ba9d010/ : SUCCESS in 5m 23s\n- openstack-tox-py37 http://logs.openstack.org/37/658237/1/check/openstack-tox-py37/2481cbf/ : SUCCESS in 5m 50s\n- openstack-tox-docs http://logs.openstack.org/37/658237/1/check/openstack-tox-docs/f1191a8/html/ : SUCCESS in 5m 08s\n- watcher-tempest-functional http://logs.openstack.org/37/658237/1/check/watcher-tempest-functional/066d3e7/ : SUCCESS in 32m 16s\n- watcher-tempest-dummy_optim http://logs.openstack.org/37/658237/1/check/watcher-tempest-dummy_optim/50e7472/ : SUCCESS in 46m 18s (non-voting)\n- watcher-tempest-actuator http://logs.openstack.org/37/658237/1/check/watcher-tempest-actuator/28695a6/ : SUCCESS in 51m 47s (non-voting)\n- watcher-tempest-basic_optim http://logs.openstack.org/37/658237/1/check/watcher-tempest-basic_optim/a9ce244/ : SUCCESS in 47m 53s (non-voting)\n- watcher-tempest-vm_workload_consolidation http://logs.openstack.org/37/658237/1/check/watcher-tempest-vm_workload_consolidation/a1e1dbf/ : SUCCESS in 46m 15s (non-voting)\n- watcher-tempest-workload_balancing http://logs.openstack.org/37/658237/1/check/watcher-tempest-workload_balancing/6e43cf0/ : SUCCESS in 47m 00s (non-voting)\n- watcherclient-tempest-functional http://logs.openstack.org/37/658237/1/check/watcherclient-tempest-functional/f27baac/ : SUCCESS in 34m 05s (non-voting)\n- watcher-tempest-zone_migration http://logs.openstack.org/37/658237/1/check/watcher-tempest-zone_migration/15ec172/ : SUCCESS in 47m 34s (non-voting)\n- watcher-tempest-host_maintenance http://logs.openstack.org/37/658237/1/check/watcher-tempest-host_maintenance/7d74bb7/ : SUCCESS in 46m 15s (non-voting)\n- watcher-tempest-storage_balance http://logs.openstack.org/37/658237/1/check/watcher-tempest-storage_balance/4078f26/ : SUCCESS in 51m 23s (non-voting)\n- watcher-tls-test http://logs.openstack.org/37/658237/1/check/watcher-tls-test/ba75ef1/ : SUCCESS in 48m 31s","accounts_in_message":[],"_revision_number":1},{"id":"9b173b27554566fbf9d42c1bb501db98f7abfc88","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-05-10 13:44:33.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"ad5eda492ca7b4e7318713e7ffeb2e00835ad80d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-10 14:55:55.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover http://logs.openstack.org/37/658237/1/check/openstack-tox-cover/f5d6e1a/cover/ : SUCCESS in 7m 48s\n- openstack-tox-lower-constraints http://logs.openstack.org/37/658237/1/check/openstack-tox-lower-constraints/95d9f97/ : SUCCESS in 4m 37s\n- openstack-tox-pep8 http://logs.openstack.org/37/658237/1/check/openstack-tox-pep8/dd12cd1/ : SUCCESS in 5m 35s\n- openstack-tox-py27 http://logs.openstack.org/37/658237/1/check/openstack-tox-py27/115d072/ : SUCCESS in 5m 01s\n- openstack-tox-py36 http://logs.openstack.org/37/658237/1/check/openstack-tox-py36/0004796/ : SUCCESS in 8m 10s\n- openstack-tox-py37 http://logs.openstack.org/37/658237/1/check/openstack-tox-py37/e01e4b1/ : SUCCESS in 5m 49s\n- openstack-tox-docs http://logs.openstack.org/37/658237/1/check/openstack-tox-docs/396c34d/html/ : SUCCESS in 5m 19s\n- watcher-tempest-functional http://logs.openstack.org/37/658237/1/check/watcher-tempest-functional/3630b38/ : FAILURE in 45m 40s\n- watcher-tempest-dummy_optim http://logs.openstack.org/37/658237/1/check/watcher-tempest-dummy_optim/af2ac04/ : SUCCESS in 48m 09s\n- watcher-tempest-actuator http://logs.openstack.org/37/658237/1/check/watcher-tempest-actuator/596a883/ : SUCCESS in 1h 03m 18s\n- watcher-tempest-basic_optim http://logs.openstack.org/37/658237/1/check/watcher-tempest-basic_optim/290e796/ : SUCCESS in 48m 07s\n- watcher-tempest-vm_workload_consolidation http://logs.openstack.org/37/658237/1/check/watcher-tempest-vm_workload_consolidation/d1ff669/ : SUCCESS in 41m 21s\n- watcher-tempest-workload_balancing http://logs.openstack.org/37/658237/1/check/watcher-tempest-workload_balancing/77eff51/ : SUCCESS in 48m 36s\n- watcherclient-tempest-functional http://logs.openstack.org/37/658237/1/check/watcherclient-tempest-functional/b1d0a6a/ : SUCCESS in 34m 01s\n- watcher-tempest-zone_migration http://logs.openstack.org/37/658237/1/check/watcher-tempest-zone_migration/d7ee66a/ : SUCCESS in 47m 47s\n- watcher-tempest-host_maintenance http://logs.openstack.org/37/658237/1/check/watcher-tempest-host_maintenance/e3fc6a3/ : SUCCESS in 49m 41s\n- watcher-tempest-storage_balance http://logs.openstack.org/37/658237/1/check/watcher-tempest-storage_balance/133e562/ : SUCCESS in 55m 01s\n- watcher-tls-test http://logs.openstack.org/37/658237/1/check/watcher-tls-test/685cb34/ : SUCCESS in 46m 48s","accounts_in_message":[],"_revision_number":1},{"id":"37b0f5a522bdad647bb0f39e5c6b4efb3758ca5c","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-11 23:12:53.000000000","message":"Patch Set 1:\n\nWhy wasn\u0027t this test failing before? Seems the test isn\u0027t really testing anything useful, or maybe there is a missing assert somewhere? In other words, if you remove the header altogether does it make a difference?","accounts_in_message":[],"_revision_number":1},{"id":"e8049239fb979939962d46bebc3277498d160416","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-05-13 06:35:29.000000000","message":"Patch Set 1:\n\n\u003e Why wasn\u0027t this test failing before? Seems the test isn\u0027t really\n \u003e testing anything useful, or maybe there is a missing assert\n \u003e somewhere? In other words, if you remove the header altogether does\n \u003e it make a difference?\n\nIf no header the test will fail. Because the test expected error response code, so the wrong header has the same effect.","accounts_in_message":[],"_revision_number":1},{"id":"b6e773b352bb3a49253f194f4ab512aa1af63d9d","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-05-13 06:35:50.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"daf85cfec21bed3f245bd4f208eee238d3936207","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-13 07:36:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/37/658237/1/check/openstack-tox-cover/45410ac/cover/ : SUCCESS in 6m 32s\n- openstack-tox-lower-constraints http://logs.openstack.org/37/658237/1/check/openstack-tox-lower-constraints/d3d953d/ : SUCCESS in 5m 50s\n- openstack-tox-pep8 http://logs.openstack.org/37/658237/1/check/openstack-tox-pep8/91edb93/ : SUCCESS in 5m 11s\n- openstack-tox-py27 http://logs.openstack.org/37/658237/1/check/openstack-tox-py27/07d501d/ : SUCCESS in 5m 24s\n- openstack-tox-py36 http://logs.openstack.org/37/658237/1/check/openstack-tox-py36/af42d26/ : SUCCESS in 5m 23s\n- openstack-tox-py37 http://logs.openstack.org/37/658237/1/check/openstack-tox-py37/f153584/ : SUCCESS in 6m 38s\n- openstack-tox-docs http://logs.openstack.org/37/658237/1/check/openstack-tox-docs/3fc0626/html/ : SUCCESS in 5m 21s\n- watcher-tempest-functional http://logs.openstack.org/37/658237/1/check/watcher-tempest-functional/b237544/ : SUCCESS in 33m 08s\n- watcher-tempest-dummy_optim http://logs.openstack.org/37/658237/1/check/watcher-tempest-dummy_optim/2b16552/ : SUCCESS in 46m 03s\n- watcher-tempest-actuator http://logs.openstack.org/37/658237/1/check/watcher-tempest-actuator/f20a2a1/ : SUCCESS in 54m 08s\n- watcher-tempest-basic_optim http://logs.openstack.org/37/658237/1/check/watcher-tempest-basic_optim/a2cefd1/ : SUCCESS in 49m 49s\n- watcher-tempest-vm_workload_consolidation http://logs.openstack.org/37/658237/1/check/watcher-tempest-vm_workload_consolidation/6ed56fa/ : SUCCESS in 56m 50s\n- watcher-tempest-workload_balancing http://logs.openstack.org/37/658237/1/check/watcher-tempest-workload_balancing/426f53f/ : SUCCESS in 48m 18s\n- watcherclient-tempest-functional http://logs.openstack.org/37/658237/1/check/watcherclient-tempest-functional/7abbb2c/ : SUCCESS in 36m 39s\n- watcher-tempest-zone_migration http://logs.openstack.org/37/658237/1/check/watcher-tempest-zone_migration/9bfc508/ : SUCCESS in 48m 02s\n- watcher-tempest-host_maintenance http://logs.openstack.org/37/658237/1/check/watcher-tempest-host_maintenance/e9661a5/ : SUCCESS in 50m 48s\n- watcher-tempest-storage_balance http://logs.openstack.org/37/658237/1/check/watcher-tempest-storage_balance/fee6c41/ : SUCCESS in 48m 32s\n- watcher-tls-test http://logs.openstack.org/37/658237/1/check/watcher-tls-test/55dc2f1/ : SUCCESS in 45m 15s","accounts_in_message":[],"_revision_number":1},{"id":"e700359a9c9ab8fba901de1c69fad32a6c64cb47","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-05-15 05:26:49.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"2bcb302b72e8a7c98ea22a9e535f1bc06ad0984a","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-05-16 08:18:58.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"0d8052050ef067fefabed76c0a7176626e4e270f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-16 08:19:10.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"de09b285d0cf829d2825c35055dd2f031de250d8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-16 08:54:58.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"397853c4578a19d7019e2c5c074730f3a48fbf44","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-16 08:54:58.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/37/658237/1/gate/openstack-tox-lower-constraints/9c8b688/ : SUCCESS in 6m 43s\n- openstack-tox-pep8 http://logs.openstack.org/37/658237/1/gate/openstack-tox-pep8/b8f99f8/ : SUCCESS in 6m 22s\n- openstack-tox-py27 http://logs.openstack.org/37/658237/1/gate/openstack-tox-py27/b65469a/ : SUCCESS in 5m 50s\n- openstack-tox-py36 http://logs.openstack.org/37/658237/1/gate/openstack-tox-py36/192193e/ : SUCCESS in 5m 53s\n- openstack-tox-py37 http://logs.openstack.org/37/658237/1/gate/openstack-tox-py37/2ba2fb2/ : SUCCESS in 5m 58s\n- openstack-tox-docs http://logs.openstack.org/37/658237/1/gate/openstack-tox-docs/2723d26/html/ : SUCCESS in 5m 43s\n- watcher-tempest-functional http://logs.openstack.org/37/658237/1/gate/watcher-tempest-functional/1775304/ : SUCCESS in 30m 27s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"606f20b66e3838632bec21ec827b3e4b4e7047dc","revisions":{"606f20b66e3838632bec21ec827b3e4b4e7047dc":{"kind":"REWORK","_number":1,"created":"2019-05-10 01:52:55.000000000","uploader":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"ref":"refs/changes/37/658237/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/37/658237/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/37/658237/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/37/658237/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/37/658237/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/37/658237/1"}}},"commit":{"parents":[{"commit":"e2285777e2bec336c9affc88457c4463604786fb","subject":"Using node replace resource_id in method add_action_disable_node()","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/e2285777e2bec336c9affc88457c4463604786fb"}]}],"author":{"name":"licanwei","email":"li.canwei2@zte.com.cn","date":"2019-05-10 01:51:21.000000000","tz":480},"committer":{"name":"licanwei","email":"li.canwei2@zte.com.cn","date":"2019-05-10 01:51:21.000000000","tz":480},"subject":"Fix API version header","message":"Fix API version header\n\nX-OpenStack-Watcher-API-Version should be OpenStack-API-Version\n\nChange-Id: Ibfb7362f4b5df0775e8215b6e0bd83f9bd784244\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/606f20b66e3838632bec21ec827b3e4b4e7047dc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/606f20b66e3838632bec21ec827b3e4b4e7047dc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}