)]}'
{"id":"openstack%2Fwatcher~658348","triplet_id":"openstack%2Fwatcher~master~I013f9d03978f8716847f8d1ee6888629faf5779b","project":"openstack/watcher","branch":"master","hashtags":[],"change_id":"I013f9d03978f8716847f8d1ee6888629faf5779b","subject":"pass default_config_dirs variable for config initialization.","status":"MERGED","created":"2019-05-10 12:39:28.000000000","updated":"2019-09-13 22:44:18.000000000","submitted":"2019-05-17 10:20:44.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"658348-1558088444559-a663f06a","meta_rev_id":"5ec51096b7ec4711a9e0dc8f8b032fbe61e117ae","_number":658348,"virtual_id_number":658348,"owner":{"_account_id":23735,"name":"sumitjami","email":"sjamgade@suse.com","username":"nthforloop"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-05-16 11:23:08.000000000","_account_id":23735,"name":"sumitjami","email":"sjamgade@suse.com","username":"nthforloop"},{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"date":"2019-05-16 06:06:57.000000000","_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":2,"date":"2019-05-17 10:20:44.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"all":[{"value":0,"_account_id":23735,"name":"sumitjami","email":"sjamgade@suse.com","username":"nthforloop"},{"value":2,"date":"2019-05-16 11:52:24.000000000","_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":1,"date":"2019-05-15 14:06:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":2,"date":"2019-05-17 07:24:32.000000000","_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"all":[{"value":0,"_account_id":23735,"name":"sumitjami","email":"sjamgade@suse.com","username":"nthforloop"},{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":1,"date":"2019-05-17 09:52:24.000000000","_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":23735,"name":"sumitjami","email":"sjamgade@suse.com","username":"nthforloop"},{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23735,"name":"sumitjami","email":"sjamgade@suse.com","username":"nthforloop"},{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-15 14:06:28.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-05-16 06:06:57.000000000","updated_by":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"reviewer":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"state":"REVIEWER"},{"updated":"2019-05-16 11:52:24.000000000","updated_by":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"reviewer":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"state":"REVIEWER"},{"updated":"2019-05-17 09:52:24.000000000","updated_by":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"reviewer":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"state":"REVIEWER"},{"updated":"2019-05-17 10:20:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1029f06d40cbf17af9567ab008ccedf4690468c5","author":{"_account_id":23735,"name":"sumitjami","email":"sjamgade@suse.com","username":"nthforloop"},"date":"2019-05-10 12:39:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4bba1463689dc34ef0344ef5c5b12307d466730b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-10 13:55:19.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/48/658348/1/check/openstack-tox-cover/3d9f602/cover/ : SUCCESS in 5m 49s\n- openstack-tox-lower-constraints http://logs.openstack.org/48/658348/1/check/openstack-tox-lower-constraints/3b40f3a/ : SUCCESS in 5m 46s\n- openstack-tox-pep8 http://logs.openstack.org/48/658348/1/check/openstack-tox-pep8/d2800b6/ : SUCCESS in 6m 53s\n- openstack-tox-py27 http://logs.openstack.org/48/658348/1/check/openstack-tox-py27/8ea17b5/ : SUCCESS in 6m 59s\n- openstack-tox-py36 http://logs.openstack.org/48/658348/1/check/openstack-tox-py36/e796746/ : SUCCESS in 5m 19s\n- openstack-tox-py37 http://logs.openstack.org/48/658348/1/check/openstack-tox-py37/126fa83/ : SUCCESS in 6m 15s\n- openstack-tox-docs http://logs.openstack.org/48/658348/1/check/openstack-tox-docs/a10ac04/html/ : SUCCESS in 6m 18s\n- watcher-tempest-functional http://logs.openstack.org/48/658348/1/check/watcher-tempest-functional/83b6029/ : SUCCESS in 30m 10s\n- watcher-grenade http://logs.openstack.org/48/658348/1/check/watcher-grenade/317971b/ : SUCCESS in 46m 44s\n- watcher-tempest-dummy_optim http://logs.openstack.org/48/658348/1/check/watcher-tempest-dummy_optim/a15f58c/ : SUCCESS in 54m 31s\n- watcher-tempest-actuator http://logs.openstack.org/48/658348/1/check/watcher-tempest-actuator/75a72ef/ : SUCCESS in 56m 57s\n- watcher-tempest-basic_optim http://logs.openstack.org/48/658348/1/check/watcher-tempest-basic_optim/5712d48/ : SUCCESS in 52m 20s\n- watcher-tempest-vm_workload_consolidation http://logs.openstack.org/48/658348/1/check/watcher-tempest-vm_workload_consolidation/7a22440/ : SUCCESS in 46m 18s\n- watcher-tempest-workload_balancing http://logs.openstack.org/48/658348/1/check/watcher-tempest-workload_balancing/45f166f/ : SUCCESS in 55m 37s\n- watcherclient-tempest-functional http://logs.openstack.org/48/658348/1/check/watcherclient-tempest-functional/bf32f4b/ : SUCCESS in 34m 38s\n- watcher-tempest-zone_migration http://logs.openstack.org/48/658348/1/check/watcher-tempest-zone_migration/5ac0e0e/ : SUCCESS in 50m 36s\n- watcher-tempest-host_maintenance http://logs.openstack.org/48/658348/1/check/watcher-tempest-host_maintenance/d0c7239/ : SUCCESS in 51m 23s\n- watcher-tempest-storage_balance http://logs.openstack.org/48/658348/1/check/watcher-tempest-storage_balance/7d60081/ : SUCCESS in 56m 07s\n- watcher-tls-test http://logs.openstack.org/48/658348/1/check/watcher-tls-test/b7b5cb6/ : SUCCESS in 1h 01m 26s","accounts_in_message":[],"_revision_number":1},{"id":"44d6e09d6e8379b1c1cebcce1b7d2f0d3161590c","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-11 23:19:01.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nIs it possible to add a test for this?","accounts_in_message":[],"_revision_number":1},{"id":"2d093812951b00f952bde67877fb7e456f212418","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-05-13 02:25:28.000000000","message":"Patch Set 1:\n\nIs this related to https://review.opendev.org/#/c/657374/?","accounts_in_message":[],"_revision_number":1},{"id":"5e7fd17c9f4a262827298bad03ed33fc18474fbd","author":{"_account_id":23735,"name":"sumitjami","email":"sjamgade@suse.com","username":"nthforloop"},"date":"2019-05-13 08:58:53.000000000","message":"Patch Set 1:\n\n\u003e (1 comment)\n \u003e \n \u003e Is it possible to add a test for this?\n\nThe test would end up testing the find_config_dirs call.","accounts_in_message":[],"_revision_number":1},{"id":"6369fc2912395989a82a589caaa0c66fea51ae33","author":{"_account_id":23735,"name":"sumitjami","email":"sjamgade@suse.com","username":"nthforloop"},"date":"2019-05-13 08:59:19.000000000","message":"Patch Set 1:\n\n\u003e Is this related to https://review.opendev.org/#/c/657374/?\n\nNo","accounts_in_message":[],"_revision_number":1},{"id":"5f385db67691da3ae2184c01d0c5f539d379fd4e","author":{"_account_id":23735,"name":"sumitjami","email":"sjamgade@suse.com","username":"nthforloop"},"date":"2019-05-13 09:09:47.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"c94c8c4c4c931591126f0303db2babacc538ccfd","author":{"_account_id":23735,"name":"sumitjami","email":"sjamgade@suse.com","username":"nthforloop"},"date":"2019-05-13 09:11:02.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ca4dab2e2ec1b891e6e5bbeebd5aec56bdd1f5a6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-13 10:06:07.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/48/658348/2/check/openstack-tox-cover/0a9c6d3/cover/ : SUCCESS in 6m 42s\n- openstack-tox-lower-constraints http://logs.openstack.org/48/658348/2/check/openstack-tox-lower-constraints/903efad/ : SUCCESS in 5m 28s\n- openstack-tox-pep8 http://logs.openstack.org/48/658348/2/check/openstack-tox-pep8/c44c5dc/ : SUCCESS in 8m 03s\n- openstack-tox-py27 http://logs.openstack.org/48/658348/2/check/openstack-tox-py27/eefa5d8/ : SUCCESS in 5m 32s\n- openstack-tox-py36 http://logs.openstack.org/48/658348/2/check/openstack-tox-py36/055841e/ : SUCCESS in 5m 13s\n- openstack-tox-py37 http://logs.openstack.org/48/658348/2/check/openstack-tox-py37/a8c8083/ : SUCCESS in 5m 49s\n- openstack-tox-docs http://logs.openstack.org/48/658348/2/check/openstack-tox-docs/42ca0b7/html/ : SUCCESS in 8m 11s\n- watcher-tempest-functional http://logs.openstack.org/48/658348/2/check/watcher-tempest-functional/c5576a8/ : SUCCESS in 25m 23s\n- watcher-grenade http://logs.openstack.org/48/658348/2/check/watcher-grenade/d035b3d/ : SUCCESS in 48m 42s\n- watcher-tempest-dummy_optim http://logs.openstack.org/48/658348/2/check/watcher-tempest-dummy_optim/b8d0635/ : SUCCESS in 46m 27s\n- watcher-tempest-actuator http://logs.openstack.org/48/658348/2/check/watcher-tempest-actuator/8109ee9/ : SUCCESS in 51m 10s\n- watcher-tempest-basic_optim http://logs.openstack.org/48/658348/2/check/watcher-tempest-basic_optim/36a719a/ : SUCCESS in 47m 05s\n- watcher-tempest-vm_workload_consolidation http://logs.openstack.org/48/658348/2/check/watcher-tempest-vm_workload_consolidation/edb07a9/ : SUCCESS in 46m 11s\n- watcher-tempest-workload_balancing http://logs.openstack.org/48/658348/2/check/watcher-tempest-workload_balancing/dda0263/ : SUCCESS in 49m 12s\n- watcherclient-tempest-functional http://logs.openstack.org/48/658348/2/check/watcherclient-tempest-functional/0d1552b/ : SUCCESS in 41m 26s\n- watcher-tempest-zone_migration http://logs.openstack.org/48/658348/2/check/watcher-tempest-zone_migration/b1f3e3c/ : SUCCESS in 47m 07s\n- watcher-tempest-host_maintenance http://logs.openstack.org/48/658348/2/check/watcher-tempest-host_maintenance/cfcfce2/ : SUCCESS in 48m 19s\n- watcher-tempest-storage_balance http://logs.openstack.org/48/658348/2/check/watcher-tempest-storage_balance/422c184/ : SUCCESS in 47m 26s\n- watcher-tls-test http://logs.openstack.org/48/658348/2/check/watcher-tls-test/a4203ed/ : SUCCESS in 46m 46s","accounts_in_message":[],"_revision_number":2},{"id":"5a8cc7134ebbf4405348dc30784ef5fcb26abfaf","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-15 14:04:10.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a6950679a0fd1547933a11e28fb55f9636b04930","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-15 14:06:28.000000000","message":"Patch Set 2: Code-Review+1\n\nOK the python-watcher thing clears this up (thanks for the commit message update). If it were me I\u0027d still try to write a unit test because if this is worth fixing it\u0027s worth having a test to make sure it\u0027s not regressed when something changes in this module, like a refactor, but I won\u0027t block on it either since I realize the test wouldn\u0027t be doing a whole lot besides asserting the code is doing what it is supposed to.","accounts_in_message":[],"_revision_number":2},{"id":"a77dcee5433c9948241fddfb8fba66022269fa7b","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-05-15 15:32:00.000000000","message":"Patch Set 2:\n\nSo if I understand correctly with this patch watcher should load config files from /etc/watcher/watcher.conf.d/.\n\nI just tried the patch but couldn\u0027t get the configuration to be loaded from /etc/watcher/watcher.conf.d/\n\nDo I need to specify the --config-dir paramaeter or is there a default value?\nIs the /etc/watcher/watcher.conf file loaded with a higher priority?\nDo the files /etc/watcher/watcher.conf.d/ need to have a specific name?","accounts_in_message":[],"_revision_number":2},{"id":"d83ee6a8f415fad8dd2724f72e23b790de25306d","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-05-16 06:06:57.000000000","message":"Patch Set 2:\n\nIn what scenario we need /etc/watcher/watcher.conf.d?","accounts_in_message":[],"_revision_number":2},{"id":"748fd36a79d1b8ae92ae6be16b80a7c3c1ecc308","author":{"_account_id":23735,"name":"sumitjami","email":"sjamgade@suse.com","username":"nthforloop"},"date":"2019-05-16 11:23:08.000000000","message":"Patch Set 2:\n\nDantali0n wrote:\n\n\u003e So if I understand correctly with this patch watcher should load\n\u003e config files from /etc/watcher/watcher.conf.d/.\n\nshould be able to, but not mandatory to have your config files in that folder\n\n\u003e I just tried the patch but couldn\u0027t get the configuration to be\n\u003e loaded from /etc/watcher/watcher.conf.d/\n\nIf you have provided --config-dir option oslo_config will go look in that folder.\nhere is an example of how it works\n\n```\n\nlinux:~ # python\nPython 2.7.13 (default, Jan 11 2017, 10:56:06) [GCC] on linux2\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n\u003e\u003e\u003e from oslo_config import cfg\n\u003e\u003e\u003e cfg.find_config_files(project\u003d\u0027watcher\u0027)\n[\u0027/etc/watcher/watcher.conf\u0027]\n\u003e\u003e\u003e cfg.find_config_dirs(project\u003d\u0027watcher\u0027)\n[\u0027/etc/watcher/watcher.conf.d\u0027]\n\u003e\u003e\u003e \nlinux:~ # ls /etc/watcher/*\n/etc/watcher/policy.yaml.sample  /etc/watcher/watcher.conf  /etc/watcher/watcher.conf.sample\n\n/etc/watcher/watcher.conf.d:\n100-watcher.conf\nlinux:~ # \n\n```\n\nSo now you can  oslo_config will load conf files from /etc/watcher and /etc/watcher/watcher.conf.d/\n\nand options defined in /etc/watcher/watcher.conf take precedence over those defined in conf.d directory.\n\nThere is more infor here - https://docs.openstack.org/oslo.config/ocata/cfg.html#loading-config-files","accounts_in_message":[],"_revision_number":2},{"id":"abc2ae8cbe8e0aaa8a8d4bac8c8427550e53edcb","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-05-16 11:52:24.000000000","message":"Patch Set 2: Code-Review+2\n\nThanks for the explanation got it to work.","accounts_in_message":[],"_revision_number":2},{"id":"93caabd7a8e2971b85e859ee950c2e18603de7ea","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-05-17 07:24:32.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"1fa3f5888a98631a87be5e50380fda270652834c","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-05-17 09:52:24.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"f9e66406102d01f809277db099640102800ab684","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-17 09:52:37.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"be67693406a3b90b673a088823526fadf37a43d2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-17 10:20:44.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"9e66824641db881e78f80c1d9f01c0ee52d6e447","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-17 10:20:44.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/48/658348/2/gate/openstack-tox-lower-constraints/0f3511b/ : SUCCESS in 5m 46s\n- openstack-tox-pep8 http://logs.openstack.org/48/658348/2/gate/openstack-tox-pep8/271cc6e/ : SUCCESS in 4m 48s\n- openstack-tox-py27 http://logs.openstack.org/48/658348/2/gate/openstack-tox-py27/012e9ea/ : SUCCESS in 5m 42s\n- openstack-tox-py36 http://logs.openstack.org/48/658348/2/gate/openstack-tox-py36/e1ebf14/ : SUCCESS in 5m 47s\n- openstack-tox-py37 http://logs.openstack.org/48/658348/2/gate/openstack-tox-py37/11ec1e2/ : SUCCESS in 5m 58s\n- openstack-tox-docs http://logs.openstack.org/48/658348/2/gate/openstack-tox-docs/a42e07b/html/ : SUCCESS in 5m 27s\n- watcher-tempest-functional http://logs.openstack.org/48/658348/2/gate/watcher-tempest-functional/5557ed3/ : SUCCESS in 27m 40s","accounts_in_message":[],"_revision_number":2},{"id":"5ec51096b7ec4711a9e0dc8f8b032fbe61e117ae","author":{"_account_id":1916,"name":"Guang Yee","email":"gyee@suse.com","username":"guang-yee"},"date":"2019-09-13 22:44:18.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit ec5780902ff99135e4883a6c45b3190bf6f7c5cb","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"dce23d7eb43e078729f21791ef758174e530059a","revisions":{"4d64185c90a256f373d370d4bb22b90f89b24420":{"kind":"REWORK","_number":1,"created":"2019-05-10 12:39:28.000000000","uploader":{"_account_id":23735,"name":"sumitjami","email":"sjamgade@suse.com","username":"nthforloop"},"ref":"refs/changes/48/658348/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/48/658348/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/48/658348/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/48/658348/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/48/658348/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/48/658348/1"}}},"commit":{"parents":[{"commit":"64d841b3f2ed2a8844ec2d3db6b3c711ae00839e","subject":"Merge \"Add tempest voting\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/64d841b3f2ed2a8844ec2d3db6b3c711ae00839e"}]}],"author":{"name":"Sumit Jamgade","email":"sjamgade@suse.com","date":"2019-05-10 12:31:48.000000000","tz":120},"committer":{"name":"Sumit Jamgade","email":"sjamgade@suse.com","date":"2019-05-10 12:31:48.000000000","tz":120},"subject":"pass default_config_dirs variable for config initialization.","message":"pass default_config_dirs variable for config initialization.\n\nCurrently default config files are being for initialization of CONF from\noslo_config. However default config dirs are not being passed as a\nresult watcher components (eg: decision-engine) are unable to load\nfiles from default directories (eg: /etc/watcher/watcher.conf.d)\nsupported by oslo_config. This is a short-coming on watcher\u0027s side.\nAlso this forces user to have multiple config for each component.\n\nThis patch adds the option after evaluating using project as \u0027watcher\u0027\nwhich is similar to evaluation of default_config_files and also allows\nit to be passed in as a function parameter.\n\nChange-Id: I013f9d03978f8716847f8d1ee6888629faf5779b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/4d64185c90a256f373d370d4bb22b90f89b24420"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/4d64185c90a256f373d370d4bb22b90f89b24420"}]},"branch":"refs/heads/master"},"dce23d7eb43e078729f21791ef758174e530059a":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-05-13 09:09:47.000000000","uploader":{"_account_id":23735,"name":"sumitjami","email":"sjamgade@suse.com","username":"nthforloop"},"ref":"refs/changes/48/658348/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/48/658348/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/48/658348/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/48/658348/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/48/658348/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/48/658348/2"}}},"commit":{"parents":[{"commit":"64d841b3f2ed2a8844ec2d3db6b3c711ae00839e","subject":"Merge \"Add tempest voting\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/64d841b3f2ed2a8844ec2d3db6b3c711ae00839e"}]}],"author":{"name":"Sumit Jamgade","email":"sjamgade@suse.com","date":"2019-05-10 12:31:48.000000000","tz":120},"committer":{"name":"Sumit Jamgade","email":"sjamgade@suse.com","date":"2019-05-13 08:59:55.000000000","tz":120},"subject":"pass default_config_dirs variable for config initialization.","message":"pass default_config_dirs variable for config initialization.\n\nCurrently default config files are being for initialization of CONF from\noslo_config. However default config dirs are not being passed as a\nresult watcher components (eg: decision-engine) are unable to load\nfiles from default directories (eg: /etc/watcher/watcher.conf.d)\nsupported by oslo_config. This is a short-coming on watcher\u0027s side.\nAlso this forces user to have multiple config for each component.\n\nWithout this default set, oslo_config will search for conf with string\n\u0027python-watcher\u0027 in it, eg: /etc/python-watcher/.... Since there is a\nbecause project\u003dpython-watcher a couple of lines below\n\nThis patch adds the option after evaluating using project as \u0027watcher\u0027\nwhich is similar to evaluation of default_config_files and also allows\nit to be passed in as a function parameter.\n\nChange-Id: I013f9d03978f8716847f8d1ee6888629faf5779b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/dce23d7eb43e078729f21791ef758174e530059a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/dce23d7eb43e078729f21791ef758174e530059a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
