)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6909bd4302f4c6a581643e59d7cbc4a657011446","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update migration notification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"instance.live_migration_post.end is the last notification,"},{"line_number":10,"context_line":"so we should use instance.live_migration_post.end instead of"},{"line_number":11,"context_line":"instance.live_migration_post_dest.end notification."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfbec78f_ca6fda28","line":9,"updated":"2019-05-15 14:13:03.000000000","message":"Correct:\n\nhttps://github.com/openstack/nova/blob/daa2ac2287df12dfdee532d66ef97a03350ca6af/nova/compute/manager.py#L6907\n\n_post_live_migration runs on the source host and calls post_live_migration_at_destination on the dest host which emits the instance.live_migration_post_dest.end notification:\n\nhttps://github.com/openstack/nova/blob/daa2ac2287df12dfdee532d66ef97a03350ca6af/nova/compute/manager.py#L7035\n\nBut it\u0027s not the last notification for the live migration operation.\n\nAlso verified in a nova functional test for the notifications here:\n\nhttps://github.com/openstack/nova/blob/daa2ac2287df12dfdee532d66ef97a03350ca6af/nova/tests/functional/notification_sample_tests/test_instance.py#L153","commit_id":"024f723e77d58707e0d08ea3c3039286c70f6010"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"f04ab7e6ffbf947e77f0dd6f3926cf02720b1bc7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update migration notification"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"instance.live_migration_post.end is the last notification,"},{"line_number":10,"context_line":"so we should use instance.live_migration_post.end instead of"},{"line_number":11,"context_line":"instance.live_migration_post_dest.end notification."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfbec78f_e91c1f79","line":9,"in_reply_to":"dfbec78f_ca6fda28","updated":"2019-05-16 07:58:13.000000000","message":"Done","commit_id":"024f723e77d58707e0d08ea3c3039286c70f6010"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6909bd4302f4c6a581643e59d7cbc4a657011446","unresolved":false,"context_lines":[{"line_number":9,"context_line":"instance.live_migration_post.end is the last notification,"},{"line_number":10,"context_line":"so we should use instance.live_migration_post.end instead of"},{"line_number":11,"context_line":"instance.live_migration_post_dest.end notification."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id1e2d98f56d5a95d49e32f98d2910660b9f48ce6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfbec78f_4a176aa5","line":12,"updated":"2019-05-15 14:13:03.000000000","message":"Seems there should be a bug reported for this. In fact is this for bug 1828598?","commit_id":"024f723e77d58707e0d08ea3c3039286c70f6010"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"9275899c9ddef66e11063a53b76f280651d959ed","unresolved":false,"context_lines":[{"line_number":9,"context_line":"instance.live_migration_post.end is the last notification,"},{"line_number":10,"context_line":"so we should use instance.live_migration_post.end instead of"},{"line_number":11,"context_line":"instance.live_migration_post_dest.end notification."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id1e2d98f56d5a95d49e32f98d2910660b9f48ce6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfbec78f_297557fa","line":12,"in_reply_to":"dfbec78f_4a176aa5","updated":"2019-05-16 07:47:35.000000000","message":"this is for bug 1828598\nhttps://review.opendev.org/#/c/658725/","commit_id":"024f723e77d58707e0d08ea3c3039286c70f6010"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3197d5fd64e7fbbc2164488fc557c6ca29ed67d1","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1]https://github.com/openstack/nova/blob/daa2ac2287df12dfdee532d66ef97a03350ca6af/nova/compute/manager.py#L6907"},{"line_number":17,"context_line":"[2]https://github.com/openstack/nova/blob/daa2ac2287df12dfdee532d66ef97a03350ca6af/nova/compute/manager.py#L7035"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Id1e2d98f56d5a95d49e32f98d2910660b9f48ce6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bfb3d3c7_882d37aa","line":18,"updated":"2019-05-16 18:41:15.000000000","message":"Related-Bug: #1828598\n\nSo I guess https://review.opendev.org/#/c/658725/ fixes the bug because tempest is waiting for the live migration to complete now?\n\nBut shouldn\u0027t tempest be waiting on the action plan to complete and shouldn\u0027t the action plan be waiting on the live migration to complete? I thought that was the problem. Or is the tempest test doing it\u0027s own wait concurrently to the action plan or something?","commit_id":"6d965121880f7d581d5773faa9d6c9c6eb65ce65"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"e8a07b9f691453b8933debb3262774f24ecb8cba","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1]https://github.com/openstack/nova/blob/daa2ac2287df12dfdee532d66ef97a03350ca6af/nova/compute/manager.py#L6907"},{"line_number":17,"context_line":"[2]https://github.com/openstack/nova/blob/daa2ac2287df12dfdee532d66ef97a03350ca6af/nova/compute/manager.py#L7035"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Id1e2d98f56d5a95d49e32f98d2910660b9f48ce6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bfb3d3c7_c4745a9c","line":18,"in_reply_to":"bfb3d3c7_1ac2d034","updated":"2019-05-20 01:26:44.000000000","message":"Yes, and also thank you for your help with Watcher!","commit_id":"6d965121880f7d581d5773faa9d6c9c6eb65ce65"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"3a0d03354844be68dbca6479052de0d8a8b75cd3","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1]https://github.com/openstack/nova/blob/daa2ac2287df12dfdee532d66ef97a03350ca6af/nova/compute/manager.py#L6907"},{"line_number":17,"context_line":"[2]https://github.com/openstack/nova/blob/daa2ac2287df12dfdee532d66ef97a03350ca6af/nova/compute/manager.py#L7035"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Id1e2d98f56d5a95d49e32f98d2910660b9f48ce6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bfb3d3c7_927a3986","line":18,"in_reply_to":"bfb3d3c7_882d37aa","updated":"2019-05-17 06:39:15.000000000","message":"tempest waits action plan [1] and action plan also waits action[2]\n[1] https://github.com/openstack/watcher-tempest-plugin/blob/master/watcher_tempest_plugin/tests/scenario/test_execute_basic_optim.py#L122\n[2] https://github.com/openstack/watcher/blob/master/watcher/applier/workflow_engine/default.py#L85\nThe reason of bug #1828598, for that test case, strategy should be executed after the migration finished. but because of no waiting for the migration, they are executed in parallel.\nand strategy spent less time than migration then when the strategy finished, tempest release the resource and delete servers.","commit_id":"6d965121880f7d581d5773faa9d6c9c6eb65ce65"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"887f41f43f2ed82fef2a200bf0ffada05f9b91c3","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1]https://github.com/openstack/nova/blob/daa2ac2287df12dfdee532d66ef97a03350ca6af/nova/compute/manager.py#L6907"},{"line_number":17,"context_line":"[2]https://github.com/openstack/nova/blob/daa2ac2287df12dfdee532d66ef97a03350ca6af/nova/compute/manager.py#L7035"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Id1e2d98f56d5a95d49e32f98d2910660b9f48ce6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bfb3d3c7_1ac2d034","line":18,"in_reply_to":"bfb3d3c7_927a3986","updated":"2019-05-18 18:31:54.000000000","message":"\u003e but because of no waiting for the migration\n\nOK and that\u0027s what you added with https://review.opendev.org/#/c/658725/ right? Thanks for patiently explaining, I\u0027m trying to learn the flow here.","commit_id":"6d965121880f7d581d5773faa9d6c9c6eb65ce65"}]}