)]}'
{"doc/source/man/watcher-status.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a26c71a21393270ceebf9aa9fa4406b15ccf4a12","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  **History of Checks**"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"  **1.12.0 (Stein)**"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  * Sample check to be filled in with checks as they are added in Stein."},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dfbec78f_d604731a","line":81,"range":{"start_line":81,"start_character":4,"end_line":81,"end_character":10},"updated":"2019-05-15 00:50:13.000000000","message":"This should actually be 2.0.0. I can fix separately.","commit_id":"a28f4750f103316466d251923ac94c144eb7b265"}],"watcher/common/clients.py":[{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"126667aec081957d2add780b55f94052ad64ee19","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# watcher features to work. If new features are added which require new"},{"line_number":40,"context_line":"# versions, they should perform version discovery and be backward compatible"},{"line_number":41,"context_line":"# for at least one release before raising the minimum required version."},{"line_number":42,"context_line":"MIN_NOVA_API_VERSION \u003d \u00272.53\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def check_min_nova_api_version(config_version):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfbec78f_98f613d7","line":42,"range":{"start_line":42,"start_character":24,"end_line":42,"end_character":28},"updated":"2019-05-16 03:38:22.000000000","message":"I think the minimum version should be 2.56 because of https://github.com/openstack/watcher/blob/master/watcher/common/nova_helper.py#L145","commit_id":"e026637cd26356e82b793d1b32e71ab15be8b9e5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"74df56ff6f376f0dc5af6d16a45f1563ca72314b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# watcher features to work. If new features are added which require new"},{"line_number":40,"context_line":"# versions, they should perform version discovery and be backward compatible"},{"line_number":41,"context_line":"# for at least one release before raising the minimum required version."},{"line_number":42,"context_line":"MIN_NOVA_API_VERSION \u003d \u00272.53\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def check_min_nova_api_version(config_version):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_c9bebffe","line":42,"range":{"start_line":42,"start_character":24,"end_line":42,"end_character":28},"in_reply_to":"bfb3d3c7_9d1b2f72","updated":"2019-05-17 19:00:31.000000000","message":"OK so it sounds like I should make the minimum required version 2.56 in this change, and then in a follow up I can remove the compatibility code in watcher_non_live_migrate_instance:\n\nhttps://github.com/openstack/watcher/blob/f337c67bfe2108fa326f556db711b544fcce3690/watcher/common/nova_helper.py#L173\n\nI figure we\u0027ll leave _check_nova_api_version since it can be used for future compatibility checks.","commit_id":"e026637cd26356e82b793d1b32e71ab15be8b9e5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d9fafa625dd17c75d4c3fa21f5ea36afa2900d04","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# watcher features to work. If new features are added which require new"},{"line_number":40,"context_line":"# versions, they should perform version discovery and be backward compatible"},{"line_number":41,"context_line":"# for at least one release before raising the minimum required version."},{"line_number":42,"context_line":"MIN_NOVA_API_VERSION \u003d \u00272.53\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def check_min_nova_api_version(config_version):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_08ed4e24","line":42,"range":{"start_line":42,"start_character":24,"end_line":42,"end_character":28},"in_reply_to":"bfb3d3c7_c9bebffe","updated":"2019-05-23 19:54:10.000000000","message":"Done","commit_id":"e026637cd26356e82b793d1b32e71ab15be8b9e5"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"1b4798530716dcc6d5a409e84ad10d2b85473372","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# watcher features to work. If new features are added which require new"},{"line_number":40,"context_line":"# versions, they should perform version discovery and be backward compatible"},{"line_number":41,"context_line":"# for at least one release before raising the minimum required version."},{"line_number":42,"context_line":"MIN_NOVA_API_VERSION \u003d \u00272.53\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def check_min_nova_api_version(config_version):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_9d1b2f72","line":42,"range":{"start_line":42,"start_character":24,"end_line":42,"end_character":28},"in_reply_to":"bfb3d3c7_e8f5d384","updated":"2019-05-17 02:34:05.000000000","message":"As you mentioned, watcher_non_live_migrate_instance will return False if api version lower 2.56. This will cause migrate return False[1], then action will fail[2] and result the action plan failed[3].\n[1]https://github.com/openstack/watcher/blob/master/watcher/applier/actions/migration.py#L172\n[2]https://github.com/openstack/watcher/blob/master/watcher/applier/workflow_engine/default.py#L151\n[3]https://github.com/openstack/watcher/blob/master/watcher/applier/action_plan/default.py#L89","commit_id":"e026637cd26356e82b793d1b32e71ab15be8b9e5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"52c7bf87038ae4f9e9432f8675e906b5de35c42b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# watcher features to work. If new features are added which require new"},{"line_number":40,"context_line":"# versions, they should perform version discovery and be backward compatible"},{"line_number":41,"context_line":"# for at least one release before raising the minimum required version."},{"line_number":42,"context_line":"MIN_NOVA_API_VERSION \u003d \u00272.53\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def check_min_nova_api_version(config_version):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_e8f5d384","line":42,"range":{"start_line":42,"start_character":24,"end_line":42,"end_character":28},"in_reply_to":"dfbec78f_98f613d7","updated":"2019-05-16 18:17:48.000000000","message":"I wasn\u0027t sure about that because of this code:\n\nhttps://github.com/openstack/watcher/blob/master/watcher/common/nova_helper.py#L171\n\nWhich does the version check and if nova isn\u0027t new enough it logs an error and returns. I\u0027m not really sure what that does to the audit though, does it fail, or try to migrate without a dest host?\n\nAnyway, that\u0027s why I didn\u0027t make the minimum 2.56.\n\nI think if we make the minimum 2.56 then we should drop that compatibility code, what do you think? If so, I would prefer to do that in a separate change (either before or after this) and then make the minimum required nova_client.api_version 2.56.","commit_id":"e026637cd26356e82b793d1b32e71ab15be8b9e5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a17542182a1047cb22e36a4cd66fb965e00a87d2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        minimum"},{"line_number":51,"context_line":"    \"\"\""},{"line_number":52,"context_line":"    min_required \u003d nova_api_versions.APIVersion(MIN_NOVA_API_VERSION)"},{"line_number":53,"context_line":"    if nova_api_versions.APIVersion(config_version) \u003c min_required:"},{"line_number":54,"context_line":"        raise ValueError(\u0027Invalid nova_client.api_version %s. %s or \u0027"},{"line_number":55,"context_line":"                         \u0027greater is required.\u0027 % (config_version,"},{"line_number":56,"context_line":"                                                   MIN_NOVA_API_VERSION))"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_bbc78696","line":53,"range":{"start_line":53,"start_character":7,"end_line":53,"end_character":51},"updated":"2019-05-27 11:46:52.000000000","message":"this doesn\u0027t work when config_version is integer:- UnsupportedVersion: Invalid format of client version \u00272\u0027. Expected format \u0027X.Y\u0027, where X is a major part and Y is a minor part of version.\n\nseeing in some job[1] where nova/api_version\u003d2 as puppet-watcher set\u0027s it to 2:- https://github.com/openstack/puppet-watcher/blob/2bd375adbe19af15765c7f0b0b5186c752e852f0/manifests/init.pp#L307\n\nCan u check is such failure expected, shouldn\u0027t it be handled on novaclient side? or puppet-watch should set non-integer.\n\n[1] https://centos.logs.rdoproject.org/weirdo-generic-puppet-openstack-scenario004/6287/weirdo-project/logs/watcher/applier.txt.gz#_2019-05-27_09_28_25_984","commit_id":"7489126d83764779f92ba61e0091d839f1adfbbd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2ca38358b8e07e492f929a74e5c6c8d754bec1a4","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        minimum"},{"line_number":51,"context_line":"    \"\"\""},{"line_number":52,"context_line":"    min_required \u003d nova_api_versions.APIVersion(MIN_NOVA_API_VERSION)"},{"line_number":53,"context_line":"    if nova_api_versions.APIVersion(config_version) \u003c min_required:"},{"line_number":54,"context_line":"        raise ValueError(\u0027Invalid nova_client.api_version %s. %s or \u0027"},{"line_number":55,"context_line":"                         \u0027greater is required.\u0027 % (config_version,"},{"line_number":56,"context_line":"                                                   MIN_NOVA_API_VERSION))"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_e5130d5b","line":53,"range":{"start_line":53,"start_character":7,"end_line":53,"end_character":51},"in_reply_to":"bfb3d3c7_bbc78696","updated":"2019-05-28 13:25:08.000000000","message":"Setting it to 2 would be treated as 2.0 which wouldn\u0027t work with current watcher anyway since watcher requires 2.47 for some of the server flavor response parsing and 2.53 for some of the nova CDM code, so puppet-watcher was likely already broken. Does anyone use it?","commit_id":"7489126d83764779f92ba61e0091d839f1adfbbd"}],"watcher/conf/nova_client.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d9fafa625dd17c75d4c3fa21f5ea36afa2900d04","unresolved":false,"context_lines":[{"line_number":27,"context_line":"               help\u003d\"\"\""},{"line_number":28,"context_line":"Version of Nova API to use in novaclient."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Minimum required version: 2.53"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Certain Watcher features depend on a minimum version of the compute"},{"line_number":33,"context_line":"API being available which is enforced with this option. See"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_68c64a9d","line":30,"range":{"start_line":30,"start_character":26,"end_line":30,"end_character":30},"updated":"2019-05-23 19:54:10.000000000","message":"Will use a replacement variable here.","commit_id":"e026637cd26356e82b793d1b32e71ab15be8b9e5"}]}