)]}'
{"id":"openstack%2Fwatcher~659307","triplet_id":"openstack%2Fwatcher~master~I16990afb82019821c443c9df26d3e515e52efa69","project":"openstack/watcher","branch":"master","topic":"bug/1828582","hashtags":[],"change_id":"I16990afb82019821c443c9df26d3e515e52efa69","subject":"Handle no nova CDM in notification code","status":"MERGED","created":"2019-05-15 15:03:26.000000000","updated":"2019-05-22 15:38:49.000000000","submitted":"2019-05-22 02:57:56.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"659307-1558493876204-b16e9fe7","meta_rev_id":"51999c00722a9add9311a3094eb8aa3df7299392","_number":659307,"virtual_id_number":659307,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-05-22 02:57:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-05-21 06:02:56.000000000","_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":2,"date":"2019-05-22 02:19:38.000000000","_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-05-22 02:23:50.000000000","_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-22 02:19:38.000000000","updated_by":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"reviewer":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"state":"REVIEWER"},{"updated":"2019-05-22 02:23:50.000000000","updated_by":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"reviewer":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"state":"REVIEWER"},{"updated":"2019-05-22 02:57:56.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d88b1dc82d698ca31802704884fb73f8ea8c9aa5","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-15 15:03:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"872b448adc1f6309cb74199e9dc267a70ede0504","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-15 16:25:43.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover http://logs.openstack.org/07/659307/1/check/openstack-tox-cover/e028787/cover/ : SUCCESS in 5m 55s\n- openstack-tox-lower-constraints http://logs.openstack.org/07/659307/1/check/openstack-tox-lower-constraints/f4a385b/ : FAILURE in 4m 52s\n- openstack-tox-pep8 http://logs.openstack.org/07/659307/1/check/openstack-tox-pep8/2798987/ : SUCCESS in 5m 30s\n- openstack-tox-py27 http://logs.openstack.org/07/659307/1/check/openstack-tox-py27/16a96af/ : SUCCESS in 4m 58s\n- openstack-tox-py36 http://logs.openstack.org/07/659307/1/check/openstack-tox-py36/6633be6/ : SUCCESS in 5m 11s\n- openstack-tox-py37 http://logs.openstack.org/07/659307/1/check/openstack-tox-py37/fbed0d3/ : SUCCESS in 5m 44s\n- openstack-tox-docs http://logs.openstack.org/07/659307/1/check/openstack-tox-docs/785d004/html/ : SUCCESS in 5m 19s\n- watcher-tempest-functional http://logs.openstack.org/07/659307/1/check/watcher-tempest-functional/e6ce7d7/ : SUCCESS in 31m 31s\n- watcher-grenade http://logs.openstack.org/07/659307/1/check/watcher-grenade/eac91aa/ : SUCCESS in 44m 17s\n- watcher-tempest-dummy_optim http://logs.openstack.org/07/659307/1/check/watcher-tempest-dummy_optim/ec748a4/ : SUCCESS in 1h 04m 12s\n- watcher-tempest-actuator http://logs.openstack.org/07/659307/1/check/watcher-tempest-actuator/053a436/ : SUCCESS in 54m 11s\n- watcher-tempest-basic_optim http://logs.openstack.org/07/659307/1/check/watcher-tempest-basic_optim/bfe6564/ : SUCCESS in 42m 25s\n- watcher-tempest-vm_workload_consolidation http://logs.openstack.org/07/659307/1/check/watcher-tempest-vm_workload_consolidation/d40133d/ : SUCCESS in 43m 10s\n- watcher-tempest-workload_balancing http://logs.openstack.org/07/659307/1/check/watcher-tempest-workload_balancing/5cf4ae2/ : SUCCESS in 48m 31s\n- watcherclient-tempest-functional http://logs.openstack.org/07/659307/1/check/watcherclient-tempest-functional/0097614/ : SUCCESS in 35m 01s\n- watcher-tempest-zone_migration http://logs.openstack.org/07/659307/1/check/watcher-tempest-zone_migration/04b0ece/ : SUCCESS in 48m 53s\n- watcher-tempest-host_maintenance http://logs.openstack.org/07/659307/1/check/watcher-tempest-host_maintenance/efb216a/ : SUCCESS in 52m 00s\n- watcher-tempest-storage_balance http://logs.openstack.org/07/659307/1/check/watcher-tempest-storage_balance/a53f025/ : SUCCESS in 49m 28s\n- watcher-tls-test http://logs.openstack.org/07/659307/1/check/watcher-tls-test/ff0c6a9/ : SUCCESS in 54m 39s","accounts_in_message":[],"_revision_number":1},{"id":"63f998e75f13a9fde9bdf8b553ca15ce7c40d0fd","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-15 18:19:52.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8b4f5e4b4611c7e338d8004eab5dd5df3ca1b29b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-15 19:26:07.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/07/659307/2/check/openstack-tox-cover/8e08eeb/cover/ : SUCCESS in 5m 50s\n- openstack-tox-lower-constraints http://logs.openstack.org/07/659307/2/check/openstack-tox-lower-constraints/df2405f/ : SUCCESS in 8m 16s\n- openstack-tox-pep8 http://logs.openstack.org/07/659307/2/check/openstack-tox-pep8/af2bb2b/ : SUCCESS in 5m 35s\n- openstack-tox-py27 http://logs.openstack.org/07/659307/2/check/openstack-tox-py27/68a5e98/ : SUCCESS in 5m 17s\n- openstack-tox-py36 http://logs.openstack.org/07/659307/2/check/openstack-tox-py36/a604b57/ : SUCCESS in 5m 52s\n- openstack-tox-py37 http://logs.openstack.org/07/659307/2/check/openstack-tox-py37/d4b6aa3/ : SUCCESS in 6m 48s\n- openstack-tox-docs http://logs.openstack.org/07/659307/2/check/openstack-tox-docs/893be9e/html/ : SUCCESS in 5m 05s\n- watcher-tempest-functional http://logs.openstack.org/07/659307/2/check/watcher-tempest-functional/ec370c6/ : SUCCESS in 29m 42s\n- watcher-grenade http://logs.openstack.org/07/659307/2/check/watcher-grenade/d4d8fae/ : SUCCESS in 43m 59s\n- watcher-tempest-dummy_optim http://logs.openstack.org/07/659307/2/check/watcher-tempest-dummy_optim/fa20b92/ : SUCCESS in 47m 24s\n- watcher-tempest-actuator http://logs.openstack.org/07/659307/2/check/watcher-tempest-actuator/48bfd58/ : SUCCESS in 45m 35s\n- watcher-tempest-basic_optim http://logs.openstack.org/07/659307/2/check/watcher-tempest-basic_optim/c05d576/ : SUCCESS in 46m 13s\n- watcher-tempest-vm_workload_consolidation http://logs.openstack.org/07/659307/2/check/watcher-tempest-vm_workload_consolidation/edfe971/ : SUCCESS in 44m 00s\n- watcher-tempest-workload_balancing http://logs.openstack.org/07/659307/2/check/watcher-tempest-workload_balancing/6166984/ : SUCCESS in 46m 45s\n- watcherclient-tempest-functional http://logs.openstack.org/07/659307/2/check/watcherclient-tempest-functional/0638364/ : SUCCESS in 37m 15s\n- watcher-tempest-zone_migration http://logs.openstack.org/07/659307/2/check/watcher-tempest-zone_migration/c5c247f/ : SUCCESS in 47m 11s\n- watcher-tempest-host_maintenance http://logs.openstack.org/07/659307/2/check/watcher-tempest-host_maintenance/0220c06/ : SUCCESS in 52m 01s\n- watcher-tempest-storage_balance http://logs.openstack.org/07/659307/2/check/watcher-tempest-storage_balance/dd28050/ : SUCCESS in 43m 51s\n- watcher-tls-test http://logs.openstack.org/07/659307/2/check/watcher-tls-test/7d93656/ : SUCCESS in 47m 58s","accounts_in_message":[],"_revision_number":2},{"id":"ce5fbd119f7c653141f3272821637c50b59188a4","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-05-16 02:36:59.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2fc0a55dc157469c4f1aa0ae8215c68efd33b814","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-16 18:45:32.000000000","message":"Patch Set 2: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e333358c402697f1bb701dfbe92b0aef0ec78e50","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-16 21:30:20.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"88079d60b10feab0d64f0c465686bad3c5a619cc","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-16 21:48:02.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"fdf59e26a9a9d103cc2d017aeaac1d2002331a06","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-16 22:53:28.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/07/659307/3/check/openstack-tox-cover/06a55db/cover/ : SUCCESS in 5m 25s\n- openstack-tox-lower-constraints http://logs.openstack.org/07/659307/3/check/openstack-tox-lower-constraints/1788a5c/ : SUCCESS in 5m 47s\n- openstack-tox-pep8 http://logs.openstack.org/07/659307/3/check/openstack-tox-pep8/91c3c5e/ : SUCCESS in 5m 27s\n- openstack-tox-py27 http://logs.openstack.org/07/659307/3/check/openstack-tox-py27/44d4e97/ : SUCCESS in 6m 17s\n- openstack-tox-py36 http://logs.openstack.org/07/659307/3/check/openstack-tox-py36/a0e9dbe/ : SUCCESS in 7m 36s\n- openstack-tox-py37 http://logs.openstack.org/07/659307/3/check/openstack-tox-py37/480012a/ : SUCCESS in 5m 55s\n- openstack-tox-docs http://logs.openstack.org/07/659307/3/check/openstack-tox-docs/7f9bdc7/html/ : SUCCESS in 6m 09s\n- watcher-tempest-functional http://logs.openstack.org/07/659307/3/check/watcher-tempest-functional/85aa783/ : SUCCESS in 34m 50s\n- watcher-grenade http://logs.openstack.org/07/659307/3/check/watcher-grenade/40e1550/ : SUCCESS in 47m 10s\n- watcher-tempest-dummy_optim http://logs.openstack.org/07/659307/3/check/watcher-tempest-dummy_optim/e387480/ : SUCCESS in 43m 58s\n- watcher-tempest-actuator http://logs.openstack.org/07/659307/3/check/watcher-tempest-actuator/a86ec14/ : SUCCESS in 52m 18s\n- watcher-tempest-basic_optim http://logs.openstack.org/07/659307/3/check/watcher-tempest-basic_optim/ac95d64/ : SUCCESS in 46m 25s\n- watcher-tempest-vm_workload_consolidation http://logs.openstack.org/07/659307/3/check/watcher-tempest-vm_workload_consolidation/a1e333f/ : SUCCESS in 51m 07s\n- watcher-tempest-workload_balancing http://logs.openstack.org/07/659307/3/check/watcher-tempest-workload_balancing/ab7b1e2/ : SUCCESS in 45m 55s\n- watcherclient-tempest-functional http://logs.openstack.org/07/659307/3/check/watcherclient-tempest-functional/d18fa5d/ : SUCCESS in 38m 21s\n- watcher-tempest-zone_migration http://logs.openstack.org/07/659307/3/check/watcher-tempest-zone_migration/485366a/ : SUCCESS in 50m 57s\n- watcher-tempest-host_maintenance http://logs.openstack.org/07/659307/3/check/watcher-tempest-host_maintenance/748565c/ : SUCCESS in 48m 38s\n- watcher-tempest-storage_balance http://logs.openstack.org/07/659307/3/check/watcher-tempest-storage_balance/87c7c74/ : SUCCESS in 47m 15s\n- watcher-tls-test http://logs.openstack.org/07/659307/3/check/watcher-tls-test/1fccd03/ : SUCCESS in 49m 27s","accounts_in_message":[],"_revision_number":3},{"id":"d29707f458d4a2c801ccc9a1140cb46b36770ccd","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-05-21 06:02:56.000000000","message":"Patch Set 3: Code-Review+2\n\nLGTM, thanks!","accounts_in_message":[],"_revision_number":3},{"id":"a0f01715b7f14a503452f6bd8ee9c354323dee43","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-05-22 02:19:38.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"0cea5ae529fc51c5c89a67ddae4a7e4520516f1a","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-05-22 02:23:50.000000000","message":"Patch Set 3: Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"238c6073a6abf29f3dce67b91807a0fa88d6534c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-22 02:24:02.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"7a2a21f1acba097b7a93d466a6732dade721a872","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-22 02:57:56.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/07/659307/3/gate/openstack-tox-lower-constraints/3ea4184/ : SUCCESS in 5m 27s\n- openstack-tox-pep8 http://logs.openstack.org/07/659307/3/gate/openstack-tox-pep8/5b8e891/ : SUCCESS in 6m 25s\n- openstack-tox-py27 http://logs.openstack.org/07/659307/3/gate/openstack-tox-py27/c1ca9cd/ : SUCCESS in 4m 47s\n- openstack-tox-py36 http://logs.openstack.org/07/659307/3/gate/openstack-tox-py36/231c4d6/ : SUCCESS in 5m 14s\n- openstack-tox-py37 http://logs.openstack.org/07/659307/3/gate/openstack-tox-py37/b6f4b86/ : SUCCESS in 5m 25s\n- openstack-tox-docs http://logs.openstack.org/07/659307/3/gate/openstack-tox-docs/e8e0ed5/html/ : SUCCESS in 5m 24s\n- watcher-tempest-functional http://logs.openstack.org/07/659307/3/gate/watcher-tempest-functional/146bd84/ : SUCCESS in 29m 29s","accounts_in_message":[],"_revision_number":3},{"id":"620884efb0a56decbd4cb9b118e83308b536c0b9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-22 02:57:56.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"432bdaa5b5070b1d7cf789c4661c75382d0963f4","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-22 15:38:49.000000000","message":"Patch Set 3: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit 3c75c13f80bfb9d82f043beae6bed97ca72557ff","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"8a206a6ae55220687a240a33062c68d947df3512","revisions":{"e2ea18563ac9c33ce39a3172876dedfb5ed09402":{"kind":"REWORK","_number":1,"created":"2019-05-15 15:03:26.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/07/659307/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/07/659307/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/07/659307/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/07/659307/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/07/659307/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/07/659307/1"}}},"commit":{"parents":[{"commit":"15c842fba2adff14be90afd71441466d16df9839","subject":"Update Sphinx requirement","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/15c842fba2adff14be90afd71441466d16df9839"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-05-15 15:00:18.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-05-15 15:00:18.000000000","tz":-240},"subject":"Handle no nova CDM in notification code","message":"Handle no nova CDM in notification code\n\nAs of change Ic4659d1f18af181203439a8bf1b38805ff34c309 the\nnova CDM will not be built until an audit is performed.\n\nAn instance.update notification can be received and processed\nwhile building a server (during scheduling) before an audit\nis ever run to create the nova CDM which will result in an\nAttributeError when NovaNotification.get_or_create_instance\ncalls self.cluster_data_model.get_instance_by_uuid.\n\nThis change side-steps that issue by checking to see that the\nnova CDM exists before trying to use it.\n\nAn alternative to this is forcefully create the nova CDM when\nnotifications are received before an audit which is what happend\nbefore change Ic4659d1f18af181203439a8bf1b38805ff34c309.\n\nChange-Id: I16990afb82019821c443c9df26d3e515e52efa69\nCloses-Bug: #1828582\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/e2ea18563ac9c33ce39a3172876dedfb5ed09402"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/e2ea18563ac9c33ce39a3172876dedfb5ed09402"}]},"branch":"refs/heads/master"},"06eac5ac8b706b7e343ceaced6f3e4fe2f81c1b0":{"kind":"REWORK","_number":2,"created":"2019-05-15 18:19:52.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/07/659307/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/07/659307/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/07/659307/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/07/659307/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/07/659307/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/07/659307/2"}}},"commit":{"parents":[{"commit":"15c842fba2adff14be90afd71441466d16df9839","subject":"Update Sphinx requirement","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/15c842fba2adff14be90afd71441466d16df9839"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-05-15 15:00:18.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-05-15 18:19:45.000000000","tz":-240},"subject":"Handle no nova CDM in notification code","message":"Handle no nova CDM in notification code\n\nAs of change Ic4659d1f18af181203439a8bf1b38805ff34c309 the\nnova CDM will not be built until an audit is performed.\n\nAn instance.update notification can be received and processed\nwhile building a server (during scheduling) before an audit\nis ever run to create the nova CDM which will result in an\nAttributeError when NovaNotification.get_or_create_instance\ncalls self.cluster_data_model.get_instance_by_uuid.\n\nThis change side-steps that issue by checking to see that the\nnova CDM exists before trying to use it.\n\nAn alternative to this is forcefully create the nova CDM when\nnotifications are received before an audit which is what happend\nbefore change Ic4659d1f18af181203439a8bf1b38805ff34c309.\n\nChange-Id: I16990afb82019821c443c9df26d3e515e52efa69\nCloses-Bug: #1828582\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/06eac5ac8b706b7e343ceaced6f3e4fe2f81c1b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/06eac5ac8b706b7e343ceaced6f3e4fe2f81c1b0"}]},"branch":"refs/heads/master"},"8a206a6ae55220687a240a33062c68d947df3512":{"kind":"REWORK","_number":3,"created":"2019-05-16 21:48:02.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/07/659307/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/07/659307/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/07/659307/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/07/659307/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/07/659307/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/07/659307/3"}}},"commit":{"parents":[{"commit":"15c842fba2adff14be90afd71441466d16df9839","subject":"Update Sphinx requirement","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/15c842fba2adff14be90afd71441466d16df9839"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-05-15 15:00:18.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-05-16 21:45:44.000000000","tz":-240},"subject":"Handle no nova CDM in notification code","message":"Handle no nova CDM in notification code\n\nAs of change Ic4659d1f18af181203439a8bf1b38805ff34c309 the\nnova CDM will not be built until an audit is performed.\n\nInstances and services (compute hosts) can be created and\ndeleted before an audit is performed which will attempt\nto use the notification callback function which relies\non the CDM being built already, and if not results in\nan AttributeError.\n\nThis change side-steps that issue by checking to see that the\nnova CDM exists before trying to call the notification\ncallback function.\n\nAn alternative to this is forcefully create the nova CDM when\nnotifications are received before an audit which is what happend\nbefore change Ic4659d1f18af181203439a8bf1b38805ff34c309.\n\nChange-Id: I16990afb82019821c443c9df26d3e515e52efa69\nCloses-Bug: #1828582\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/8a206a6ae55220687a240a33062c68d947df3512"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/8a206a6ae55220687a240a33062c68d947df3512"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}