)]}'
{"id":"openstack%2Fwatcher~659726","triplet_id":"openstack%2Fwatcher~master~Idfd099f718873d9056fdc35a97954771c9ae5762","project":"openstack/watcher","branch":"master","topic":"bug/1829542","hashtags":[],"change_id":"Idfd099f718873d9056fdc35a97954771c9ae5762","subject":"Fix typo in ceilometer datasource","status":"MERGED","created":"2019-05-17 07:07:19.000000000","updated":"2019-05-20 07:44:55.000000000","submitted":"2019-05-20 07:44:55.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"659726-1558338295377-334d6ac5","meta_rev_id":"4a737909855e8f3c4d083ca7fad79f5bd80181a1","_number":659726,"virtual_id_number":659726,"owner":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-05-20 07:44:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"date":"2019-05-20 06:59:15.000000000","_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-05-18 02:58:11.000000000","_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-05-20 06:50:15.000000000","_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-05-20 07:02:15.000000000","_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-17 13:54:27.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-05-20 06:50:15.000000000","updated_by":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"reviewer":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"state":"REVIEWER"},{"updated":"2019-05-20 07:02:15.000000000","updated_by":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"reviewer":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"state":"REVIEWER"},{"updated":"2019-05-20 07:44:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"98a45424def3f2108d7b18ddf7cf868fd9e485ed","author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"date":"2019-05-17 07:07:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cfadb928321a97ae8f196f2ead15381c866d5ca6","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-05-17 07:32:29.000000000","message":"Patch Set 1: Code-Review+2\n\nAh yes this should not have been changed yet, this should change to \u0027aggregate\u0027 with the merging of https://review.opendev.org/#/c/656622/","accounts_in_message":[],"_revision_number":1},{"id":"3d95abcafd994b31b770aa5acda49f41d068827a","author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"date":"2019-05-17 08:03:30.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"abd619e58f59b944a3a07fc612b8d864e821b17f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-17 08:59:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/26/659726/2/check/openstack-tox-cover/858c3b5/cover/ : SUCCESS in 5m 29s\n- openstack-tox-lower-constraints http://logs.openstack.org/26/659726/2/check/openstack-tox-lower-constraints/d6fe965/ : SUCCESS in 5m 44s\n- openstack-tox-pep8 http://logs.openstack.org/26/659726/2/check/openstack-tox-pep8/2f84b0e/ : SUCCESS in 5m 07s\n- openstack-tox-py27 http://logs.openstack.org/26/659726/2/check/openstack-tox-py27/20300e9/ : SUCCESS in 5m 17s\n- openstack-tox-py36 http://logs.openstack.org/26/659726/2/check/openstack-tox-py36/7e0aa1c/ : SUCCESS in 4m 40s\n- openstack-tox-py37 http://logs.openstack.org/26/659726/2/check/openstack-tox-py37/f587b08/ : SUCCESS in 5m 50s\n- openstack-tox-docs http://logs.openstack.org/26/659726/2/check/openstack-tox-docs/7689a4e/html/ : SUCCESS in 5m 09s\n- watcher-tempest-functional http://logs.openstack.org/26/659726/2/check/watcher-tempest-functional/c1471b5/ : SUCCESS in 30m 53s\n- watcher-grenade http://logs.openstack.org/26/659726/2/check/watcher-grenade/6553ae4/ : SUCCESS in 46m 32s\n- watcher-tempest-dummy_optim http://logs.openstack.org/26/659726/2/check/watcher-tempest-dummy_optim/24a5643/ : SUCCESS in 45m 28s\n- watcher-tempest-actuator http://logs.openstack.org/26/659726/2/check/watcher-tempest-actuator/352c181/ : SUCCESS in 50m 52s\n- watcher-tempest-basic_optim http://logs.openstack.org/26/659726/2/check/watcher-tempest-basic_optim/b3bf221/ : SUCCESS in 45m 50s\n- watcher-tempest-vm_workload_consolidation http://logs.openstack.org/26/659726/2/check/watcher-tempest-vm_workload_consolidation/f88acee/ : SUCCESS in 46m 43s\n- watcher-tempest-workload_balancing http://logs.openstack.org/26/659726/2/check/watcher-tempest-workload_balancing/1bb32e8/ : SUCCESS in 43m 44s\n- watcherclient-tempest-functional http://logs.openstack.org/26/659726/2/check/watcherclient-tempest-functional/5d61048/ : SUCCESS in 31m 28s\n- watcher-tempest-zone_migration http://logs.openstack.org/26/659726/2/check/watcher-tempest-zone_migration/75d3452/ : SUCCESS in 45m 44s\n- watcher-tempest-host_maintenance http://logs.openstack.org/26/659726/2/check/watcher-tempest-host_maintenance/c20cc2c/ : SUCCESS in 47m 20s\n- watcher-tempest-storage_balance http://logs.openstack.org/26/659726/2/check/watcher-tempest-storage_balance/2097d97/ : SUCCESS in 44m 43s\n- watcher-tls-test http://logs.openstack.org/26/659726/2/check/watcher-tls-test/58985d1/ : SUCCESS in 43m 12s","accounts_in_message":[],"_revision_number":2},{"id":"953b65d9292fce7c36cb9c57b154d956dd27c53d","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-05-17 09:11:56.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"00758043d571a30854155d249aa336f0d68eca3d","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-17 13:48:15.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"98af6784b39baf27c5e2ba81902281cc5b2dbb40","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-05-17 13:50:43.000000000","message":"Patch Set 2:\n\n\u003e (1 comment)\n\nI think it would make sense to backport this to stable and possibly wait for the formal datasource interface to merge to fix it in master","accounts_in_message":[],"_revision_number":2},{"id":"d98c88ce858ab85231785a589d84e9c6bee99a2c","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-17 13:52:39.000000000","message":"Patch Set 2:\n\n\u003e I think it would make sense to backport this to stable and possibly wait for the formal datasource interface to merge to fix it in master\n\nIf you wait to fix this until the code is all refactored, it would make backporting much harder, so the thing to do would be fix the thing that is easier to backport before doing a refactor.","accounts_in_message":[],"_revision_number":2},{"id":"fc86bb073ea1c1cdcda5d24e9b9a56a4b43b24d8","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-17 13:54:27.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nWe should have a bug, reference the regression change in the commit message, and fix the tests to actually be useful by using spec or autospec on the mock.","accounts_in_message":[],"_revision_number":2},{"id":"5080259f8549242bcaf615ac71462e5864504388","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-17 14:16:49.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"683f6f76489f385290c4c0b4f2839e1db4b5cb4a","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-17 14:21:33.000000000","message":"Patch Set 2:\n\nReported bug 1829542 for this. Will push up a new version with the bug, reference to the regression and improved tests.","accounts_in_message":[],"_revision_number":2},{"id":"80194177fa1ae8efdb67c2a4fad384a78522cf64","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-17 15:19:03.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2f2e4b3c55febf70b5a0143e9245d4d9b7c14c28","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-17 16:06:20.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a7258be63ad97c6310da6b1f0dab9164fc7c4f8e","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-17 16:06:56.000000000","message":"Uploaded patch set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"28799275fcb5ec38bb09c4d9e6eaf9ddb0e4ceb2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-17 17:06:25.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/26/659726/4/check/openstack-tox-cover/d46cdf7/cover/ : SUCCESS in 6m 09s\n- openstack-tox-lower-constraints http://logs.openstack.org/26/659726/4/check/openstack-tox-lower-constraints/b2587cc/ : SUCCESS in 5m 07s\n- openstack-tox-pep8 http://logs.openstack.org/26/659726/4/check/openstack-tox-pep8/d9425ea/ : SUCCESS in 5m 06s\n- openstack-tox-py27 http://logs.openstack.org/26/659726/4/check/openstack-tox-py27/f6a5d1a/ : SUCCESS in 5m 51s\n- openstack-tox-py36 http://logs.openstack.org/26/659726/4/check/openstack-tox-py36/687e73d/ : SUCCESS in 4m 50s\n- openstack-tox-py37 http://logs.openstack.org/26/659726/4/check/openstack-tox-py37/b18ff59/ : SUCCESS in 6m 05s\n- openstack-tox-docs http://logs.openstack.org/26/659726/4/check/openstack-tox-docs/a0ba168/html/ : SUCCESS in 5m 02s\n- watcher-tempest-functional http://logs.openstack.org/26/659726/4/check/watcher-tempest-functional/ff54240/ : SUCCESS in 35m 22s\n- watcher-grenade http://logs.openstack.org/26/659726/4/check/watcher-grenade/bd4c07d/ : SUCCESS in 45m 18s\n- watcher-tempest-dummy_optim http://logs.openstack.org/26/659726/4/check/watcher-tempest-dummy_optim/0d2108a/ : SUCCESS in 43m 12s\n- watcher-tempest-actuator http://logs.openstack.org/26/659726/4/check/watcher-tempest-actuator/a9581ed/ : SUCCESS in 54m 05s\n- watcher-tempest-basic_optim http://logs.openstack.org/26/659726/4/check/watcher-tempest-basic_optim/7d88555/ : SUCCESS in 55m 30s\n- watcher-tempest-vm_workload_consolidation http://logs.openstack.org/26/659726/4/check/watcher-tempest-vm_workload_consolidation/3d9a104/ : SUCCESS in 54m 49s\n- watcher-tempest-workload_balancing http://logs.openstack.org/26/659726/4/check/watcher-tempest-workload_balancing/30dda82/ : SUCCESS in 42m 36s\n- watcherclient-tempest-functional http://logs.openstack.org/26/659726/4/check/watcherclient-tempest-functional/49827b6/ : SUCCESS in 26m 28s\n- watcher-tempest-zone_migration http://logs.openstack.org/26/659726/4/check/watcher-tempest-zone_migration/148bfd7/ : SUCCESS in 50m 36s\n- watcher-tempest-host_maintenance http://logs.openstack.org/26/659726/4/check/watcher-tempest-host_maintenance/1944a0e/ : SUCCESS in 46m 01s\n- watcher-tempest-storage_balance http://logs.openstack.org/26/659726/4/check/watcher-tempest-storage_balance/8d3355f/ : SUCCESS in 46m 14s\n- watcher-tls-test http://logs.openstack.org/26/659726/4/check/watcher-tls-test/abc8164/ : SUCCESS in 41m 10s","accounts_in_message":[],"_revision_number":4},{"id":"b29c60fe9856bc658bf38064bc87acc330396e62","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-05-18 02:58:11.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"7012a655b656a399bcc3040085c39563e9f48123","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-05-20 06:50:15.000000000","message":"Patch Set 4: Code-Review+2\n\nAs discussed, lets merge this before https://review.opendev.org/#/c/656622/","accounts_in_message":[],"_revision_number":4},{"id":"ae7f39c2618acebd1331b5f6c9a1671fcd4939dc","author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"date":"2019-05-20 06:59:15.000000000","message":"Patch Set 4:\n\nlets merge this, already two +2s","accounts_in_message":[],"_revision_number":4},{"id":"0d9034661afea98e8f7e5f715c3fe3aee5837584","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-05-20 07:02:15.000000000","message":"Patch Set 4: Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"0b21bbe22a4639564aac1092f3bbfac580fb2a2d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-20 07:02:26.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"2ea07f36865317462181e16ebd504d6be01c229e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-20 07:44:55.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4},{"id":"a57ec28bdd339b1bd512a1992cc37730a34e6736","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-20 07:44:55.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/26/659726/4/gate/openstack-tox-lower-constraints/1598771/ : SUCCESS in 5m 33s\n- openstack-tox-pep8 http://logs.openstack.org/26/659726/4/gate/openstack-tox-pep8/ee29c4b/ : SUCCESS in 5m 23s\n- openstack-tox-py27 http://logs.openstack.org/26/659726/4/gate/openstack-tox-py27/5bbe274/ : SUCCESS in 7m 40s\n- openstack-tox-py36 http://logs.openstack.org/26/659726/4/gate/openstack-tox-py36/f0e49b1/ : SUCCESS in 5m 46s\n- openstack-tox-py37 http://logs.openstack.org/26/659726/4/gate/openstack-tox-py37/8c26f00/ : SUCCESS in 6m 01s\n- openstack-tox-docs http://logs.openstack.org/26/659726/4/gate/openstack-tox-docs/91d13f6/html/ : SUCCESS in 4m 53s\n- watcher-tempest-functional http://logs.openstack.org/26/659726/4/gate/watcher-tempest-functional/fb52de4/ : SUCCESS in 41m 34s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"f92f77f683656f93fbb71057089c20326e729263","revisions":{"587a36a994d56ec5f60e21ca6c2789583161ed18":{"kind":"REWORK","_number":1,"created":"2019-05-17 07:07:19.000000000","uploader":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"ref":"refs/changes/26/659726/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/26/659726/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/26/659726/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/26/659726/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/26/659726/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/26/659726/1"}}},"commit":{"parents":[{"commit":"ce1d64a16c03e90b185a7ba301c0d92318502dc6","subject":"Merge \"Remove unused utilities file\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/ce1d64a16c03e90b185a7ba301c0d92318502dc6"}]}],"author":{"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","date":"2019-05-17 07:01:37.000000000","tz":480},"committer":{"name":"Kevin_Zheng","email":"zhengzhenyu@huawei.com","date":"2019-05-17 07:06:33.000000000","tz":480},"subject":"Fix typo in ceilometer datasource","message":"Fix typo in ceilometer datasource\n\nFix typo in ceilometer datasource\n\nChange-Id: Idfd099f718873d9056fdc35a97954771c9ae5762\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/587a36a994d56ec5f60e21ca6c2789583161ed18"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/587a36a994d56ec5f60e21ca6c2789583161ed18"}]},"branch":"refs/heads/master"},"ab5ca31c0d25a437f2a3f149a5412399120afa05":{"kind":"REWORK","_number":2,"created":"2019-05-17 08:03:30.000000000","uploader":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"ref":"refs/changes/26/659726/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/26/659726/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/26/659726/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/26/659726/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/26/659726/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/26/659726/2"}}},"commit":{"parents":[{"commit":"ce1d64a16c03e90b185a7ba301c0d92318502dc6","subject":"Merge \"Remove unused utilities file\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/ce1d64a16c03e90b185a7ba301c0d92318502dc6"}]}],"author":{"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","date":"2019-05-17 07:01:37.000000000","tz":480},"committer":{"name":"Kevin_Zheng","email":"zhengzhenyu@huawei.com","date":"2019-05-17 08:03:12.000000000","tz":480},"subject":"Fix typo in ceilometer datasource","message":"Fix typo in ceilometer datasource\n\nFix typo in ceilometer datasource\n\nChange-Id: Idfd099f718873d9056fdc35a97954771c9ae5762\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/ab5ca31c0d25a437f2a3f149a5412399120afa05"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/ab5ca31c0d25a437f2a3f149a5412399120afa05"}]},"branch":"refs/heads/master"},"c88dde71fa023463856fdd33f388ff9538c16f5b":{"kind":"REWORK","_number":3,"created":"2019-05-17 16:06:20.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/26/659726/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/26/659726/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/26/659726/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/26/659726/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/26/659726/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/26/659726/3"}}},"commit":{"parents":[{"commit":"ce1d64a16c03e90b185a7ba301c0d92318502dc6","subject":"Merge \"Remove unused utilities file\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/ce1d64a16c03e90b185a7ba301c0d92318502dc6"}]}],"author":{"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","date":"2019-05-17 07:01:37.000000000","tz":480},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-05-17 15:58:43.000000000","tz":-240},"subject":"Fix typo in ceilometer datasource","message":"Fix typo in ceilometer datasource\n\nChange I25b4cb0e1b85379ff0c4da9d0c1474380d75ce3a in\nQueens refactored the statistic_aggregation method\nand renamed the \"aggregate\" kwarg to \"aggregation\",\npresumably to match the signature of the GnocchiHelper\nstatistic_aggregation method (the commit message does\nnot give details) so a base method could be added to\nthe parent class for all datasource helpers.\n\nAs a result, the CeilometerHelper calls to its\nstatistic_aggregation started passing the new\n\"granularity\" kwarg but failed to match the rename\nto the \"aggregation\" kwarg, which breaks the\nCeilometerHelper. This was missed by the unit tests\nbecause the tests were just asserting the erroneous\ncall that the runtime code made.\n\nThis change fixes the kwarg typo and makes the\ntests more robust by using the mock spec kwarg\nto define a spec for the statistic_aggregation\nmock so that it must be called with the correct\nparameters defined in the method signature. The\ntest is refactored to reduce duplicate mocking.\nThe same test hardening can and should be done\nin the gnocchi and monasca helper tests but that\nshould be done in a separate change.\n\nCo-Authored-By: Matt Riedemann \u003cmriedem.os@gmail.com\u003e\n\nChange-Id: Idfd099f718873d9056fdc35a97954771c9ae5762\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/c88dde71fa023463856fdd33f388ff9538c16f5b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/c88dde71fa023463856fdd33f388ff9538c16f5b"}]},"branch":"refs/heads/master"},"f92f77f683656f93fbb71057089c20326e729263":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2019-05-17 16:06:56.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/26/659726/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/26/659726/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/26/659726/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/26/659726/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/26/659726/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/26/659726/4"}}},"commit":{"parents":[{"commit":"ce1d64a16c03e90b185a7ba301c0d92318502dc6","subject":"Merge \"Remove unused utilities file\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/ce1d64a16c03e90b185a7ba301c0d92318502dc6"}]}],"author":{"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","date":"2019-05-17 07:01:37.000000000","tz":480},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-05-17 16:06:42.000000000","tz":-240},"subject":"Fix typo in ceilometer datasource","message":"Fix typo in ceilometer datasource\n\nChange I25b4cb0e1b85379ff0c4da9d0c1474380d75ce3a in\nQueens refactored the statistic_aggregation method\nand renamed the \"aggregate\" kwarg to \"aggregation\",\npresumably to match the signature of the GnocchiHelper\nstatistic_aggregation method (the commit message does\nnot give details) so a base method could be added to\nthe parent class for all datasource helpers.\n\nAs a result, the CeilometerHelper calls to its\nstatistic_aggregation started passing the new\n\"granularity\" kwarg but failed to match the rename\nto the \"aggregation\" kwarg, which breaks the\nCeilometerHelper. This was missed by the unit tests\nbecause the tests were just asserting the erroneous\ncall that the runtime code made.\n\nThis change fixes the kwarg typo and makes the\ntests more robust by using the mock spec kwarg\nto define a spec for the statistic_aggregation\nmock so that it must be called with the correct\nparameters defined in the method signature. The\ntest is refactored to reduce duplicate mocking.\nThe same test hardening can and should be done\nin the gnocchi and monasca helper tests but that\nshould be done in a separate change.\n\nCo-Authored-By: Matt Riedemann \u003cmriedem.os@gmail.com\u003e\n\nCloses-Bug: #1829542\n\nChange-Id: Idfd099f718873d9056fdc35a97954771c9ae5762\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/f92f77f683656f93fbb71057089c20326e729263"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/f92f77f683656f93fbb71057089c20326e729263"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}