)]}'
{"watcher/applier/actions/change_nova_service_state.py":[{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"3348d9cbd522c3539185bd35a94203f23f4ea330","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                },"},{"line_number":63,"context_line":"                \u0027resource_name\u0027: {"},{"line_number":64,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":65,"context_line":"                    \"minlength\": 0"},{"line_number":66,"context_line":"                },"},{"line_number":67,"context_line":"                \u0027state\u0027: {"},{"line_number":68,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_6828b733","line":65,"range":{"start_line":65,"start_character":33,"end_line":65,"end_character":34},"updated":"2019-07-09 07:22:25.000000000","message":"at least 1","commit_id":"31803f728b7bc9013e71817b09c7e42022c39cef"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"1983464d8f6f355e099acf9235d110fd14b4c05a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                },"},{"line_number":63,"context_line":"                \u0027resource_name\u0027: {"},{"line_number":64,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":65,"context_line":"                    \"minlength\": 0"},{"line_number":66,"context_line":"                },"},{"line_number":67,"context_line":"                \u0027state\u0027: {"},{"line_number":68,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_28771fd7","line":65,"range":{"start_line":65,"start_character":33,"end_line":65,"end_character":34},"in_reply_to":"7faddb67_6828b733","updated":"2019-07-09 07:49:26.000000000","message":"Done","commit_id":"31803f728b7bc9013e71817b09c7e42022c39cef"}],"watcher/applier/actions/migration.py":[{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"3348d9cbd522c3539185bd35a94203f23f4ea330","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                },"},{"line_number":90,"context_line":"                \u0027resource_name\u0027: {"},{"line_number":91,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":92,"context_line":"                    \"minlength\": 0"},{"line_number":93,"context_line":"                },"},{"line_number":94,"context_line":"                \u0027source_node\u0027: {"},{"line_number":95,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_481dbb0d","line":92,"range":{"start_line":92,"start_character":21,"end_line":92,"end_character":34},"updated":"2019-07-09 07:22:25.000000000","message":"at least 1","commit_id":"31803f728b7bc9013e71817b09c7e42022c39cef"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"1983464d8f6f355e099acf9235d110fd14b4c05a","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                },"},{"line_number":90,"context_line":"                \u0027resource_name\u0027: {"},{"line_number":91,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":92,"context_line":"                    \"minlength\": 0"},{"line_number":93,"context_line":"                },"},{"line_number":94,"context_line":"                \u0027source_node\u0027: {"},{"line_number":95,"context_line":"                    \u0027type\u0027: \u0027string\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_48729be5","line":92,"range":{"start_line":92,"start_character":21,"end_line":92,"end_character":34},"in_reply_to":"7faddb67_481dbb0d","updated":"2019-07-09 07:49:26.000000000","message":"Done\nThanks.","commit_id":"31803f728b7bc9013e71817b09c7e42022c39cef"}],"watcher/decision_engine/strategy/strategies/basic_consolidation.py":[{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"97cbcde752e9620c88eb1eabbad01df93d7e6420","unresolved":false,"context_lines":[{"line_number":328,"context_line":"    def add_action_disable_node(self, node):"},{"line_number":329,"context_line":"        parameters \u003d {\u0027state\u0027: element.ServiceState.DISABLED.value,"},{"line_number":330,"context_line":"                      \u0027disabled_reason\u0027: self.REASON_FOR_DISABLE,"},{"line_number":331,"context_line":"                      \u0027resource_name\u0027: node.hostname}"},{"line_number":332,"context_line":"        self.solution.add_action(action_type\u003dself.CHANGE_NOVA_SERVICE_STATE,"},{"line_number":333,"context_line":"                                 resource_id\u003dnode.uuid,"},{"line_number":334,"context_line":"                                 input_parameters\u003dparameters)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_9bafed28","line":331,"range":{"start_line":331,"start_character":39,"end_line":331,"end_character":52},"updated":"2019-05-30 03:32:34.000000000","message":"I think we should unify the source of resource_name, \neither instance.human_id, node.human_id or instance.name, node.name.","commit_id":"9152baa64b5556f4bb192b1910364a3b489fd16d"},{"author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"change_message_id":"0fd5f9ed76da67eae915becb1fc0cf728312c25e","unresolved":false,"context_lines":[{"line_number":328,"context_line":"    def add_action_disable_node(self, node):"},{"line_number":329,"context_line":"        parameters \u003d {\u0027state\u0027: element.ServiceState.DISABLED.value,"},{"line_number":330,"context_line":"                      \u0027disabled_reason\u0027: self.REASON_FOR_DISABLE,"},{"line_number":331,"context_line":"                      \u0027resource_name\u0027: node.hostname}"},{"line_number":332,"context_line":"        self.solution.add_action(action_type\u003dself.CHANGE_NOVA_SERVICE_STATE,"},{"line_number":333,"context_line":"                                 resource_id\u003dnode.uuid,"},{"line_number":334,"context_line":"                                 input_parameters\u003dparameters)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_e173e5e5","line":331,"range":{"start_line":331,"start_character":39,"end_line":331,"end_character":52},"in_reply_to":"bfb3d3c7_9bafed28","updated":"2019-06-28 03:04:10.000000000","message":"According the patch[1] and the discussion at the meeting[2], we replaced human-id with name. Regarding the name of the node, I think it\u0027s better to use hostname. Because it keeps the same field  when creating and updating the datamodel[3][4].\n[1]. https://review.opendev.org/#/c/660295/\n[2]. http://eavesdrop.openstack.org/meetings/watcher/2019/watcher.2019-06-19-08.00.log.html#l-47\n[3]. https://github.com/openstack/watcher/blob/master/watcher/decision_engine/model/collector/nova.py#L307\n[4]. https://github.com/openstack/watcher/blob/master/watcher/decision_engine/model/notification/nova.py#L130","commit_id":"9152baa64b5556f4bb192b1910364a3b489fd16d"}]}