)]}'
{"id":"openstack%2Fwatcher~662089","triplet_id":"openstack%2Fwatcher~master~I84f387982f665d7cc11bffe8ec390cc7e7ed5278","project":"openstack/watcher","branch":"master","topic":"compute-cdm-perf-server-list-host-filter","hashtags":[],"change_id":"I84f387982f665d7cc11bffe8ec390cc7e7ed5278","subject":"Optimize NovaHelper.get_compute_node_by_hostname","status":"MERGED","created":"2019-05-29 20:44:42.000000000","updated":"2019-06-14 02:31:13.000000000","submitted":"2019-06-14 02:31:13.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"662089-1560479473488-9e97f1fb","meta_rev_id":"df1881aba96660e1d98c111c8c8ad782062e949e","_number":662089,"virtual_id_number":662089,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},{"value":0,"date":"2019-06-03 16:33:00.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-06-14 02:31:13.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":30413,"name":"chaiguanglong","email":"chaigl@awcloud.com","username":"chaiguanglong"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"recommended":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"all":[{"value":1,"date":"2019-06-10 06:47:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-06-03 16:30:32.000000000","_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":2,"date":"2019-06-03 16:30:32.000000000","_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":1,"date":"2019-06-03 16:30:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30413,"name":"chaiguanglong","email":"chaigl@awcloud.com","username":"chaiguanglong"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"all":[{"value":0,"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-06-14 01:41:50.000000000","_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":30413,"name":"chaiguanglong","email":"chaigl@awcloud.com","username":"chaiguanglong"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":30413,"name":"chaiguanglong","email":"chaigl@awcloud.com","username":"chaiguanglong"}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"_account_id":30413,"name":"chaiguanglong","email":"chaigl@awcloud.com","username":"chaiguanglong"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-01 02:50:53.000000000","updated_by":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"reviewer":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"state":"REVIEWER"},{"updated":"2019-06-01 05:02:00.000000000","updated_by":{"_account_id":30413,"name":"chaiguanglong","email":"chaigl@awcloud.com","username":"chaiguanglong"},"reviewer":{"_account_id":30413,"name":"chaiguanglong","email":"chaigl@awcloud.com","username":"chaiguanglong"},"state":"REVIEWER"},{"updated":"2019-06-10 06:47:26.000000000","updated_by":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"reviewer":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"state":"REVIEWER"},{"updated":"2019-06-14 01:41:50.000000000","updated_by":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"reviewer":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"state":"REVIEWER"},{"updated":"2019-06-14 02:31:13.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d4da91514a13d4bd0bcea0582f825ef283b64394","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-29 20:44:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"03f252bd8432b5ccf1ec5a995c4870f9e3d5d13d","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-05-29 20:50:36.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c8cd8aad16e8a87b3844bd24330ce7a561371fcc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-29 21:47:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/89/662089/1/check/openstack-tox-cover/7ab3452/cover/ : SUCCESS in 6m 36s\n- openstack-tox-lower-constraints http://logs.openstack.org/89/662089/1/check/openstack-tox-lower-constraints/84ad9d8/ : SUCCESS in 5m 43s\n- openstack-tox-pep8 http://logs.openstack.org/89/662089/1/check/openstack-tox-pep8/75ec9b7/ : SUCCESS in 4m 59s\n- openstack-tox-py27 http://logs.openstack.org/89/662089/1/check/openstack-tox-py27/8373493/ : SUCCESS in 6m 18s\n- openstack-tox-py36 http://logs.openstack.org/89/662089/1/check/openstack-tox-py36/4ab0a7d/ : SUCCESS in 5m 03s\n- openstack-tox-py37 http://logs.openstack.org/89/662089/1/check/openstack-tox-py37/9e17943/ : SUCCESS in 7m 56s\n- openstack-tox-docs http://logs.openstack.org/89/662089/1/check/openstack-tox-docs/8f12a13/html/ : SUCCESS in 5m 43s\n- watcher-tempest-functional http://logs.openstack.org/89/662089/1/check/watcher-tempest-functional/cc40b80/ : SUCCESS in 31m 26s\n- watcher-grenade http://logs.openstack.org/89/662089/1/check/watcher-grenade/668f3b7/ : SUCCESS in 46m 51s\n- watcher-tempest-dummy_optim http://logs.openstack.org/89/662089/1/check/watcher-tempest-dummy_optim/6904955/ : SUCCESS in 45m 24s\n- watcher-tempest-actuator http://logs.openstack.org/89/662089/1/check/watcher-tempest-actuator/3a4010c/ : SUCCESS in 49m 05s\n- watcher-tempest-basic_optim http://logs.openstack.org/89/662089/1/check/watcher-tempest-basic_optim/08dbc97/ : SUCCESS in 58m 37s\n- watcher-tempest-vm_workload_consolidation http://logs.openstack.org/89/662089/1/check/watcher-tempest-vm_workload_consolidation/1021a2a/ : SUCCESS in 47m 51s\n- watcher-tempest-workload_balancing http://logs.openstack.org/89/662089/1/check/watcher-tempest-workload_balancing/1d8f296/ : SUCCESS in 45m 55s\n- watcherclient-tempest-functional http://logs.openstack.org/89/662089/1/check/watcherclient-tempest-functional/0bf861f/ : SUCCESS in 31m 58s\n- watcher-tempest-zone_migration http://logs.openstack.org/89/662089/1/check/watcher-tempest-zone_migration/b52ec99/ : SUCCESS in 51m 47s\n- watcher-tempest-host_maintenance http://logs.openstack.org/89/662089/1/check/watcher-tempest-host_maintenance/443ec9d/ : SUCCESS in 47m 13s\n- watcher-tempest-storage_balance http://logs.openstack.org/89/662089/1/check/watcher-tempest-storage_balance/2034b41/ : SUCCESS in 47m 52s\n- watcher-tls-test http://logs.openstack.org/89/662089/1/check/watcher-tls-test/686175c/ : SUCCESS in 46m 31s","accounts_in_message":[],"_revision_number":1},{"id":"c24f9e62fb0afbcb0ccf366befc3b1af53850164","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-05-30 02:43:32.000000000","message":"Patch Set 1: Code-Review+2\n\nThanks~","accounts_in_message":[],"_revision_number":1},{"id":"8caccf21d22339c562da65bdb108f05f8a5edb32","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-06-01 02:50:53.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"8903d86db805d6f8a0a18432514b40c5fe50800e","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-06-01 03:18:49.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"cad68160e95fac497d998b696df7a24849ab9d7e","author":{"_account_id":30413,"name":"chaiguanglong","email":"chaigl@awcloud.com","username":"chaiguanglong"},"date":"2019-06-01 05:02:00.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"b9cdabeddf66042cc0efcfe5b250a002b840bcd5","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-03 16:30:32.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"16b5252f286dceea480fc633f832c1aa39d5ead6","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-03 16:33:00.000000000","message":"Patch Set 2:\n\nTracking this with bug 1831464.","accounts_in_message":[],"_revision_number":2},{"id":"1e60bf36c6b3516e2ffe3c4295eeb530b4cf75f3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-03 17:48:36.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover http://logs.openstack.org/89/662089/2/check/openstack-tox-cover/e1a89d1/cover/ : SUCCESS in 6m 52s\n- openstack-tox-lower-constraints http://logs.openstack.org/89/662089/2/check/openstack-tox-lower-constraints/eab8661/ : SUCCESS in 5m 54s\n- openstack-tox-pep8 http://logs.openstack.org/89/662089/2/check/openstack-tox-pep8/4d3c613/ : SUCCESS in 5m 22s\n- openstack-tox-py27 http://logs.openstack.org/89/662089/2/check/openstack-tox-py27/8dd94bc/ : SUCCESS in 5m 34s\n- openstack-tox-py36 http://logs.openstack.org/89/662089/2/check/openstack-tox-py36/8722c11/ : SUCCESS in 5m 04s\n- openstack-tox-py37 http://logs.openstack.org/89/662089/2/check/openstack-tox-py37/0baf0db/ : SUCCESS in 5m 47s\n- openstack-tox-docs http://logs.openstack.org/89/662089/2/check/openstack-tox-docs/ae28122/ : FAILURE in 6m 13s\n- watcher-tempest-functional http://logs.openstack.org/89/662089/2/check/watcher-tempest-functional/234dabf/ : SUCCESS in 35m 41s\n- watcher-grenade http://logs.openstack.org/89/662089/2/check/watcher-grenade/c989382/ : SUCCESS in 47m 36s\n- watcher-tempest-dummy_optim http://logs.openstack.org/89/662089/2/check/watcher-tempest-dummy_optim/315ae03/ : SUCCESS in 44m 54s\n- watcher-tempest-actuator http://logs.openstack.org/89/662089/2/check/watcher-tempest-actuator/e9096de/ : SUCCESS in 58m 28s\n- watcher-tempest-basic_optim http://logs.openstack.org/89/662089/2/check/watcher-tempest-basic_optim/01cbb31/ : SUCCESS in 53m 15s\n- watcher-tempest-vm_workload_consolidation http://logs.openstack.org/89/662089/2/check/watcher-tempest-vm_workload_consolidation/c905255/ : SUCCESS in 47m 53s\n- watcher-tempest-workload_balancing http://logs.openstack.org/89/662089/2/check/watcher-tempest-workload_balancing/7d3bad1/ : SUCCESS in 50m 06s\n- watcherclient-tempest-functional http://logs.openstack.org/89/662089/2/check/watcherclient-tempest-functional/6a71b49/ : SUCCESS in 32m 16s\n- watcher-tempest-zone_migration http://logs.openstack.org/89/662089/2/check/watcher-tempest-zone_migration/d136828/ : SUCCESS in 49m 25s\n- watcher-tempest-host_maintenance http://logs.openstack.org/89/662089/2/check/watcher-tempest-host_maintenance/9185073/ : SUCCESS in 46m 49s\n- watcher-tempest-storage_balance http://logs.openstack.org/89/662089/2/check/watcher-tempest-storage_balance/074a077/ : SUCCESS in 54m 53s\n- watcher-tls-test http://logs.openstack.org/89/662089/2/check/watcher-tls-test/8aa77f5/ : SUCCESS in 1h 09m 55s","accounts_in_message":[],"_revision_number":2},{"id":"d782c3f159bf801b7c7686b273d46183d21e7357","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-06-04 11:17:50.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"1f8e6c2d23ac1c370e036cfab066e46d92334fd0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-04 12:39:27.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/89/662089/2/check/openstack-tox-cover/856411c/cover/ : SUCCESS in 7m 09s\n- openstack-tox-lower-constraints http://logs.openstack.org/89/662089/2/check/openstack-tox-lower-constraints/176b2b9/ : SUCCESS in 8m 37s\n- openstack-tox-pep8 http://logs.openstack.org/89/662089/2/check/openstack-tox-pep8/0551144/ : SUCCESS in 5m 09s\n- openstack-tox-py27 http://logs.openstack.org/89/662089/2/check/openstack-tox-py27/2935192/ : SUCCESS in 5m 47s\n- openstack-tox-py36 http://logs.openstack.org/89/662089/2/check/openstack-tox-py36/a557870/ : SUCCESS in 5m 38s\n- openstack-tox-py37 http://logs.openstack.org/89/662089/2/check/openstack-tox-py37/f8d1d2d/ : SUCCESS in 5m 59s\n- openstack-tox-docs http://logs.openstack.org/89/662089/2/check/openstack-tox-docs/82edd61/html/ : SUCCESS in 4m 54s\n- watcher-tempest-functional http://logs.openstack.org/89/662089/2/check/watcher-tempest-functional/491c43c/ : SUCCESS in 32m 11s\n- watcher-grenade http://logs.openstack.org/89/662089/2/check/watcher-grenade/f628bea/ : SUCCESS in 46m 22s\n- watcher-tempest-dummy_optim http://logs.openstack.org/89/662089/2/check/watcher-tempest-dummy_optim/49e6a55/ : SUCCESS in 45m 54s\n- watcher-tempest-actuator http://logs.openstack.org/89/662089/2/check/watcher-tempest-actuator/08b30ba/ : SUCCESS in 50m 27s\n- watcher-tempest-basic_optim http://logs.openstack.org/89/662089/2/check/watcher-tempest-basic_optim/303229a/ : SUCCESS in 44m 09s\n- watcher-tempest-vm_workload_consolidation http://logs.openstack.org/89/662089/2/check/watcher-tempest-vm_workload_consolidation/a5839e6/ : SUCCESS in 44m 09s\n- watcher-tempest-workload_balancing http://logs.openstack.org/89/662089/2/check/watcher-tempest-workload_balancing/cc6fa3c/ : SUCCESS in 51m 38s\n- watcherclient-tempest-functional http://logs.openstack.org/89/662089/2/check/watcherclient-tempest-functional/eda945f/ : SUCCESS in 27m 37s\n- watcher-tempest-zone_migration http://logs.openstack.org/89/662089/2/check/watcher-tempest-zone_migration/9385d93/ : SUCCESS in 44m 35s\n- watcher-tempest-host_maintenance http://logs.openstack.org/89/662089/2/check/watcher-tempest-host_maintenance/4836086/ : SUCCESS in 46m 21s\n- watcher-tempest-storage_balance http://logs.openstack.org/89/662089/2/check/watcher-tempest-storage_balance/51908a4/ : SUCCESS in 47m 00s\n- watcher-tls-test http://logs.openstack.org/89/662089/2/check/watcher-tls-test/76c0320/ : SUCCESS in 43m 36s","accounts_in_message":[],"_revision_number":2},{"id":"9766417b8d40cb3319b938c7327f1ac9ba0c106f","author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"date":"2019-06-10 06:47:26.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"8c4d4646029f2f2261a33362cc98a31d6d2d4566","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-06-14 01:41:50.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"6c7d79815db7d0ab432152b3986d6ca3a3d91db9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-14 01:48:52.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"da27e8430cc29eb80021b1e88c888fdfdc8768f6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-14 02:31:13.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"779a39cc6cffbd5e47ca46bf5ff2b5824f119abc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-14 02:31:13.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/89/662089/2/gate/openstack-tox-lower-constraints/ac620f8/ : SUCCESS in 5m 46s\n- openstack-tox-pep8 http://logs.openstack.org/89/662089/2/gate/openstack-tox-pep8/8df4743/ : SUCCESS in 6m 23s\n- openstack-tox-py27 http://logs.openstack.org/89/662089/2/gate/openstack-tox-py27/9d0285f/ : SUCCESS in 6m 18s\n- openstack-tox-py36 http://logs.openstack.org/89/662089/2/gate/openstack-tox-py36/bbfbd5f/ : SUCCESS in 6m 16s\n- openstack-tox-py37 http://logs.openstack.org/89/662089/2/gate/openstack-tox-py37/5e8a35b/ : SUCCESS in 6m 14s\n- openstack-tox-docs http://logs.openstack.org/89/662089/2/gate/openstack-tox-docs/bfe9b2c/html/ : SUCCESS in 5m 06s\n- watcher-tempest-functional http://logs.openstack.org/89/662089/2/gate/watcher-tempest-functional/15b92b9/ : SUCCESS in 33m 36s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"374fd2791fcd76653d517ee354bb33a164b86c9a","revisions":{"b51f9be45e571601d903705ca651e9f9b7ff0924":{"kind":"REWORK","_number":1,"created":"2019-05-29 20:44:42.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/89/662089/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/89/662089/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/89/662089/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/89/662089/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/89/662089/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/89/662089/1"}}},"commit":{"parents":[{"commit":"0394005b91102ce5afc467782180b6899d244dc4","subject":"Optimize hypervisor API calls","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/0394005b91102ce5afc467782180b6899d244dc4"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-05-29 20:35:04.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-05-29 20:35:04.000000000","tz":-240},"subject":"Optimize NovaHelper.get_compute_node_by_hostname","message":"Optimize NovaHelper.get_compute_node_by_hostname\n\nThe get_compute_node_by_hostname method is given a\ncompute service hostname and then does two queries to\nfind the matching hypervisor (compute node) with details:\n\n1. List hypervisors with details and find the one that\n   matches the given compute service hostname.\n\n2. Using that node, search for hypervisors with the\n   matching hypervisor_hostname.\n\nThere are two issues here:\n\n1. The first query is inefficient in that it has to list\n   all hypervisors in the deployment to try and match the\n   one with the compute service hostname client side.\n\n2. The second query is a fuzzy match on the server side [1]\n   so even though we have matched on the node we want,\n   get_compute_node_by_name can still return more than\n   one hypervisor which will result in the helper method\n   raising ComputeNodeNotFound. Consider having compute\n   hosts with names compute1, compute10, compute11, compute100,\n   and so on. The fuzzy match on compute1 would return all of\n   those hypervisors.\n\nFor non-ironic nodes in nova, the compute service host and\nhypervisor should be 1:1, meaning the hypervisor.service[\u0027host\u0027]\nshould be the same as hypervisor.hypervisor_hostname. Knowing\nthis, we can simplify the code to search just on the given\ncompute service hostname and if we get more than one result, it\nis because of the fuzzy match and we can then do our client-side\nfiltering on the compute service hostname.\n\n[1] https://github.com/openstack/nova/blob/d4f58f5eb/nova/db/sqlalchemy/api.py#L676\n\nChange-Id: I84f387982f665d7cc11bffe8ec390cc7e7ed5278\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/b51f9be45e571601d903705ca651e9f9b7ff0924"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/b51f9be45e571601d903705ca651e9f9b7ff0924"}]},"branch":"refs/heads/master"},"374fd2791fcd76653d517ee354bb33a164b86c9a":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-06-03 16:30:32.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/89/662089/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/89/662089/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/89/662089/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/89/662089/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/89/662089/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/89/662089/2"}}},"commit":{"parents":[{"commit":"3f76f9cfdb6a1ce4dd120fa3de6c7fb05761102a","subject":"Optimize hypervisor API calls","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/3f76f9cfdb6a1ce4dd120fa3de6c7fb05761102a"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-05-29 20:35:04.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-06-03 16:18:54.000000000","tz":-240},"subject":"Optimize NovaHelper.get_compute_node_by_hostname","message":"Optimize NovaHelper.get_compute_node_by_hostname\n\nThe get_compute_node_by_hostname method is given a\ncompute service hostname and then does two queries to\nfind the matching hypervisor (compute node) with details:\n\n1. List hypervisors with details and find the one that\n   matches the given compute service hostname.\n\n2. Using that node, search for hypervisors with the\n   matching hypervisor_hostname.\n\nThere are two issues here:\n\n1. The first query is inefficient in that it has to list\n   all hypervisors in the deployment to try and match the\n   one with the compute service hostname client side.\n\n2. The second query is a fuzzy match on the server side [1]\n   so even though we have matched on the node we want,\n   get_compute_node_by_name can still return more than\n   one hypervisor which will result in the helper method\n   raising ComputeNodeNotFound. Consider having compute\n   hosts with names compute1, compute10, compute11, compute100,\n   and so on. The fuzzy match on compute1 would return all of\n   those hypervisors.\n\nFor non-ironic nodes in nova, the compute service host and\nhypervisor should be 1:1, meaning the hypervisor.service[\u0027host\u0027]\nshould be the same as hypervisor.hypervisor_hostname. Knowing\nthis, we can simplify the code to search just on the given\ncompute service hostname and if we get more than one result, it\nis because of the fuzzy match and we can then do our client-side\nfiltering on the compute service hostname.\n\n[1] https://github.com/openstack/nova/blob/d4f58f5eb/nova/db/sqlalchemy/api.py#L676\n\nChange-Id: I84f387982f665d7cc11bffe8ec390cc7e7ed5278\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/374fd2791fcd76653d517ee354bb33a164b86c9a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/374fd2791fcd76653d517ee354bb33a164b86c9a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}