)]}'
{".zuul.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9345f259592a7578a98a5824bcc526ea3d14fa7b","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        s-proxy: false"},{"line_number":185,"context_line":"      devstack_localrc:"},{"line_number":186,"context_line":"        TEMPEST_PLUGINS: /opt/stack/watcher-tempest-plugin"},{"line_number":187,"context_line":"      devstack_local_conf:"},{"line_number":188,"context_line":"        post-config:"},{"line_number":189,"context_line":"          $NOVA_CONF:"},{"line_number":190,"context_line":"            # Enable both versioned and unversioned notifications. Watcher only"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_b963f941","line":187,"updated":"2019-06-12 00:28:08.000000000","message":"If https://review.opendev.org/#/c/663332/8/devstack/settings works then we don\u0027t need this.","commit_id":"6cde6cb15855919c927bbc55b5d9ddd72d33c052"}],"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e32b034ae28ddc2785550756fed36d46d4d01c5d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Configure nova notification format"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova used to emit versioned and unversioned notiifcations"},{"line_number":10,"context_line":"by default but that changed in https://review.opendev.org/603079/"},{"line_number":11,"context_line":"so now nova emits only unversioned notifications by default."},{"line_number":12,"context_line":"Watcher listens for versioned notifications so we need to configure"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_0c558ec6","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":57},"updated":"2019-06-05 17:41:01.000000000","message":"notifications","commit_id":"487643d0bca7d35fa557013f9560edd9d1798e0b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4a6bdca7316bc300ca1358829ab15467b347c202","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1831917"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Depends-On: https://review.opendev.org/662849"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I7e441608b38338eecd80e663ed3abe66a89e504f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fb8cfa7_61d39161","line":23,"updated":"2019-06-11 19:40:18.000000000","message":"I\u0027m not sure that this is being pulled in.","commit_id":"537d23910ccb2d2121f5c174233851f0fa682005"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d442c1cb20e2b364f68e93c38b0ccc7f2ab04fa5","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1831917"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Depends-On: https://review.opendev.org/662849"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I7e441608b38338eecd80e663ed3abe66a89e504f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fb8cfa7_a16ae97d","line":23,"in_reply_to":"9fb8cfa7_61d39161","updated":"2019-06-11 19:47:40.000000000","message":"Looks like zuul is cloning it in:\n\nhttp://logs.openstack.org/32/663332/6/check/watcher-grenade/e85ebab/job-output.txt.gz#_2019-06-11_18_14_45_369294","commit_id":"537d23910ccb2d2121f5c174233851f0fa682005"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"246ccf7d8eb7bd9d670b71726a455d4c98b1ad16","unresolved":false,"context_lines":[{"line_number":13,"context_line":"nova to emit both versioned (for Watcher) and unversioned"},{"line_number":14,"context_line":"(for Ceilometer) notifications explicitly."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This adds an override-defaults file so devstack will load up"},{"line_number":17,"context_line":"the nova devstack variable to set the notification_format before"},{"line_number":18,"context_line":"importing and stacking the nova lib script."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9fb8cfa7_e00568c3","line":16,"range":{"start_line":16,"start_character":13,"end_line":16,"end_character":30},"updated":"2019-06-24 19:18:17.000000000","message":"The local.conf changes aren\u0027t mentioned in the commit message, and it\u0027s not clear to me from the PS history whether they\u0027re still needed or why.","commit_id":"966a4dfa5f030d4b88e4902c9f762a2d6213a670"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"259853351ae3db0d79f1950582df135a2d1d5ae4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"nova to emit both versioned (for Watcher) and unversioned"},{"line_number":14,"context_line":"(for Ceilometer) notifications explicitly."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This adds an override-defaults file so devstack will load up"},{"line_number":17,"context_line":"the nova devstack variable to set the notification_format before"},{"line_number":18,"context_line":"importing and stacking the nova lib script."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9fb8cfa7_2f96fff1","line":16,"range":{"start_line":16,"start_character":13,"end_line":16,"end_character":30},"in_reply_to":"9fb8cfa7_2fa27faf","updated":"2019-06-25 15:18:43.000000000","message":"Ight. I guess it would be more obvious if they were named local.conf.sample, but...","commit_id":"966a4dfa5f030d4b88e4902c9f762a2d6213a670"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4141adf7de451499606730ab7418bb4174e21515","unresolved":false,"context_lines":[{"line_number":13,"context_line":"nova to emit both versioned (for Watcher) and unversioned"},{"line_number":14,"context_line":"(for Ceilometer) notifications explicitly."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This adds an override-defaults file so devstack will load up"},{"line_number":17,"context_line":"the nova devstack variable to set the notification_format before"},{"line_number":18,"context_line":"importing and stacking the nova lib script."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9fb8cfa7_2fa27faf","line":16,"range":{"start_line":16,"start_character":13,"end_line":16,"end_character":30},"in_reply_to":"9fb8cfa7_e00568c3","updated":"2019-06-25 15:00:03.000000000","message":"They are only used for the contributor docs to setup watcher using the local.conf samples provided in-tree:\n\nhttps://docs.openstack.org/watcher/latest/contributor/devstack.html\n\nAs a new contributor to watcher it took me awhile to figure out what those were used for as well, but I\u0027m assuming existing contributors are aware so I\u0027m not sure it needs to be called out.\n\nIOW, see the note at the top of each sample file (I didn\u0027t notice that when I was originally wondering what they were used for).","commit_id":"966a4dfa5f030d4b88e4902c9f762a2d6213a670"}],"devstack/local.conf.compute":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e6a04152e68c2ff5d77a30dd9a9582510f94e40d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"[[post-config|$NOVA_CONF]]"},{"line_number":46,"context_line":"[DEFAULT]"},{"line_number":47,"context_line":"compute_monitors\u003dcpu.virt_driver"},{"line_number":48,"context_line":"[notifications]"},{"line_number":49,"context_line":"# Enable both versioned and unversioned notifications. Watcher only"},{"line_number":50,"context_line":"# uses versioned notifications but ceilometer uses unversioned. We"},{"line_number":51,"context_line":"# can change this to just versioned when ceilometer handles versioned"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9fb8cfa7_0cc02e7b","line":48,"updated":"2019-06-05 17:40:04.000000000","message":"This isn\u0027t getting into nova.conf:\n\nhttp://logs.openstack.org/32/663332/1/check/watcher-tempest-vm_workload_consolidation/67d143a/controller/logs/etc/nova/nova-cpu_conf.txt.gz","commit_id":"487643d0bca7d35fa557013f9560edd9d1798e0b"}],"devstack/local.conf.controller":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e6a04152e68c2ff5d77a30dd9a9582510f94e40d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"[[post-config|$NOVA_CONF]]"},{"line_number":50,"context_line":"[DEFAULT]"},{"line_number":51,"context_line":"compute_monitors\u003dcpu.virt_driver"},{"line_number":52,"context_line":"[notifications]"},{"line_number":53,"context_line":"# Enable both versioned and unversioned notifications. Watcher only"},{"line_number":54,"context_line":"# uses versioned notifications but ceilometer uses unversioned. We"},{"line_number":55,"context_line":"# can change this to just versioned when ceilometer handles versioned"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9fb8cfa7_accfa2ae","line":52,"updated":"2019-06-05 17:40:04.000000000","message":"It doesn\u0027t look like this is getting into nova.conf:\n\nhttp://logs.openstack.org/32/663332/1/check/watcher-tempest-vm_workload_consolidation/67d143a/controller/logs/etc/nova/nova_conf.txt.gz","commit_id":"487643d0bca7d35fa557013f9560edd9d1798e0b"}],"devstack/override-defaults":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"246ccf7d8eb7bd9d670b71726a455d4c98b1ad16","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# can change this to just versioned when ceilometer handles"},{"line_number":7,"context_line":"# versioned notifications from nova:"},{"line_number":8,"context_line":"# https://bugs.launchpad.net/ceilometer/+bug/1665449"},{"line_number":9,"context_line":"NOVA_NOTIFICATION_FORMAT\u003dboth"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"9fb8cfa7_80482c2d","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":29},"updated":"2019-06-24 19:18:17.000000000","message":"nts: support for this was added via Ied9d50b07c368d5c2be658c744f340a8d1ee41e0","commit_id":"966a4dfa5f030d4b88e4902c9f762a2d6213a670"}],"devstack/settings":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2fea1c6ed6a675b0c6c291d778cab9a57654de11","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# can change this to just versioned when ceilometer handles"},{"line_number":17,"context_line":"# versioned notifications from nova:"},{"line_number":18,"context_line":"# https://bugs.launchpad.net/ceilometer/+bug/1665449"},{"line_number":19,"context_line":"NOVA_NOTIFICATION_FORMAT\u003dboth"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"9fb8cfa7_e25530fb","line":19,"updated":"2019-06-12 14:21:07.000000000","message":"Still not working after the grenade upgrade:\n\nhttp://logs.openstack.org/32/663332/8/check/watcher-grenade/32f6696/logs/screen-n-api.txt.gz#_Jun_12_01_26_33_816726","commit_id":"6cde6cb15855919c927bbc55b5d9ddd72d33c052"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9345f259592a7578a98a5824bcc526ea3d14fa7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9fb8cfa7_79cee12d","line":20,"updated":"2019-06-12 00:28:08.000000000","message":"If this doesn\u0027t work, we can try:\n\n[[post-config|$NOVA_CONF]]\n[notifications]\nnotification_format\u003dboth","commit_id":"6cde6cb15855919c927bbc55b5d9ddd72d33c052"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"659b8868ba85d1924149a0f270e3dd651460099f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9fb8cfa7_34029e0b","line":20,"in_reply_to":"9fb8cfa7_79cee12d","updated":"2019-06-12 18:48:46.000000000","message":"This, like the change above, likely won\u0027t matter because I\u0027m guessing the problem is devstack is loading this up *after* it\u0027s already deployed nova.\n\nLooking at a grenade run, the watcher grenade settings are loaded here:\n\nhttp://logs.openstack.org/32/663332/8/check/watcher-grenade/32f6696/logs/grenade.sh.txt.gz#_2019-06-12_00_53_48_155\n\nFor some reason it seems grenade is only loading the devstack/settings on the old side (where the NOVA_NOTIFICATION_FORMAT variable doesn\u0027t exist):\n\nhttp://logs.openstack.org/32/663332/8/check/watcher-grenade/32f6696/logs/grenade.sh.txt.gz#_2019-06-12_00_53_54_322\n\nIt looks like maybe we should have an \"override-defaults\" file to load that up early.\n\nhttp://logs.openstack.org/32/663332/8/check/watcher-grenade/32f6696/logs/grenade.sh.txt.gz#_2019-06-12_00_53_53_672\n\nI suppose override-defaults is for overriding defaults for *other* services and \"settings\" is for overriding defaults for *this* service (which is kind of weird because we\u0027d just define those in devstack/lib/watcher).\n\nThe devstack-plugin-ceph plugin overrides cinder defaults:\n\nhttps://github.com/openstack/devstack-plugin-ceph/blob/master/devstack/override-defaults\n\nSo I guess we can use that as a template.\n\nAlso: https://docs.openstack.org/devstack/latest/plugins.html#plugin-interface","commit_id":"6cde6cb15855919c927bbc55b5d9ddd72d33c052"}],"devstack/upgrade/settings":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3f53fb0acb7de36005864cd657e2305aa0d29332","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# TODO(mriedem): Remove this in the U release or define it in the"},{"line_number":11,"context_line":"# watcher-grenade job definition when that job is zuul v3 native (no longer"},{"line_number":12,"context_line":"# using legacy devstack-gate setup)."},{"line_number":13,"context_line":"devstack_localrc target \u0027\\n\u0027\"[[post-config|$NOVA_CONF]]\"\u0027\\n\u0027\"[notifications]\"\u0027\\n\u0027\"notification_format\u003dboth\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"BASE_RUN_SMOKE\u003dFalse"},{"line_number":16,"context_line":"TARGET_RUN_SMOKE\u003dFalse"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"9fb8cfa7_b55d4716","line":13,"updated":"2019-06-11 16:18:02.000000000","message":"Not surprisingly this blows up:\n\nhttp://logs.openstack.org/32/663332/4/check/watcher-grenade/f563468/logs/grenade.sh.txt.gz#_2019-06-11_15_57_05_138","commit_id":"f9ac25a354d20ecb31bf0ed720c272397a2b21f3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b2f5afaffc857bb3796caf4aa96a3b3415ae7e87","unresolved":false,"context_lines":[{"line_number":7,"context_line":"devstack_localrc base enable_service watcher-api watcher-decision-engine watcher-applier"},{"line_number":8,"context_line":"devstack_localrc target enable_service watcher-api watcher-decision-engine watcher-applier"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# TODO(mriedem): Remove this in the U release or define it in the"},{"line_number":11,"context_line":"# watcher-grenade job definition when that job is zuul v3 native (no longer"},{"line_number":12,"context_line":"# using legacy devstack-gate setup)."},{"line_number":13,"context_line":"devstack_localrc target \u0027\\n\u0027\"[[post-config|$NOVA_CONF]]\"\u0027\\n\u0027\"[notifications]\"\u0027\\n\u0027\"notification_format\u003dboth\""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"9fb8cfa7_3011655e","line":10,"updated":"2019-06-11 18:00:23.000000000","message":"Forgot to remove this.","commit_id":"1eba61638a34c47d644721e15ac09445038336c7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4b83f3df3709ee0b732bd843f54fb579a8356296","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# can change this to just versioned when ceilometer handles"},{"line_number":13,"context_line":"# versioned notifications from nova:"},{"line_number":14,"context_line":"# https://bugs.launchpad.net/ceilometer/+bug/1665449"},{"line_number":15,"context_line":"export NOVA_NOTIFICATION_FORMAT\u003d\"both\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"BASE_RUN_SMOKE\u003dFalse"},{"line_number":18,"context_line":"TARGET_RUN_SMOKE\u003dFalse"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"9fb8cfa7_b915399e","line":15,"updated":"2019-06-12 00:24:22.000000000","message":"Hmm, still not working:\n\nhttp://logs.openstack.org/32/663332/7/check/watcher-grenade/03dcb3a/logs/screen-n-api.txt.gz#_Jun_11_20_56_28_932138","commit_id":"e1b7e0a30a2d6af976720676dd8d0fd75f92eb56"}],"playbooks/legacy/grenade-devstack-watcher/run.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4a6bdca7316bc300ca1358829ab15467b347c202","unresolved":false,"context_lines":[{"line_number":42,"context_line":"          # can change this to just versioned when ceilometer handles"},{"line_number":43,"context_line":"          # versioned notifications from nova:"},{"line_number":44,"context_line":"          # https://bugs.launchpad.net/ceilometer/+bug/1665449"},{"line_number":45,"context_line":"          export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"NOVA_NOTIFICATION_FORMAT\u003dboth\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"          export DEVSTACK_GATE_TEMPEST_NOTESTS\u003d1"},{"line_number":48,"context_line":"          export DEVSTACK_GATE_GRENADE\u003dpullup"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_c1e03d29","line":45,"updated":"2019-06-11 19:40:18.000000000","message":"We could maybe just put this into devstack/upgrade/settings.","commit_id":"537d23910ccb2d2121f5c174233851f0fa682005"}]}