)]}'
{"watcher/tests/decision_engine/model/notification/test_nova_notifications.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c0b4525f67a393ea64b4db8443401b3246ec69b3","unresolved":false,"context_lines":[{"line_number":332,"context_line":"            exception.ComputeNodeNotFound,"},{"line_number":333,"context_line":"            compute_model.get_node_by_uuid, \u0027Node_2\u0027)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    @mock.patch.object(nova_helper.NovaHelper, \u0027get_compute_node_by_hostname\u0027)"},{"line_number":336,"context_line":"    def test_nova_instance_create(self, m_get_node):"},{"line_number":337,"context_line":"        m_get_node.return_value \u003d mock.Mock("},{"line_number":338,"context_line":"            id\u003d3,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_e8c3ca87","line":335,"updated":"2019-06-12 20:00:18.000000000","message":"nit: assert that this mock is called.","commit_id":"1083802281bd136f059c1879f8991403f389a739"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"70eff5befd6dc256cf31dfc4af5ba9e6ff691451","unresolved":false,"context_lines":[{"line_number":332,"context_line":"            exception.ComputeNodeNotFound,"},{"line_number":333,"context_line":"            compute_model.get_node_by_uuid, \u0027Node_2\u0027)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    @mock.patch.object(nova_helper.NovaHelper, \u0027get_compute_node_by_hostname\u0027)"},{"line_number":336,"context_line":"    def test_nova_instance_create(self, m_get_node):"},{"line_number":337,"context_line":"        m_get_node.return_value \u003d mock.Mock("},{"line_number":338,"context_line":"            id\u003d3,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_f1072ec9","line":335,"in_reply_to":"9fb8cfa7_e8c3ca87","updated":"2019-06-13 07:58:50.000000000","message":"Done","commit_id":"1083802281bd136f059c1879f8991403f389a739"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c0b4525f67a393ea64b4db8443401b3246ec69b3","unresolved":false,"context_lines":[{"line_number":333,"context_line":"            compute_model.get_node_by_uuid, \u0027Node_2\u0027)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    @mock.patch.object(nova_helper.NovaHelper, \u0027get_compute_node_by_hostname\u0027)"},{"line_number":336,"context_line":"    def test_nova_instance_create(self, m_get_node):"},{"line_number":337,"context_line":"        m_get_node.return_value \u003d mock.Mock("},{"line_number":338,"context_line":"            id\u003d3,"},{"line_number":339,"context_line":"            hypervisor_hostname\u003d\"compute\","}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_28f562ed","line":336,"updated":"2019-06-12 20:00:18.000000000","message":"The test seems to be racy but I\u0027m not sure why. It seems the error you\u0027re hitting is the misleading one you\u0027re fixing with https://review.opendev.org/#/c/663513/:\n\nft1.21: watcher.tests.decision_engine.model.notification.test_nova_notifications.TestNovaNotifications.test_nova_instance_createtesttools.testresult.real._StringException: Traceback (most recent call last):\n  File \"/home/zuul/src/opendev.org/openstack/watcher/.tox/lower-constraints/lib/python3.6/site-packages/mock/mock.py\", line 1305, in patched\n    return func(*args, **keywargs)\n  File \"/home/zuul/src/opendev.org/openstack/watcher/watcher/tests/decision_engine/model/notification/test_nova_notifications.py\", line 368, in test_nova_instance_create\n    instance0_uuid)\n  File \"/home/zuul/src/opendev.org/openstack/watcher/.tox/lower-constraints/lib/python3.6/site-packages/oslo_concurrency/lockutils.py\", line 274, in inner\n    return f(*args, **kwargs)\n  File \"/home/zuul/src/opendev.org/openstack/watcher/watcher/decision_engine/model/model_root.py\", line 173, in get_node_by_instance_uuid\n    raise exception.ComputeNodeNotFound(name\u003dinstance_uuid)\nwatcher.common.exception.ComputeNodeNotFound: The compute node c03c0bf9-f46e-4e4f-93f1-817568567ee2 could not be found\n\nI\u0027m not sure if it\u0027s because you\u0027re mocking NovaHelper globally rather than mocking helper._nova so it\u0027s just the instance of the object for this test.","commit_id":"1083802281bd136f059c1879f8991403f389a739"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"70eff5befd6dc256cf31dfc4af5ba9e6ff691451","unresolved":false,"context_lines":[{"line_number":333,"context_line":"            compute_model.get_node_by_uuid, \u0027Node_2\u0027)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    @mock.patch.object(nova_helper.NovaHelper, \u0027get_compute_node_by_hostname\u0027)"},{"line_number":336,"context_line":"    def test_nova_instance_create(self, m_get_node):"},{"line_number":337,"context_line":"        m_get_node.return_value \u003d mock.Mock("},{"line_number":338,"context_line":"            id\u003d3,"},{"line_number":339,"context_line":"            hypervisor_hostname\u003d\"compute\","}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_91e4b20e","line":336,"in_reply_to":"9fb8cfa7_28f562ed","updated":"2019-06-13 07:58:50.000000000","message":"Thanks, here should mock NovaHelper class, not just get_compute_node_by_hostname.","commit_id":"1083802281bd136f059c1879f8991403f389a739"}]}