)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d01628032e32be80f607c0d1287986252744a9c3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Backwards compatibility for node parameter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds backwards compatibility for node parameter used by strategies. If"},{"line_number":10,"context_line":"the node value is none default it will override the value for"},{"line_number":11,"context_line":"compute_node which is the value used in the strategies now."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Idaea062789a6b169e64f556fecc34cfbaaee5076"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fb8cfa7_524d0198","line":11,"range":{"start_line":9,"start_character":68,"end_line":11,"end_character":59},"updated":"2019-06-11 16:07:22.000000000","message":"This is a bit hard for me to parse. Do you mean, \"If the node value is none *by* default it will override\"? Or do you mean if the node value is NOT none it will override the value for compute_node?\n\nWas there a regression at some point that makes us need this? Or is this part of some bigger effort? Why/when was \u0027node\u0027 deprecated in favor of \u0027compute_node\u0027?","commit_id":"d80cf0c3e50156e46c0d5fc3a89c3c04edc32e64"},{"author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"change_message_id":"4107398eeb64c9f80ee37e41d79e73efd4cb15a6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Backwards compatibility for node parameter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds backwards compatibility for node parameter used by strategies. If"},{"line_number":10,"context_line":"the node value is none default it will override the value for"},{"line_number":11,"context_line":"compute_node which is the value used in the strategies now."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Idaea062789a6b169e64f556fecc34cfbaaee5076"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fb8cfa7_d18a4168","line":11,"range":{"start_line":9,"start_character":68,"end_line":11,"end_character":59},"in_reply_to":"9fb8cfa7_524d0198","updated":"2019-06-12 07:04:48.000000000","message":"When the value is set by the configuration (not the default)\n\nThis was introduced in: https://review.opendev.org/#/c/656622/\nThis patch was discussed in the last meeting: http://eavesdrop.openstack.org/meetings/watcher/2019/watcher.2019-04-10-08.01.log.html","commit_id":"d80cf0c3e50156e46c0d5fc3a89c3c04edc32e64"},{"author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"change_message_id":"fbea124bc00eafaa481be8d5e609e449d6778d98","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Backwards compatibility for node parameter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds backwards compatibility for node parameter used by strategies. If"},{"line_number":10,"context_line":"the node value is none default it will override the value for"},{"line_number":11,"context_line":"compute_node which is the value used in the strategies now."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Idaea062789a6b169e64f556fecc34cfbaaee5076"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fb8cfa7_679cf70d","line":11,"range":{"start_line":9,"start_character":68,"end_line":11,"end_character":59},"in_reply_to":"9fb8cfa7_b1d30d60","updated":"2019-06-12 09:44:31.000000000","message":"Done","commit_id":"d80cf0c3e50156e46c0d5fc3a89c3c04edc32e64"},{"author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"change_message_id":"addd6749a9df1093fe110b2351826f213579ee8e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Backwards compatibility for node parameter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds backwards compatibility for node parameter used by strategies. If"},{"line_number":10,"context_line":"the node value is none default it will override the value for"},{"line_number":11,"context_line":"compute_node which is the value used in the strategies now."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Idaea062789a6b169e64f556fecc34cfbaaee5076"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fb8cfa7_b1d30d60","line":11,"range":{"start_line":9,"start_character":68,"end_line":11,"end_character":59},"in_reply_to":"9fb8cfa7_d18a4168","updated":"2019-06-12 07:08:54.000000000","message":"Wrong meeting, this is the right one: http://eavesdrop.openstack.org/meetings/watcher/2019/watcher.2019-06-05-08.00.log.html","commit_id":"d80cf0c3e50156e46c0d5fc3a89c3c04edc32e64"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"06fb1da16cf0bc63f40883148edfcbe1fd82a999","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Backwards compatibility for node parameter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds backwards compatibility for node parameter used by strategies. If"},{"line_number":10,"context_line":"the node value is set by the user configuration  it will override the"},{"line_number":11,"context_line":"value for compute_node which is the value used by the strategies now."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change was introduced in: https://review.opendev.org/#/c/656622/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fb8cfa7_c80b6b27","line":10,"range":{"start_line":10,"start_character":47,"end_line":10,"end_character":49},"updated":"2019-06-12 16:23:35.000000000","message":"nit: one space","commit_id":"9f1f77ace5497c18e9d49b6074a13f6798fd553e"}],"releasenotes/notes/formal-datasource-interface-implementation-222769d55a127d33.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"06fb1da16cf0bc63f40883148edfcbe1fd82a999","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    and any out-of-tree strategies will have to be adopted."},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    Several strategies have changed the `node` parameter to `compute_node` to"},{"line_number":14,"context_line":"    be beter inline with terminology. These strategies include"},{"line_number":15,"context_line":"    `basic_consolidation` and `workload_stabilzation`. The `node` parameter"},{"line_number":16,"context_line":"    will remain supported during Train release and will be removed in the"},{"line_number":17,"context_line":"    subsequent release."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_3302b80b","line":14,"range":{"start_line":14,"start_character":13,"end_line":14,"end_character":19},"updated":"2019-06-12 16:23:35.000000000","message":"aligned?","commit_id":"9f1f77ace5497c18e9d49b6074a13f6798fd553e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"06fb1da16cf0bc63f40883148edfcbe1fd82a999","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    and any out-of-tree strategies will have to be adopted."},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    Several strategies have changed the `node` parameter to `compute_node` to"},{"line_number":14,"context_line":"    be beter inline with terminology. These strategies include"},{"line_number":15,"context_line":"    `basic_consolidation` and `workload_stabilzation`. The `node` parameter"},{"line_number":16,"context_line":"    will remain supported during Train release and will be removed in the"},{"line_number":17,"context_line":"    subsequent release."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_8801f308","line":14,"range":{"start_line":14,"start_character":7,"end_line":14,"end_character":12},"updated":"2019-06-12 16:23:35.000000000","message":"better","commit_id":"9f1f77ace5497c18e9d49b6074a13f6798fd553e"}],"watcher/decision_engine/strategy/strategies/basic_consolidation.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d01628032e32be80f607c0d1287986252744a9c3","unresolved":false,"context_lines":[{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        # backwards compatibility for node parameter."},{"line_number":409,"context_line":"        if self.aggregation_method[\u0027node\u0027] is not \u0027\u0027:"},{"line_number":410,"context_line":"            LOG.warning(\u0027Parameter node has been renamed to compute_node and\u0027"},{"line_number":411,"context_line":"                        \u0027will be removed in next release.\u0027)"},{"line_number":412,"context_line":"            self.aggregation_method[\u0027compute_node\u0027] \u003d \\"},{"line_number":413,"context_line":"                self.aggregation_method[\u0027node\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_52642122","line":410,"range":{"start_line":410,"start_character":76,"end_line":410,"end_character":77},"updated":"2019-06-11 16:07:22.000000000","message":"need a space","commit_id":"d80cf0c3e50156e46c0d5fc3a89c3c04edc32e64"},{"author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"change_message_id":"4107398eeb64c9f80ee37e41d79e73efd4cb15a6","unresolved":false,"context_lines":[{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        # backwards compatibility for node parameter."},{"line_number":409,"context_line":"        if self.aggregation_method[\u0027node\u0027] is not \u0027\u0027:"},{"line_number":410,"context_line":"            LOG.warning(\u0027Parameter node has been renamed to compute_node and\u0027"},{"line_number":411,"context_line":"                        \u0027will be removed in next release.\u0027)"},{"line_number":412,"context_line":"            self.aggregation_method[\u0027compute_node\u0027] \u003d \\"},{"line_number":413,"context_line":"                self.aggregation_method[\u0027node\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_8b52643a","line":410,"range":{"start_line":410,"start_character":76,"end_line":410,"end_character":77},"in_reply_to":"9fb8cfa7_52642122","updated":"2019-06-12 07:04:48.000000000","message":"Done","commit_id":"d80cf0c3e50156e46c0d5fc3a89c3c04edc32e64"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d01628032e32be80f607c0d1287986252744a9c3","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        # backwards compatibility for node parameter."},{"line_number":409,"context_line":"        if self.aggregation_method[\u0027node\u0027] is not \u0027\u0027:"},{"line_number":410,"context_line":"            LOG.warning(\u0027Parameter node has been renamed to compute_node and\u0027"},{"line_number":411,"context_line":"                        \u0027will be removed in next release.\u0027)"},{"line_number":412,"context_line":"            self.aggregation_method[\u0027compute_node\u0027] \u003d \\"},{"line_number":413,"context_line":"                self.aggregation_method[\u0027node\u0027]"},{"line_number":414,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_326f2dfd","line":411,"updated":"2019-06-11 16:07:22.000000000","message":"Is this something that should go into a deprecation release note for anyone that has out-of-tree plugin strategies?","commit_id":"d80cf0c3e50156e46c0d5fc3a89c3c04edc32e64"},{"author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"change_message_id":"4107398eeb64c9f80ee37e41d79e73efd4cb15a6","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        # backwards compatibility for node parameter."},{"line_number":409,"context_line":"        if self.aggregation_method[\u0027node\u0027] is not \u0027\u0027:"},{"line_number":410,"context_line":"            LOG.warning(\u0027Parameter node has been renamed to compute_node and\u0027"},{"line_number":411,"context_line":"                        \u0027will be removed in next release.\u0027)"},{"line_number":412,"context_line":"            self.aggregation_method[\u0027compute_node\u0027] \u003d \\"},{"line_number":413,"context_line":"                self.aggregation_method[\u0027node\u0027]"},{"line_number":414,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_6b329012","line":411,"in_reply_to":"9fb8cfa7_326f2dfd","updated":"2019-06-12 07:04:48.000000000","message":"Seems like a decent idea, the release-note for this feature was missed entirely. I\u0027ll add a release-note. Now that I am looking back on it the name change of these parameters could have been a separate patch. https://review.opendev.org/#/c/656622/","commit_id":"d80cf0c3e50156e46c0d5fc3a89c3c04edc32e64"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7884d33b2552bf92b4699c9c0df775c74b8027a3","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        # backwards compatibility for node parameter."},{"line_number":409,"context_line":"        if self.aggregation_method[\u0027node\u0027] is not \u0027\u0027:"},{"line_number":410,"context_line":"            LOG.warning(\u0027Parameter node has been renamed to compute_node and\u0027"},{"line_number":411,"context_line":"                        \u0027will be removed in next release.\u0027)"},{"line_number":412,"context_line":"            self.aggregation_method[\u0027compute_node\u0027] \u003d \\"},{"line_number":413,"context_line":"                self.aggregation_method[\u0027node\u0027]"},{"line_number":414,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_4820dbac","line":411,"in_reply_to":"9fb8cfa7_6b329012","updated":"2019-06-12 16:21:16.000000000","message":"\u003e Now that I am looking back on it the name change of these parameters could have been a separate patch. https://review.opendev.org/#/c/656622/\n\nYeah that change is huge. This is why I try to push for separating changes into individual patches as much as possible because it\u0027s hard to review a lot of unrelated changes in a single large patch (and really had to revert or backport if we need to).","commit_id":"d80cf0c3e50156e46c0d5fc3a89c3c04edc32e64"},{"author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"change_message_id":"fbea124bc00eafaa481be8d5e609e449d6778d98","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        # backwards compatibility for node parameter."},{"line_number":409,"context_line":"        if self.aggregation_method[\u0027node\u0027] is not \u0027\u0027:"},{"line_number":410,"context_line":"            LOG.warning(\u0027Parameter node has been renamed to compute_node and\u0027"},{"line_number":411,"context_line":"                        \u0027will be removed in next release.\u0027)"},{"line_number":412,"context_line":"            self.aggregation_method[\u0027compute_node\u0027] \u003d \\"},{"line_number":413,"context_line":"                self.aggregation_method[\u0027node\u0027]"},{"line_number":414,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_a7966fef","line":411,"in_reply_to":"9fb8cfa7_6b329012","updated":"2019-06-12 09:44:31.000000000","message":"Done","commit_id":"d80cf0c3e50156e46c0d5fc3a89c3c04edc32e64"}],"watcher/decision_engine/strategy/strategies/workload_stabilization.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d01628032e32be80f607c0d1287986252744a9c3","unresolved":false,"context_lines":[{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        # backwards compatibility for node parameter with aggregate."},{"line_number":510,"context_line":"        if self.aggregation_method[\u0027node\u0027] is not \u0027\u0027:"},{"line_number":511,"context_line":"            LOG.warning(\u0027Parameter node has been renamed to compute_node and\u0027"},{"line_number":512,"context_line":"                        \u0027will be removed in next release.\u0027)"},{"line_number":513,"context_line":"            self.aggregation_method[\u0027compute_node\u0027] \u003d \\"},{"line_number":514,"context_line":"                self.aggregation_method[\u0027node\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_32488d85","line":511,"range":{"start_line":511,"start_character":76,"end_line":511,"end_character":77},"updated":"2019-06-11 16:07:22.000000000","message":"space","commit_id":"d80cf0c3e50156e46c0d5fc3a89c3c04edc32e64"},{"author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"change_message_id":"4107398eeb64c9f80ee37e41d79e73efd4cb15a6","unresolved":false,"context_lines":[{"line_number":508,"context_line":""},{"line_number":509,"context_line":"        # backwards compatibility for node parameter with aggregate."},{"line_number":510,"context_line":"        if self.aggregation_method[\u0027node\u0027] is not \u0027\u0027:"},{"line_number":511,"context_line":"            LOG.warning(\u0027Parameter node has been renamed to compute_node and\u0027"},{"line_number":512,"context_line":"                        \u0027will be removed in next release.\u0027)"},{"line_number":513,"context_line":"            self.aggregation_method[\u0027compute_node\u0027] \u003d \\"},{"line_number":514,"context_line":"                self.aggregation_method[\u0027node\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_2b3818ec","line":511,"range":{"start_line":511,"start_character":76,"end_line":511,"end_character":77},"in_reply_to":"9fb8cfa7_32488d85","updated":"2019-06-12 07:04:48.000000000","message":"Done","commit_id":"d80cf0c3e50156e46c0d5fc3a89c3c04edc32e64"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d01628032e32be80f607c0d1287986252744a9c3","unresolved":false,"context_lines":[{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        # backwards compatibility for node parameter with period."},{"line_number":517,"context_line":"        if self.periods[\u0027node\u0027] is not 0:"},{"line_number":518,"context_line":"            LOG.warning(\u0027Parameter node has been renamed to compute_node and\u0027"},{"line_number":519,"context_line":"                        \u0027will be removed in next release.\u0027)"},{"line_number":520,"context_line":"            self.periods[\u0027compute_node\u0027] \u003d self.periods[\u0027node\u0027]"},{"line_number":521,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_d2601104","line":518,"range":{"start_line":518,"start_character":76,"end_line":518,"end_character":77},"updated":"2019-06-11 16:07:22.000000000","message":"space","commit_id":"d80cf0c3e50156e46c0d5fc3a89c3c04edc32e64"},{"author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"change_message_id":"4107398eeb64c9f80ee37e41d79e73efd4cb15a6","unresolved":false,"context_lines":[{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        # backwards compatibility for node parameter with period."},{"line_number":517,"context_line":"        if self.periods[\u0027node\u0027] is not 0:"},{"line_number":518,"context_line":"            LOG.warning(\u0027Parameter node has been renamed to compute_node and\u0027"},{"line_number":519,"context_line":"                        \u0027will be removed in next release.\u0027)"},{"line_number":520,"context_line":"            self.periods[\u0027compute_node\u0027] \u003d self.periods[\u0027node\u0027]"},{"line_number":521,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_eb2520c3","line":518,"range":{"start_line":518,"start_character":76,"end_line":518,"end_character":77},"in_reply_to":"9fb8cfa7_d2601104","updated":"2019-06-12 07:04:48.000000000","message":"Done","commit_id":"d80cf0c3e50156e46c0d5fc3a89c3c04edc32e64"}]}