)]}'
{"id":"openstack%2Fwatcher~664750","triplet_id":"openstack%2Fwatcher~master~I869e89c53284c8da45e0b1293f2d35011f5bfbf9","project":"openstack/watcher","branch":"master","topic":"conf-fixture","hashtags":[],"change_id":"I869e89c53284c8da45e0b1293f2d35011f5bfbf9","subject":"Cleanup ConfFixture","status":"MERGED","created":"2019-06-12 00:20:17.000000000","updated":"2019-06-17 13:48:22.000000000","submitted":"2019-06-16 08:32:41.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"664750-1560673961952-a6cfe23d","meta_rev_id":"94eacd847a43cbbb9efac4be054e11ceb2c5ef10","_number":664750,"virtual_id_number":664750,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":23735,"name":"sumitjami","email":"sjamgade@suse.com","username":"nthforloop"},{"value":0,"_account_id":28935,"name":"98k","email":"18552437190@163.com","username":"98k"},{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":2,"date":"2019-06-16 08:32:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"recommended":{"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},"all":[{"value":1,"date":"2019-06-12 16:36:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":1,"date":"2019-06-13 14:41:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23735,"name":"sumitjami","email":"sjamgade@suse.com","username":"nthforloop"},{"value":1,"date":"2019-06-14 11:46:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28935,"name":"98k","email":"18552437190@163.com","username":"98k"},{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":1,"date":"2019-06-14 14:38:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},{"value":2,"date":"2019-06-14 09:16:39.000000000","_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-06-14 14:57:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"all":[{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":23735,"name":"sumitjami","email":"sjamgade@suse.com","username":"nthforloop"},{"value":0,"_account_id":28935,"name":"98k","email":"18552437190@163.com","username":"98k"},{"value":1,"date":"2019-06-16 08:05:25.000000000","_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":23735,"name":"sumitjami","email":"sjamgade@suse.com","username":"nthforloop"},{"value":0,"_account_id":28935,"name":"98k","email":"18552437190@163.com","username":"98k"},{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23735,"name":"sumitjami","email":"sjamgade@suse.com","username":"nthforloop"},{"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"},{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"_account_id":28935,"name":"98k","email":"18552437190@163.com","username":"98k"},{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-12 16:36:46.000000000","updated_by":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"reviewer":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"state":"REVIEWER"},{"updated":"2019-06-13 14:41:30.000000000","updated_by":{"_account_id":23735,"name":"sumitjami","email":"sjamgade@suse.com","username":"nthforloop"},"reviewer":{"_account_id":23735,"name":"sumitjami","email":"sjamgade@suse.com","username":"nthforloop"},"state":"REVIEWER"},{"updated":"2019-06-14 09:16:39.000000000","updated_by":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"reviewer":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"state":"REVIEWER"},{"updated":"2019-06-14 11:46:42.000000000","updated_by":{"_account_id":28935,"name":"98k","email":"18552437190@163.com","username":"98k"},"reviewer":{"_account_id":28935,"name":"98k","email":"18552437190@163.com","username":"98k"},"state":"REVIEWER"},{"updated":"2019-06-14 14:38:24.000000000","updated_by":{"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},"reviewer":{"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},"state":"REVIEWER"},{"updated":"2019-06-14 14:57:50.000000000","updated_by":{"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"},"reviewer":{"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"},"state":"REVIEWER"},{"updated":"2019-06-16 08:05:25.000000000","updated_by":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"reviewer":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"state":"REVIEWER"},{"updated":"2019-06-16 08:32:41.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"92a3eb3725ae7e729f8f9fcc951900274d380256","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-12 00:20:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"280e6aeb1ff06febb67f30932ec8ac31d26dfbcc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-12 01:43:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/50/664750/1/check/openstack-tox-cover/ef8d0fc/cover/ : SUCCESS in 5m 37s\n- openstack-tox-lower-constraints http://logs.openstack.org/50/664750/1/check/openstack-tox-lower-constraints/b5ddea8/ : SUCCESS in 5m 50s\n- openstack-tox-pep8 http://logs.openstack.org/50/664750/1/check/openstack-tox-pep8/3f20a90/ : SUCCESS in 5m 13s\n- openstack-tox-py27 http://logs.openstack.org/50/664750/1/check/openstack-tox-py27/769ee77/ : SUCCESS in 5m 31s\n- openstack-tox-py36 http://logs.openstack.org/50/664750/1/check/openstack-tox-py36/42c8374/ : SUCCESS in 5m 41s\n- openstack-tox-py37 http://logs.openstack.org/50/664750/1/check/openstack-tox-py37/bf985b5/ : SUCCESS in 6m 23s\n- openstack-tox-docs http://logs.openstack.org/50/664750/1/check/openstack-tox-docs/81c5cdb/html/ : SUCCESS in 5m 06s\n- watcher-tempest-functional http://logs.openstack.org/50/664750/1/check/watcher-tempest-functional/28c01b1/ : SUCCESS in 38m 48s\n- watcher-tempest-dummy_optim http://logs.openstack.org/50/664750/1/check/watcher-tempest-dummy_optim/9cb5cbf/ : SUCCESS in 49m 12s\n- watcher-tempest-actuator http://logs.openstack.org/50/664750/1/check/watcher-tempest-actuator/29e4677/ : SUCCESS in 51m 46s\n- watcher-tempest-basic_optim http://logs.openstack.org/50/664750/1/check/watcher-tempest-basic_optim/39774b2/ : SUCCESS in 44m 59s\n- watcher-tempest-vm_workload_consolidation http://logs.openstack.org/50/664750/1/check/watcher-tempest-vm_workload_consolidation/483ccc9/ : SUCCESS in 46m 17s\n- watcher-tempest-workload_balancing http://logs.openstack.org/50/664750/1/check/watcher-tempest-workload_balancing/6b6ebe4/ : SUCCESS in 47m 11s\n- watcherclient-tempest-functional http://logs.openstack.org/50/664750/1/check/watcherclient-tempest-functional/6508499/ : SUCCESS in 38m 19s\n- watcher-tempest-zone_migration http://logs.openstack.org/50/664750/1/check/watcher-tempest-zone_migration/4e54d04/ : SUCCESS in 48m 41s\n- watcher-tempest-host_maintenance http://logs.openstack.org/50/664750/1/check/watcher-tempest-host_maintenance/b6b3e45/ : SUCCESS in 49m 20s\n- watcher-tempest-storage_balance http://logs.openstack.org/50/664750/1/check/watcher-tempest-storage_balance/61718a2/ : SUCCESS in 49m 24s\n- watcher-tls-test http://logs.openstack.org/50/664750/1/check/watcher-tls-test/39292be/ : SUCCESS in 55m 41s","accounts_in_message":[],"_revision_number":1},{"id":"a9dd256f68a8283303e2fe59ba9564bf07b1502b","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2019-06-12 16:36:46.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"abd767c9849994ecbcf2439048fb7b1ceb9476d8","author":{"_account_id":23735,"name":"sumitjami","email":"sjamgade@suse.com","username":"nthforloop"},"date":"2019-06-13 14:41:30.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"9becce7fa08d97810cc5a341d315618e0f9c3651","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-06-14 09:16:39.000000000","message":"Patch Set 1: Code-Review+2\n\nThanks. Could you find the history when import_opt was removed?. I want to learn it.","accounts_in_message":[],"_revision_number":1},{"id":"e26b37c7cf2c36c65061411fc507bd3cd669b49c","author":{"_account_id":28935,"name":"98k","email":"18552437190@163.com","username":"98k"},"date":"2019-06-14 11:46:42.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"6d4d508bdb9f5e0150be60951813b2195ebba78c","author":{"_account_id":17499,"name":"Filippo Inzaghi","email":"zhao.daqing@99cloud.net","username":"qingszhao"},"date":"2019-06-14 14:38:24.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"27951e82bbd15a3e7e2d111e53bcf7ed5c5dba90","author":{"_account_id":28543,"name":"shupeng","email":"15050873171@163.com","username":"Vieri"},"date":"2019-06-14 14:57:50.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"3574753d6ad2efb35f99ff79ce2d216b644be55d","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-06-16 08:05:25.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"9a6e07acb3f61359f8960510ef8241dfc5f7eb0a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-16 08:05:36.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"e5cb9a73ecb7ca2a432370c83db108310ab8476d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-16 08:32:41.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"826c5fa1731128b68576f23cb2375bc5a6ce5d8a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-16 08:32:41.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/50/664750/1/gate/openstack-tox-lower-constraints/c656c83/ : SUCCESS in 5m 34s\n- openstack-tox-pep8 http://logs.openstack.org/50/664750/1/gate/openstack-tox-pep8/722b138/ : SUCCESS in 5m 10s\n- openstack-tox-py27 http://logs.openstack.org/50/664750/1/gate/openstack-tox-py27/0b3c573/ : SUCCESS in 8m 01s\n- openstack-tox-py36 http://logs.openstack.org/50/664750/1/gate/openstack-tox-py36/abbbd5c/ : SUCCESS in 7m 50s\n- openstack-tox-py37 http://logs.openstack.org/50/664750/1/gate/openstack-tox-py37/da3aded/ : SUCCESS in 5m 35s\n- openstack-tox-docs http://logs.openstack.org/50/664750/1/gate/openstack-tox-docs/a6b3234/html/ : SUCCESS in 7m 16s\n- watcher-tempest-functional http://logs.openstack.org/50/664750/1/gate/watcher-tempest-functional/30473f0/ : SUCCESS in 26m 02s","accounts_in_message":[],"_revision_number":1},{"id":"3a7c34d1401214af8cd36f5fa5ac509219b3c559","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-17 13:48:22.000000000","message":"Patch Set 1:\n\n\u003e Could you find the history when import_opt was removed?. I want to learn it.\n\nThe import_opt statements were added the conf_fixture module in 6a55914b05c77f7e7fd3e95ce5ce65954939d314 which was 4 years ago and maybe necessary at the time, but reading https://github.com/openstack/oslo.config/blob/9c71b0140931b51ffffc3bbdc1b655fdaccce45b/oslo_config/cfgfilter.py it sounds like you\u0027d use import_opt if you wanted to enforce explicitly declaring and restricting which options you\u0027re going to use from an external dependency, and watcher isn\u0027t using ConfigFilter so the import_opt statements are unnecessary. The original change that used them didn\u0027t mention why they were needed either (this is why it\u0027s good to have code comments for this kind of stuff when it\u0027s added - so people 4 years later have an idea what it was for).","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"251264b1b6781d0560988401e4c8095a5cb6f64a","revisions":{"251264b1b6781d0560988401e4c8095a5cb6f64a":{"kind":"REWORK","_number":1,"created":"2019-06-12 00:20:17.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/50/664750/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/50/664750/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/50/664750/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/50/664750/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/50/664750/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/50/664750/1"}}},"commit":{"parents":[{"commit":"46a36d1ad73ca9024ee99c8b1c9cd29c3fea14e0","subject":"Merge \"Fix string formatting\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/46a36d1ad73ca9024ee99c8b1c9cd29c3fea14e0"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-06-12 00:18:20.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-06-12 00:18:20.000000000","tz":-240},"subject":"Cleanup ConfFixture","message":"Cleanup ConfFixture\n\nThis makes the ConfFixture extend the Config fixture from\noslo.config which handles cleanup for us. The module level\nimport_opt calls are also removed since they are no longer\nneeded.\n\nChange-Id: I869e89c53284c8da45e0b1293f2d35011f5bfbf9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/251264b1b6781d0560988401e4c8095a5cb6f64a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/251264b1b6781d0560988401e4c8095a5cb6f64a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}