)]}'
{"id":"openstack%2Fwatcher~665099","triplet_id":"openstack%2Fwatcher~master~I26c553e1067a3cbeac6c0afe1c4bfdee4d939055","project":"openstack/watcher","branch":"master","topic":"remove_dead_code","hashtags":[],"change_id":"I26c553e1067a3cbeac6c0afe1c4bfdee4d939055","subject":"Remove dead code","status":"MERGED","created":"2019-06-13 09:32:49.000000000","updated":"2019-06-14 02:28:47.000000000","submitted":"2019-06-14 02:28:47.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"665099-1560479327291-ac94a5b2","meta_rev_id":"942be379c8d5c0280c186bae91950298015b6f5a","_number":665099,"virtual_id_number":665099,"owner":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":2,"date":"2019-06-14 02:28:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"recommended":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"all":[{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":1,"date":"2019-06-13 19:47:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":1,"date":"2019-06-13 22:43:58.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":2,"date":"2019-06-13 13:17:16.000000000","_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"all":[{"value":0,"date":"2019-06-13 13:17:27.000000000","_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":1,"date":"2019-06-14 01:39:24.000000000","_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-13 13:17:16.000000000","updated_by":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"reviewer":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"state":"REVIEWER"},{"updated":"2019-06-13 13:17:27.000000000","updated_by":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"reviewer":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"state":"REVIEWER"},{"updated":"2019-06-13 19:47:45.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-06-13 22:43:58.000000000","updated_by":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"reviewer":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"state":"REVIEWER"},{"updated":"2019-06-14 02:28:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f4ac7968e13605fb4322a7ea477a96b28a23b006","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-06-13 09:32:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"57a204e78df40b7c7f7576e700b37eb9fbf7f4af","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-13 11:04:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/99/665099/1/check/openstack-tox-cover/8681898/cover/ : SUCCESS in 6m 54s\n- openstack-tox-lower-constraints http://logs.openstack.org/99/665099/1/check/openstack-tox-lower-constraints/0f99042/ : SUCCESS in 5m 36s\n- openstack-tox-pep8 http://logs.openstack.org/99/665099/1/check/openstack-tox-pep8/d36ee59/ : SUCCESS in 5m 15s\n- openstack-tox-py27 http://logs.openstack.org/99/665099/1/check/openstack-tox-py27/417adf7/ : SUCCESS in 5m 49s\n- openstack-tox-py36 http://logs.openstack.org/99/665099/1/check/openstack-tox-py36/b077c74/ : SUCCESS in 6m 51s\n- openstack-tox-py37 http://logs.openstack.org/99/665099/1/check/openstack-tox-py37/e7428cb/ : SUCCESS in 6m 23s\n- openstack-tox-docs http://logs.openstack.org/99/665099/1/check/openstack-tox-docs/be0f334/html/ : SUCCESS in 5m 15s\n- watcher-tempest-functional http://logs.openstack.org/99/665099/1/check/watcher-tempest-functional/0fcfcec/ : SUCCESS in 30m 01s\n- watcher-grenade http://logs.openstack.org/99/665099/1/check/watcher-grenade/4136312/ : SUCCESS in 46m 05s\n- watcher-tempest-dummy_optim http://logs.openstack.org/99/665099/1/check/watcher-tempest-dummy_optim/af855d7/ : SUCCESS in 46m 48s\n- watcher-tempest-actuator http://logs.openstack.org/99/665099/1/check/watcher-tempest-actuator/b3ac3ff/ : SUCCESS in 53m 03s\n- watcher-tempest-basic_optim http://logs.openstack.org/99/665099/1/check/watcher-tempest-basic_optim/a50f964/ : SUCCESS in 47m 26s\n- watcher-tempest-vm_workload_consolidation http://logs.openstack.org/99/665099/1/check/watcher-tempest-vm_workload_consolidation/5c5ce39/ : SUCCESS in 50m 21s\n- watcher-tempest-workload_balancing http://logs.openstack.org/99/665099/1/check/watcher-tempest-workload_balancing/85ecca3/ : SUCCESS in 48m 38s\n- watcherclient-tempest-functional http://logs.openstack.org/99/665099/1/check/watcherclient-tempest-functional/1b1694a/ : SUCCESS in 34m 52s\n- watcher-tempest-zone_migration http://logs.openstack.org/99/665099/1/check/watcher-tempest-zone_migration/c0f1f90/ : SUCCESS in 54m 02s\n- watcher-tempest-host_maintenance http://logs.openstack.org/99/665099/1/check/watcher-tempest-host_maintenance/7357580/ : SUCCESS in 48m 34s\n- watcher-tempest-storage_balance http://logs.openstack.org/99/665099/1/check/watcher-tempest-storage_balance/3d8d0f6/ : SUCCESS in 49m 04s\n- watcher-tls-test http://logs.openstack.org/99/665099/1/check/watcher-tls-test/02e5c88/ : SUCCESS in 50m 53s","accounts_in_message":[],"_revision_number":1},{"id":"3904a29adeb2d453a49ea93b899a9e6704a4d530","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-06-13 13:17:16.000000000","message":"Patch Set 1: Code-Review+2\n\nGood Discovery. Actually it will not return None or False.\nhttps://github.com/openstack/watcher/blob/master/watcher/decision_engine/model/model_root.py#L167","accounts_in_message":[],"_revision_number":1},{"id":"69b61c4d4ed73bd7a822aee4de7940b07e4442fc","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-13 19:47:45.000000000","message":"Patch Set 1: Code-Review+1\n\nYup.","accounts_in_message":[],"_revision_number":1},{"id":"c06e2bf2ddba1a07ee91aafb3c4e3d76f54faa42","author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"date":"2019-06-13 22:43:58.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"dac8ff45c54c96221422106f0201910e6a0ef438","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-06-14 01:39:24.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"dafa4ef9d65571061f3d720fc155300acc3ed652","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-14 01:39:37.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"6bbcb94376bb1546a1eeecb31c4b68ccb1a91123","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-14 02:28:47.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/99/665099/1/gate/openstack-tox-lower-constraints/fa75e3c/ : SUCCESS in 5m 40s\n- openstack-tox-pep8 http://logs.openstack.org/99/665099/1/gate/openstack-tox-pep8/6a8a8ab/ : SUCCESS in 5m 35s\n- openstack-tox-py27 http://logs.openstack.org/99/665099/1/gate/openstack-tox-py27/ce4bad2/ : SUCCESS in 5m 46s\n- openstack-tox-py36 http://logs.openstack.org/99/665099/1/gate/openstack-tox-py36/ec1d520/ : SUCCESS in 5m 58s\n- openstack-tox-py37 http://logs.openstack.org/99/665099/1/gate/openstack-tox-py37/c2148e7/ : SUCCESS in 6m 28s\n- openstack-tox-docs http://logs.openstack.org/99/665099/1/gate/openstack-tox-docs/97427f5/html/ : SUCCESS in 5m 13s\n- watcher-tempest-functional http://logs.openstack.org/99/665099/1/gate/watcher-tempest-functional/3b98946/ : SUCCESS in 33m 08s","accounts_in_message":[],"_revision_number":1},{"id":"0e2b438ac38a2c3385f6db6eb19f83aaba549d5f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-14 02:28:47.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7281f6184f6f8d014790bc295ed091420e341cdf","revisions":{"7281f6184f6f8d014790bc295ed091420e341cdf":{"kind":"REWORK","_number":1,"created":"2019-06-13 09:32:49.000000000","uploader":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"ref":"refs/changes/99/665099/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/99/665099/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/99/665099/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/99/665099/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/99/665099/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/99/665099/1"}}},"commit":{"parents":[{"commit":"46a36d1ad73ca9024ee99c8b1c9cd29c3fea14e0","subject":"Merge \"Fix string formatting\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/46a36d1ad73ca9024ee99c8b1c9cd29c3fea14e0"}]}],"author":{"name":"licanwei","email":"li.canwei2@zte.com.cn","date":"2019-06-13 09:31:49.000000000","tz":480},"committer":{"name":"licanwei","email":"li.canwei2@zte.com.cn","date":"2019-06-13 09:31:49.000000000","tz":480},"subject":"Remove dead code","message":"Remove dead code\n\nget_node_by_instance_uuid will never return None,\nso the OR condition is dead code.\n\nChange-Id: I26c553e1067a3cbeac6c0afe1c4bfdee4d939055\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/7281f6184f6f8d014790bc295ed091420e341cdf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/7281f6184f6f8d014790bc295ed091420e341cdf"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}