)]}'
{"id":"openstack%2Fwatcher~666856","triplet_id":"openstack%2Fwatcher~master~Ifd8be7491669c429482d880fdf0219be5ef03163","project":"openstack/watcher","branch":"master","topic":"grafana_upstream_config_update","hashtags":[],"change_id":"Ifd8be7491669c429482d880fdf0219be5ef03163","subject":"Improve the configuration parameters for grafana","status":"MERGED","created":"2019-06-21 14:49:11.000000000","updated":"2019-06-27 07:03:21.000000000","submitted":"2019-06-27 07:03:21.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":18,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"666856-1561619001249-0124e28e","meta_rev_id":"813f1d4f1fcdb0e2ab8fb7f4a2528182d7a0eb98","_number":666856,"virtual_id_number":666856,"owner":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":2,"date":"2019-06-27 07:03:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"recommended":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":1,"date":"2019-06-25 06:39:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":1,"date":"2019-06-24 18:39:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-06-25 13:10:49.000000000","_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":2,"date":"2019-06-26 09:09:19.000000000","_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"all":[{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":1,"date":"2019-06-26 09:09:19.000000000","_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-24 18:39:09.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-06-25 13:10:49.000000000","updated_by":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"reviewer":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"state":"REVIEWER"},{"updated":"2019-06-26 09:09:19.000000000","updated_by":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"reviewer":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"state":"REVIEWER"},{"updated":"2019-06-27 07:03:20.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"afea91907da89563502cafa268c134bb5d26559f","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-06-21 14:49:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dfb3c2ef90cb7561a2223c0aedd3d68a2c9400a9","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-21 15:09:28.000000000","message":"Patch Set 1: Code-Review-1\n\n(7 comments)\n\nThanks for following up, a few small issues inline.","accounts_in_message":[],"_revision_number":1},{"id":"d9bf18b72e2b64d81eacd37d313a9cd093510f1d","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-06-21 15:42:44.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2c2d0f6e3eb959b31f578d48b58db6c5a5f2611e","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-06-21 15:42:59.000000000","message":"Patch Set 1:\n\n(6 comments)","accounts_in_message":[],"_revision_number":1},{"id":"e158afc88530ddface6d1c33062236853a7b86c7","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-21 15:57:52.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c19378ecc52b9bf6e9036a065369f7d7aecc4218","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-21 15:58:30.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)\n\nlgtm thanks","accounts_in_message":[],"_revision_number":2},{"id":"34c94d5de5fa468825804da13532d3f6619d5a9e","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-06-21 16:00:25.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"771fd173c10059f58528ce14649085ce061a7542","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-21 16:04:21.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"3f2abf1b0dafe2ebb128a2e602e82ac4076f7a41","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-21 16:58:30.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/56/666856/2/check/openstack-tox-cover/f322d47/cover/ : SUCCESS in 6m 29s\n- openstack-tox-lower-constraints http://logs.openstack.org/56/666856/2/check/openstack-tox-lower-constraints/6b7cfbe/ : SUCCESS in 5m 45s\n- openstack-tox-pep8 http://logs.openstack.org/56/666856/2/check/openstack-tox-pep8/a5e7145/ : SUCCESS in 5m 33s\n- openstack-tox-py27 http://logs.openstack.org/56/666856/2/check/openstack-tox-py27/8fb6555/ : SUCCESS in 5m 39s\n- openstack-tox-py36 http://logs.openstack.org/56/666856/2/check/openstack-tox-py36/ba0081d/ : SUCCESS in 5m 44s\n- openstack-tox-py37 http://logs.openstack.org/56/666856/2/check/openstack-tox-py37/f907ba7/ : SUCCESS in 6m 29s\n- openstack-tox-docs http://logs.openstack.org/56/666856/2/check/openstack-tox-docs/0c61762/html/ : SUCCESS in 5m 00s\n- watcher-tempest-functional http://logs.openstack.org/56/666856/2/check/watcher-tempest-functional/9e43625/ : SUCCESS in 33m 25s\n- watcher-grenade http://logs.openstack.org/56/666856/2/check/watcher-grenade/c2eac2a/ : SUCCESS in 50m 21s\n- watcher-tempest-dummy_optim http://logs.openstack.org/56/666856/2/check/watcher-tempest-dummy_optim/5586e69/ : SUCCESS in 49m 10s\n- watcher-tempest-actuator http://logs.openstack.org/56/666856/2/check/watcher-tempest-actuator/5af56c7/ : SUCCESS in 56m 51s\n- watcher-tempest-basic_optim http://logs.openstack.org/56/666856/2/check/watcher-tempest-basic_optim/b28dbd4/ : SUCCESS in 49m 37s\n- watcher-tempest-vm_workload_consolidation http://logs.openstack.org/56/666856/2/check/watcher-tempest-vm_workload_consolidation/de45574/ : SUCCESS in 47m 58s\n- watcher-tempest-workload_balancing http://logs.openstack.org/56/666856/2/check/watcher-tempest-workload_balancing/a91a14d/ : SUCCESS in 59m 48s\n- watcherclient-tempest-functional http://logs.openstack.org/56/666856/2/check/watcherclient-tempest-functional/a9fb872/ : SUCCESS in 33m 13s\n- watcher-tempest-zone_migration http://logs.openstack.org/56/666856/2/check/watcher-tempest-zone_migration/f8d7067/ : SUCCESS in 50m 53s\n- watcher-tempest-host_maintenance http://logs.openstack.org/56/666856/2/check/watcher-tempest-host_maintenance/9a4d8fa/ : SUCCESS in 51m 01s\n- watcher-tempest-storage_balance http://logs.openstack.org/56/666856/2/check/watcher-tempest-storage_balance/4d69884/ : SUCCESS in 58m 39s\n- watcher-tls-test http://logs.openstack.org/56/666856/2/check/watcher-tls-test/bdc5e04/ : SUCCESS in 49m 30s","accounts_in_message":[],"_revision_number":2},{"id":"fe2283831ed29a635489c91ace0ef5c6b4925ef3","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-21 17:58:34.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"72fa316fa26ce155cc1d6540048a13edd9f5bb75","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-21 18:01:59.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"736923711b9c2d21e7c65b454523ae7885bb483f","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-21 18:02:22.000000000","message":"Patch Set 3: Code-Review+1\n\nFixed the group help issue for the docs.","accounts_in_message":[],"_revision_number":3},{"id":"82f09cbee2fa54ddb46e305950bdcd46cadb8f94","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-21 19:18:06.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-cover http://logs.openstack.org/56/666856/3/check/openstack-tox-cover/111afb9/ : FAILURE in 5m 56s\n- openstack-tox-lower-constraints http://logs.openstack.org/56/666856/3/check/openstack-tox-lower-constraints/9ec39ba/ : FAILURE in 5m 43s\n- openstack-tox-pep8 http://logs.openstack.org/56/666856/3/check/openstack-tox-pep8/15ac6b2/ : SUCCESS in 6m 18s\n- openstack-tox-py27 http://logs.openstack.org/56/666856/3/check/openstack-tox-py27/c67d94b/ : FAILURE in 6m 42s\n- openstack-tox-py36 http://logs.openstack.org/56/666856/3/check/openstack-tox-py36/ae98c76/ : FAILURE in 6m 19s\n- openstack-tox-py37 http://logs.openstack.org/56/666856/3/check/openstack-tox-py37/0857464/ : FAILURE in 6m 42s\n- openstack-tox-docs http://logs.openstack.org/56/666856/3/check/openstack-tox-docs/4ca15e6/html/ : SUCCESS in 5m 15s\n- watcher-tempest-functional http://logs.openstack.org/56/666856/3/check/watcher-tempest-functional/e20db08/ : SUCCESS in 33m 55s\n- watcher-grenade http://logs.openstack.org/56/666856/3/check/watcher-grenade/56a98b0/ : SUCCESS in 49m 59s\n- watcher-tempest-dummy_optim http://logs.openstack.org/56/666856/3/check/watcher-tempest-dummy_optim/9530b93/ : SUCCESS in 51m 55s\n- watcher-tempest-actuator http://logs.openstack.org/56/666856/3/check/watcher-tempest-actuator/fc6fdbb/ : SUCCESS in 52m 02s\n- watcher-tempest-basic_optim http://logs.openstack.org/56/666856/3/check/watcher-tempest-basic_optim/ba31d8c/ : SUCCESS in 48m 02s\n- watcher-tempest-vm_workload_consolidation http://logs.openstack.org/56/666856/3/check/watcher-tempest-vm_workload_consolidation/3686606/ : SUCCESS in 47m 22s\n- watcher-tempest-workload_balancing http://logs.openstack.org/56/666856/3/check/watcher-tempest-workload_balancing/c838898/ : SUCCESS in 50m 16s\n- watcherclient-tempest-functional http://logs.openstack.org/56/666856/3/check/watcherclient-tempest-functional/bf152fb/ : SUCCESS in 36m 13s\n- watcher-tempest-zone_migration http://logs.openstack.org/56/666856/3/check/watcher-tempest-zone_migration/a6719dc/ : SUCCESS in 49m 08s\n- watcher-tempest-host_maintenance http://logs.openstack.org/56/666856/3/check/watcher-tempest-host_maintenance/7c39c56/ : SUCCESS in 48m 48s\n- watcher-tempest-storage_balance http://logs.openstack.org/56/666856/3/check/watcher-tempest-storage_balance/538a597/ : SUCCESS in 54m 26s\n- watcher-tls-test http://logs.openstack.org/56/666856/3/check/watcher-tls-test/ed7a438/ : SUCCESS in 48m 33s","accounts_in_message":[],"_revision_number":3},{"id":"4b5405759734f578e9bd8257c80c73343accf213","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-21 20:22:58.000000000","message":"Patch Set 3: -Code-Review\n\nOh oops it looks like using the OptGroup in list_opts breaks some tests (those tests probably need to be fixed). I could do that as a follow up if you want to undo PS3.","accounts_in_message":[],"_revision_number":3},{"id":"536efc10e716e22ea21fea6dd66cce178fbb797b","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-24 18:38:56.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"82004553b08a94d47ce0e52366504a3bec5da601","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-24 18:39:09.000000000","message":"Patch Set 4: Code-Review+1\n\nI fixed the unit test failures.","accounts_in_message":[],"_revision_number":4},{"id":"c69e5b4508e273fc405e405cdae68042abf31b52","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-24 19:49:16.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/56/666856/4/check/openstack-tox-cover/84581c7/cover/ : SUCCESS in 5m 31s\n- openstack-tox-lower-constraints http://logs.openstack.org/56/666856/4/check/openstack-tox-lower-constraints/39e651a/ : SUCCESS in 4m 55s\n- openstack-tox-pep8 http://logs.openstack.org/56/666856/4/check/openstack-tox-pep8/8cb17b2/ : SUCCESS in 3m 56s\n- openstack-tox-py27 http://logs.openstack.org/56/666856/4/check/openstack-tox-py27/f596e10/ : SUCCESS in 4m 58s\n- openstack-tox-py36 http://logs.openstack.org/56/666856/4/check/openstack-tox-py36/27e41b0/ : SUCCESS in 4m 32s\n- openstack-tox-py37 http://logs.openstack.org/56/666856/4/check/openstack-tox-py37/6576a41/ : SUCCESS in 4m 22s\n- openstack-tox-docs http://logs.openstack.org/56/666856/4/check/openstack-tox-docs/35b8914/html/ : SUCCESS in 3m 44s\n- watcher-tempest-functional http://logs.openstack.org/56/666856/4/check/watcher-tempest-functional/a56d2b8/ : SUCCESS in 30m 00s\n- watcher-grenade http://logs.openstack.org/56/666856/4/check/watcher-grenade/f38cdfc/ : SUCCESS in 45m 33s\n- watcher-tempest-dummy_optim http://logs.openstack.org/56/666856/4/check/watcher-tempest-dummy_optim/af04e3f/ : SUCCESS in 49m 29s\n- watcher-tempest-actuator http://logs.openstack.org/56/666856/4/check/watcher-tempest-actuator/6b9e68e/ : SUCCESS in 50m 43s\n- watcher-tempest-basic_optim http://logs.openstack.org/56/666856/4/check/watcher-tempest-basic_optim/48bb78a/ : SUCCESS in 49m 57s\n- watcher-tempest-vm_workload_consolidation http://logs.openstack.org/56/666856/4/check/watcher-tempest-vm_workload_consolidation/8179d34/ : SUCCESS in 50m 52s\n- watcher-tempest-workload_balancing http://logs.openstack.org/56/666856/4/check/watcher-tempest-workload_balancing/7aee1b7/ : SUCCESS in 51m 49s\n- watcherclient-tempest-functional http://logs.openstack.org/56/666856/4/check/watcherclient-tempest-functional/9961106/ : SUCCESS in 35m 41s\n- watcher-tempest-zone_migration http://logs.openstack.org/56/666856/4/check/watcher-tempest-zone_migration/75f9c9c/ : SUCCESS in 1h 00m 24s\n- watcher-tempest-host_maintenance http://logs.openstack.org/56/666856/4/check/watcher-tempest-host_maintenance/bd75f12/ : SUCCESS in 48m 45s\n- watcher-tempest-storage_balance http://logs.openstack.org/56/666856/4/check/watcher-tempest-storage_balance/e5d7e93/ : SUCCESS in 50m 30s\n- watcher-tls-test http://logs.openstack.org/56/666856/4/check/watcher-tls-test/dca30fb/ : SUCCESS in 48m 45s","accounts_in_message":[],"_revision_number":4},{"id":"95d38069eceec375057829ddd0a43b21bc6913f4","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-06-25 06:39:24.000000000","message":"Patch Set 4: Code-Review+1\n\nMatt\u0027s additions look good to me, Maybe we could do a follow up patch were we add the OptGroup object in all the options not just for Grafana and Placement.","accounts_in_message":[],"_revision_number":4},{"id":"6c1e85c7d6d0298d3df10fbd651f3ab298de81f4","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-06-25 13:10:49.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"5d82aa7f7cbf6ac0b0228af91be8e3286fc7bc4b","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-06-25 14:52:02.000000000","message":"Patch Set 4:\n\n\u003e Maybe we could do a follow up patch were we add the OptGroup object in all the options not just for Grafana and Placement.\n\nI looked at the rest and none have a help kwarg in the OptGroup so using the group wouldn\u0027t really buy us much unless we wanted to start documenting help for the other groups as well - unless you\u0027re just thinking of doing that for the future (or so that new opt groups that copy existing ones don\u0027t run into the same problem).","accounts_in_message":[],"_revision_number":4},{"id":"bb99ec6206377eb658974a370cbd89755dfcd4fd","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-06-26 08:28:58.000000000","message":"Patch Set 4:\n\n\u003e \u003e Maybe we could do a follow up patch were we add the OptGroup\n \u003e object in all the options not just for Grafana and Placement.\n \u003e \n \u003e I looked at the rest and none have a help kwarg in the OptGroup so\n \u003e using the group wouldn\u0027t really buy us much unless we wanted to\n \u003e start documenting help for the other groups as well - unless you\u0027re\n \u003e just thinking of doing that for the future (or so that new opt\n \u003e groups that copy existing ones don\u0027t run into the same problem).\n\nI think it is good for future reference and consistency. Furthermore, I noticed using the OptGroup objects in list_opts ensures the titles are rendered in the configuration sample. I have made a follow-up: https://review.opendev.org/#/c/667522/","accounts_in_message":[],"_revision_number":4},{"id":"7df4f00de634659d7a5e2ba22fd06997e1c4e324","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-06-26 09:09:19.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"15016b9942adaa935b4968b7a72229eeacfc4bfd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-27 06:20:24.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"e2b59df5b7011d8679011c78e19219de28e519ce","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-27 07:03:20.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/56/666856/4/gate/openstack-tox-lower-constraints/7e45229/ : SUCCESS in 7m 53s\n- openstack-tox-pep8 http://logs.openstack.org/56/666856/4/gate/openstack-tox-pep8/9ed066e/ : SUCCESS in 4m 13s\n- openstack-tox-py27 http://logs.openstack.org/56/666856/4/gate/openstack-tox-py27/bf1ce10/ : SUCCESS in 5m 24s\n- openstack-tox-py36 http://logs.openstack.org/56/666856/4/gate/openstack-tox-py36/4b017a4/ : SUCCESS in 5m 29s\n- openstack-tox-py37 http://logs.openstack.org/56/666856/4/gate/openstack-tox-py37/f75e515/ : SUCCESS in 5m 04s\n- openstack-tox-docs http://logs.openstack.org/56/666856/4/gate/openstack-tox-docs/78a58cb/html/ : SUCCESS in 4m 49s\n- watcher-tempest-functional http://logs.openstack.org/56/666856/4/gate/watcher-tempest-functional/a7cd095/ : SUCCESS in 37m 34s","accounts_in_message":[],"_revision_number":4},{"id":"a88fbcbb6583d9484b32ed59ab30d341c4c43d17","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-27 07:03:21.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"d08d7c396eb0c4231d44700c5b5ee3901a0e68ac","revisions":{"65a9e98b69acb3e131cc90b4fab2c0ca5d59d35b":{"kind":"REWORK","_number":1,"created":"2019-06-21 14:49:11.000000000","uploader":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"ref":"refs/changes/56/666856/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/56/666856/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/56/666856/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/56/666856/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/56/666856/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/56/666856/1"}}},"commit":{"parents":[{"commit":"d98f51c452aa15f5a17f75772e0fe6a99030429f","subject":"Merge \"Implement the configuration for Grafana datasource\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/d98f51c452aa15f5a17f75772e0fe6a99030429f"}]}],"author":{"name":"Dantali0n","email":"info@dantalion.nl","date":"2019-06-21 14:48:21.000000000","tz":120},"committer":{"name":"Dantali0n","email":"info@dantalion.nl","date":"2019-06-21 14:48:21.000000000","tz":120},"subject":"Improve the configuration parameters for grafana","message":"Improve the configuration parameters for grafana\n\nThis improves the documentation on configuration parameters for the\nGrafana datasource.\n\nDepends-on: I5d1d3129b5d225f0f2fc86d149c046f9aab94d47\nChange-Id: Ifd8be7491669c429482d880fdf0219be5ef03163\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/65a9e98b69acb3e131cc90b4fab2c0ca5d59d35b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/65a9e98b69acb3e131cc90b4fab2c0ca5d59d35b"}]},"branch":"refs/heads/master"},"4f04d558470c99669e57d3d98e6a9d907ee30f0f":{"kind":"REWORK","_number":2,"created":"2019-06-21 15:42:44.000000000","uploader":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"ref":"refs/changes/56/666856/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/56/666856/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/56/666856/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/56/666856/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/56/666856/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/56/666856/2"}}},"commit":{"parents":[{"commit":"d98f51c452aa15f5a17f75772e0fe6a99030429f","subject":"Merge \"Implement the configuration for Grafana datasource\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/d98f51c452aa15f5a17f75772e0fe6a99030429f"}]}],"author":{"name":"Dantali0n","email":"info@dantalion.nl","date":"2019-06-21 14:48:21.000000000","tz":120},"committer":{"name":"Dantali0n","email":"info@dantalion.nl","date":"2019-06-21 15:42:12.000000000","tz":120},"subject":"Improve the configuration parameters for grafana","message":"Improve the configuration parameters for grafana\n\nThis improves the documentation on configuration parameters for the\nGrafana datasource.\n\nFollow-up: If1f27dc01e853c5b24bdb21f1e810f64eaee2e5c\nDepends-on: I5d1d3129b5d225f0f2fc86d149c046f9aab94d47\nChange-Id: Ifd8be7491669c429482d880fdf0219be5ef03163\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/4f04d558470c99669e57d3d98e6a9d907ee30f0f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/4f04d558470c99669e57d3d98e6a9d907ee30f0f"}]},"branch":"refs/heads/master"},"f209136194ec08ef3c008c6d2e0b13144f67ff55":{"kind":"REWORK","_number":3,"created":"2019-06-21 18:01:59.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/56/666856/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/56/666856/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/56/666856/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/56/666856/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/56/666856/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/56/666856/3"}}},"commit":{"parents":[{"commit":"d98f51c452aa15f5a17f75772e0fe6a99030429f","subject":"Merge \"Implement the configuration for Grafana datasource\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/d98f51c452aa15f5a17f75772e0fe6a99030429f"}]}],"author":{"name":"Dantali0n","email":"info@dantalion.nl","date":"2019-06-21 14:48:21.000000000","tz":120},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-06-21 18:01:51.000000000","tz":-240},"subject":"Improve the configuration parameters for grafana","message":"Improve the configuration parameters for grafana\n\nThis improves the documentation on configuration parameters for the\nGrafana datasource.\n\nFollow-up: If1f27dc01e853c5b24bdb21f1e810f64eaee2e5c\nDepends-on: I5d1d3129b5d225f0f2fc86d149c046f9aab94d47\nChange-Id: Ifd8be7491669c429482d880fdf0219be5ef03163\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/f209136194ec08ef3c008c6d2e0b13144f67ff55"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/f209136194ec08ef3c008c6d2e0b13144f67ff55"}]},"branch":"refs/heads/master"},"d08d7c396eb0c4231d44700c5b5ee3901a0e68ac":{"kind":"REWORK","_number":4,"created":"2019-06-24 18:38:56.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/56/666856/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/56/666856/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/56/666856/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/56/666856/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/56/666856/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/56/666856/4"}}},"commit":{"parents":[{"commit":"d98f51c452aa15f5a17f75772e0fe6a99030429f","subject":"Merge \"Implement the configuration for Grafana datasource\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/d98f51c452aa15f5a17f75772e0fe6a99030429f"}]}],"author":{"name":"Dantali0n","email":"info@dantalion.nl","date":"2019-06-21 14:48:21.000000000","tz":120},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-06-24 18:38:42.000000000","tz":-240},"subject":"Improve the configuration parameters for grafana","message":"Improve the configuration parameters for grafana\n\nThis improves the documentation on configuration parameters for the\nGrafana datasource.\n\nFollow-up: If1f27dc01e853c5b24bdb21f1e810f64eaee2e5c\nDepends-on: I5d1d3129b5d225f0f2fc86d149c046f9aab94d47\nChange-Id: Ifd8be7491669c429482d880fdf0219be5ef03163\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/d08d7c396eb0c4231d44700c5b5ee3901a0e68ac"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/d08d7c396eb0c4231d44700c5b5ee3901a0e68ac"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}