)]}'
{"id":"openstack%2Fwatcher~670301","triplet_id":"openstack%2Fwatcher~master~I7453678cc76892ebeacca23c3501a10a08725d1d","project":"openstack/watcher","branch":"master","topic":"bug/1836195","hashtags":[],"change_id":"I7453678cc76892ebeacca23c3501a10a08725d1d","subject":"Resolve aggregate error in workload_stabilization","status":"MERGED","created":"2019-07-11 13:00:16.000000000","updated":"2019-07-12 02:03:59.000000000","submitted":"2019-07-12 02:03:59.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"670301-1562897039607-4e3e88c1","meta_rev_id":"df3a3e2c424900b6ae490f02499533da2b7d7407","_number":670301,"virtual_id_number":670301,"owner":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":2,"date":"2019-07-12 02:03:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"date":"2019-07-11 14:36:07.000000000","_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"all":[{"value":2,"date":"2019-07-11 14:38:08.000000000","_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":2,"date":"2019-07-12 01:32:49.000000000","_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"all":[{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"value":1,"date":"2019-07-12 01:32:56.000000000","_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-07-11 13:01:01.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-11 13:01:01.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-07-11 14:38:08.000000000","updated_by":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"reviewer":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"state":"REVIEWER"},{"updated":"2019-07-12 01:32:56.000000000","updated_by":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"reviewer":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"state":"REVIEWER"},{"updated":"2019-07-12 02:03:59.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f4c842caa320e7bbcc6cec307dc712ec5c5d37d5","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-07-11 13:00:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"17db03c60099bfbe0e94eab5102b4e039febe186","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-11 14:06:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/01/670301/1/check/openstack-tox-cover/aa29180/cover/ : SUCCESS in 6m 32s\n- openstack-tox-lower-constraints http://logs.openstack.org/01/670301/1/check/openstack-tox-lower-constraints/9c0f0cf/ : SUCCESS in 4m 17s\n- openstack-tox-pep8 http://logs.openstack.org/01/670301/1/check/openstack-tox-pep8/d8a9028/ : SUCCESS in 5m 02s\n- openstack-tox-py27 http://logs.openstack.org/01/670301/1/check/openstack-tox-py27/cc9c1bb/ : SUCCESS in 4m 24s\n- openstack-tox-py36 http://logs.openstack.org/01/670301/1/check/openstack-tox-py36/f46cd85/ : SUCCESS in 4m 26s\n- openstack-tox-py37 http://logs.openstack.org/01/670301/1/check/openstack-tox-py37/cf033c7/ : SUCCESS in 7m 41s\n- openstack-tox-docs http://logs.openstack.org/01/670301/1/check/openstack-tox-docs/b56da1e/html/ : SUCCESS in 3m 03s\n- watcher-tempest-functional http://logs.openstack.org/01/670301/1/check/watcher-tempest-functional/eba4c38/ : SUCCESS in 30m 17s\n- watcher-grenade http://logs.openstack.org/01/670301/1/check/watcher-grenade/e910f75/ : SUCCESS in 48m 19s\n- watcher-tempest-dummy_optim http://logs.openstack.org/01/670301/1/check/watcher-tempest-dummy_optim/b4837f8/ : SUCCESS in 50m 31s\n- watcher-tempest-actuator http://logs.openstack.org/01/670301/1/check/watcher-tempest-actuator/7f28976/ : SUCCESS in 55m 38s\n- watcher-tempest-basic_optim http://logs.openstack.org/01/670301/1/check/watcher-tempest-basic_optim/ea6133b/ : SUCCESS in 49m 07s\n- watcher-tempest-vm_workload_consolidation http://logs.openstack.org/01/670301/1/check/watcher-tempest-vm_workload_consolidation/31f9dfe/ : SUCCESS in 52m 20s\n- watcher-tempest-workload_balancing http://logs.openstack.org/01/670301/1/check/watcher-tempest-workload_balancing/df331f8/ : SUCCESS in 54m 50s\n- watcherclient-tempest-functional http://logs.openstack.org/01/670301/1/check/watcherclient-tempest-functional/4f91ead/ : SUCCESS in 33m 11s\n- watcher-tempest-zone_migration http://logs.openstack.org/01/670301/1/check/watcher-tempest-zone_migration/c68c79f/ : SUCCESS in 53m 39s\n- watcher-tempest-host_maintenance http://logs.openstack.org/01/670301/1/check/watcher-tempest-host_maintenance/b1efdde/ : SUCCESS in 47m 48s\n- watcher-tempest-storage_balance http://logs.openstack.org/01/670301/1/check/watcher-tempest-storage_balance/db4fa98/ : SUCCESS in 57m 00s\n- watcher-tls-test http://logs.openstack.org/01/670301/1/check/watcher-tls-test/415c9e9/ : SUCCESS in 47m 16s","accounts_in_message":[],"_revision_number":1},{"id":"a7857a2e83c64f2c7a06cf8c0fb1a02493258b20","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-07-11 14:27:17.000000000","message":"Patch Set 1:\n\nIs this bug happening on the stein version?","accounts_in_message":[],"_revision_number":1},{"id":"cb9be1224d6e3121dc0ab7fcb76b198a1182cdca","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-07-11 14:28:51.000000000","message":"Patch Set 1:\n\n\u003e Is this bug happening on the stein version?\n\nNo, https://github.com/openstack/watcher/blob/stable/stein/watcher/decision_engine/strategy/strategies/workload_stabilization.py#L512","accounts_in_message":[],"_revision_number":1},{"id":"e60e0ed79b0c26d5bc8a3b7d0ef72eb2f7a56043","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-07-11 14:33:58.000000000","message":"Patch Set 1:\n\n\u003e \u003e Is this bug happening on the stein version?\n \u003e \n \u003e No, https://github.com/openstack/watcher/blob/stable/stein/watcher/decision_engine/strategy/strategies/workload_stabilization.py#L512\n\nOk. I remeber this patch: https://review.opendev.org/#/c/664534/7","accounts_in_message":[],"_revision_number":1},{"id":"4b1dbb11c852148f3ff021fb6a3f16400e1fce6e","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-07-11 14:36:07.000000000","message":"Patch Set 1:\n\n\u003e \u003e \u003e Is this bug happening on the stein version?\n \u003e \u003e\n \u003e \u003e No, https://github.com/openstack/watcher/blob/stable/stein/watcher/decision_engine/strategy/strategies/workload_stabilization.py#L512\n \u003e \n \u003e Ok. I remeber this patch: https://review.opendev.org/#/c/664534/7\n\nYes, it is not backported to stein.","accounts_in_message":[],"_revision_number":1},{"id":"fcd345bfcf703b9ae44503c4f0856edac0c4014d","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-07-11 14:38:08.000000000","message":"Patch Set 1: Code-Review+2\n\n\u003e\u003e\u003e a\u003du\u0027\u0027\n\u003e\u003e\u003e a\nu\u0027\u0027\n\u003e\u003e\u003e type(a)\n\u003ctype \u0027unicode\u0027\u003e\n\u003e\u003e\u003e b\u003d\u0027\u0027\n\u003e\u003e\u003e a is b\nFalse\n\u003e\u003e\u003e a \u003d\u003d b\nTrue","accounts_in_message":[],"_revision_number":1},{"id":"e729a7a77b83ab7a5361c1d6bd24f8ea65d5cb0b","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-07-12 01:32:49.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"37a04b5dbc3536923682579e8230b96a5c2cbe43","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-07-12 01:32:56.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"90da8fccceb5100d3d7772d5c3862fedba9dd5fe","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-12 01:33:15.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"6d5de18c5d95cea117a6d8ff46e96222ebe154e1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-12 02:03:59.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/01/670301/1/gate/openstack-tox-lower-constraints/8e24a75/ : SUCCESS in 5m 14s\n- openstack-tox-pep8 http://logs.openstack.org/01/670301/1/gate/openstack-tox-pep8/8c8c5df/ : SUCCESS in 4m 54s\n- openstack-tox-py27 http://logs.openstack.org/01/670301/1/gate/openstack-tox-py27/1b20d22/ : SUCCESS in 5m 30s\n- openstack-tox-py36 http://logs.openstack.org/01/670301/1/gate/openstack-tox-py36/ac7b8c3/ : SUCCESS in 5m 24s\n- openstack-tox-py37 http://logs.openstack.org/01/670301/1/gate/openstack-tox-py37/0231cb0/ : SUCCESS in 5m 46s\n- openstack-tox-docs http://logs.openstack.org/01/670301/1/gate/openstack-tox-docs/269aa8e/html/ : SUCCESS in 4m 16s\n- watcher-tempest-functional http://logs.openstack.org/01/670301/1/gate/watcher-tempest-functional/bcfc401/ : SUCCESS in 27m 26s","accounts_in_message":[],"_revision_number":1},{"id":"1d1652fd5f629545045b67a3ed542c95b6bb0e90","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-12 02:03:59.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"80e8d0002a0690f5eb52cb105ddea9955f5138bb","revisions":{"80e8d0002a0690f5eb52cb105ddea9955f5138bb":{"kind":"REWORK","_number":1,"created":"2019-07-11 13:00:16.000000000","uploader":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"ref":"refs/changes/01/670301/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/01/670301/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/01/670301/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/01/670301/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/01/670301/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/01/670301/1"}}},"commit":{"parents":[{"commit":"5259e5b332d642b9fd7235b55c347970c1244943","subject":"Merge \"Add marker option for get_instance_list()\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/5259e5b332d642b9fd7235b55c347970c1244943"}]}],"author":{"name":"Dantali0n","email":"info@dantalion.nl","date":"2019-07-11 12:54:04.000000000","tz":120},"committer":{"name":"Dantali0n","email":"info@dantalion.nl","date":"2019-07-11 12:54:04.000000000","tz":120},"subject":"Resolve aggregate error in workload_stabilization","message":"Resolve aggregate error in workload_stabilization\n\nThis error is caused because the condition \"is not \u0027\u0027:\" is not always\ntrue. Sometimes self.aggregation_method[\u0027node\u0027] is u\u0027\u0027 instead of \u0027\u0027.\nThis patch ensures that in both cases the behavior is the same.\n\nChange-Id: I7453678cc76892ebeacca23c3501a10a08725d1d\nCloses-bug: #1836195\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/80e8d0002a0690f5eb52cb105ddea9955f5138bb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/80e8d0002a0690f5eb52cb105ddea9955f5138bb"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}