)]}'
{"id":"openstack%2Fwatcher~674223","triplet_id":"openstack%2Fwatcher~master~I7104c1a6752ad0b8c9837a643e51b0a13194a81b","project":"openstack/watcher","branch":"master","topic":"remove_stale_comment","hashtags":[],"change_id":"I7104c1a6752ad0b8c9837a643e51b0a13194a81b","subject":"Remove stale comment in method execute()","status":"MERGED","created":"2019-08-02 08:32:53.000000000","updated":"2019-08-06 07:52:17.000000000","submitted":"2019-08-06 07:52:16.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"674223-1565077937095-c33df9d0","meta_rev_id":"2a140fda95bb0a42beec4d590bd6a355b1ae6a67","_number":674223,"virtual_id_number":674223,"owner":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":2,"date":"2019-08-06 07:52:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-08-05 11:13:22.000000000","_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"all":[{"value":2,"date":"2019-08-05 09:29:28.000000000","_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":2,"date":"2019-08-06 07:15:35.000000000","_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"all":[{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":1,"date":"2019-08-06 07:15:35.000000000","_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},{"value":0,"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-05 09:29:28.000000000","updated_by":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"reviewer":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"state":"REVIEWER"},{"updated":"2019-08-06 07:15:35.000000000","updated_by":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"reviewer":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"state":"REVIEWER"},{"updated":"2019-08-06 07:52:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"21d0367e349cc3e52a99f567e956f50be32a02c1","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-08-02 08:32:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1afef3c449410931b21690c0ee168a94a8d30274","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-02 09:49:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://logs.opendev.org/23/674223/1/check/openstack-tox-cover/0ab6733/cover/ : SUCCESS in 6m 01s\n- openstack-tox-lower-constraints https://logs.opendev.org/23/674223/1/check/openstack-tox-lower-constraints/d2b0135/ : SUCCESS in 6m 47s\n- openstack-tox-pep8 https://logs.opendev.org/23/674223/1/check/openstack-tox-pep8/239d41b/ : SUCCESS in 5m 43s\n- openstack-tox-py27 https://logs.opendev.org/23/674223/1/check/openstack-tox-py27/1ae27c5/ : SUCCESS in 5m 46s\n- openstack-tox-py36 https://logs.opendev.org/23/674223/1/check/openstack-tox-py36/a881b6f/ : SUCCESS in 4m 43s\n- openstack-tox-py37 https://logs.opendev.org/23/674223/1/check/openstack-tox-py37/016d1be/ : SUCCESS in 6m 10s\n- openstack-tox-docs https://logs.opendev.org/23/674223/1/check/openstack-tox-docs/dac6004/html/ : SUCCESS in 4m 37s\n- watcher-tempest-functional https://logs.opendev.org/23/674223/1/check/watcher-tempest-functional/01d7947/ : SUCCESS in 39m 23s\n- watcher-grenade https://logs.opendev.org/23/674223/1/check/watcher-grenade/c0c0396/ : SUCCESS in 59m 53s\n- watcher-tempest-dummy_optim https://logs.opendev.org/23/674223/1/check/watcher-tempest-dummy_optim/07bc35b/ : SUCCESS in 57m 17s\n- watcher-tempest-actuator https://logs.opendev.org/23/674223/1/check/watcher-tempest-actuator/4727c99/ : SUCCESS in 55m 42s\n- watcher-tempest-basic_optim https://logs.opendev.org/23/674223/1/check/watcher-tempest-basic_optim/e20d862/ : SUCCESS in 56m 46s\n- watcher-tempest-vm_workload_consolidation https://logs.opendev.org/23/674223/1/check/watcher-tempest-vm_workload_consolidation/18b0630/ : SUCCESS in 57m 34s\n- watcher-tempest-workload_balancing https://logs.opendev.org/23/674223/1/check/watcher-tempest-workload_balancing/122e538/ : SUCCESS in 1h 06m 32s\n- watcherclient-tempest-functional https://logs.opendev.org/23/674223/1/check/watcherclient-tempest-functional/d6380e9/ : SUCCESS in 40m 19s\n- watcher-tempest-zone_migration https://logs.opendev.org/23/674223/1/check/watcher-tempest-zone_migration/5650f03/ : SUCCESS in 1h 04m 07s\n- watcher-tempest-host_maintenance https://logs.opendev.org/23/674223/1/check/watcher-tempest-host_maintenance/8682556/ : SUCCESS in 55m 40s\n- watcher-tempest-storage_balance https://logs.opendev.org/23/674223/1/check/watcher-tempest-storage_balance/e8d2ad8/ : SUCCESS in 55m 57s\n- watcher-tls-test https://logs.opendev.org/23/674223/1/check/watcher-tls-test/32de3ff/ : SUCCESS in 54m 01s","accounts_in_message":[],"_revision_number":1},{"id":"758c8d46aa0172327f47d746a8f6444351de8eca","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-08-05 01:11:25.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"3cca2a56377a2e34d9beb2fb4bd11dfb22e03422","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-05 02:12:39.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://logs.opendev.org/23/674223/2/check/openstack-tox-cover/ba3672e/cover/ : SUCCESS in 4m 26s\n- openstack-tox-lower-constraints https://logs.opendev.org/23/674223/2/check/openstack-tox-lower-constraints/a893d44/ : SUCCESS in 5m 24s\n- openstack-tox-pep8 https://logs.opendev.org/23/674223/2/check/openstack-tox-pep8/0ca22c4/ : SUCCESS in 4m 10s\n- openstack-tox-py27 https://logs.opendev.org/23/674223/2/check/openstack-tox-py27/329b9c8/ : SUCCESS in 5m 11s\n- openstack-tox-py36 https://logs.opendev.org/23/674223/2/check/openstack-tox-py36/eb70317/ : SUCCESS in 4m 30s\n- openstack-tox-py37 https://logs.opendev.org/23/674223/2/check/openstack-tox-py37/7834ecf/ : SUCCESS in 5m 40s\n- openstack-tox-docs https://logs.opendev.org/23/674223/2/check/openstack-tox-docs/524609e/html/ : SUCCESS in 3m 46s\n- watcher-tempest-functional https://logs.opendev.org/23/674223/2/check/watcher-tempest-functional/8eef29e/ : SUCCESS in 32m 45s\n- watcher-grenade https://logs.opendev.org/23/674223/2/check/watcher-grenade/af3e998/ : SUCCESS in 42m 32s\n- watcher-tempest-dummy_optim https://logs.opendev.org/23/674223/2/check/watcher-tempest-dummy_optim/6f4b136/ : SUCCESS in 57m 55s\n- watcher-tempest-actuator https://logs.opendev.org/23/674223/2/check/watcher-tempest-actuator/ec353e7/ : SUCCESS in 47m 31s\n- watcher-tempest-basic_optim https://logs.opendev.org/23/674223/2/check/watcher-tempest-basic_optim/4baade3/ : SUCCESS in 56m 38s\n- watcher-tempest-vm_workload_consolidation https://logs.opendev.org/23/674223/2/check/watcher-tempest-vm_workload_consolidation/a352abf/ : SUCCESS in 46m 13s\n- watcher-tempest-workload_balancing https://logs.opendev.org/23/674223/2/check/watcher-tempest-workload_balancing/286cad5/ : SUCCESS in 48m 54s\n- watcherclient-tempest-functional https://logs.opendev.org/23/674223/2/check/watcherclient-tempest-functional/3677884/ : SUCCESS in 37m 11s\n- watcher-tempest-zone_migration https://logs.opendev.org/23/674223/2/check/watcher-tempest-zone_migration/4ebf7d1/ : SUCCESS in 51m 56s\n- watcher-tempest-host_maintenance https://logs.opendev.org/23/674223/2/check/watcher-tempest-host_maintenance/cdd242f/ : SUCCESS in 48m 58s\n- watcher-tempest-storage_balance https://logs.opendev.org/23/674223/2/check/watcher-tempest-storage_balance/c00d75c/ : SUCCESS in 44m 56s\n- watcher-tls-test https://logs.opendev.org/23/674223/2/check/watcher-tls-test/7478a63/ : SUCCESS in 46m 09s","accounts_in_message":[],"_revision_number":2},{"id":"f80e406d401c53aae9dc8ce1e85e2a652ff05b6b","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2019-08-05 09:29:28.000000000","message":"Patch Set 2: Code-Review+2\n\nYes this can be cleaned, there are more comments around the cluster model collectors that can be removed.","accounts_in_message":[],"_revision_number":2},{"id":"b0c69718ca589fa2df486a279aecbc41733daf02","author":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"date":"2019-08-05 11:13:22.000000000","message":"Patch Set 2:\n\n\u003e Yes this can be cleaned, there are more comments around the cluster\n \u003e model collectors that can be removed.\n\nYep, I will check.","accounts_in_message":[],"_revision_number":2},{"id":"5d52c4fd1618102fa555adf8be81fa1d8d2c94dd","author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"date":"2019-08-06 07:15:35.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"9825f05eeb41efbe2a687c5d638c6d9e0cea1b2f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 07:15:48.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"b992f63f256cf1619394b69b48e3dff3eaa84495","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 07:52:16.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://logs.opendev.org/23/674223/2/gate/openstack-tox-lower-constraints/958452b/ : SUCCESS in 5m 49s\n- openstack-tox-pep8 https://logs.opendev.org/23/674223/2/gate/openstack-tox-pep8/0eec77e/ : SUCCESS in 5m 23s\n- openstack-tox-py27 https://logs.opendev.org/23/674223/2/gate/openstack-tox-py27/614b8e4/ : SUCCESS in 6m 35s\n- openstack-tox-py36 https://logs.opendev.org/23/674223/2/gate/openstack-tox-py36/2acd988/ : SUCCESS in 5m 48s\n- openstack-tox-py37 https://logs.opendev.org/23/674223/2/gate/openstack-tox-py37/d23f762/ : SUCCESS in 5m 47s\n- openstack-tox-docs https://logs.opendev.org/23/674223/2/gate/openstack-tox-docs/094ac6f/html/ : SUCCESS in 5m 24s\n- watcher-tempest-functional https://logs.opendev.org/23/674223/2/gate/watcher-tempest-functional/a85b370/ : SUCCESS in 34m 29s","accounts_in_message":[],"_revision_number":2},{"id":"15f9ae0445202ee1a2c56739a679fef919be1690","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 07:52:17.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"251ad35c8bec06360d66997227594449b82bd8e9","revisions":{"38e50acf8bc88f2b260d7585b4a2bc81bd17d0f4":{"kind":"REWORK","_number":1,"created":"2019-08-02 08:32:53.000000000","uploader":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"ref":"refs/changes/23/674223/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/23/674223/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/23/674223/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/23/674223/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/23/674223/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/23/674223/1"}}},"commit":{"parents":[{"commit":"f2020a9283e81f932007e98269c89eed7c0b3c40","subject":"Merge \"Getting data from placement when updating datamodel\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/f2020a9283e81f932007e98269c89eed7c0b3c40"}]}],"author":{"name":"chenke","email":"chen.ke14@zte.com.cn","date":"2019-08-02 08:29:57.000000000","tz":480},"committer":{"name":"chenke","email":"chen.ke14@zte.com.cn","date":"2019-08-02 08:29:57.000000000","tz":480},"subject":"Remove stale comment in method execute()","message":"Remove stale comment in method execute()\n\nThe code associated with virtual a has been removed\nbefore, and the relevant comments should be removed here.\n\nChange-Id: I7104c1a6752ad0b8c9837a643e51b0a13194a81b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/38e50acf8bc88f2b260d7585b4a2bc81bd17d0f4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/38e50acf8bc88f2b260d7585b4a2bc81bd17d0f4"}]},"branch":"refs/heads/master"},"251ad35c8bec06360d66997227594449b82bd8e9":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-08-05 01:11:25.000000000","uploader":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"ref":"refs/changes/23/674223/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/23/674223/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/23/674223/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/23/674223/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/23/674223/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/23/674223/2"}}},"commit":{"parents":[{"commit":"f2020a9283e81f932007e98269c89eed7c0b3c40","subject":"Merge \"Getting data from placement when updating datamodel\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/f2020a9283e81f932007e98269c89eed7c0b3c40"}]}],"author":{"name":"chenke","email":"chen.ke14@zte.com.cn","date":"2019-08-02 08:29:57.000000000","tz":480},"committer":{"name":"chenke","email":"chen.ke14@zte.com.cn","date":"2019-08-05 01:10:13.000000000","tz":480},"subject":"Remove stale comment in method execute()","message":"Remove stale comment in method execute()\n\nThe code associated with virtual has been removed before,\nand the relevant comments should be removed here.\n\nChange-Id: I7104c1a6752ad0b8c9837a643e51b0a13194a81b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/251ad35c8bec06360d66997227594449b82bd8e9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/251ad35c8bec06360d66997227594449b82bd8e9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}