)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"ac6c6e8e4c60636f7e654b5f5e27401f58f44238","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix issues on stable/rocky"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fixes issues present to stable/rocky branch. Due to heavy"},{"line_number":10,"context_line":"refactoring in later branches backporting is no possible."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I896a7c49eea1b267099fc90d837458ec7bb7853d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_0441d20b","line":9,"range":{"start_line":9,"start_character":17,"end_line":9,"end_character":47},"updated":"2019-10-08 02:25:41.000000000","message":"Would you describe the details? If it\u0027s a bug, I wish you report it on https://bugs.launchpad.net/watcher.","commit_id":"bc88890e93d551f3312b33a854682a1f5feef6f0"},{"author":{"_account_id":28014,"name":"Stamatis Katsaounis","email":"skatsaounis@admin.grnet.gr","username":"skatsaounis"},"change_message_id":"0d9912426b82a2521459f047d53b4e02dd4afb59","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix issues on stable/rocky"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fixes issues present to stable/rocky branch. Due to heavy"},{"line_number":10,"context_line":"refactoring in later branches backporting is no possible."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I896a7c49eea1b267099fc90d837458ec7bb7853d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_ea5a3f4e","line":9,"range":{"start_line":9,"start_character":17,"end_line":9,"end_character":47},"in_reply_to":"3fa7e38b_0441d20b","updated":"2019-10-08 07:57:31.000000000","message":"Hi licanwei,\n\nThank you for reviewing this patch. Me and my team are working on an OpenStack Rocky deployment and we would love to utilize watcher. During our tests we faced the following issues:\n\n1) VM Consolidation Strategy expects configuration option datasource and this is fine. At the same time, the DataSourceManager class expects to find datasources. This is a bug which is not present to later stable branches due to a big refactor which is not backported to stable/rocky.\n2) Gnocchi\u0027s statistic_aggregation method had default aggregation kwarg set to \u0027avg\u0027. This is a bug because there is no such aggregation to gnocchi, only \u0027mean\u0027. This is not present to later stable branches due to another big refactor\n3) We found out that if for some reason ceilometer could not get some metrics for an instance, then the watcher fails because gnocchi does not contain any data. This is why we added the filter \u0027ACTIVE\u0027 because our stopped or failed instances does not have their metrics collected. We would expect watcher to work with the active instances rather than failing miserably. I do not know if this is the intention or a bug.","commit_id":"bc88890e93d551f3312b33a854682a1f5feef6f0"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"055024a0bbe17782a5e9bd0f3149942bba775f0b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix issues on stable/rocky"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch fixes issues present to stable/rocky branch. Due to heavy"},{"line_number":10,"context_line":"refactoring in later branches backporting is no possible."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I896a7c49eea1b267099fc90d837458ec7bb7853d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_3f4ac2ab","line":9,"range":{"start_line":9,"start_character":17,"end_line":9,"end_character":47},"in_reply_to":"3fa7e38b_ea5a3f4e","updated":"2019-10-09 03:31:08.000000000","message":"about 3), I think it\u0027s a bug, you can report a bug and paste the error message. Maybe it\u0027s better to check the instance status before getting metrics.","commit_id":"bc88890e93d551f3312b33a854682a1f5feef6f0"}],"watcher/common/nova_helper.py":[{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"ac6c6e8e4c60636f7e654b5f5e27401f58f44238","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def get_instance_list(self):"},{"line_number":77,"context_line":"        return self.nova.servers.list("},{"line_number":78,"context_line":"            search_opts\u003d{\u0027all_tenants\u0027: True, \u0027status\u0027: \u0027ACTIVE\u0027},"},{"line_number":79,"context_line":"            limit\u003d-1)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def get_flavor_list(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_a468fe86","line":78,"range":{"start_line":78,"start_character":45,"end_line":78,"end_character":64},"updated":"2019-10-08 02:25:41.000000000","message":"I don\u0027t know the reason, if get_instance_list gets only active instances, the compute data model will include active instances, it\u0027s not complete.\nrefer to :https://github.com/openstack/watcher/blob/stable/rocky/watcher/decision_engine/model/collector/nova.py#L325","commit_id":"bc88890e93d551f3312b33a854682a1f5feef6f0"},{"author":{"_account_id":28014,"name":"Stamatis Katsaounis","email":"skatsaounis@admin.grnet.gr","username":"skatsaounis"},"change_message_id":"0d9912426b82a2521459f047d53b4e02dd4afb59","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def get_instance_list(self):"},{"line_number":77,"context_line":"        return self.nova.servers.list("},{"line_number":78,"context_line":"            search_opts\u003d{\u0027all_tenants\u0027: True, \u0027status\u0027: \u0027ACTIVE\u0027},"},{"line_number":79,"context_line":"            limit\u003d-1)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def get_flavor_list(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_6a340ffc","line":78,"range":{"start_line":78,"start_character":45,"end_line":78,"end_character":64},"in_reply_to":"3fa7e38b_a468fe86","updated":"2019-10-08 07:57:31.000000000","message":"Please take a look at number 3 of my previous comment.","commit_id":"bc88890e93d551f3312b33a854682a1f5feef6f0"}]}