)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"e1cd1c6290ba820b4756043ae9bf1b12625c0579","unresolved":false,"context_lines":[{"line_number":9,"context_line":"when directly using the `curl` command to create audit template,"},{"line_number":10,"context_line":"strategy name can be accepted."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related bug:1884174"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7c0ca760a7fa414faca03c5293df34a84aad6fac"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf51134e_577f3f66","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":18},"updated":"2020-06-19 08:00:38.000000000","message":"Closed-Bug: #1884174","commit_id":"866b7318e0a8914b88c9fe87c1f0e947bb28b726"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"f84b6e5c6b54d4aabfe8559a30f2c6b878bd6557","unresolved":false,"context_lines":[{"line_number":9,"context_line":"when directly using the `curl` command to create audit template,"},{"line_number":10,"context_line":"strategy name can be accepted."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related bug:1884174"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I7c0ca760a7fa414faca03c5293df34a84aad6fac"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf51134e_22401d07","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":19},"updated":"2020-06-26 03:16:12.000000000","message":"should be Related-Bug: # or Closed-Bug: #","commit_id":"7b39d4758faee4c92a24b079257bc47453aba044"}],"watcher/api/controllers/v1/audit_template.py":[{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"e1cd1c6290ba820b4756043ae9bf1b12625c0579","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        if audit_template.strategy:"},{"line_number":164,"context_line":"            available_strategies \u003d objects.Strategy.list("},{"line_number":165,"context_line":"                AuditTemplatePostType._ctx)"},{"line_number":166,"context_line":"            available_strategies_uuids_map \u003d {"},{"line_number":167,"context_line":"                s.uuid: s for s in available_strategies}"},{"line_number":168,"context_line":"            available_strategies_names_map \u003d {"},{"line_number":169,"context_line":"                s.name: s for s in available_strategies}"},{"line_number":170,"context_line":"            if audit_template.strategy in available_strategies_uuids_map:"},{"line_number":171,"context_line":"                strategy \u003d available_strategies_uuids_map["},{"line_number":172,"context_line":"                    audit_template.strategy]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_f702d308","line":169,"range":{"start_line":166,"start_character":12,"end_line":169,"end_character":56},"updated":"2020-06-19 08:00:38.000000000","message":"you can check if audit_template.strategy is uuid or not\n\nrefer to:\nhttps://github.com/openstack/watcher/blob/master/watcher/api/controllers/v1/audit_template.py#L286","commit_id":"866b7318e0a8914b88c9fe87c1f0e947bb28b726"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"f84b6e5c6b54d4aabfe8559a30f2c6b878bd6557","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                        \"included and excluded together\"))"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        if audit_template.strategy:"},{"line_number":164,"context_line":"            available_strategies \u003d objects.Strategy.list("},{"line_number":165,"context_line":"                AuditTemplatePostType._ctx)"},{"line_number":166,"context_line":"            try:"},{"line_number":167,"context_line":"                if (common_utils.is_uuid_like(audit_template.strategy) or"},{"line_number":168,"context_line":"                        common_utils.is_int_like(audit_template.strategy)):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_62dfb568","line":165,"range":{"start_line":164,"start_character":12,"end_line":165,"end_character":43},"updated":"2020-06-26 03:16:12.000000000","message":"unused, pls remove it.","commit_id":"7b39d4758faee4c92a24b079257bc47453aba044"},{"author":{"_account_id":31455,"name":"Min Li","email":"limin.lc@inspur.com","username":"limin0801"},"change_message_id":"c9ba7ce3c5f99c43bb46d1e9f6bd3d71e207e196","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                        \"included and excluded together\"))"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        if audit_template.strategy:"},{"line_number":164,"context_line":"            available_strategies \u003d objects.Strategy.list("},{"line_number":165,"context_line":"                AuditTemplatePostType._ctx)"},{"line_number":166,"context_line":"            try:"},{"line_number":167,"context_line":"                if (common_utils.is_uuid_like(audit_template.strategy) or"},{"line_number":168,"context_line":"                        common_utils.is_int_like(audit_template.strategy)):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_f842423d","line":165,"range":{"start_line":164,"start_character":12,"end_line":165,"end_character":43},"in_reply_to":"bf51134e_62dfb568","updated":"2020-06-28 06:50:48.000000000","message":"If strategy.id !\u003d goal.id, the Exception information needs to give possible choices, var available_strategies is used, so I added this in line180","commit_id":"7b39d4758faee4c92a24b079257bc47453aba044"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"f84b6e5c6b54d4aabfe8559a30f2c6b878bd6557","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                if (common_utils.is_uuid_like(audit_template.strategy) or"},{"line_number":168,"context_line":"                        common_utils.is_int_like(audit_template.strategy)):"},{"line_number":169,"context_line":"                    strategy \u003d objects.Strategy.get("},{"line_number":170,"context_line":"                        pecan.request.context, audit_template.strategy)"},{"line_number":171,"context_line":"                else:"},{"line_number":172,"context_line":"                    strategy \u003d objects.Strategy.get_by_name("},{"line_number":173,"context_line":"                        pecan.request.context, audit_template.strategy)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_82e00928","line":170,"range":{"start_line":170,"start_character":24,"end_line":170,"end_character":45},"updated":"2020-06-26 03:16:12.000000000","message":"AuditTemplatePostType._ctx","commit_id":"7b39d4758faee4c92a24b079257bc47453aba044"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"c3db9b70ad77c76e2ab1cc87cbbdba4066084570","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                        pecan.request.context, audit_template.strategy)"},{"line_number":171,"context_line":"                else:"},{"line_number":172,"context_line":"                    strategy \u003d objects.Strategy.get_by_name("},{"line_number":173,"context_line":"                        pecan.request.context, audit_template.strategy)"},{"line_number":174,"context_line":"            except exception.InvalidStrategy:"},{"line_number":175,"context_line":"                raise exception.InvalidStrategy("},{"line_number":176,"context_line":"                    strategy\u003daudit_template.strategy)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_bd68cef4","line":173,"range":{"start_line":173,"start_character":24,"end_line":173,"end_character":45},"updated":"2020-06-26 06:53:35.000000000","message":"AuditTemplatePostType._ctx","commit_id":"7b39d4758faee4c92a24b079257bc47453aba044"},{"author":{"_account_id":21692,"name":"licanwei","email":"li.canwei2@zte.com.cn","username":"licanwei"},"change_message_id":"f84b6e5c6b54d4aabfe8559a30f2c6b878bd6557","unresolved":false,"context_lines":[{"line_number":171,"context_line":"                else:"},{"line_number":172,"context_line":"                    strategy \u003d objects.Strategy.get_by_name("},{"line_number":173,"context_line":"                        pecan.request.context, audit_template.strategy)"},{"line_number":174,"context_line":"            except exception.InvalidStrategy:"},{"line_number":175,"context_line":"                raise exception.InvalidStrategy("},{"line_number":176,"context_line":"                    strategy\u003daudit_template.strategy)"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_e2d4654a","line":174,"range":{"start_line":174,"start_character":19,"end_line":174,"end_character":44},"updated":"2020-06-26 03:16:12.000000000","message":"pls remove","commit_id":"7b39d4758faee4c92a24b079257bc47453aba044"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"6d40adda781bd606e22bee7a81545a8e2f662533","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                else:"},{"line_number":170,"context_line":"                    strategy \u003d objects.Strategy.get_by_name("},{"line_number":171,"context_line":"                        AuditTemplatePostType._ctx, audit_template.strategy)"},{"line_number":172,"context_line":"            except:"},{"line_number":173,"context_line":"                raise exception.InvalidStrategy("},{"line_number":174,"context_line":"                    strategy\u003daudit_template.strategy)"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_bd9d5c0b","line":172,"updated":"2020-06-28 04:58:03.000000000","message":"pep8: E722 do not use bare \u0027except\u0027","commit_id":"95f571d7ef51de5938b7d99a32a64f0147b55510"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"6d40adda781bd606e22bee7a81545a8e2f662533","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                else:"},{"line_number":170,"context_line":"                    strategy \u003d objects.Strategy.get_by_name("},{"line_number":171,"context_line":"                        AuditTemplatePostType._ctx, audit_template.strategy)"},{"line_number":172,"context_line":"            except:"},{"line_number":173,"context_line":"                raise exception.InvalidStrategy("},{"line_number":174,"context_line":"                    strategy\u003daudit_template.strategy)"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_9da05844","line":172,"updated":"2020-06-28 04:58:03.000000000","message":"pep8: H201: no \u0027except:\u0027 at least use \u0027except Exception:\u0027","commit_id":"95f571d7ef51de5938b7d99a32a64f0147b55510"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"6d40adda781bd606e22bee7a81545a8e2f662533","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            # specified goal"},{"line_number":178,"context_line":"            if strategy.goal_id !\u003d goal.id:"},{"line_number":179,"context_line":"                choices \u003d [\"\u0027%s\u0027 (%s)\" % (s.uuid, s.name)"},{"line_number":180,"context_line":"                           for s in available_strategies]"},{"line_number":181,"context_line":"                raise exception.InvalidStrategy("},{"line_number":182,"context_line":"                    message\u003d_("},{"line_number":183,"context_line":"                        \"\u0027%(strategy)s\u0027 strategy does relate to the \""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_fd8a34bc","line":180,"updated":"2020-06-28 04:58:03.000000000","message":"pep8: F821 undefined name \u0027available_strategies\u0027","commit_id":"95f571d7ef51de5938b7d99a32a64f0147b55510"}]}