)]}'
{"id":"openstack%2Fwatcher~798883","triplet_id":"openstack%2Fwatcher~stable%2Fwallaby~I0ad514da647bb08790259fd27e56a41f6dbbbaa0","project":"openstack/watcher","branch":"stable/wallaby","topic":"change-797889-1-stable/wallaby","hashtags":[],"change_id":"I0ad514da647bb08790259fd27e56a41f6dbbbaa0","subject":"Replace deprecated with_lockmode with with_for_update","status":"MERGED","created":"2021-07-01 06:41:10.000000000","updated":"2021-07-01 10:40:03.000000000","submitted":"2021-07-01 10:38:28.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"798883-change-797889-1-stable/wallaby","cherry_pick_of_change":797889,"cherry_pick_of_patch_set":3,"meta_rev_id":"cdc23c211398bda783bef2d91c4fa10b5257eb09","_number":798883,"virtual_id_number":798883,"owner":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-07-01 10:38:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},{"value":0,"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"recommended":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-07-01 10:29:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},{"value":2,"date":"2021-07-01 10:07:54.000000000","_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},{"value":1,"date":"2021-07-01 10:07:54.000000000","_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-07-01 06:41:10.000000000","updated_by":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"reviewer":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"state":"REVIEWER"},{"updated":"2021-07-01 08:36:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"2251b0e6f10c2b729d750f126021ce5f33fce778","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2021-07-01 06:41:10.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"9d06e5092e64f01e5f8c65b570229fc5956700c2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-01 08:36:50.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ca9dfa8878a7431d8282c95c7cdad23a : FAILURE in 8m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8ecc3ebbdc8443838717fa7fd9610e39 : SUCCESS in 6m 27s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2af8d650743744ec916144c0771d9bb4 : FAILURE in 7m 10s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b4dbee0570564532b9ad21e850f6c7ff : FAILURE in 7m 18s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/3359ca6dee914ba182b650f3563fc64d : FAILURE in 7m 21s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cda8cbdf1ce14470a88a41450af85bf2 : SUCCESS in 8m 41s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/e970a72d78674523bf719f18cb775647 : SUCCESS in 6m 01s\n- watcher-tempest-functional https://zuul.opendev.org/t/openstack/build/5688db309d154565936511f3ecde4546 : SUCCESS in 34m 10s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/f0b7e0d82d3743ddb80b4d09cc7b9b4d : SUCCESS in 50m 02s\n- watcher-tempest-strategies https://zuul.opendev.org/t/openstack/build/a4845b8de1554240ba18673e870d316f : SUCCESS in 51m 07s\n- watcher-tempest-actuator https://zuul.opendev.org/t/openstack/build/1fb7227ee23e458a83eb052e3d478df5 : SUCCESS in 51m 38s\n- watcherclient-tempest-functional https://zuul.opendev.org/t/openstack/build/b4dd8607abb14879978acbd1dc44e2ae : TIMED_OUT in 1h 13m 42s\n- watcher-tls-test https://zuul.opendev.org/t/openstack/build/1400580dbd5a4ddbbc46dc96e783c5bc : SUCCESS in 1h 48m 32s\n- watcher-tempest-functional-ipv6-only https://zuul.opendev.org/t/openstack/build/73e4c27f5a214d4fb846e89faf2d2ab8 : SUCCESS in 38m 27s","accounts_in_message":[],"_revision_number":1},{"id":"377bacd4bb883963f02f52a4c0d2f979c555db3a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2021-07-01 09:12:03.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"ea8e8eb4f3bbe931e3b14f082b8fe35939c91ec6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-01 10:07:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/7e61a331ef664efbb6a57a7f078dd1c8 : SUCCESS in 7m 18s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5ff476e4ec9845efa813099591e7c228 : SUCCESS in 4m 53s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9e5f365ca58b4c2886f8915ef005b944 : SUCCESS in 5m 51s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/8853f2c185cf4cd081ae197865cad86f : SUCCESS in 5m 37s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/29a8604988384448be2cf83c5be93584 : SUCCESS in 6m 02s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7a28734f14674cb0a5b21f368a7e9688 : SUCCESS in 6m 37s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/523426a286204a5e8a8b2aabea41da34 : SUCCESS in 4m 20s\n- watcher-tempest-functional https://zuul.opendev.org/t/openstack/build/a1205925d65b4c138d57926cdb9d87a4 : SUCCESS in 36m 56s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/9949ab7798c24b38a8d0f3e231a85ffe : SUCCESS in 49m 17s\n- watcher-tempest-strategies https://zuul.opendev.org/t/openstack/build/a8394cc0cb80484aa8feae702b9a90e8 : SUCCESS in 52m 55s\n- watcher-tempest-actuator https://zuul.opendev.org/t/openstack/build/bf8ab58c62184ef995679650aa94ffe0 : SUCCESS in 52m 21s\n- watcherclient-tempest-functional https://zuul.opendev.org/t/openstack/build/a9f9fc14f34649d7b66a135c45c26988 : SUCCESS in 37m 18s\n- watcher-tls-test https://zuul.opendev.org/t/openstack/build/76a0208716484367831b7e9b7d4c4ffb : SUCCESS in 54m 12s\n- watcher-tempest-functional-ipv6-only https://zuul.opendev.org/t/openstack/build/9f151f4c283449b2b32d3fd0080f0cbd : SUCCESS in 31m 42s","accounts_in_message":[],"_revision_number":2},{"id":"8edeeeb036aa0d8a5478ec7aaee698c0ffd710eb","author":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"date":"2021-07-01 10:07:54.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"d845528ddd35aa7b313b3ae5150382d4f50e55a2","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-01 10:08:12.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"cf33651bdddebce14c075a22b8dcb118cd992592","author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"date":"2021-07-01 10:29:41.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"36fae47e085e7972540206a54aa91dfece4ba857","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-01 10:38:27.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/13b317f2c76b42169e08c1e89d3146fc : SUCCESS in 5m 55s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5ba8020624f3476dbfcaf243c6609402 : SUCCESS in 6m 21s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/98c7849f81264891b10ebbe8ca9e4797 : SUCCESS in 6m 03s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3579304889c640d8ba7de4f92d5e2a4a : SUCCESS in 6m 33s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/bfb046b58b33440ebb4b970b86bf8ea0 : SUCCESS in 4m 54s\n- watcher-tempest-functional https://zuul.opendev.org/t/openstack/build/6390c55078ef4bb4922931e1f50ee66e : SUCCESS in 27m 45s\n- watcher-tempest-functional-ipv6-only https://zuul.opendev.org/t/openstack/build/86a24f912b6042b997345f43d9f0b656 : SUCCESS in 28m 08s","accounts_in_message":[],"_revision_number":2},{"id":"c7de5c4f3b0a1cee46acc075ca101e2f7c627dd1","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-01 10:38:28.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"cdc23c211398bda783bef2d91c4fa10b5257eb09","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-01 10:40:03.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b73e05087de84f4a8ffa445d2f891393 : SUCCESS in 1m 16s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/3c314d2561c540439b10307654f92851 : SUCCESS in 1m 10s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"281455a08a4c2606f887f9ce3fe3cd30af6333f7","revisions":{"51c15cad645f087a472e238e529379d4b296ce27":{"kind":"REWORK","_number":1,"created":"2021-07-01 06:41:10.000000000","uploader":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"ref":"refs/changes/83/798883/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/83/798883/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/83/798883/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/83/798883/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/83/798883/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/83/798883/1"}}},"commit":{"parents":[{"commit":"863815153e3451f2354f14e6c271233e24e84782","subject":"[goal] Deprecate the JSON formatted policy file","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/863815153e3451f2354f14e6c271233e24e84782"}]}],"author":{"name":"ericxiett","email":"eric_xiett@163.com","date":"2021-06-24 12:27:05.000000000","tz":0},"committer":{"name":"Dantali0n","email":"info@dantalion.nl","date":"2021-07-01 06:41:10.000000000","tz":0},"subject":"Replace deprecated with_lockmode with with_for_update","message":"Replace deprecated with_lockmode with with_for_update\n\nThe Query.with_lockmode() method is deprecated since version 0.9.0\nand will be removed in a future release. [1]\nThis patch replaces it with Query.with_for_update().\nThe \u0027faultstring\u0027 was been modified to \u0027Exactly 5 or 6 columns has to be\nspecified for iterator expression\u0027, so adds one space between \"iterator\"\nand \"expression\" for \u0027expected_error_msg\u0027.\n\nAlso use upper-constraints in doc build to avoid issues in pdf build.\n\n[1]\nhttps://docs.sqlalchemy.org/en/13/orm/query.html#sqlalchemy.orm.query.Query.with_lockmode\n\nCloses-Bug: #1933226\nChange-Id: I0ad514da647bb08790259fd27e56a41f6dbbbaa0\n(cherry picked from commit 9ca44fa3ab16ba99c65b75c7fa2fde3b2c160b1d)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/51c15cad645f087a472e238e529379d4b296ce27"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/51c15cad645f087a472e238e529379d4b296ce27"}]},"branch":"refs/heads/stable/wallaby"},"281455a08a4c2606f887f9ce3fe3cd30af6333f7":{"kind":"REWORK","_number":2,"created":"2021-07-01 09:12:03.000000000","uploader":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"},"ref":"refs/changes/83/798883/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/83/798883/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/83/798883/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/83/798883/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/83/798883/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/83/798883/2"}}},"commit":{"parents":[{"commit":"863815153e3451f2354f14e6c271233e24e84782","subject":"[goal] Deprecate the JSON formatted policy file","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/863815153e3451f2354f14e6c271233e24e84782"}]}],"author":{"name":"ericxiett","email":"eric_xiett@163.com","date":"2021-06-24 12:27:05.000000000","tz":0},"committer":{"name":"Dantali0n","email":"info@dantalion.nl","date":"2021-07-01 09:11:58.000000000","tz":0},"subject":"Replace deprecated with_lockmode with with_for_update","message":"Replace deprecated with_lockmode with with_for_update\n\nThe Query.with_lockmode() method is deprecated since version 0.9.0\nand will be removed in a future release. [1]\nThis patch replaces it with Query.with_for_update().\nThe \u0027faultstring\u0027 was been modified to \u0027Exactly 5 or 6 columns has to be\nspecified for iterator expression\u0027, so adds one space between \"iterator\"\nand \"expression\" for \u0027expected_error_msg\u0027.\n\nAlso use upper-constraints in doc build to avoid issues in pdf build.\n\n[1]\nhttps://docs.sqlalchemy.org/en/13/orm/query.html#sqlalchemy.orm.query.Query.with_lockmode\n\nCloses-Bug: #1933226\nChange-Id: I0ad514da647bb08790259fd27e56a41f6dbbbaa0\n(cherry picked from commit 9ca44fa3ab16ba99c65b75c7fa2fde3b2c160b1d)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/281455a08a4c2606f887f9ce3fe3cd30af6333f7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/281455a08a4c2606f887f9ce3fe3cd30af6333f7"}]},"branch":"refs/heads/stable/wallaby"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":29911,"name":"Dantali0n","email":"info@dantalion.nl","username":"Dantali0n"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}