)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"63c43819c0554cb7608875e07cecaa6bbf93272e","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix incorrect logging format"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix incorrect logging format for multiple variables because of what this functionality didn\u0027t work correctly and some log messages were skipped."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I74ed44134b50782c105a0e82f3af34a5fa45d119"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"48fa92e9_0000a0d5","line":9,"updated":"2025-01-08 07:20:27.000000000","message":"this change looks fine but i don\u0027t understand how/where the log messages were skipped. I mean the previous/current format should also work no?","commit_id":"2f48c501dfb36137700c1c81750a9363cf3cc19e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9bf875e9129c2c6417ae8ea3a2441dfe8e36a3a9","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix incorrect logging format"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix incorrect logging format for multiple variables because of what this functionality didn\u0027t work correctly and some log messages were skipped."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I74ed44134b50782c105a0e82f3af34a5fa45d119"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"54741bff_35d45b3f","line":9,"in_reply_to":"48fa92e9_0000a0d5","updated":"2025-01-09 23:31:09.000000000","message":"i cant see any funtional change and there is not test coverate asserting the bug so im not inclined to proceed with thsi.\n\nthere is also no bug report.\n\n\ni dont see any obvious issue with the patch but i dont think this is requried eitehr.","commit_id":"2f48c501dfb36137700c1c81750a9363cf3cc19e"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"0fb4afdb0f06b08aef81ce95fb8a475a51761ab7","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix incorrect logging format"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix incorrect logging format for multiple variables because of what this functionality didn\u0027t work correctly and some log messages were skipped."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I74ed44134b50782c105a0e82f3af34a5fa45d119"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9b9bbc7a_c30a38c6","line":9,"in_reply_to":"54741bff_35d45b3f","updated":"2025-05-08 13:53:46.000000000","message":"I hit this and opened a bug for it, it\u0027s now linked in the  commit message. I\u0027ve taken over the patch and submitted a new one with some unit test coverage. The problem with the original code is that the arguments are passed in a tuple, so it\u0027s interpreted as only one argument, hence one is missing","commit_id":"2f48c501dfb36137700c1c81750a9363cf3cc19e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82f3d820467082becd0cf6bf69e3affff53b1306","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix incorrect logging format"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix incorrect logging format for multiple variables because of what this functionality didn\u0027t work correctly and some log messages were skipped."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I74ed44134b50782c105a0e82f3af34a5fa45d119"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"6fae7348_2c5c2659","line":9,"in_reply_to":"9b9bbc7a_c30a38c6","updated":"2025-05-08 14:40:28.000000000","message":"ack i see, this is a delta between \n\n```\n\"some string %s %s\" % (\"val 1\", \"val 2\")\n```\nand usign \n```\nlog.debug(\"some string %s %s\", \"val 1\", \"val 2\")\n```\n\na touple is correct for % string interpolation.\n\nbut our loging fucntiosn act kind fo like print so your correct this si a bug.\n\nconverting to dict format was nto reuqired to fix this but its fine and a little clearer.","commit_id":"2f48c501dfb36137700c1c81750a9363cf3cc19e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34322,"name":"Sergei Afanasev","display_name":"Sergei Afanasev","email":"afanasev.s@selectel.ru","username":"afanasev_sergei"},"change_message_id":"a1ea7efbf67c304fba09705340f408bdbc2d80a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f76066e7_8a5ceec7","updated":"2021-12-22 21:27:08.000000000","message":"recheck","commit_id":"241a39ef94f29c059240851f661a914fccb6743a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"82f3d820467082becd0cf6bf69e3affff53b1306","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"19366ac3_86ab8a34","updated":"2025-05-08 14:40:28.000000000","message":"@jgilaber@redhat.com are you going tot take this over to bring it to completion?\n\nthis change still is missing unitest for the loging change to assert this work and we dont regureess","commit_id":"f94ee8e18ee4f5c1939050d810f15bed2dd3b16c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d0fb518f7b23d9b5b0904e452c2b164e744bf783","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"768a77a8_889e46b9","updated":"2025-05-08 14:42:16.000000000","message":"if we add the testing in a follow up patch im ok with merging the two patches at the same time when we are happy with both","commit_id":"f94ee8e18ee4f5c1939050d810f15bed2dd3b16c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fac1c3af228432dea22ea9d6cf0bece40fe0d58f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"898b6e95_66494912","updated":"2025-05-08 15:04:16.000000000","message":"showign it boken by assertign the message is not waht we want and then showign its fixed is fine but we need to update the test again in this patch.\n\nso at present both this and the pach below cant pass ci.","commit_id":"f94ee8e18ee4f5c1939050d810f15bed2dd3b16c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d0fb518f7b23d9b5b0904e452c2b164e744bf783","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"61c68918_36789402","in_reply_to":"19366ac3_86ab8a34","updated":"2025-05-08 14:42:16.000000000","message":"i think you did the rebase in the wrong order?\nhttps://review.opendev.org/c/openstack/watcher/+/949187/1 shoudl be on top the top patch in gerrit and the bottom pach in your git rebase","commit_id":"f94ee8e18ee4f5c1939050d810f15bed2dd3b16c"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"ea6ca4251aba035fc5cc4a2a7945032431a471d5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"19b1d802_3824194a","in_reply_to":"61c68918_36789402","updated":"2025-05-08 14:51:03.000000000","message":"yep, I\u0027ll finish this. It looks ok in git, I  wanted to have this on top of https://review.opendev.org/c/openstack/watcher/+/949187, so now I can commment out the failing asserts there and uncomment them here, but I\u0027ll double check later/tomorrow if I did it righ","commit_id":"f94ee8e18ee4f5c1939050d810f15bed2dd3b16c"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"75bdae13f8f927ac903a4cd7f679aa478c9598fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bfb6d4f3_cdd048fc","in_reply_to":"898b6e95_66494912","updated":"2025-05-08 15:54:06.000000000","message":"my idea was to first show that the test fail with the same error as the bug report and then check the message, but that does not seem to work. If I run the tests manually with stestr passing the class it catcher the error, but if I run all the unittests it does not fail, I need to find out why when all the test runs the logging is ignored","commit_id":"f94ee8e18ee4f5c1939050d810f15bed2dd3b16c"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"dd9deb2e0553b889a64542566d1e93549f75954c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8456adab_6b1e91e7","updated":"2025-05-22 17:56:32.000000000","message":"Fix looks good, all previous changes in tests were also reverted here. Thanks!","commit_id":"0f5b6a07d0659af9bdce37813faec7f4b922f2ca"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c5a14ff7a4bb45c4a0021ad0d72bdb1dd082449c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a1980446_431857a8","updated":"2025-05-26 11:18:26.000000000","message":"it","commit_id":"0f5b6a07d0659af9bdce37813faec7f4b922f2ca"}]}