)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0d9304d73a7655022e743c3cf781078572a9af7b","unresolved":true,"context_lines":[{"line_number":13,"context_line":"This is based on the pre-commit config used in nova"},{"line_number":14,"context_line":"with some addtional hooks that add value."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Follow changes will adress the FIXME comments"},{"line_number":17,"context_line":"related to sphinx-lint and codespell as well as update tox"},{"line_number":18,"context_line":"to enforce these checks in ci."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"69108ad3_c80779fc","line":16,"range":{"start_line":16,"start_character":20,"end_line":16,"end_character":26},"updated":"2024-10-22 17:30:55.000000000","message":"\"address\"","commit_id":"46e6d354d801456b0bb4d855ae41287f4d67226d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1a31340ef6bfa8c48f4db511a9e4edfa4ac01317","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This is based on the pre-commit config used in nova"},{"line_number":14,"context_line":"with some addtional hooks that add value."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Follow changes will adress the FIXME comments"},{"line_number":17,"context_line":"related to sphinx-lint and codespell as well as update tox"},{"line_number":18,"context_line":"to enforce these checks in ci."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9050849d_92df0f76","line":16,"range":{"start_line":16,"start_character":20,"end_line":16,"end_character":26},"in_reply_to":"69108ad3_c80779fc","updated":"2024-10-22 19:38:38.000000000","message":"Done","commit_id":"46e6d354d801456b0bb4d855ae41287f4d67226d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0d9304d73a7655022e743c3cf781078572a9af7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8f82a92f_10ee0b47","updated":"2024-10-22 17:30:55.000000000","message":"Typo in the commit message (honestly, there are other grammar issues there, but at least the misspelling should be fixed, IMHO). Also I think the tab removal wasn\u0027t quite right. Otherwise looks like a bunch of good consistency-fixing things. The JSON samples must not be validated anywhere because those fixes are not just cosmetic.","commit_id":"46e6d354d801456b0bb4d855ae41287f4d67226d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a09741e2bf35a2f6166b9d43ebbebce19a3c86a7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fc49d17f_c791ae1b","in_reply_to":"8f82a92f_10ee0b47","updated":"2024-10-22 18:41:04.000000000","message":"thanks for the review I\u0027ll correct the typos in the commit message shortly.\n\ncodespell is the second patch in the series and that found a buch of typos in the policy tests which again are not just cosmetic.\n\nhttps://review.opendev.org/c/openstack/watcher/+/933044/1/watcher/tests/api/v1/test_actions.py#539\n\ni have not looked into the correctness of the tests\nbut they pass before and after the change which implies they may not be testing things correctly.\n\ni have not looked to see if we have api sample tests in tree but\n\nhttps://review.opendev.org/c/openstack/watcher/+/933038/1/api-ref/source/samples/datamodel-list-response.json\n\nimplies that at least that file is not being tested/used properly\n\nhttps://review.opendev.org/c/openstack/watcher/+/933038/1/api-ref/source/samples/audit-list-detailed-response.json is more sometic as json does not really care about whitespace like python does so mixing tabs and spaces would not change correctness in that specific case.","commit_id":"46e6d354d801456b0bb4d855ae41287f4d67226d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6c6ea8672cd024e5358864d424d3efa4e0377733","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dbac1d8c_b93771dc","in_reply_to":"fc49d17f_c791ae1b","updated":"2024-10-22 18:45:02.000000000","message":"\u003e implies that at least that file is not being tested/used properly\n\nYep, that was my point, that this sample file (at least) must not be decoded/used in any tests, so maybe something for the todo list.","commit_id":"46e6d354d801456b0bb4d855ae41287f4d67226d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1a31340ef6bfa8c48f4db511a9e4edfa4ac01317","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8399c0ed_e60f3c21","updated":"2024-10-22 19:38:38.000000000","message":"Thanks for these changes and the general grammar bump in the commit message. Looks good to me now.","commit_id":"9d8b990fd100ed364f4a221b004e072d1b83792e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"69cc3881f6326867ebfc50c083cf07d6bcd42c1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"428e3d9c_2a5245d9","updated":"2024-10-23 10:17:33.000000000","message":"note that the master gate is currently blocked by grenade until https://review.opendev.org/c/openstack/watcher/+/933062 is merged on stable/2024.2\n\nit needs to merge on the stable branch first to allow grenade on master to work correctly.\n\nhttps://review.opendev.org/c/openstack/watcher/+/933046 is the master verion but that need to merge after the stable version which is unusable but this often happens with grenede issues like this so it not unheard of.","commit_id":"9d8b990fd100ed364f4a221b004e072d1b83792e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"96b8951618351fe4ef72c75470e305d2ae39d290","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d603f1c3_40a80926","updated":"2024-10-24 02:44:57.000000000","message":"recheck https://review.opendev.org/c/openstack/watcher/+/933046 is now merged\ni believe that change was not included in the last run.\nif this fails again i will rebase the series and debug futher.","commit_id":"9d8b990fd100ed364f4a221b004e072d1b83792e"}],"api-ref/source/samples/audit-list-detailed-response.json":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0d9304d73a7655022e743c3cf781078572a9af7b","unresolved":true,"context_lines":[{"line_number":30,"context_line":"                }"},{"line_number":31,"context_line":"            },"},{"line_number":32,"context_line":"            \"auto_trigger\": false,"},{"line_number":33,"context_line":"        \"force\": false,"},{"line_number":34,"context_line":"            \"uuid\": \"65a5da84-5819-4aea-8278-a28d2b489028\","},{"line_number":35,"context_line":"            \"goal_name\": \"workload_balancing\","},{"line_number":36,"context_line":"            \"scope\": [],"}],"source_content_type":"application/json","patch_set":1,"id":"e2f5bd6e_dfc80805","line":33,"updated":"2024-10-22 17:30:55.000000000","message":"This doesn\u0027t look right to me. Removing the tab is good, but it\u0027s not aligned anymore.","commit_id":"46e6d354d801456b0bb4d855ae41287f4d67226d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1a31340ef6bfa8c48f4db511a9e4edfa4ac01317","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                }"},{"line_number":31,"context_line":"            },"},{"line_number":32,"context_line":"            \"auto_trigger\": false,"},{"line_number":33,"context_line":"        \"force\": false,"},{"line_number":34,"context_line":"            \"uuid\": \"65a5da84-5819-4aea-8278-a28d2b489028\","},{"line_number":35,"context_line":"            \"goal_name\": \"workload_balancing\","},{"line_number":36,"context_line":"            \"scope\": [],"}],"source_content_type":"application/json","patch_set":1,"id":"4fb153c2_2c0c922e","line":33,"in_reply_to":"c10811b8_6286d4d9","updated":"2024-10-22 19:38:38.000000000","message":"Done","commit_id":"46e6d354d801456b0bb4d855ae41287f4d67226d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a09741e2bf35a2f6166b9d43ebbebce19a3c86a7","unresolved":true,"context_lines":[{"line_number":30,"context_line":"                }"},{"line_number":31,"context_line":"            },"},{"line_number":32,"context_line":"            \"auto_trigger\": false,"},{"line_number":33,"context_line":"        \"force\": false,"},{"line_number":34,"context_line":"            \"uuid\": \"65a5da84-5819-4aea-8278-a28d2b489028\","},{"line_number":35,"context_line":"            \"goal_name\": \"workload_balancing\","},{"line_number":36,"context_line":"            \"scope\": [],"}],"source_content_type":"application/json","patch_set":1,"id":"c10811b8_6286d4d9","line":33,"in_reply_to":"e2f5bd6e_dfc80805","updated":"2024-10-22 18:41:04.000000000","message":"ack ill fix that and respin.","commit_id":"46e6d354d801456b0bb4d855ae41287f4d67226d"}]}