)]}'
{"id":"openstack%2Fwatcher~934385","triplet_id":"openstack%2Fwatcher~master~I967f3469bd66e69c00863d553bc859343afbb3ff","project":"openstack/watcher","branch":"master","topic":"unit-test-cleanup","attention_set":{},"removed_from_attention_set":{"11604":{"account":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"last_update":"2024-11-19 19:15:45.000000000","reason":"Change was submitted"},"4393":{"account":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"last_update":"2024-11-19 18:28:31.000000000","reason":"\u003cGERRIT_ACCOUNT_4393\u003e replied on the change","reason_account":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}},"28748":{"account":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"last_update":"2024-11-19 19:15:45.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I967f3469bd66e69c00863d553bc859343afbb3ff","subject":"[eventlet] Ensure unit tests are monkey patched","status":"MERGED","created":"2024-11-07 21:57:08.000000000","updated":"2024-11-19 19:17:01.000000000","submitted":"2024-11-19 19:15:45.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"934385-unit-test-cleanup","meta_rev_id":"7260816fa079cd64592b81266f5cc1efef6b7e67","_number":934385,"virtual_id_number":934385,"owner":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2024-11-19 19:15:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"all":[{"value":2,"date":"2024-11-19 14:26:10.000000000","_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"value":2,"date":"2024-11-19 18:28:31.000000000","_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":0,"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"value":1,"date":"2024-11-19 18:28:31.000000000","_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"}],"reviewers":{"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-11-07 23:08:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-11-19 14:12:05.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2024-11-19 14:12:05.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":28748,"name":"chenker","email":"chen.ke14@zte.com.cn","username":"chenke"},"state":"REVIEWER"},{"updated":"2024-11-19 14:26:10.000000000","updated_by":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"reviewer":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"state":"REVIEWER"}],"messages":[{"id":"b12b2a2bbeec4434b24993ace462390a337dad30","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2024-11-07 21:57:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fab21904bc72a994c3e2fd16070995aa4e05985a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-11-07 23:08:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/669522aad71f48a79940926ddea6d0c2\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ec8299fe3041401383afe81ff518ada0 : SUCCESS in 5m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1172fc7ebd76460f9526155e1014569b : SUCCESS in 5m 38s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/288f86e40b0442919a71276113950604 : SUCCESS in 4m 43s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/43437da0a7994ce495aeffb1cf5fbd37 : SUCCESS in 3m 38s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/827eb8c6fbcb4acf9ad97147feef4e07 : SUCCESS in 7m 14s\n- watcher-tempest-functional https://zuul.opendev.org/t/openstack/build/225cd089d8134eaca5e2cc1f76f73c80 : SUCCESS in 18m 05s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/abb222b0567c45069ee2b4a0ada5e24d : SUCCESS in 40m 12s\n- watcher-tempest-strategies https://zuul.opendev.org/t/openstack/build/f64695fb46c543f38ef78d3b8a37f664 : SUCCESS in 50m 22s\n- watcher-tempest-actuator https://zuul.opendev.org/t/openstack/build/336c76e63aa142afba13268d005f4f03 : SUCCESS in 50m 39s\n- watcherclient-tempest-functional https://zuul.opendev.org/t/openstack/build/9f67199b9ab64284aea491260b1d5a06 : SUCCESS in 41m 17s\n- watcher-tempest-functional-ipv6-only https://zuul.opendev.org/t/openstack/build/0e24bb445722469c883c98fd41a95e87 : SUCCESS in 37m 01s","accounts_in_message":[],"_revision_number":1},{"id":"16f11ac82d8b3b498d6fbad534895e8919e916c4","author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"date":"2024-11-19 14:26:10.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d467e6476081f03397c0f67905511edb8e81cfb9","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2024-11-19 18:28:31.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"d6b1da4e442ac3d39514c3b5701bb074c4128ccc","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-11-19 18:29:04.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"167459c2ab88d8a3a1b6c655bf6b51618f2013ad","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-11-19 19:15:45.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/aaa59ee9522f48c1bfb55567fe9f9c44\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/67b9e83473b54b979de7da26ca4d8229 : SUCCESS in 4m 34s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/7f1888facdf046c4b8b4672167da88c5 : SUCCESS in 4m 16s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/9b47366cc6774cf4a0fbe3a20be1eec5 : SUCCESS in 6m 10s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9650ee146e604f498ebf255acf82100b : SUCCESS in 6m 28s\n- watcher-tempest-functional https://zuul.opendev.org/t/openstack/build/4b90fbf72b29455fa6e5be732a9e242c : SUCCESS in 35m 25s\n- watcher-tempest-functional-ipv6-only https://zuul.opendev.org/t/openstack/build/562496f34896455f94bc9e8cc716fbf2 : SUCCESS in 39m 16s","accounts_in_message":[],"_revision_number":1},{"id":"d25cbda488514e415aedc2f08ae737b9273f0e65","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-11-19 19:15:45.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"7260816fa079cd64592b81266f5cc1efef6b7e67","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-11-19 19:17:01.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/4be445a7019d456789dc826d128f38c6\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/52f15546f1b04dba9b561a786a2ff5d6 : SUCCESS in 39s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c5edad224659596a2534ee58be06a8a8190366c0","revisions":{"c5edad224659596a2534ee58be06a8a8190366c0":{"kind":"REWORK","_number":1,"created":"2024-11-07 21:57:08.000000000","uploader":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"ref":"refs/changes/85/934385/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/85/934385/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/85/934385/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/85/934385/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/85/934385/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/85/934385/1"}}},"commit":{"parents":[{"commit":"405bb93030c781ea49ad7b1e5fb719a8986e2ec5","subject":"[tox] update tox.ini to enable debugging","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/405bb93030c781ea49ad7b1e5fb719a8986e2ec5"}]}],"author":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2024-11-07 18:33:50.000000000","tz":0},"committer":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2024-11-07 19:50:59.000000000","tz":0},"subject":"[eventlet] Ensure unit tests are monkey patched","message":"[eventlet] Ensure unit tests are monkey patched\n\nThis change refactors how watcher manages monkey_patching\nmodules to achieve 2 goals.\n\nFirst, we want to ensure the watcher code is tested as it is used\nin production. While many tests can run without eventlet,\nthe existing unit tests depend on eventlet monkey patching\nindirectly by importing watcher code that uses eventlet.spawn and\ngreenthread executors. While that mostly functions today it has\nincorrect and inconsistent behaviour on Python 3.9 vs Python 3.12.\n\nSecond, the unit tests that test the cmd module were indirectly\nmonkey patching the test executor during the execution of the tests\nas a side effect of importing watcher.cmd. As such the order the tests\nexecute in and how they are distributed across test workers changed\nif the test was monkey-patched or not.\n\nThis change makes all tests run with monkey_patching by adding\nmonkey patching in the watcher/tests/__init__.py\nThis change also splits the monkey patching from the import\nin preparation for an eventual removal of eventlet in a future\nrelease.\n\nChange-Id: I967f3469bd66e69c00863d553bc859343afbb3ff\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/c5edad224659596a2534ee58be06a8a8190366c0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/c5edad224659596a2534ee58be06a8a8190366c0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}