)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f4a49c81d671b16ddefbd8b297eb149a2455f1d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cdb0babf_d79b2834","updated":"2024-11-11 08:07:34.000000000","message":"if we do want to update the tests it can be a followup patch (looks like Ghanshyam has hands full already for this patch/series https://review.opendev.org/q/topic:%22policy-yaml-file%22","commit_id":"2eefaeed140f0edbc6a1c42465f3f15998d30b9b"}],"watcher/common/policy.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f4a49c81d671b16ddefbd8b297eb149a2455f1d3","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# https://github.com/openstack/oslo.policy/blob/a626ad12fe5a3abd49d70e3e5b95589d279ab578/oslo_policy/opts.py#L49"},{"line_number":33,"context_line":"DEFAULT_POLICY_FILE \u003d \u0027policy.yaml\u0027"},{"line_number":34,"context_line":"opts.set_defaults(CONF, DEFAULT_POLICY_FILE)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# we can get a policy enforcer by this init."},{"line_number":38,"context_line":"# oslo policy support change policy rule dynamically."}],"source_content_type":"text/x-python","patch_set":1,"id":"32dd66c3_e7a7b5e2","side":"PARENT","line":35,"updated":"2024-11-11 08:07:34.000000000","message":"thanks for the patch o/\n\ngrep gave up another one:\n\n```\n./watcher/tests/policy_fixture.py:20:from oslo_policy import opts as policy_opts\n\n\n...\n\n./watcher/tests/policy_fixture.py-32-        self.policy_file_name \u003d os.path.join(self.policy_dir.path,\n./watcher/tests/policy_fixture.py-33-                                             \u0027policy.yaml\u0027)\n./watcher/tests/policy_fixture.py-34-        with open(self.policy_file_name, \u0027w\u0027) as policy_file:\n./watcher/tests/policy_fixture.py-35-            policy_file.write(fake_policy.policy_data)\n\n\n```\n\nthough... I\u0027m not sure if that one needs an update to be honest. It does call oslo_policy.opts.set_defaults like the code here (and seems to override the default to use policy.yaml albeit the \u0027fixture\u0027 version of it)","commit_id":"4d5022ab94ce604cd362d9f50ea0ba7deb94d0f7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8263e8049a8347a21f752933c8908216efcbd352","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# https://github.com/openstack/oslo.policy/blob/a626ad12fe5a3abd49d70e3e5b95589d279ab578/oslo_policy/opts.py#L49"},{"line_number":33,"context_line":"DEFAULT_POLICY_FILE \u003d \u0027policy.yaml\u0027"},{"line_number":34,"context_line":"opts.set_defaults(CONF, DEFAULT_POLICY_FILE)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# we can get a policy enforcer by this init."},{"line_number":38,"context_line":"# oslo policy support change policy rule dynamically."}],"source_content_type":"text/x-python","patch_set":1,"id":"46ff586c_057f91a3","side":"PARENT","line":35,"in_reply_to":"32dd66c3_e7a7b5e2","updated":"2024-11-11 22:52:27.000000000","message":"that is required to set the other defaults also.","commit_id":"4d5022ab94ce604cd362d9f50ea0ba7deb94d0f7"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"32b089957e89c141bb38d211b2ee2f947e1160b9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# https://github.com/openstack/oslo.policy/blob/a626ad12fe5a3abd49d70e3e5b95589d279ab578/oslo_policy/opts.py#L49"},{"line_number":33,"context_line":"DEFAULT_POLICY_FILE \u003d \u0027policy.yaml\u0027"},{"line_number":34,"context_line":"opts.set_defaults(CONF, DEFAULT_POLICY_FILE)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# we can get a policy enforcer by this init."},{"line_number":38,"context_line":"# oslo policy support change policy rule dynamically."}],"source_content_type":"text/x-python","patch_set":1,"id":"e2a01bf5_08fecd3d","side":"PARENT","line":35,"in_reply_to":"46ff586c_057f91a3","updated":"2024-11-15 08:38:34.000000000","message":"thanks for checking","commit_id":"4d5022ab94ce604cd362d9f50ea0ba7deb94d0f7"}]}