)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"51f86f3602c62a28038d9a1dd6ba6462f985635d","unresolved":true,"context_lines":[{"line_number":10,"context_line":"to validate the expected error message when creating a continuous"},{"line_number":11,"context_line":"audit with a wrong interval. The error message is now slightly"},{"line_number":12,"context_line":"different, since \"croniter\" was bumped to latest version in openstack"},{"line_number":13,"context_line":"requirements[1]."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #2089866"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"340f56c1_60d86472","line":13,"updated":"2024-11-28 19:36:15.000000000","message":"once watcher is better maintained we may want to add a cross job to the requirements repo to run watcher unit tests to highlight this in the future.\n\nnice find.","commit_id":"0a0728282ed20ae2c359f016b9727c4383f65712"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d07fcd5ac15d11c4bc8951af18917099f92b93ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"64b9d2d7_2617826c","updated":"2024-11-28 19:32:39.000000000","message":"lets see what others think\nthe messages seams to be pretty stabel given how long this has wroked form but i agree that shortening is also valid.","commit_id":"0a0728282ed20ae2c359f016b9727c4383f65712"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"3af55645c164f368c7537077ba583cc988db4847","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5866a5ba_8a801e36","updated":"2024-11-29 18:14:08.000000000","message":"recheck\n\njob failure[1] not related with this change. Lets rerun to check the outputs again.\n\n[1] https://9835f754a8c548c7984a-a75a90e4f62f1557c9429d321082a0da.ssl.cf1.rackcdn.com/936654/2/check/watcher-tempest-functional/3467b6a/testr_results.html","commit_id":"fbb290b2238e9e72054892e9ae6108a8907f47d7"}],"watcher/tests/api/v1/test_audits.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"1393cca9a0f055337e5d73228e09d65a04bdb6c0","unresolved":true,"context_lines":[{"line_number":701,"context_line":"        response \u003d self.post_json(\u0027/audits\u0027, audit_dict, expect_errors\u003dTrue)"},{"line_number":702,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":703,"context_line":"        self.assertEqual(HTTPStatus.INTERNAL_SERVER_ERROR, response.status_int)"},{"line_number":704,"context_line":"        expected_error_msg \u003d (\u0027Exactly 5, 6 or 7 columns has to be \u0027"},{"line_number":705,"context_line":"                              \u0027specified for iterator expression.\u0027)"},{"line_number":706,"context_line":"        self.assertTrue(response.json[\u0027error_message\u0027])"},{"line_number":707,"context_line":"        self.assertIn(expected_error_msg, response.json[\u0027error_message\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"e4633798_2ff69ca1","line":704,"range":{"start_line":704,"start_character":31,"end_line":704,"end_character":48},"updated":"2024-11-28 18:18:07.000000000","message":"It doesn\u0027t prevent future breakages, so maybe shorten the string we\u0027re checking here.","commit_id":"0a0728282ed20ae2c359f016b9727c4383f65712"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"ca3ce5ade40abf917da96e626098088704957610","unresolved":false,"context_lines":[{"line_number":701,"context_line":"        response \u003d self.post_json(\u0027/audits\u0027, audit_dict, expect_errors\u003dTrue)"},{"line_number":702,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":703,"context_line":"        self.assertEqual(HTTPStatus.INTERNAL_SERVER_ERROR, response.status_int)"},{"line_number":704,"context_line":"        expected_error_msg \u003d (\u0027Exactly 5, 6 or 7 columns has to be \u0027"},{"line_number":705,"context_line":"                              \u0027specified for iterator expression.\u0027)"},{"line_number":706,"context_line":"        self.assertTrue(response.json[\u0027error_message\u0027])"},{"line_number":707,"context_line":"        self.assertIn(expected_error_msg, response.json[\u0027error_message\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ee2f0afe_1a31d00e","line":704,"range":{"start_line":704,"start_character":31,"end_line":704,"end_character":48},"in_reply_to":"e4633798_2ff69ca1","updated":"2024-11-29 13:17:13.000000000","message":"Done","commit_id":"0a0728282ed20ae2c359f016b9727c4383f65712"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d07fcd5ac15d11c4bc8951af18917099f92b93ff","unresolved":true,"context_lines":[{"line_number":701,"context_line":"        response \u003d self.post_json(\u0027/audits\u0027, audit_dict, expect_errors\u003dTrue)"},{"line_number":702,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":703,"context_line":"        self.assertEqual(HTTPStatus.INTERNAL_SERVER_ERROR, response.status_int)"},{"line_number":704,"context_line":"        expected_error_msg \u003d (\u0027Exactly 5, 6 or 7 columns has to be \u0027"},{"line_number":705,"context_line":"                              \u0027specified for iterator expression.\u0027)"},{"line_number":706,"context_line":"        self.assertTrue(response.json[\u0027error_message\u0027])"},{"line_number":707,"context_line":"        self.assertIn(expected_error_msg, response.json[\u0027error_message\u0027])"},{"line_number":708,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"41abced6_c7c236bf","line":705,"range":{"start_line":704,"start_character":8,"end_line":705,"end_character":67},"updated":"2024-11-28 19:32:39.000000000","message":"this was added 7 years ago in \n\nhttps://github.com/openstack/watcher/commit/0b44492da7b71a737f065a5065c0b3b661d6b0a4#diff-3ab27378411bbb1686715502fc10d65f1a17fcdec807aaa2f50b60f25ac22ef1R634\n\nlooking at that commit  the number of colums was not relevnet to the test so yes i think you can shorten this too \n\n\n```suggestion\n        expected_error_msg \u003d (\n          \u0027columns has to be specified for iterator expression.\u0027)\n```","commit_id":"0a0728282ed20ae2c359f016b9727c4383f65712"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"fb0d6fa62f001dc8544642ea43cd84e64908be9e","unresolved":true,"context_lines":[{"line_number":701,"context_line":"        response \u003d self.post_json(\u0027/audits\u0027, audit_dict, expect_errors\u003dTrue)"},{"line_number":702,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":703,"context_line":"        self.assertEqual(HTTPStatus.INTERNAL_SERVER_ERROR, response.status_int)"},{"line_number":704,"context_line":"        expected_error_msg \u003d (\u0027Exactly 5, 6 or 7 columns has to be \u0027"},{"line_number":705,"context_line":"                              \u0027specified for iterator expression.\u0027)"},{"line_number":706,"context_line":"        self.assertTrue(response.json[\u0027error_message\u0027])"},{"line_number":707,"context_line":"        self.assertIn(expected_error_msg, response.json[\u0027error_message\u0027])"},{"line_number":708,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8f65365d_c33ec903","line":705,"range":{"start_line":704,"start_character":8,"end_line":705,"end_character":67},"in_reply_to":"0fea7439_caa338e5","updated":"2024-11-29 13:04:04.000000000","message":"ack, agreed. I will update this in the next PS","commit_id":"0a0728282ed20ae2c359f016b9727c4383f65712"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"9a0e959cdd77d62e8e23afa6e93dec5769073c62","unresolved":true,"context_lines":[{"line_number":701,"context_line":"        response \u003d self.post_json(\u0027/audits\u0027, audit_dict, expect_errors\u003dTrue)"},{"line_number":702,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":703,"context_line":"        self.assertEqual(HTTPStatus.INTERNAL_SERVER_ERROR, response.status_int)"},{"line_number":704,"context_line":"        expected_error_msg \u003d (\u0027Exactly 5, 6 or 7 columns has to be \u0027"},{"line_number":705,"context_line":"                              \u0027specified for iterator expression.\u0027)"},{"line_number":706,"context_line":"        self.assertTrue(response.json[\u0027error_message\u0027])"},{"line_number":707,"context_line":"        self.assertIn(expected_error_msg, response.json[\u0027error_message\u0027])"},{"line_number":708,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"0fea7439_caa338e5","line":705,"range":{"start_line":704,"start_character":8,"end_line":705,"end_character":67},"in_reply_to":"41abced6_c7c236bf","updated":"2024-11-29 12:29:08.000000000","message":"I\u0027d try to make the check backwards compatible by just using Sean\u0027s approach. Some distros may have lower versions etc. Otherwise, we should also bump minimal version to the one that implements that change in https://github.com/openstack/watcher/blob/master/requirements.txt#L11","commit_id":"0a0728282ed20ae2c359f016b9727c4383f65712"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"f233d944ad50628bd7af3c30f58f9fb98136c6c8","unresolved":true,"context_lines":[{"line_number":701,"context_line":"        response \u003d self.post_json(\u0027/audits\u0027, audit_dict, expect_errors\u003dTrue)"},{"line_number":702,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":703,"context_line":"        self.assertEqual(HTTPStatus.INTERNAL_SERVER_ERROR, response.status_int)"},{"line_number":704,"context_line":"        expected_error_msg \u003d (\u0027Exactly 5, 6 or 7 columns has to be \u0027"},{"line_number":705,"context_line":"                              \u0027specified for iterator expression.\u0027)"},{"line_number":706,"context_line":"        self.assertTrue(response.json[\u0027error_message\u0027])"},{"line_number":707,"context_line":"        self.assertIn(expected_error_msg, response.json[\u0027error_message\u0027])"},{"line_number":708,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"327d62b2_f9d453fe","line":705,"range":{"start_line":704,"start_character":8,"end_line":705,"end_character":67},"in_reply_to":"41abced6_c7c236bf","updated":"2024-11-29 12:26:55.000000000","message":"the second part of the string seems to be the same, I think it makes sense to just testing that part, specially considering that we\u0027re also asserting other information like the HTTPStatus","commit_id":"0a0728282ed20ae2c359f016b9727c4383f65712"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bbdc7d34f55b0491ead1492d1cce5937cca04dbd","unresolved":false,"context_lines":[{"line_number":701,"context_line":"        response \u003d self.post_json(\u0027/audits\u0027, audit_dict, expect_errors\u003dTrue)"},{"line_number":702,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":703,"context_line":"        self.assertEqual(HTTPStatus.INTERNAL_SERVER_ERROR, response.status_int)"},{"line_number":704,"context_line":"        expected_error_msg \u003d (\u0027Exactly 5, 6 or 7 columns has to be \u0027"},{"line_number":705,"context_line":"                              \u0027specified for iterator expression.\u0027)"},{"line_number":706,"context_line":"        self.assertTrue(response.json[\u0027error_message\u0027])"},{"line_number":707,"context_line":"        self.assertIn(expected_error_msg, response.json[\u0027error_message\u0027])"},{"line_number":708,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7612d6f2_26866a1d","line":705,"range":{"start_line":704,"start_character":8,"end_line":705,"end_character":67},"in_reply_to":"8109fee6_8b582588","updated":"2024-11-29 14:16:26.000000000","message":"thats a good point about disto depenance.\n\nif we just updated wew would effectivly be raising the min version +1","commit_id":"0a0728282ed20ae2c359f016b9727c4383f65712"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"ca3ce5ade40abf917da96e626098088704957610","unresolved":false,"context_lines":[{"line_number":701,"context_line":"        response \u003d self.post_json(\u0027/audits\u0027, audit_dict, expect_errors\u003dTrue)"},{"line_number":702,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":703,"context_line":"        self.assertEqual(HTTPStatus.INTERNAL_SERVER_ERROR, response.status_int)"},{"line_number":704,"context_line":"        expected_error_msg \u003d (\u0027Exactly 5, 6 or 7 columns has to be \u0027"},{"line_number":705,"context_line":"                              \u0027specified for iterator expression.\u0027)"},{"line_number":706,"context_line":"        self.assertTrue(response.json[\u0027error_message\u0027])"},{"line_number":707,"context_line":"        self.assertIn(expected_error_msg, response.json[\u0027error_message\u0027])"},{"line_number":708,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8109fee6_8b582588","line":705,"range":{"start_line":704,"start_character":8,"end_line":705,"end_character":67},"in_reply_to":"8f65365d_c33ec903","updated":"2024-11-29 13:17:13.000000000","message":"Done","commit_id":"0a0728282ed20ae2c359f016b9727c4383f65712"}]}