)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4c4319843cb977ba61dfb5e5f601c2d5c346127d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"95cf88de_f779e294","updated":"2024-12-19 12:35:21.000000000","message":"Thanks for proposing this.\nI would request to at least mention the cherry-picks and related bugs (if exists) as documented in [1].\n\n[1] https://docs.openstack.org/project-team-guide/stable-branches.html#proposing-fixes","commit_id":"36049dad763c77a7d7b764b09cba8f9fea6f3511"}],"watcher/tests/api/v1/test_audits.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ee4ef6b2fdb96ed4e0e738445b52ccfea74b9c3e","unresolved":true,"context_lines":[{"line_number":700,"context_line":"        response \u003d self.post_json(\u0027/audits\u0027, audit_dict, expect_errors\u003dTrue)"},{"line_number":701,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":702,"context_line":"        self.assertEqual(HTTPStatus.INTERNAL_SERVER_ERROR, response.status_int)"},{"line_number":703,"context_line":"        # NOTE(dviroel): this error message check was shortened to try avoid"},{"line_number":704,"context_line":"        # future breakages. See bug #2089866 for more details."},{"line_number":705,"context_line":"        expected_error_msg \u003d (\u0027columns has to be specified for iterator \u0027"},{"line_number":706,"context_line":"                              \u0027expression.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"eb0827ce_db971940","line":703,"updated":"2024-12-19 07:59:42.000000000","message":"as commented on https://review.opendev.org/c/openstack/watcher/+/937825 this one is a bit newer than mentioned in the commit message.\n\nthat should go to 2024.2 before we merge this (https://github.com/openstack/watcher/commit/fbb290b2238e9e72054892e9ae6108a8907f47d7)","commit_id":"36049dad763c77a7d7b764b09cba8f9fea6f3511"},{"author":{"_account_id":37309,"name":"Bryan Fraschetti","display_name":"Bryan Fraschetti","email":"bryan.fraschetti@canonical.com","username":"bryanfraschetti"},"change_message_id":"bedef097fb2f1205c89305fda8ff235cd48bd76e","unresolved":true,"context_lines":[{"line_number":700,"context_line":"        response \u003d self.post_json(\u0027/audits\u0027, audit_dict, expect_errors\u003dTrue)"},{"line_number":701,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":702,"context_line":"        self.assertEqual(HTTPStatus.INTERNAL_SERVER_ERROR, response.status_int)"},{"line_number":703,"context_line":"        # NOTE(dviroel): this error message check was shortened to try avoid"},{"line_number":704,"context_line":"        # future breakages. See bug #2089866 for more details."},{"line_number":705,"context_line":"        expected_error_msg \u003d (\u0027columns has to be specified for iterator \u0027"},{"line_number":706,"context_line":"                              \u0027expression.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"882bee51_18192bd3","line":703,"in_reply_to":"4732ed4e_8972c4ce","updated":"2024-12-19 23:00:08.000000000","message":"Hi Douglas and Marios,\n\nI believe I was mistaken in my assumption that the test_audit failure was related to the Omnibus patch that I was backporting.\n\nI had observed the same traceback as described in [1] when running tox locally against stable/2024.1 and stable/2024.2, however, you\u0027re right that the test_audit fix doesn\u0027t need to be applied for the Omnibus backport to pass the remote Opendev CI. The issue I encountered appears to be related to dependency resolution. Ubuntu\u0027s 2024 releases ship with Python 3.12 and so the croniter\u003e\u003d0.3.20 dependency in requirements.txt resolves to croniter\u003d\u003d5.0.1, which is the same version that recently manifested the issue for the 2025.1 CI. As a result of this croniter version, CI fails locally on Ubuntu. The local CI failure is not present for the 2023 releases because Ubuntu\u0027s 2023 releases ship with Python 3.11 - on which croniter\u003d\u003d1.3.14 is installed by tox\u0027s invocation of pip. The test change is, therefore, probably not necessary for the 2023 branches. Opendev\u0027s gate for the 2024 releases of watcher test against Python 3.11, and so this failure won\u0027t occur in the gate.\n\nAs for next steps, I can cherry-pick the test_audits change separately to both 2024 releases, drop the commit from this backport, and reapply this commit to 2024.1 and 2023.2 with better reference to the original commit [2] and the public bug report at [3]. Let me know if you agree with these steps and your assessment on whether or you\u0027d like to see the test_audit change cherry-picked to 2023.2.\n\n[1] https://bugs.launchpad.net/watcher/+bug/2089866\n[2] https://opendev.org/openstack/watcher/commit/d6f169197efc5b4f6c8a2e6bc38177b0641ca05c\n[3] https://bugs.launchpad.net/ubuntu/+source/watcher/+bug/2091947","commit_id":"36049dad763c77a7d7b764b09cba8f9fea6f3511"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"cce91606f0c9b2e2f77256df7357261deb65eb43","unresolved":true,"context_lines":[{"line_number":700,"context_line":"        response \u003d self.post_json(\u0027/audits\u0027, audit_dict, expect_errors\u003dTrue)"},{"line_number":701,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":702,"context_line":"        self.assertEqual(HTTPStatus.INTERNAL_SERVER_ERROR, response.status_int)"},{"line_number":703,"context_line":"        # NOTE(dviroel): this error message check was shortened to try avoid"},{"line_number":704,"context_line":"        # future breakages. See bug #2089866 for more details."},{"line_number":705,"context_line":"        expected_error_msg \u003d (\u0027columns has to be specified for iterator \u0027"},{"line_number":706,"context_line":"                              \u0027expression.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"eeb1bc7a_2aaeeb00","line":703,"in_reply_to":"882bee51_18192bd3","updated":"2024-12-20 07:43:57.000000000","message":"thanks Bryan ... imo yes to removing the Commit fbb290b (https://github.com/openstack/watcher/commit/fbb290b) from this patch and the related 2023.2 patch, if it isn\u0027t actually required and +1 to Doug\u0027s comments about adding more info about the included commits.\n\nnot sure yet about backporting Commit fbb290b to 2024.2/1 though. \n\nfor both 2024.1 and 2024.2 the project was still pretty dormant, and we only really picked things up after 2024.2 was released. we have discussed backports before but not reached any strong consensus; mainly they should be easy enough to do (project was dormant so we should be able to cherrypick things easily/cleanly) but then, does anyone care? Is anyone trying to use 2024.1/2 anywhere? If they were they were doing so very quietly ;) \n\nSo, I added a note to revisit the discussion about backports in the next irc meet at  https://etherpad.opendev.org/p/openstack-watcher-irc-meeting . Let\u0027s see if there are any new opinions/concerns about that.","commit_id":"36049dad763c77a7d7b764b09cba8f9fea6f3511"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4c4319843cb977ba61dfb5e5f601c2d5c346127d","unresolved":true,"context_lines":[{"line_number":700,"context_line":"        response \u003d self.post_json(\u0027/audits\u0027, audit_dict, expect_errors\u003dTrue)"},{"line_number":701,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":702,"context_line":"        self.assertEqual(HTTPStatus.INTERNAL_SERVER_ERROR, response.status_int)"},{"line_number":703,"context_line":"        # NOTE(dviroel): this error message check was shortened to try avoid"},{"line_number":704,"context_line":"        # future breakages. See bug #2089866 for more details."},{"line_number":705,"context_line":"        expected_error_msg \u003d (\u0027columns has to be specified for iterator \u0027"},{"line_number":706,"context_line":"                              \u0027expression.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4732ed4e_8972c4ce","line":703,"in_reply_to":"eb0827ce_db971940","updated":"2024-12-19 12:35:21.000000000","message":"Actually this fix doesn\u0027t need to be backported, since it only affects master branch. More info here[1]\n\n[1] https://bugs.launchpad.net/watcher/+bug/2089866","commit_id":"36049dad763c77a7d7b764b09cba8f9fea6f3511"},{"author":{"_account_id":37309,"name":"Bryan Fraschetti","display_name":"Bryan Fraschetti","email":"bryan.fraschetti@canonical.com","username":"bryanfraschetti"},"change_message_id":"5dbcc39365a0220d4dace42588bd6e94337f9788","unresolved":true,"context_lines":[{"line_number":700,"context_line":"        response \u003d self.post_json(\u0027/audits\u0027, audit_dict, expect_errors\u003dTrue)"},{"line_number":701,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"},{"line_number":702,"context_line":"        self.assertEqual(HTTPStatus.INTERNAL_SERVER_ERROR, response.status_int)"},{"line_number":703,"context_line":"        # NOTE(dviroel): this error message check was shortened to try avoid"},{"line_number":704,"context_line":"        # future breakages. See bug #2089866 for more details."},{"line_number":705,"context_line":"        expected_error_msg \u003d (\u0027columns has to be specified for iterator \u0027"},{"line_number":706,"context_line":"                              \u0027expression.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"838ecfcb_8fca8793","line":703,"in_reply_to":"eeb1bc7a_2aaeeb00","updated":"2025-01-07 17:44:39.000000000","message":"Thanks Marios,\n\nIt looks like in the meantime these same two backports were cleanly cherrypicked, applied separately, and are active proposed changes. The omnibus fixes cherrypick: https://review.opendev.org/c/openstack/watcher/+/938434 and the continuous audit test cherrypick: https://review.opendev.org/c/openstack/watcher/+/938437\n\nTo avoid confusion and having multiple open backports of the same issue, I suggest that I abandon mine and the discussion regarding the viability/relevance of these backports continues on the cleaner threads that have since been opened.\n\nLet me know if this sounds good to you","commit_id":"36049dad763c77a7d7b764b09cba8f9fea6f3511"}]}