)]}'
{"id":"openstack%2Fwatcher~938434","triplet_id":"openstack%2Fwatcher~stable%2F2024.1~I000e5e78f97f82ed4ea64d42f1c38354c3252e08","project":"openstack/watcher","branch":"stable/2024.1","topic":"sqlalchemy-20-stable/2024.1","attention_set":{},"removed_from_attention_set":{"11604":{"account":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"last_update":"2025-01-07 11:44:09.000000000","reason":"\u003cGERRIT_ACCOUNT_11604\u003e replied on the change","reason_account":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}},"34720":{"account":{"_account_id":34720,"name":"JamesLin","display_name":"jneo8","email":"james.lin@canonical.com","username":"jneo8"},"last_update":"2025-01-10 02:24:02.000000000","reason":"Change was abandoned"},"8449":{"account":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"last_update":"2025-01-07 07:41:26.000000000","reason":"\u003cGERRIT_ACCOUNT_8449\u003e replied on the change","reason_account":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"}}},"hashtags":[],"change_id":"I000e5e78f97f82ed4ea64d42f1c38354c3252e08","subject":"SQLAlchemy 2.0: Omnibus fixes patch","status":"ABANDONED","created":"2025-01-06 07:19:24.000000000","updated":"2025-01-10 02:24:02.000000000","total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"cherry_pick_of_change":918500,"cherry_pick_of_patch_set":6,"meta_rev_id":"19aec88456b0bf721953d03f44b4d06f97e7f573","_number":938434,"virtual_id_number":938434,"owner":{"_account_id":34720,"name":"JamesLin","display_name":"jneo8","email":"james.lin@canonical.com","username":"jneo8"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2025-01-06 08:30:30.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":1,"date":"2025-01-06 07:42:08.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"}],"REVIEWER":[{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-01-06 07:19:24.000000000","updated_by":{"_account_id":34720,"name":"JamesLin","display_name":"jneo8","email":"james.lin@canonical.com","username":"jneo8"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"CC"},{"updated":"2025-01-06 07:41:56.000000000","updated_by":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"reviewer":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"state":"CC"},{"updated":"2025-01-06 07:41:56.000000000","updated_by":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2025-01-06 07:42:08.000000000","updated_by":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"reviewer":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"state":"REVIEWER"},{"updated":"2025-01-06 08:30:30.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d8e4538067e6e874a47b1a2d70a1c47136209ae2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34720,"name":"JamesLin","display_name":"jneo8","email":"james.lin@canonical.com","username":"jneo8"},"date":"2025-01-06 07:19:24.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"85988d12cabaf791770884f5efd0ea53c27c2c1a","author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"date":"2025-01-06 07:41:56.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"70593c207d3162c38f10b406cbfd2aa28bb19239","author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"date":"2025-01-06 07:42:08.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8e0cce34c32a61892a919c4b9987f5a8d96499bb","author":{"_account_id":34720,"name":"JamesLin","display_name":"jneo8","email":"james.lin@canonical.com","username":"jneo8"},"date":"2025-01-06 08:10:01.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b071f785ec97779aff403b39cd643ece8753f3b4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-01-06 08:30:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/825c8903528943c88e93db664d1051d5\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2637fdc90afd44eda98feac307bf7c16 : SUCCESS in 5m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8cc7f68d33154c81946cd6df34b7b60a : SUCCESS in 3m 35s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1726f55d6a474796aa5e2c26563fdd85 : SUCCESS in 4m 24s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/32f80e6593994d3e98b8d4b4aef39a85 : SUCCESS in 4m 34s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8b13c4d069f7440491511464f37d7aea : SUCCESS in 6m 26s\n- watcher-tempest-functional https://zuul.opendev.org/t/openstack/build/0cac9c25a7724f2a9579674b3bbc16e7 : SUCCESS in 32m 28s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/3bff24a17187425e96c00eb38a55d019 : SUCCESS in 58m 11s\n- watcher-tempest-strategies https://zuul.opendev.org/t/openstack/build/02bfd5478fe54536800298120dbcd750 : SUCCESS in 53m 16s\n- watcher-tempest-actuator https://zuul.opendev.org/t/openstack/build/03ae4d48a9e9490a8e40f68fa4b300bf : SUCCESS in 47m 36s\n- watcherclient-tempest-functional https://zuul.opendev.org/t/openstack/build/26ebc492136149daabe307477506ef5b : SUCCESS in 36m 11s\n- watcher-tempest-functional-ipv6-only https://zuul.opendev.org/t/openstack/build/824f4e820b5a4cd0b1b73e4ff4b7f7a0 : SUCCESS in 19m 17s","accounts_in_message":[],"_revision_number":1},{"id":"6775a688553ba2ee6f7a2c2017c41ee3b61b0352","author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"date":"2025-01-07 07:41:26.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f4d0cc067bb07aacf6e51d369a1b861d80eabe8f","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2025-01-07 11:44:09.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"19aec88456b0bf721953d03f44b4d06f97e7f573","tag":"autogenerated:gerrit:abandon","author":{"_account_id":34720,"name":"JamesLin","display_name":"jneo8","email":"james.lin@canonical.com","username":"jneo8"},"date":"2025-01-10 02:24:02.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"934ad5c73a887a8ac4e2cbd0f4e163a832a7d8fe","revisions":{"934ad5c73a887a8ac4e2cbd0f4e163a832a7d8fe":{"kind":"REWORK","_number":1,"created":"2025-01-06 07:19:24.000000000","uploader":{"_account_id":34720,"name":"JamesLin","display_name":"jneo8","email":"james.lin@canonical.com","username":"jneo8"},"ref":"refs/changes/34/938434/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/34/938434/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/34/938434/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/34/938434/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/34/938434/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/34/938434/1"}}},"commit":{"parents":[{"commit":"6b433b3547466f592c9e5ed22477bd8e534512b9","subject":"Fix oslo.db \u003e\u003d 15.0.0 compatibility","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/6b433b3547466f592c9e5ed22477bd8e534512b9"}]}],"author":{"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","date":"2024-05-08 06:24:52.000000000","tz":540},"committer":{"name":"JamesLin","email":"james.lin@canonical.com","date":"2025-01-06 07:19:24.000000000","tz":0},"subject":"SQLAlchemy 2.0: Omnibus fixes patch","message":"SQLAlchemy 2.0: Omnibus fixes patch\n\nThis was originally five patches, but they are all needed to pass\nany of the test jobs now, so they have been squashed into one:\n\nCo-Authored-By: Dan Smith (dms@danplanet.com)\n\nFirst:\n\nThe autoload argument was removed[1] in SQLAlchemy and only\nthe autoload_with argument should be passed.\n\nThe autoload argument is set according to the autoload_with argument\nautomatically even in SQLAlchemy 1.x[2] so is not at all needed.\n\n[1] https://github.com/sqlalchemy/sqlalchemy/commit/c932123bacad9bf047d160b85e3f95d396c513ae\n[2] https://github.com/sqlalchemy/sqlalchemy/commit/ad8f921e969b6f735dc8e08d882c961dde78f2b1\n\nSecond:\n\nRemove _warn_on_bytestring for newer SA, AFAICT, this flag has been\nremoved from SQLAlchemy and that is why watcher-db-manage fails to\ninitialize the DB for me on jammy. This migration was passing the\ndefault value (\u003dFalse) anyway, so I assume this is the right \"fix\".\n\nThird:\n\nFix joinedload passing string attribute names\n\nFourth:\n\nFix engine.select pattern to use begin() per the migration guide.\n\nFifth:\n\nOverride the apscheduler get_next_run_time() which appears to be\ntrivially not compatible with SQLAlchemy 2.0 because of a return type\nfrom scalar().\n\nChange-Id: I000e5e78f97f82ed4ea64d42f1c38354c3252e08\n(cherry picked from commit d6f169197efc5b4f6c8a2e6bc38177b0641ca05c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/934ad5c73a887a8ac4e2cbd0f4e163a832a7d8fe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/934ad5c73a887a8ac4e2cbd0f4e163a832a7d8fe"}]},"parents_data":[{"branch_name":"refs/heads/stable/2024.1","commit_id":"6b433b3547466f592c9e5ed22477bd8e534512b9","is_merged_in_target_branch":false,"change_id":"I33be53f647faae2aad30a43c10980df950d5d7c2","change_number":914451,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/stable/2024.1"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}
