)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9cfe69eedd0ce767dbf0d28e2022a8c108d95b63","unresolved":true,"context_lines":[{"line_number":10,"context_line":"job."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Also remove requirements installed automatically by pre-commit from"},{"line_number":13,"context_line":"test-requirements."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I45af8c47afb262882ebbee74ae52446fed741e26"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5c42b3d9_2b13e360","line":13,"updated":"2025-02-09 21:25:58.000000000","message":"the lxml chagnges are incorrect.","commit_id":"65b15fd2cf113de7ea1d2a19db563d312c107e6b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9de63b69c62deba9b570a30a8bd28225d2365c5b","unresolved":true,"context_lines":[{"line_number":10,"context_line":"job."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Also remove requirements installed automatically by pre-commit from"},{"line_number":13,"context_line":"test-requirements."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I45af8c47afb262882ebbee74ae52446fed741e26"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fbe6f761_e14c0a86","line":13,"in_reply_to":"5776cbe4_260cd9b5","updated":"2025-02-10 12:39:19.000000000","message":"OK. That\u0027s a fair point.","commit_id":"65b15fd2cf113de7ea1d2a19db563d312c107e6b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a70bfa1e4627ac94de0c724c6766bd5352d886b7","unresolved":true,"context_lines":[{"line_number":10,"context_line":"job."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Also remove requirements installed automatically by pre-commit from"},{"line_number":13,"context_line":"test-requirements."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I45af8c47afb262882ebbee74ae52446fed741e26"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"723f905c_041610df","line":13,"in_reply_to":"5c42b3d9_2b13e360","updated":"2025-02-10 02:23:25.000000000","message":"As I wrote in my another comment, the whole defusedxml is not deprecated but I disabled the bandit error for now to have a separate discussion.","commit_id":"65b15fd2cf113de7ea1d2a19db563d312c107e6b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5850c41f81b01f9bd57600363e0584da984d7d56","unresolved":true,"context_lines":[{"line_number":10,"context_line":"job."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Also remove requirements installed automatically by pre-commit from"},{"line_number":13,"context_line":"test-requirements."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I45af8c47afb262882ebbee74ae52446fed741e26"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5776cbe4_260cd9b5","line":13,"in_reply_to":"723f905c_041610df","updated":"2025-02-10 10:50:29.000000000","message":"we really should not be useing it in openstack in general IMO\n\ni understand the orginal motivation but to me it didnt delivber.\n\nnova at least only use xml to talk to libvirt so we are not using lxml for untrusted input so defused xml is not really useful\n\nin watcher we only use it to prodcues parsable errors or in to_xml fucntions\nmeanign we are not using it for parsign so we do not ahve any of the usecases taht defusedxml was intendign to adress.\n\nso to me defusedxml add no value for either nova or watcher while requiring use to ship bot packages in downstream openstack project since nova and several other project dont plan to move to defusedxml.","commit_id":"65b15fd2cf113de7ea1d2a19db563d312c107e6b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f6f68d71813b4a79050709cb5243b7354a39caa3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"job."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Also remove requirements installed automatically by pre-commit from"},{"line_number":13,"context_line":"test-requirements."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I45af8c47afb262882ebbee74ae52446fed741e26"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ee3b4679_500a4c18","line":13,"in_reply_to":"fbe6f761_e14c0a86","updated":"2025-02-10 14:41:48.000000000","message":"Acknowledged","commit_id":"65b15fd2cf113de7ea1d2a19db563d312c107e6b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"406ddba5273fa595d0b40b9fe96633001faa83ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5c26decf_2efd15d4","updated":"2025-02-09 13:41:43.000000000","message":"recheck CI was not started due to outage","commit_id":"65b15fd2cf113de7ea1d2a19db563d312c107e6b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f6f68d71813b4a79050709cb5243b7354a39caa3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"25f1b31b_32c9e7f8","updated":"2025-02-10 14:41:48.000000000","message":"looks good to me thanks takashi","commit_id":"dd0082c343c22d0846e0c892bbca4e4b8e6d4443"}],"test-requirements.txt":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f6f68d71813b4a79050709cb5243b7354a39caa3","unresolved":true,"context_lines":[{"line_number":2,"context_line":"doc8\u003e\u003d0.8.0 # Apache-2.0"},{"line_number":3,"context_line":"freezegun\u003e\u003d0.3.10 # Apache-2.0"},{"line_number":4,"context_line":"hacking\u003e\u003d7.0.0,\u003c7.1.0 # Apache-2.0"},{"line_number":5,"context_line":"oslotest\u003e\u003d3.3.0 # Apache-2.0"},{"line_number":6,"context_line":"testscenarios\u003e\u003d0.5.0 # Apache-2.0/BSD"},{"line_number":7,"context_line":"testtools\u003e\u003d2.3.0 # MIT"},{"line_number":8,"context_line":"stestr\u003e\u003d2.0.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":5,"id":"b85cbfa5_12f6e59e","side":"PARENT","line":5,"updated":"2025-02-10 14:41:48.000000000","message":"this cap was wrong for other reasons too so this is good to fix that.","commit_id":"5f6fbaea56889eaf1bd317f9873f314b716e0ddc"}],"tox.ini":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9cfe69eedd0ce767dbf0d28e2022a8c108d95b63","unresolved":true,"context_lines":[{"line_number":109,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":110,"context_line":"commands \u003d sphinx-build -a -W -E -d releasenotes/build/doctrees --keep-going -b html releasenotes/source releasenotes/build/html"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"[testenv:bandit]"},{"line_number":113,"context_line":"deps \u003d -r{toxinidir}/test-requirements.txt"},{"line_number":114,"context_line":"commands \u003d bandit -r watcher -x watcher/tests/* -n5 -ll"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"e3530f6b_73972318","side":"PARENT","line":112,"updated":"2025-02-09 21:25:58.000000000","message":"usually if it had a tox target and we move it to precommit we keep the tox target and just have it call pre-commit instead\n\nhttps://github.com/openstack/nova/blob/master/tox.ini#L104-L142","commit_id":"5f6fbaea56889eaf1bd317f9873f314b716e0ddc"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9725c4558861c1b1e7b8ac70b22b0bababe3ead3","unresolved":false,"context_lines":[{"line_number":109,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":110,"context_line":"commands \u003d sphinx-build -a -W -E -d releasenotes/build/doctrees --keep-going -b html releasenotes/source releasenotes/build/html"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"[testenv:bandit]"},{"line_number":113,"context_line":"deps \u003d -r{toxinidir}/test-requirements.txt"},{"line_number":114,"context_line":"commands \u003d bandit -r watcher -x watcher/tests/* -n5 -ll"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"ab23fe91_ac48ba81","side":"PARENT","line":112,"in_reply_to":"e3530f6b_73972318","updated":"2025-02-10 02:22:17.000000000","message":"I wasn\u0027t aware of that trick. Thanks !","commit_id":"5f6fbaea56889eaf1bd317f9873f314b716e0ddc"}],"watcher/decision_engine/model/element/base.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"de5e2375bd5160d8401660fe43601dbccdef981c","unresolved":true,"context_lines":[{"line_number":19,"context_line":"import abc"},{"line_number":20,"context_line":"import collections"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from defusedxml import ElementTree as etree"},{"line_number":23,"context_line":"from oslo_log import log"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from watcher.objects import base"}],"source_content_type":"text/x-python","patch_set":2,"id":"2f99cbc5_0e335517","line":22,"updated":"2025-02-09 21:23:23.000000000","message":"-1 defusedxml is not maintained and we shoudl nto be replacing lxml with it\n\nhttps://github.com/PyCQA/bandit/issues/435","commit_id":"65b15fd2cf113de7ea1d2a19db563d312c107e6b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9725c4558861c1b1e7b8ac70b22b0bababe3ead3","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import abc"},{"line_number":20,"context_line":"import collections"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from defusedxml import ElementTree as etree"},{"line_number":23,"context_line":"from oslo_log import log"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from watcher.objects import base"}],"source_content_type":"text/x-python","patch_set":2,"id":"825e8406_d4000f1b","line":22,"in_reply_to":"2f99cbc5_0e335517","updated":"2025-02-10 02:22:17.000000000","message":"Done","commit_id":"65b15fd2cf113de7ea1d2a19db563d312c107e6b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5850c41f81b01f9bd57600363e0584da984d7d56","unresolved":true,"context_lines":[{"line_number":20,"context_line":"import collections"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from lxml import etree"},{"line_number":23,"context_line":"from defusedxml import ElementTree as etree"},{"line_number":24,"context_line":"from oslo_log import log"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from watcher.objects import base"}],"source_content_type":"text/x-python","patch_set":3,"id":"b970e82e_53447f5a","line":23,"updated":"2025-02-10 10:50:29.000000000","message":"you still importing defused xml here, you obvioly just missed it in the revert\nthe rest looks good.","commit_id":"a88ced5503228bd04d5eaeb803ed698a0fd53227"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9de63b69c62deba9b570a30a8bd28225d2365c5b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import collections"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from lxml import etree"},{"line_number":23,"context_line":"from defusedxml import ElementTree as etree"},{"line_number":24,"context_line":"from oslo_log import log"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from watcher.objects import base"}],"source_content_type":"text/x-python","patch_set":3,"id":"5c9fa6bd_da84f18c","line":23,"in_reply_to":"b970e82e_53447f5a","updated":"2025-02-10 12:39:19.000000000","message":"Oops. Yes.","commit_id":"a88ced5503228bd04d5eaeb803ed698a0fd53227"}],"watcher/decision_engine/model/model_root.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"de5e2375bd5160d8401660fe43601dbccdef981c","unresolved":true,"context_lines":[{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import ast"},{"line_number":20,"context_line":"from defusedxml import ElementTree as etree"},{"line_number":21,"context_line":"import networkx as nx"},{"line_number":22,"context_line":"from oslo_concurrency import lockutils"},{"line_number":23,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":2,"id":"cc7ef9da_ca38945b","line":20,"updated":"2025-02-09 21:23:23.000000000","message":"same we shoudl not be useing defuedxml\n\nthe orginal reason for doing this nolonger applies\n\nsee https://github.com/PyCQA/bandit/issues/435","commit_id":"65b15fd2cf113de7ea1d2a19db563d312c107e6b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9da98922e8614e91e1d51c1e82c7ac6eeeadbf04","unresolved":true,"context_lines":[{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import ast"},{"line_number":20,"context_line":"from defusedxml import ElementTree as etree"},{"line_number":21,"context_line":"import networkx as nx"},{"line_number":22,"context_line":"from oslo_concurrency import lockutils"},{"line_number":23,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":2,"id":"cf5dba29_b205ac0d","line":20,"in_reply_to":"cc7ef9da_ca38945b","updated":"2025-02-10 02:17:17.000000000","message":"IIUC what is actually deprecated is defusedxml.lxml, not defusedxml itself. But I see defusedxml hasn\u0027t been updated ro 2 years which may indicate that we should get rid of it...","commit_id":"65b15fd2cf113de7ea1d2a19db563d312c107e6b"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9725c4558861c1b1e7b8ac70b22b0bababe3ead3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import ast"},{"line_number":20,"context_line":"from defusedxml import ElementTree as etree"},{"line_number":21,"context_line":"import networkx as nx"},{"line_number":22,"context_line":"from oslo_concurrency import lockutils"},{"line_number":23,"context_line":"from oslo_log import log"}],"source_content_type":"text/x-python","patch_set":2,"id":"98635393_8adfef59","line":20,"in_reply_to":"cf5dba29_b205ac0d","updated":"2025-02-10 02:22:17.000000000","message":"I\u0027ve reverted this change if it can be controversial.","commit_id":"65b15fd2cf113de7ea1d2a19db563d312c107e6b"}]}