)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"975228735a91305c535048d5a7b26f3b4cec1ba3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a6e2b565_fa4b6696","updated":"2025-05-02 13:01:24.000000000","message":"I don\u0027t get what you want to do here, just update documentation? By reading the commit message, seems that you are actually trying to replace something in the code.","commit_id":"79528bf52c9d7af193716769251d8975f6072988"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d6e65143c9d2c91cabb15d3844d205978642bae7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4ea79955_dc2a5398","in_reply_to":"0fc575b6_fc251c1f","updated":"2025-05-14 03:58:41.000000000","message":"Sorry my mistake Sean, I got confused on Doug documentation comment and pasted git grep output. I also misplaced the link in the commit message.\n\nThank you Sean once again for explaining it.","commit_id":"79528bf52c9d7af193716769251d8975f6072988"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"062731dc05927e34aa832e5ab8b88b5cb3220bb6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e5a8a5e2_e7c332be","in_reply_to":"4ccc2980_c2b0e54f","updated":"2025-05-12 06:47:12.000000000","message":"Thank you @seanmooney8202@yahoo.ie @viroel@gmail.com for the review. Based on my git grep\n```\nwatcher on  master [$] via 🐍 v3.13.3 \n❯ git grep \u0027nova service-list\u0027\nwatcher/applier/actions/change_nova_service_state.py:    nova-compute services is returned by this command: ``nova service-list\nwatcher/applier/actions/migration.py:    hosts is returned by this command: ``nova service-list --binary\n```\n`nova service-list` is referenced in the following code and used directly in strategies to generate the doc in runtime.https://github.com/openstack/watcher/blob/c4acce91d6bb87b4ab865bc8e4d442a148dba1d5/doc/source/strategies/host_maintenance.rst?plain\u003d1#L45\n```\n  * - ``migration``\n         - .. watcher-term:: watcher.applier.actions.migration.Migrate\n       * - ``change_nova_service_state``\n         - .. watcher-term:: watcher.applier.actions.change_nova_service_state.ChangeNovaServiceState\n```\nthat\u0027s why I was modifying the code.\n\nBased on above discussion, I will drop the cli reference from the code. thank you!","commit_id":"79528bf52c9d7af193716769251d8975f6072988"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e581e9a1f4b0768935d81d9b0cb7d1aefd8a61f3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4ccc2980_c2b0e54f","in_reply_to":"a6e2b565_fa4b6696","updated":"2025-05-08 11:05:16.000000000","message":"right this is just s doc text update but the update docs are incorrect as were the orginal docs since both imply we use a cli for this which we dont.","commit_id":"79528bf52c9d7af193716769251d8975f6072988"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"757b3453af2f3358237349c55089679e9eed3e84","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0fc575b6_fc251c1f","in_reply_to":"e5a8a5e2_e7c332be","updated":"2025-05-13 11:17:15.000000000","message":"did you actully read the code your refernecing.\n\n\nit is menthioned in the doc string\n\nhttps://github.com/openstack/watcher/blob/fd3d8b67ffbd7b89b6a84f5f17cb4d5890c1bb29/watcher/applier/actions/change_nova_service_state.py#L42-L44\n\n\nbut it calls self._nova_manage_service(target_state)\n\nhttps://github.com/openstack/watcher/blob/master/watcher/applier/actions/change_nova_service_state.py#L102\n\nwhich delegates to enable_service_nova_compute or disable_service_nova_compute\n\nhttps://github.com/openstack/watcher/blob/master/watcher/applier/actions/change_nova_service_state.py#L119-L121\n\n\nwhich internally delegates to the Nova rest client instance\n\nhttps://github.com/openstack/watcher/blob/master/watcher/common/nova_helper.py#L425-L450\n\n\nso it calling list \nhttps://github.com/openstack/python-novaclient/blob/master/novaclient/v2/services.py#L39\nenable and disable\nhttps://github.com/openstack/python-novaclient/blob/master/novaclient/v2/services.py#L80-L93\n\nusing the Python binding for the rest api provided by the \n\npython-novaclient python repository, but it is not using the cli module or the nova CLI binary to make these calls.\n\n\nSo, as I said before, the doc strings are wrong\n\nThey are just explaining what the equivalent CLI commands would be if you were to replicate this by hand but the watcher code does not use the cli and the docstrics are misleading becuase it implies it may.\n\n\nlooking at the most recent verion you have updated the docs stricng to drop the refence to the cli so this now looks good to me.","commit_id":"79528bf52c9d7af193716769251d8975f6072988"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"cc0b6b65690a1f36b1ecf012cd048afc8ef6f4f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"973eb10e_744949be","updated":"2025-05-13 12:01:03.000000000","message":"Thanks for the updates Chandan, in the end it was an interesting discussion around how we communicate with other services and about the tech debt to move to openstacksdk.","commit_id":"3f6c7e406af2e79c33e0c589a008bc94029dfa4f"}],"watcher/applier/actions/change_nova_service_state.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"282387759f74c815039d46891f5b5471ae1380c0","unresolved":true,"context_lines":[{"line_number":42,"context_line":"    The `resource_id` references a nova-compute service name (list of available"},{"line_number":43,"context_line":"    nova-compute services is returned by this command: ``nova service-list"},{"line_number":44,"context_line":"    --binary nova-compute``)."},{"line_number":45,"context_line":"    The `state` value should either be `ONLINE` or `OFFLINE`."},{"line_number":46,"context_line":"    The `disabled_reason` references the reason why Watcher disables this"},{"line_number":47,"context_line":"    nova-compute service. The value should be with `watcher_` prefix, such as"},{"line_number":48,"context_line":"    `watcher_disabled`, `watcher_maintaining`."}],"source_content_type":"text/x-python","patch_set":1,"id":"04c91ef9_58a06961","side":"PARENT","line":45,"updated":"2025-05-01 12:11:01.000000000","message":"unfortunetly this was wrong before.","commit_id":"adbcac93190905decab0dbce3aefccd86c33a1df"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"282387759f74c815039d46891f5b5471ae1380c0","unresolved":true,"context_lines":[{"line_number":42,"context_line":"    The `resource_id` references a nova-compute service name (list of available"},{"line_number":43,"context_line":"    nova-compute services is returned by this command: ``openstack compute"},{"line_number":44,"context_line":"    service list --service nova-compute --long``)."},{"line_number":45,"context_line":"    The `state` value should either be `up` or `down`."},{"line_number":46,"context_line":"    The `disabled_reason` references the reason why Watcher disables this"},{"line_number":47,"context_line":"    nova-compute service. The value should be with `watcher_` prefix, such as"},{"line_number":48,"context_line":"    `watcher_disabled`, `watcher_maintaining`."}],"source_content_type":"text/x-python","patch_set":1,"id":"96326605_285e317f","line":45,"updated":"2025-05-01 12:11:01.000000000","message":"and htis is even more incorrect\n\nthe code in quetion is \n\nhttps://github.com/openstack/watcher/blob/c4acce91d6bb87b4ab865bc8e4d442a148dba1d5/watcher/common/nova_helper.py#L150-L152\n\nthat is calling the python binding for the nova api that is used to implement the cli but tis not useing the command at all and never was\n\nhttps://github.com/openstack/python-novaclient/blob/master/novaclient/v2/services.py#L39-L53\n\nand it definitely not calling the openstack cli because we do not even have that as a dependency and won\u0027t.\n\ndocumenting the equivalent command is not useful to have in the help text since it implies we use the cli instead of the python bindings. \n\nmy prefence wold be remove any refence to the cli command.","commit_id":"79528bf52c9d7af193716769251d8975f6072988"}]}