)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f27726bb37c60541f30deef38e652a2160e5025b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chandan Kumar (raukadah) \u003cchkumar@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-04-25 15:51:20 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[host_maintenance] Pass des hostname in add_action solution"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently we are passing src_node and des_node uuid when we try to run"},{"line_number":10,"context_line":"migrate action."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"54cfd152_3ba9cbd6","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":27},"updated":"2025-05-01 13:14:19.000000000","message":"the?\n\nlater\n-----\n\nOh this is a non-standard abbreviation for destination\n\nWe normally shorten to dest","commit_id":"278cb7e98c3a23069d0913f3e4a240c4679b79d9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f27726bb37c60541f30deef38e652a2160e5025b","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Based on https://github.com/openstack/watcher/blob/57f55190ff4a6e0df06ae2affba5b4f633ef7c48/watcher/applier/actions/migration.py#L122"},{"line_number":17,"context_line":"and"},{"line_number":18,"context_line":"https://github.com/openstack/watcher/blob/57f55190ff4a6e0df06ae2affba5b4f633ef7c48/watcher/common/nova_helper.py#L322,"},{"line_number":19,"context_line":"live_migrate_instance expects destination hostname not uuid."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This cr replaces dest_node uuid to hostname."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d360f84a_a6ba866c","line":19,"updated":"2025-05-01 13:14:19.000000000","message":"correct a better refernce is looking a the comput api refernce docs\n\nhttps://docs.openstack.org/api-ref/compute/#id129\n\nthe value that is being pass is host it not the uuid.\n\nthe host value is not the same as the computer hypervisor_hostname.\n\nso we need to check what is being store in wathcer carfully.","commit_id":"278cb7e98c3a23069d0913f3e4a240c4679b79d9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"511874bf9f3ba34f8da3321099e1118af9d2788a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"03cbae82_2e167415","updated":"2025-05-02 12:54:48.000000000","message":"Fix lgtm, thanks @chkumar@redhat.com","commit_id":"278cb7e98c3a23069d0913f3e4a240c4679b79d9"}],"watcher/decision_engine/strategy/strategies/host_maintenance.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f27726bb37c60541f30deef38e652a2160e5025b","unresolved":true,"context_lines":[{"line_number":195,"context_line":"                  \u0027source_node\u0027: src_node.uuid,"},{"line_number":196,"context_line":"                  \u0027resource_name\u0027: instance.name}"},{"line_number":197,"context_line":"        if des_node:"},{"line_number":198,"context_line":"            params[\u0027destination_node\u0027] \u003d des_node.hostname"},{"line_number":199,"context_line":"        self.solution.add_action(action_type\u003dself.INSTANCE_MIGRATION,"},{"line_number":200,"context_line":"                                 resource_id\u003dinstance.uuid,"},{"line_number":201,"context_line":"                                 input_parameters\u003dparams)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c30c0c2b_f30a3e42","line":198,"updated":"2025-05-01 13:14:19.000000000","message":"so destnode is an instnace of a ComptueNode element\n\nhttps://github.com/openstack/watcher/blob/master/watcher/decision_engine/model/element/node.py#L37\n\nwe are modeling the comptue node with a hostname filed\n\nbut computer node do not have a host name filed they have \n\nhost or hypervior_hostname\n\nthey two value are not required ot be the  same and for ironic they are not the same for example...\n\nif we look at the other field they are actully not part of the ocmptue service repsocne but the hyperviors api. so we need to dig deeper.\n\nwhere we find \n\nhttps://github.com/openstack/watcher/blob/master/watcher/decision_engine/model/collector/nova.py#L368-L426\n\nwe see that this is the comptue service host value\n\n\"hostname\": node.service[\"host\"],\n   \nThat\u0027s problematic because compute node and comptue service are not a 1:1 mapping in Nova and there is a reason why we have do differnt resouce in the api\n\ncompute services and hypervisors (aka compute nodes)\n\nThis is a long way to say the code change is correct but wathcer internal datamodel is not correct.","commit_id":"278cb7e98c3a23069d0913f3e4a240c4679b79d9"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"70cd8d242ca54361226f3b5da19f95a1b2672d5c","unresolved":true,"context_lines":[{"line_number":195,"context_line":"                  \u0027source_node\u0027: src_node.uuid,"},{"line_number":196,"context_line":"                  \u0027resource_name\u0027: instance.name}"},{"line_number":197,"context_line":"        if des_node:"},{"line_number":198,"context_line":"            params[\u0027destination_node\u0027] \u003d des_node.hostname"},{"line_number":199,"context_line":"        self.solution.add_action(action_type\u003dself.INSTANCE_MIGRATION,"},{"line_number":200,"context_line":"                                 resource_id\u003dinstance.uuid,"},{"line_number":201,"context_line":"                                 input_parameters\u003dparams)"}],"source_content_type":"text/x-python","patch_set":2,"id":"10282470_8fb6fd22","line":198,"in_reply_to":"0e662544_9a208347","updated":"2025-05-05 04:41:22.000000000","message":"Thank you Sean for the comment, I will open a bug and we can triage it during the meeting.","commit_id":"278cb7e98c3a23069d0913f3e4a240c4679b79d9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ecaf64b3bfe33c68ec5934f4c3477700f9bd42ab","unresolved":true,"context_lines":[{"line_number":195,"context_line":"                  \u0027source_node\u0027: src_node.uuid,"},{"line_number":196,"context_line":"                  \u0027resource_name\u0027: instance.name}"},{"line_number":197,"context_line":"        if des_node:"},{"line_number":198,"context_line":"            params[\u0027destination_node\u0027] \u003d des_node.hostname"},{"line_number":199,"context_line":"        self.solution.add_action(action_type\u003dself.INSTANCE_MIGRATION,"},{"line_number":200,"context_line":"                                 resource_id\u003dinstance.uuid,"},{"line_number":201,"context_line":"                                 input_parameters\u003dparams)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ccb0f4c8_4c21f767","line":198,"in_reply_to":"10282470_8fb6fd22","updated":"2025-05-06 10:33:29.000000000","message":"im not sure. we would have to review how watcher treats nova instnace that are hosted on vmware or ironic in general.\n\nin the later case live/cold migration is not supproted but in the former case it is.\n\nThe way the two concepts are used interchangeably here suggests that Watcher only supports virt drivers where there is a 1:1 mapping between the compute service and compute node. So, we may just need to initially call that out as a limitation in the docs.","commit_id":"278cb7e98c3a23069d0913f3e4a240c4679b79d9"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"511874bf9f3ba34f8da3321099e1118af9d2788a","unresolved":true,"context_lines":[{"line_number":195,"context_line":"                  \u0027source_node\u0027: src_node.uuid,"},{"line_number":196,"context_line":"                  \u0027resource_name\u0027: instance.name}"},{"line_number":197,"context_line":"        if des_node:"},{"line_number":198,"context_line":"            params[\u0027destination_node\u0027] \u003d des_node.hostname"},{"line_number":199,"context_line":"        self.solution.add_action(action_type\u003dself.INSTANCE_MIGRATION,"},{"line_number":200,"context_line":"                                 resource_id\u003dinstance.uuid,"},{"line_number":201,"context_line":"                                 input_parameters\u003dparams)"}],"source_content_type":"text/x-python","patch_set":2,"id":"0e662544_9a208347","line":198,"in_reply_to":"c30c0c2b_f30a3e42","updated":"2025-05-02 12:54:48.000000000","message":"thanks Sean, do we need to open a bug to track this issue with the modelling? can we hit a bug in future due to it?","commit_id":"278cb7e98c3a23069d0913f3e4a240c4679b79d9"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"79cf3bef5336bef432102846fc742185274840b1","unresolved":true,"context_lines":[{"line_number":195,"context_line":"                  \u0027source_node\u0027: src_node.uuid,"},{"line_number":196,"context_line":"                  \u0027resource_name\u0027: instance.name}"},{"line_number":197,"context_line":"        if des_node:"},{"line_number":198,"context_line":"            params[\u0027destination_node\u0027] \u003d des_node.hostname"},{"line_number":199,"context_line":"        self.solution.add_action(action_type\u003dself.INSTANCE_MIGRATION,"},{"line_number":200,"context_line":"                                 resource_id\u003dinstance.uuid,"},{"line_number":201,"context_line":"                                 input_parameters\u003dparams)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4f7a9085_3d0458c0","line":198,"in_reply_to":"ccb0f4c8_4c21f767","updated":"2025-05-12 06:58:45.000000000","message":"Ack, Make sense! I will include the limitation. May I write like this: `It only supports migrations on Libvirt KVM virt drivers where there is a 1:1 mapping between compute service and compute nodes` ? Thank you!","commit_id":"278cb7e98c3a23069d0913f3e4a240c4679b79d9"}]}