)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"535c88f38ceba144b751efc5d2cbc157dbd03b27","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     jgilaber \u003cjgilaber@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-05-08 14:33:24 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set keystone_client default interface to internal"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Set the default interface for keystone_client to internal in the watcher"},{"line_number":10,"context_line":"conf instead of admin. In addition, in devstack deployments configure it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"b5e9060a_2b6b36e9","line":7,"range":{"start_line":7,"start_character":41,"end_line":7,"end_character":49},"updated":"2025-05-08 16:28:14.000000000","message":"in the end, you moved to public, not internal","commit_id":"98551055ab3a9d48b4e7c87b292d9625f1c11a22"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"94fd4b212b248783040f815f593d0ff6eefb56f2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jgilaber \u003cjgilaber@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-05-08 14:33:24 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set keystone_client default interface to internal"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Set the default interface for keystone_client to internal in the watcher"},{"line_number":10,"context_line":"conf instead of admin. In addition, in devstack deployments configure it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"e1a4bb50_7d2c2f6c","line":7,"range":{"start_line":7,"start_character":41,"end_line":7,"end_character":49},"in_reply_to":"b5e9060a_2b6b36e9","updated":"2025-05-09 06:21:32.000000000","message":"Done","commit_id":"98551055ab3a9d48b4e7c87b292d9625f1c11a22"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"535c88f38ceba144b751efc5d2cbc157dbd03b27","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2025-05-08 14:33:24 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set keystone_client default interface to internal"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Set the default interface for keystone_client to internal in the watcher"},{"line_number":10,"context_line":"conf instead of admin. In addition, in devstack deployments configure it"},{"line_number":11,"context_line":"to use the public insterface instead."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: 2109494"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"a1202695_efb6f1a1","line":11,"range":{"start_line":8,"start_character":0,"end_line":11,"end_character":37},"updated":"2025-05-08 16:28:14.000000000","message":"this also don\u0027t reflect anymore the change. It is default to public, and no devstack change needed.","commit_id":"98551055ab3a9d48b4e7c87b292d9625f1c11a22"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"94fd4b212b248783040f815f593d0ff6eefb56f2","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2025-05-08 14:33:24 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set keystone_client default interface to internal"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Set the default interface for keystone_client to internal in the watcher"},{"line_number":10,"context_line":"conf instead of admin. In addition, in devstack deployments configure it"},{"line_number":11,"context_line":"to use the public insterface instead."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: 2109494"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"c7ffb429_48342a54","line":11,"range":{"start_line":8,"start_character":0,"end_line":11,"end_character":37},"in_reply_to":"a1202695_efb6f1a1","updated":"2025-05-09 06:21:32.000000000","message":"ah yes, I forgot to update the commit message, it\u0027s done now","commit_id":"98551055ab3a9d48b4e7c87b292d9625f1c11a22"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c4df318929ac0d41b009be0e5fce775eca3bb939","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2025-05-08 14:33:24 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set keystone_client default interface to internal"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Set the default interface for keystone_client to internal in the watcher"},{"line_number":10,"context_line":"conf instead of admin. In addition, in devstack deployments configure it"},{"line_number":11,"context_line":"to use the public insterface instead."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: 2109494"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"f1c344e2_79f2ae52","line":11,"range":{"start_line":8,"start_character":0,"end_line":11,"end_character":37},"in_reply_to":"c7ffb429_48342a54","updated":"2025-05-09 11:19:54.000000000","message":"Done","commit_id":"98551055ab3a9d48b4e7c87b292d9625f1c11a22"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5026a7f3df2a90513376a978902c3c6fb674f710","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f19cb234_77678ede","updated":"2025-05-02 12:33:42.000000000","message":"we shoudl do a follow up change to change all the other service to internal too.\n\nfor this change can you add a fixes and upgrade release note \n\nand in the follow up change we will just need a upgrade release note.\ni think we will want to backport this change but not the followup\n\nthe admin endpoint often does not have auth and is only intended for inital bootstrapping of services so i consider this sevear enouch to warrent backporting but aligning all our default to internal for all services is not.","commit_id":"12d72b40d2aa07c04db53e09c3096ebf1afa5f45"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"ccc8730bd4246197aad52a678c89ec0948ec0251","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"28f308e3_c07ebef8","in_reply_to":"b1249de0_7fb07424","updated":"2025-05-02 15:18:14.000000000","message":"I\u0027ve added release notes for the change","commit_id":"12d72b40d2aa07c04db53e09c3096ebf1afa5f45"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0dd13fa7b0f2b89355bd07840088a4526bf1b31d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b1249de0_7fb07424","in_reply_to":"f19cb234_77678ede","updated":"2025-05-02 12:41:53.000000000","message":"i guess we need to think about htis a bit more. please add the fixes release note  for this patch and we shoudl loop back ot normalising things later\n\nthere is a diffent config option that is a preferentially order list of endpoint that comes form keyston auth\n\nperhaps we shoud defer chaing the other for now and consider fi we want to swap to that as part fo replacing all teh client with the openstack sdk","commit_id":"12d72b40d2aa07c04db53e09c3096ebf1afa5f45"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"79413717024dbb5a4317efde2d050d7171e16f6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"89354cbe_9b7ee5b3","updated":"2025-05-08 12:11:04.000000000","message":"The rest of clients are configured to use public by default, see:\n\nhttps://github.com/openstack/watcher/blob/77e7e4ef7b5b0cd29e27b3529fdac4fdc2287d40/watcher/conf/cinder_client.py#L29\n\nhttps://github.com/openstack/watcher/blob/77e7e4ef7b5b0cd29e27b3529fdac4fdc2287d40/watcher/conf/neutron_client.py#L29\n\nhttps://github.com/openstack/watcher/blob/77e7e4ef7b5b0cd29e27b3529fdac4fdc2287d40/watcher/conf/nova_client.py#L40\n\nI\u0027d be consistent with that and would use public  instead of admin.","commit_id":"2a493052559bc80a92665dedc556a5741a1cd4a6"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"b01f661e2b942478f55120842d01c112fd30df49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5aafccde_eeb14570","in_reply_to":"022729af_94cd5ffa","updated":"2025-05-08 12:29:03.000000000","message":"I also think public is aligned to use defaults in devstack...","commit_id":"2a493052559bc80a92665dedc556a5741a1cd4a6"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"bb3a57b36688dfff10af25ccc7f219afb91ab3ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"feaa2a24_8f3d7de5","in_reply_to":"4b7a049b_16c867db","updated":"2025-05-08 14:08:29.000000000","message":"Thanks!","commit_id":"2a493052559bc80a92665dedc556a5741a1cd4a6"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"0b202c32fdffb2c9aa6d5833e559cbc813fe0347","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4b7a049b_16c867db","in_reply_to":"5aafccde_eeb14570","updated":"2025-05-08 12:34:52.000000000","message":"that\u0027s true, I changed it to public, and also removed the devstack config option override, since we can use the new default","commit_id":"2a493052559bc80a92665dedc556a5741a1cd4a6"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"c02b62a981124a00935679555d66fcfa07c8f3e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"022729af_94cd5ffa","in_reply_to":"89354cbe_9b7ee5b3","updated":"2025-05-08 12:17:45.000000000","message":"internal is the default for monasca, I guess that\u0027s why I went with internal as default, but I have no problem using public by default","commit_id":"2a493052559bc80a92665dedc556a5741a1cd4a6"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"ef7b46dcce8d1bd8f5bd8fcbc1d9cd615f81cceb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bfc656a5_76f3547c","updated":"2025-05-13 07:06:26.000000000","message":"check-rdo","commit_id":"ae48f65f206ba9422765add3f936baea1a35cf07"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c4df318929ac0d41b009be0e5fce775eca3bb939","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e2e41800_2026c181","updated":"2025-05-09 11:19:54.000000000","message":"thanks Joan, this looks aligned with the rest of the clients now. Thanks","commit_id":"ae48f65f206ba9422765add3f936baea1a35cf07"}],"devstack/lib/watcher":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0dafbeb6489a481bfef391d11c2fce2dfb8bc2ec","unresolved":true,"context_lines":[{"line_number":169,"context_line":"    configure_keystone_authtoken_middleware $WATCHER_CONF watcher \"watcher_clients_auth\""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    # config keystone client interface"},{"line_number":172,"context_line":"    iniset $WATCHER_CONF keystone_client interface \"public\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    if is_fedora || is_suse; then"},{"line_number":175,"context_line":"        # watcher defaults to /usr/local/bin, but fedora and suse pip like to"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"2ea67f24_eaf9387b","line":172,"updated":"2025-05-02 12:26:54.000000000","message":"why use public here?\nadmin is valid for devstack and its what you shoudl defautl to in production so i think it would be better to remvoe this","commit_id":"12d72b40d2aa07c04db53e09c3096ebf1afa5f45"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"45a155a71a0caf88b3353132984f49b0ceac9d74","unresolved":true,"context_lines":[{"line_number":169,"context_line":"    configure_keystone_authtoken_middleware $WATCHER_CONF watcher \"watcher_clients_auth\""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    # config keystone client interface"},{"line_number":172,"context_line":"    iniset $WATCHER_CONF keystone_client interface \"public\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    if is_fedora || is_suse; then"},{"line_number":175,"context_line":"        # watcher defaults to /usr/local/bin, but fedora and suse pip like to"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"dd5c6952_402bc3f0","line":172,"in_reply_to":"0ad2318b_5748ed9b","updated":"2025-05-02 12:40:02.000000000","message":"use the new default i.e. internal in devstack\n\noh i see\n\nthis is needed beasuse devstack by default only creats the public endpoint\n```\n(.venv) sean@devstack-ui:~/repos/python-openstackclient$ openstack --os-cloud devstack-admin endpoint list\n+----------------------------------+-----------+--------------+----------------+---------+-----------+-------------------------------------------------+\n| ID                               | Region    | Service Name | Service Type   | Enabled | Interface | URL                                             |\n+----------------------------------+-----------+--------------+----------------+---------+-----------+-------------------------------------------------+\n| 0adda2222a2c4e11b4a880787dfaecfe | RegionOne | watcher      | infra-optim    | True    | public    | http://192.168.16.185/infra-optim               |\n| 0e00061f64974b2ea1198d19df0ca125 | RegionOne | nova         | compute        | True    | public    | http://192.168.16.185/compute/v2.1              |\n| 2b01f2c166e0461f9725b2f436562b1b | RegionOne | watcher      | infra-optim    | True    | admin     | http://192.168.16.185/infra-optim               |\n| 41e5e245b0904716ada24db68ab1e7c7 | RegionOne | keystone     | identity       | True    | public    | http://192.168.16.185/identity                  |\n| 62db9e9f03ee48b290883db8a2995849 | RegionOne | cinder       | block-storage  | True    | public    | http://192.168.16.185/volume/v3                 |\n| 6c4c9b5515c7497aabdc34456c3260f8 | RegionOne | glance       | image          | True    | public    | http://192.168.16.185/image                     |\n| 6edad85242dc4dff886a665c7f8538d7 | RegionOne | watcher      | infra-optim    | True    | internal  | http://192.168.16.185/infra-optim               |\n| 7a6e605776b541289d2e159979175092 | RegionOne | nova_legacy  | compute_legacy | True    | public    | http://192.168.16.185/compute/v2/$(project_id)s |\n| 9ab83d0dd296457fa78b52c0ca001361 | RegionOne | aodh         | alarming       | True    | public    | http://192.168.16.185/alarming                  |\n| b273b8fba3f84abb827ea5ae43b9cbe1 | RegionOne | placement    | placement      | True    | public    | http://192.168.16.185/placement                 |\n| f7827a52e3484207bf883d9200d082a7 | RegionOne | neutron      | network        | True    | public    | http://192.168.16.185:9696/networking           |\n+----------------------------------+-----------+--------------+----------------+---------+-----------+-------------------------------------------------+\n\n```\nok then this overried for devstack makes sense.\n\nso we shoudl keep it.","commit_id":"12d72b40d2aa07c04db53e09c3096ebf1afa5f45"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"6f639ded03d7dbf6be0c517dda86ac17bbb1911d","unresolved":true,"context_lines":[{"line_number":169,"context_line":"    configure_keystone_authtoken_middleware $WATCHER_CONF watcher \"watcher_clients_auth\""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    # config keystone client interface"},{"line_number":172,"context_line":"    iniset $WATCHER_CONF keystone_client interface \"public\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    if is_fedora || is_suse; then"},{"line_number":175,"context_line":"        # watcher defaults to /usr/local/bin, but fedora and suse pip like to"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"0ad2318b_5748ed9b","line":172,"in_reply_to":"2ea67f24_eaf9387b","updated":"2025-05-02 12:29:16.000000000","message":"you mean we should use the admin interface in devstack, or use the \u0027internal\u0027 default that this patch sets?","commit_id":"12d72b40d2aa07c04db53e09c3096ebf1afa5f45"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"e97017b7e0d2ad91d7165bf0cd5d030c882cb56e","unresolved":true,"context_lines":[{"line_number":169,"context_line":"    configure_keystone_authtoken_middleware $WATCHER_CONF watcher \"watcher_clients_auth\""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    # config keystone client interface"},{"line_number":172,"context_line":"    iniset $WATCHER_CONF keystone_client interface \"public\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    if is_fedora || is_suse; then"},{"line_number":175,"context_line":"        # watcher defaults to /usr/local/bin, but fedora and suse pip like to"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"f915d326_d722de55","line":172,"in_reply_to":"dd5c6952_402bc3f0","updated":"2025-05-02 12:42:54.000000000","message":"yes, I added it because I didn\u0027t have the internal endpoint in my deployment. That was the next question I was going to ask, as I wasn\u0027t sure if it was an issue with my setup, thanks for confirming. I\u0027ll add the release notes and mark the patch as ready for review","commit_id":"12d72b40d2aa07c04db53e09c3096ebf1afa5f45"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"ccc8730bd4246197aad52a678c89ec0948ec0251","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    configure_keystone_authtoken_middleware $WATCHER_CONF watcher \"watcher_clients_auth\""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    # config keystone client interface"},{"line_number":172,"context_line":"    iniset $WATCHER_CONF keystone_client interface \"public\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    if is_fedora || is_suse; then"},{"line_number":175,"context_line":"        # watcher defaults to /usr/local/bin, but fedora and suse pip like to"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7ed63c7e_2035885e","line":172,"in_reply_to":"f915d326_d722de55","updated":"2025-05-02 15:18:14.000000000","message":"Done","commit_id":"12d72b40d2aa07c04db53e09c3096ebf1afa5f45"}],"watcher/conf/keystone_client.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0dafbeb6489a481bfef391d11c2fce2dfb8bc2ec","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"KEYSTONE_CLIENT_OPTS \u003d ["},{"line_number":23,"context_line":"    cfg.StrOpt(\u0027interface\u0027,"},{"line_number":24,"context_line":"               default\u003d\u0027internal\u0027,"},{"line_number":25,"context_line":"               choices\u003d[\u0027internal\u0027, \u0027public\u0027, \u0027admin\u0027],"},{"line_number":26,"context_line":"               help\u003d\u0027Type of endpoint to use in keystoneclient.\u0027),"},{"line_number":27,"context_line":"    cfg.StrOpt(\u0027region_name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"4fa18592_b36b031c","line":24,"updated":"2025-05-02 12:26:54.000000000","message":"wow, ya that wrong.\nwe should never use the admin interface.","commit_id":"12d72b40d2aa07c04db53e09c3096ebf1afa5f45"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"ccc8730bd4246197aad52a678c89ec0948ec0251","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"KEYSTONE_CLIENT_OPTS \u003d ["},{"line_number":23,"context_line":"    cfg.StrOpt(\u0027interface\u0027,"},{"line_number":24,"context_line":"               default\u003d\u0027internal\u0027,"},{"line_number":25,"context_line":"               choices\u003d[\u0027internal\u0027, \u0027public\u0027, \u0027admin\u0027],"},{"line_number":26,"context_line":"               help\u003d\u0027Type of endpoint to use in keystoneclient.\u0027),"},{"line_number":27,"context_line":"    cfg.StrOpt(\u0027region_name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"c239f228_23a2076e","line":24,"in_reply_to":"4fa18592_b36b031c","updated":"2025-05-02 15:18:14.000000000","message":"should I also remove the \u0027admin\u0027 from the choices below, or should we do that in a follow-up?","commit_id":"12d72b40d2aa07c04db53e09c3096ebf1afa5f45"}]}