)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"2a3daf7a2c844a978a210c3e227e62c117e99608","unresolved":true,"context_lines":[{"line_number":13,"context_line":"by different strategy. If host maintenace use those compute nodes for"},{"line_number":14,"context_line":"migration, It might affect customer workloads."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Host maintenance strategy should never touch disabled hosts."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This cr drops the logic for using disabled compute node for maintenance."},{"line_number":19,"context_line":"Host maintaince is already using nova schedular for migrating the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"85d7d5ee_77ad1637","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":60},"updated":"2025-05-13 18:02:01.000000000","message":"nit: unless the user specify a disable host as backup node.","commit_id":"5c47ec04d92131a0ba79a28ebd03ab78c5b61546"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"10570db41db7f131f011a62a535f919beb516851","unresolved":false,"context_lines":[{"line_number":13,"context_line":"by different strategy. If host maintenace use those compute nodes for"},{"line_number":14,"context_line":"migration, It might affect customer workloads."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Host maintenance strategy should never touch disabled hosts."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This cr drops the logic for using disabled compute node for maintenance."},{"line_number":19,"context_line":"Host maintaince is already using nova schedular for migrating the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"70905676_d89c14a0","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":60},"in_reply_to":"85d7d5ee_77ad1637","updated":"2025-05-14 03:55:32.000000000","message":"Done","commit_id":"5c47ec04d92131a0ba79a28ebd03ab78c5b61546"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"49d3bec91d51720073ef51f4903f5e071d992578","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"734b7356_0c62a78e","updated":"2025-05-07 04:41:54.000000000","message":"recheck","commit_id":"15fe1b695c2d2c1fb40734ac498d84c77d29dd2e"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6a74efef5ea760c14605ca0bb1841d5a831ce3c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2f6be359_78451a0f","updated":"2025-05-07 11:18:29.000000000","message":"still reviewing the code, but we are missing a release notes here, explaining the what we are fixing.","commit_id":"15fe1b695c2d2c1fb40734ac498d84c77d29dd2e"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a52aa7e1d307a5779df38b5b7c251309d1ec1124","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d78c2731_96023791","updated":"2025-05-07 11:18:42.000000000","message":"updating vote","commit_id":"15fe1b695c2d2c1fb40734ac498d84c77d29dd2e"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"da6bbe372aaab4f2f2652bc0f41cf98e5ccaaf41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9da0db82_adef8f9d","in_reply_to":"2f6be359_78451a0f","updated":"2025-05-07 15:05:42.000000000","message":"Added.","commit_id":"15fe1b695c2d2c1fb40734ac498d84c77d29dd2e"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"2a3daf7a2c844a978a210c3e227e62c117e99608","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"120543db_ee75083f","updated":"2025-05-13 18:02:01.000000000","message":"lgtm, most comments are nits\nthanks Chandan","commit_id":"5c47ec04d92131a0ba79a28ebd03ab78c5b61546"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"93aeef118343c70d7c56ea8d773fb376edd73c93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2cdc3ea3_34a07849","updated":"2025-05-16 17:42:48.000000000","message":"LGTM, thanks for updating the release notes.","commit_id":"9dea55bd64faf66e4de4c3220d8581683db0bf7c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"96d9738571ec0c13315623d8bef401c3c3923bd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ccbf86e3_034b0e90","updated":"2025-05-14 11:27:35.000000000","message":"OK lets proceed with this in its current form\n\nwe can revisit if/how we want to disable host that we enable and if that is something we shoudl do separately.\n\ni think this is a good improvement as is and its better to not increase the scope of this patch.","commit_id":"9dea55bd64faf66e4de4c3220d8581683db0bf7c"}],"releasenotes/notes/donot-run-host-migration-strategy-on-disabled-hosts-24084a22d4c8f914.yaml":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"2a3daf7a2c844a978a210c3e227e62c117e99608","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Host maintenance strategy should migrate vms based on backup node if specified"},{"line_number":5,"context_line":"    or rely on nova scheduler. It was enabling disabled hosts with watcher_disabled"},{"line_number":6,"context_line":"    reason and migrating vm to those nodes. It can impact customer workload. Compute"},{"line_number":7,"context_line":"    nodes were disabled for reason."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"83e93ffe_1b9d0df0","line":4,"range":{"start_line":4,"start_character":45,"end_line":4,"end_character":48},"updated":"2025-05-13 18:02:01.000000000","message":"nit: servers (I personally think that is better)","commit_id":"5c47ec04d92131a0ba79a28ebd03ab78c5b61546"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"10570db41db7f131f011a62a535f919beb516851","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Host maintenance strategy should migrate vms based on backup node if specified"},{"line_number":5,"context_line":"    or rely on nova scheduler. It was enabling disabled hosts with watcher_disabled"},{"line_number":6,"context_line":"    reason and migrating vm to those nodes. It can impact customer workload. Compute"},{"line_number":7,"context_line":"    nodes were disabled for reason."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7dd7bf9a_19c9023f","line":4,"range":{"start_line":4,"start_character":45,"end_line":4,"end_character":48},"in_reply_to":"83e93ffe_1b9d0df0","updated":"2025-05-14 03:55:32.000000000","message":"Done","commit_id":"5c47ec04d92131a0ba79a28ebd03ab78c5b61546"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"2a3daf7a2c844a978a210c3e227e62c117e99608","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Host maintenance strategy should migrate vms based on backup node if specified"},{"line_number":5,"context_line":"    or rely on nova scheduler. It was enabling disabled hosts with watcher_disabled"},{"line_number":6,"context_line":"    reason and migrating vm to those nodes. It can impact customer workload. Compute"},{"line_number":7,"context_line":"    nodes were disabled for reason."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    Host maintenance strategy is fixed now to support migrating servers only on backup"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d5696aa4_12153978","line":6,"range":{"start_line":6,"start_character":25,"end_line":6,"end_character":27},"updated":"2025-05-13 18:02:01.000000000","message":"nit: servers","commit_id":"5c47ec04d92131a0ba79a28ebd03ab78c5b61546"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"10570db41db7f131f011a62a535f919beb516851","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Host maintenance strategy should migrate vms based on backup node if specified"},{"line_number":5,"context_line":"    or rely on nova scheduler. It was enabling disabled hosts with watcher_disabled"},{"line_number":6,"context_line":"    reason and migrating vm to those nodes. It can impact customer workload. Compute"},{"line_number":7,"context_line":"    nodes were disabled for reason."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    Host maintenance strategy is fixed now to support migrating servers only on backup"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"64457c92_32f5b873","line":6,"range":{"start_line":6,"start_character":25,"end_line":6,"end_character":27},"in_reply_to":"d5696aa4_12153978","updated":"2025-05-14 03:55:32.000000000","message":"Done","commit_id":"5c47ec04d92131a0ba79a28ebd03ab78c5b61546"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"2a3daf7a2c844a978a210c3e227e62c117e99608","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Host maintenance strategy should migrate vms based on backup node if specified"},{"line_number":5,"context_line":"    or rely on nova scheduler. It was enabling disabled hosts with watcher_disabled"},{"line_number":6,"context_line":"    reason and migrating vm to those nodes. It can impact customer workload. Compute"},{"line_number":7,"context_line":"    nodes were disabled for reason."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    Host maintenance strategy is fixed now to support migrating servers only on backup"},{"line_number":10,"context_line":"    node or rely on nova scheduler if no backup node is provided."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e7501458_f1977768","line":7,"range":{"start_line":7,"start_character":28,"end_line":7,"end_character":34},"updated":"2025-05-13 18:02:01.000000000","message":"nit: a reason","commit_id":"5c47ec04d92131a0ba79a28ebd03ab78c5b61546"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"10570db41db7f131f011a62a535f919beb516851","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Host maintenance strategy should migrate vms based on backup node if specified"},{"line_number":5,"context_line":"    or rely on nova scheduler. It was enabling disabled hosts with watcher_disabled"},{"line_number":6,"context_line":"    reason and migrating vm to those nodes. It can impact customer workload. Compute"},{"line_number":7,"context_line":"    nodes were disabled for reason."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    Host maintenance strategy is fixed now to support migrating servers only on backup"},{"line_number":10,"context_line":"    node or rely on nova scheduler if no backup node is provided."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7c01bd2a_11d86767","line":7,"range":{"start_line":7,"start_character":28,"end_line":7,"end_character":34},"in_reply_to":"e7501458_f1977768","updated":"2025-05-14 03:55:32.000000000","message":"Done","commit_id":"5c47ec04d92131a0ba79a28ebd03ab78c5b61546"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"2a3daf7a2c844a978a210c3e227e62c117e99608","unresolved":true,"context_lines":[{"line_number":6,"context_line":"    reason and migrating vm to those nodes. It can impact customer workload. Compute"},{"line_number":7,"context_line":"    nodes were disabled for reason."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    Host maintenance strategy is fixed now to support migrating servers only on backup"},{"line_number":10,"context_line":"    node or rely on nova scheduler if no backup node is provided."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4d228bd4_a41f16e6","line":9,"range":{"start_line":9,"start_character":64,"end_line":9,"end_character":71},"updated":"2025-05-13 18:02:01.000000000","message":"here we have \u0027servers\u0027 :)","commit_id":"5c47ec04d92131a0ba79a28ebd03ab78c5b61546"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"10570db41db7f131f011a62a535f919beb516851","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    reason and migrating vm to those nodes. It can impact customer workload. Compute"},{"line_number":7,"context_line":"    nodes were disabled for reason."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    Host maintenance strategy is fixed now to support migrating servers only on backup"},{"line_number":10,"context_line":"    node or rely on nova scheduler if no backup node is provided."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5d192f05_54d1e71f","line":9,"range":{"start_line":9,"start_character":64,"end_line":9,"end_character":71},"in_reply_to":"4d228bd4_a41f16e6","updated":"2025-05-14 03:55:32.000000000","message":"Acknowledged","commit_id":"5c47ec04d92131a0ba79a28ebd03ab78c5b61546"}],"watcher/decision_engine/strategy/strategies/host_maintenance.py":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"509eeab962dc5ffe5c9347711f16f8f0861ab7be","unresolved":true,"context_lines":[{"line_number":228,"context_line":"        # all instances from the maintaining node to the backup node."},{"line_number":229,"context_line":"        if backup_node:"},{"line_number":230,"context_line":"            if self.host_fits(maintenance_node, backup_node):"},{"line_number":231,"context_line":"                self.enable_compute_node_if_disabled(backup_node)"},{"line_number":232,"context_line":"                self.add_action_maintain_compute_node(maintenance_node)"},{"line_number":233,"context_line":"                self.host_migration(maintenance_node, backup_node)"},{"line_number":234,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"44c5a0d0_98eab92e","side":"PARENT","line":231,"range":{"start_line":231,"start_character":0,"end_line":231,"end_character":2},"updated":"2025-05-08 14:17:18.000000000","message":"iiuc, here, in case a compute node is specified as backup_node and it is disabled for any reason, it will enable it. Do we want to maintain this behavior or it the audit should fail in this case?","commit_id":"77e7e4ef7b5b0cd29e27b3529fdac4fdc2287d40"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"cc1b09b7c00fa8002a6745d3484ada37da74a3ff","unresolved":true,"context_lines":[{"line_number":228,"context_line":"        # all instances from the maintaining node to the backup node."},{"line_number":229,"context_line":"        if backup_node:"},{"line_number":230,"context_line":"            if self.host_fits(maintenance_node, backup_node):"},{"line_number":231,"context_line":"                self.enable_compute_node_if_disabled(backup_node)"},{"line_number":232,"context_line":"                self.add_action_maintain_compute_node(maintenance_node)"},{"line_number":233,"context_line":"                self.host_migration(maintenance_node, backup_node)"},{"line_number":234,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"8b4c4cdd_dc64194d","side":"PARENT","line":231,"range":{"start_line":231,"start_character":0,"end_line":231,"end_character":2},"in_reply_to":"334e746f_d653b3ea","updated":"2025-05-12 06:36:35.000000000","message":"That would be a wondeful improvement to restore the node back once migration is done. thank you @seanmooney8202@yahoo.ie @amoralej@redhat.com, I will send a seperate cr for the same. I am not sure about context manager(Since we are going to restore it one time once migration is done). But I would another method to disable compute node. What do you say?","commit_id":"77e7e4ef7b5b0cd29e27b3529fdac4fdc2287d40"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"28706accf7af04919bcdb4bcc0bb7159c0738157","unresolved":true,"context_lines":[{"line_number":228,"context_line":"        # all instances from the maintaining node to the backup node."},{"line_number":229,"context_line":"        if backup_node:"},{"line_number":230,"context_line":"            if self.host_fits(maintenance_node, backup_node):"},{"line_number":231,"context_line":"                self.enable_compute_node_if_disabled(backup_node)"},{"line_number":232,"context_line":"                self.add_action_maintain_compute_node(maintenance_node)"},{"line_number":233,"context_line":"                self.host_migration(maintenance_node, backup_node)"},{"line_number":234,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"cbed8eaf_5e08e65c","side":"PARENT","line":231,"range":{"start_line":231,"start_character":0,"end_line":231,"end_character":2},"in_reply_to":"44c5a0d0_98eab92e","updated":"2025-05-08 14:39:43.000000000","message":"Yes, I think we should keep this behaviour(to enable the backup node) as user might be aware about that backup node is disabled and they are going to use it for migration.","commit_id":"77e7e4ef7b5b0cd29e27b3529fdac4fdc2287d40"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"2a3daf7a2c844a978a210c3e227e62c117e99608","unresolved":true,"context_lines":[{"line_number":228,"context_line":"        # all instances from the maintaining node to the backup node."},{"line_number":229,"context_line":"        if backup_node:"},{"line_number":230,"context_line":"            if self.host_fits(maintenance_node, backup_node):"},{"line_number":231,"context_line":"                self.enable_compute_node_if_disabled(backup_node)"},{"line_number":232,"context_line":"                self.add_action_maintain_compute_node(maintenance_node)"},{"line_number":233,"context_line":"                self.host_migration(maintenance_node, backup_node)"},{"line_number":234,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"9738ac08_065b95e9","side":"PARENT","line":231,"range":{"start_line":231,"start_character":0,"end_line":231,"end_character":2},"in_reply_to":"8b4c4cdd_dc64194d","updated":"2025-05-13 18:02:01.000000000","message":"yeah, it a good point, to include a last action to disable it again. We can discuss more about, and if it should be configurable or not.","commit_id":"77e7e4ef7b5b0cd29e27b3529fdac4fdc2287d40"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"6451a5d1b54d0380159113f707a4c955940fc0d3","unresolved":true,"context_lines":[{"line_number":228,"context_line":"        # all instances from the maintaining node to the backup node."},{"line_number":229,"context_line":"        if backup_node:"},{"line_number":230,"context_line":"            if self.host_fits(maintenance_node, backup_node):"},{"line_number":231,"context_line":"                self.enable_compute_node_if_disabled(backup_node)"},{"line_number":232,"context_line":"                self.add_action_maintain_compute_node(maintenance_node)"},{"line_number":233,"context_line":"                self.host_migration(maintenance_node, backup_node)"},{"line_number":234,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"eca0ae2d_75393673","side":"PARENT","line":231,"range":{"start_line":231,"start_character":0,"end_line":231,"end_character":2},"in_reply_to":"9738ac08_065b95e9","updated":"2025-05-14 09:51:50.000000000","message":"works for me.","commit_id":"77e7e4ef7b5b0cd29e27b3529fdac4fdc2287d40"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9f6db24832ebea566ed5544cbe4ace49b9b7b748","unresolved":true,"context_lines":[{"line_number":228,"context_line":"        # all instances from the maintaining node to the backup node."},{"line_number":229,"context_line":"        if backup_node:"},{"line_number":230,"context_line":"            if self.host_fits(maintenance_node, backup_node):"},{"line_number":231,"context_line":"                self.enable_compute_node_if_disabled(backup_node)"},{"line_number":232,"context_line":"                self.add_action_maintain_compute_node(maintenance_node)"},{"line_number":233,"context_line":"                self.host_migration(maintenance_node, backup_node)"},{"line_number":234,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"334e746f_d653b3ea","side":"PARENT","line":231,"range":{"start_line":231,"start_character":0,"end_line":231,"end_character":2},"in_reply_to":"cbed8eaf_5e08e65c","updated":"2025-05-08 22:12:48.000000000","message":"Both are valid, I think we should keep the current behavior to minimize the upgrade impact.\n\nThe real question i have is shoudl we turn this into a context manager that will disable it again when we leave this scope.\n\ni feel like if watcher enables a comptue in operations like this, its should restore the state after its done, but i also think that should be a separate commit if we decied to make that change.\n\nim also unsure if that should be configurable.","commit_id":"77e7e4ef7b5b0cd29e27b3529fdac4fdc2287d40"}]}