)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"7910f94528f20bdab3f138363daca4a0215e3236","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"505de035_874b1448","updated":"2025-05-09 14:53:42.000000000","message":"Thanks for your reviews!","commit_id":"417220059d89e0a489ac786c55ebf6d1a5c0f2d0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2b15dfe36179efb4eee4e93074e7811aa84f6d84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"28d12342_c4a2c361","updated":"2025-05-09 13:28:24.000000000","message":"lets leave this open for a week or two to see if we get any input form mailing list thread. +1 over all but i think we should move where we log.\n\nsee comemnt inline.\nim not sure if we want to use debtcollertor but that is how we are ment to deprecate things consitently in openstack so it proably some thing we shoudl consider.","commit_id":"417220059d89e0a489ac786c55ebf6d1a5c0f2d0"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"754baa2487dd8a0604e982d31494af371b65e8e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"203b6a2a_860d2d9f","updated":"2025-05-08 12:12:42.000000000","message":"lgtm, thanks Doug, do we need anything else to deprecate it? Announce it in the mailing list or similar?","commit_id":"417220059d89e0a489ac786c55ebf6d1a5c0f2d0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1f68801379c9c8b7cae8a726d8f9614bf05e60bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"98db1fab_49e6b376","updated":"2025-05-12 19:04:33.000000000","message":"one question inline but i think this is OK as is.","commit_id":"17d1cf535a93931856d7ee8cf234dbd21e5a271d"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"c5ece1070777c546bd4ed544eb6e8ff08b3376d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1bb52ab3_4c808c8b","updated":"2025-05-12 21:01:04.000000000","message":"recheck\n\ntest_execute_workload_stabilization_strategy failed, maybe due to [1] metrics were not properly injected, and no migration was proposed as part of the action plan. Requires more investigation.\n\n[1] https://bugs.launchpad.net/watcher-tempest-plugin/+bug/2090854","commit_id":"17d1cf535a93931856d7ee8cf234dbd21e5a271d"}],"watcher/decision_engine/strategy/context/default.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2b15dfe36179efb4eee4e93074e7811aa84f6d84","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        selected_strategy.audit_scope \u003d audit.scope"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if selected_strategy.get_name() \u003d\u003d \u0027noisy_neighbor\u0027:"},{"line_number":61,"context_line":"            LOG.warning(\u0027The noisy_neighbor strategy is deprecated and will \u0027"},{"line_number":62,"context_line":"                        \u0027be removed in a future release.\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        schema \u003d selected_strategy.get_schema()"},{"line_number":65,"context_line":"        if not audit.parameters and schema:"},{"line_number":66,"context_line":"            # Default value feedback if no predefined strategy"}],"source_content_type":"text/x-python","patch_set":2,"id":"232c48da_7823f502","line":63,"range":{"start_line":61,"start_character":11,"end_line":63,"end_character":1},"updated":"2025-05-09 13:28:24.000000000","message":"this is accpatble but i think its in the wrong place. it should be in teh sragy iteself.\n\n\n\nwe could also consider using debtcollector\u0027s removed decorator\n\nhttps://github.com/openstack/debtcollector/blob/master/debtcollector/removals.py#L162\nor we coudl use the remove class verion of it\n\nin either case we would set version to 2025.2 and removal_version set to 2026.2\n\ni woudl alos not do this her but on https://github.com/openstack/watcher/blob/master/watcher/decision_engine/strategy/strategies/noisy_neighbor.py#L29\n\nor on \n\nhttps://github.com/openstack/watcher/blob/master/watcher/decision_engine/strategy/strategies/noisy_neighbor.py#L228\n\n\nthat allows use to set the fitler ot once \n\nhttps://opendev.org/openstack/watcher-tempest-plugin/src/branch/master/watcher_tempest_plugin/tests/client_functional/__init__.py#L19\n\n\nim not sure if we want to have it log once per start up of the agen on on evy use of the polcy.\n\n\ni guess, based on our knowlsge of the fact that the data required to make this to work was remvoed form nvoa because the interface nova/libvirt had was remvoed form the kernel\n\nwe expect that this does nto work on any real deployment today.\n\ncertenly not one theat is usign master content.\n\nand if that is the case we would not ever expect this to print.\n\nso perhaps with that context priting on every execution is fine but and we can keep it sime with just a directly log but we should move it to here\n\nhttps://github.com/openstack/watcher/blob/master/watcher/decision_engine/strategy/strategies/noisy_neighbor.py#L229\n\nin my opipion.","commit_id":"417220059d89e0a489ac786c55ebf6d1a5c0f2d0"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"7910f94528f20bdab3f138363daca4a0215e3236","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        selected_strategy.audit_scope \u003d audit.scope"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if selected_strategy.get_name() \u003d\u003d \u0027noisy_neighbor\u0027:"},{"line_number":61,"context_line":"            LOG.warning(\u0027The noisy_neighbor strategy is deprecated and will \u0027"},{"line_number":62,"context_line":"                        \u0027be removed in a future release.\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        schema \u003d selected_strategy.get_schema()"},{"line_number":65,"context_line":"        if not audit.parameters and schema:"},{"line_number":66,"context_line":"            # Default value feedback if no predefined strategy"}],"source_content_type":"text/x-python","patch_set":2,"id":"4c278933_9f6dddd5","line":63,"range":{"start_line":61,"start_character":11,"end_line":63,"end_character":1},"in_reply_to":"232c48da_7823f502","updated":"2025-05-09 14:53:42.000000000","message":"yeah, I originally thought on setting it to the strategy itself, it would be easier to remove the warning message together with the strategy code.\nIn the end, I put it here since was the first place that the deprecated strategy is referenced.\nbut I have no preference, we can move to the strategy class yeah.\nWRT to debtcollector, I don\u0027t see many advantages vs a warning message. Maybe it would be easier to grep all deprecations..?","commit_id":"417220059d89e0a489ac786c55ebf6d1a5c0f2d0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f0b704018431315864e683f61fed6cb8b153fb22","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        selected_strategy.audit_scope \u003d audit.scope"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if selected_strategy.get_name() \u003d\u003d \u0027noisy_neighbor\u0027:"},{"line_number":61,"context_line":"            LOG.warning(\u0027The noisy_neighbor strategy is deprecated and will \u0027"},{"line_number":62,"context_line":"                        \u0027be removed in a future release.\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        schema \u003d selected_strategy.get_schema()"},{"line_number":65,"context_line":"        if not audit.parameters and schema:"},{"line_number":66,"context_line":"            # Default value feedback if no predefined strategy"}],"source_content_type":"text/x-python","patch_set":2,"id":"13d922af_4d5c505d","line":63,"range":{"start_line":61,"start_character":11,"end_line":63,"end_character":1},"in_reply_to":"3820b65b_7c767cd3","updated":"2025-05-09 15:32:28.000000000","message":"yep its more grepable and the message is formated in a way that its eser to filter out in the logs if you dont care.\n\nbut either works.","commit_id":"417220059d89e0a489ac786c55ebf6d1a5c0f2d0"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"717884ee3a723e0be9d7153a0bc4004e59b8fe6a","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        selected_strategy.audit_scope \u003d audit.scope"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if selected_strategy.get_name() \u003d\u003d \u0027noisy_neighbor\u0027:"},{"line_number":61,"context_line":"            LOG.warning(\u0027The noisy_neighbor strategy is deprecated and will \u0027"},{"line_number":62,"context_line":"                        \u0027be removed in a future release.\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        schema \u003d selected_strategy.get_schema()"},{"line_number":65,"context_line":"        if not audit.parameters and schema:"},{"line_number":66,"context_line":"            # Default value feedback if no predefined strategy"}],"source_content_type":"text/x-python","patch_set":2,"id":"3820b65b_7c767cd3","line":63,"range":{"start_line":61,"start_character":11,"end_line":63,"end_character":1},"in_reply_to":"4c278933_9f6dddd5","updated":"2025-05-09 14:56:37.000000000","message":"As we go through the code and testing, we identify more and more broken/unmaintained code that we should deprecate. So maybe debtcollector removal would assist us on tracking these..","commit_id":"417220059d89e0a489ac786c55ebf6d1a5c0f2d0"}],"watcher/decision_engine/strategy/strategies/noisy_neighbor.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1f68801379c9c8b7cae8a726d8f9614bf05e60bd","unresolved":true,"context_lines":[{"line_number":27,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":28,"context_line":"CONF \u003d cfg.CONF"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"warnings.simplefilter(\u0027always\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@removals.removed_class(\"NoisyNeighbor\", version\u003d\"2025.2\","}],"source_content_type":"text/x-python","patch_set":3,"id":"5c9f6822_2072539a","line":30,"range":{"start_line":30,"start_character":23,"end_line":30,"end_character":30},"updated":"2025-05-12 19:04:33.000000000","message":"do we really want always or should this be once?","commit_id":"17d1cf535a93931856d7ee8cf234dbd21e5a271d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8a39a3b35d1f9f59a67f08571c36aaebeee272d3","unresolved":true,"context_lines":[{"line_number":27,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":28,"context_line":"CONF \u003d cfg.CONF"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"warnings.simplefilter(\u0027always\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@removals.removed_class(\"NoisyNeighbor\", version\u003d\"2025.2\","}],"source_content_type":"text/x-python","patch_set":3,"id":"bc47351b_5c231fdb","line":30,"range":{"start_line":30,"start_character":23,"end_line":30,"end_character":30},"in_reply_to":"585bc3b4_eaf736c9","updated":"2025-05-12 23:28:58.000000000","message":"That\u0027s fair.\n\nin nova i think we silanced those eventlet warning in the test code althoug i dont recall if we filter them in production as well. we may consider doing the same for watcher.","commit_id":"17d1cf535a93931856d7ee8cf234dbd21e5a271d"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"378abd19632ff0fa41736aede3a3a6a8898e59c4","unresolved":true,"context_lines":[{"line_number":27,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":28,"context_line":"CONF \u003d cfg.CONF"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"warnings.simplefilter(\u0027always\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@removals.removed_class(\"NoisyNeighbor\", version\u003d\"2025.2\","}],"source_content_type":"text/x-python","patch_set":3,"id":"585bc3b4_eaf736c9","line":30,"range":{"start_line":30,"start_character":23,"end_line":30,"end_character":30},"in_reply_to":"5c9f6822_2072539a","updated":"2025-05-12 19:30:52.000000000","message":"I personally think that is better to set \u0027always\u0027. As for today, its almost get lost in the middle of so many other eventlet deprecation warnings XD","commit_id":"17d1cf535a93931856d7ee8cf234dbd21e5a271d"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"0280a71a4ced035c755b10605ecb4617dcd14d53","unresolved":true,"context_lines":[{"line_number":30,"context_line":"warnings.simplefilter(\u0027always\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@removals.removed_class(\"NoisyNeighbor\", version\u003d\"2025.2\","},{"line_number":34,"context_line":"                        removal_version\u003d\"2026.2\")"},{"line_number":35,"context_line":"class NoisyNeighbor(base.NoisyNeighborBaseStrategy):"},{"line_number":36,"context_line":"    \"\"\"Noisy Neighbor strategy using live migration"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"4c8c0b93_fce1d623","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":49},"updated":"2025-05-12 18:45:52.000000000","message":"Message:\n\nDeprecationWarning: Using class \u0027NoisyNeighbor\u0027 (either directly or via inheritance) is deprecated in version \u00272025.2\u0027 and will be removed in version \u00272026.2\u0027","commit_id":"17d1cf535a93931856d7ee8cf234dbd21e5a271d"}]}