)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"99605f786a15ef38ffe8d6b7eb6fdcad11ad5a3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"991ec271_74c1c950","updated":"2025-05-16 17:40:40.000000000","message":"LGTM, thanks Joan!","commit_id":"322c89d9820e2f2ee153eb56d8e2068506f6f309"}],"watcher/tests/db/test_migrations.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5af93e70066d96d632a7437241c0fba7118fa4f","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        metadata.reflect(bind\u003dself.engine)"},{"line_number":121,"context_line":"        eff_ind_table \u003d sqlalchemy.Table(\u0027efficacy_indicators\u0027, metadata)"},{"line_number":122,"context_line":"        connection.execute(eff_ind_table.insert(), eff_ind_values)"},{"line_number":123,"context_line":"        connection.commit()"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def _pre_upgrade_15f7375ca737(self, connection):"},{"line_number":126,"context_line":"        \"\"\"Add data to the database before applying the 15f7375ca737 revision."}],"source_content_type":"text/x-python","patch_set":2,"id":"7f957d5d_3d387cf2","side":"PARENT","line":123,"updated":"2025-05-16 10:38:29.000000000","message":"as an aside even in test code we proably should avoid direct commits of tansaction unless its explictly needed by the test case.\n\nsticking with the same transaction context mnagers in teh tesst will be less error prone.","commit_id":"fd3d8b67ffbd7b89b6a84f5f17cb4d5890c1bb29"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"dbe0f8cd07a78c9b6b6f81e8e945c367b644657b","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        metadata.reflect(bind\u003dself.engine)"},{"line_number":121,"context_line":"        eff_ind_table \u003d sqlalchemy.Table(\u0027efficacy_indicators\u0027, metadata)"},{"line_number":122,"context_line":"        connection.execute(eff_ind_table.insert(), eff_ind_values)"},{"line_number":123,"context_line":"        connection.commit()"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def _pre_upgrade_15f7375ca737(self, connection):"},{"line_number":126,"context_line":"        \"\"\"Add data to the database before applying the 15f7375ca737 revision."}],"source_content_type":"text/x-python","patch_set":2,"id":"871ca140_dafd1c47","side":"PARENT","line":123,"in_reply_to":"7f957d5d_3d387cf2","updated":"2025-05-16 10:44:01.000000000","message":"yep, this was definitely a beginner mistake on my part 😊, I think the current version introduced should be correct, but feedback is always wellcome","commit_id":"fd3d8b67ffbd7b89b6a84f5f17cb4d5890c1bb29"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5af93e70066d96d632a7437241c0fba7118fa4f","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                sqlalchemy.select(eff_ind_table.c.data).where("},{"line_number":133,"context_line":"                    eff_ind_table.c.id \u003d\u003d id"},{"line_number":134,"context_line":"                    )"},{"line_number":135,"context_line":"                ).one()"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def _pre_upgrade_15f7375ca737(self, connection):"},{"line_number":138,"context_line":"        \"\"\"Add data to the database before applying the 15f7375ca737 revision."}],"source_content_type":"text/x-python","patch_set":2,"id":"21a42daa_b9d605fc","line":135,"updated":"2025-05-16 10:38:29.000000000","message":"ack so your addign this so we can exiplicity bypas our normal load logic so you can direclty check the value before and after.\n\n+1","commit_id":"322c89d9820e2f2ee153eb56d8e2068506f6f309"}]}