)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"dc2e8306ab6653f15ddf22518278d60293f6a18b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"db51d023_9078fc88","updated":"2025-05-27 18:33:29.000000000","message":"LGTM, thanks Alfredo","commit_id":"891119470cefd76d2b7f0f9d683eb8e94ff5c8db"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"099136b1a2dc71dd3e3ab91467e7845fcedc0b94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e2ec0ffe_60438b18","updated":"2025-05-16 09:08:00.000000000","message":"lgtm, the test should reproduce the bug","commit_id":"891119470cefd76d2b7f0f9d683eb8e94ff5c8db"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"47f5a0876e8e27b028352f58c5fb45109cce1f7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6a17ca3e_9923f555","updated":"2025-05-26 15:56:41.000000000","message":"you have removed the two comment in the next patch but please try and follow the normal convetisonz\n\n\ni.e. using TODO,FIXME,NOTE followed by your name encosed in perens and then a : \nin some repos we have a hacking check to enforce this style.\ni proably should look into enableing that in the future but\n\nsince the comemtn are removed in teh next commit that is fine\n\nyou can also add unnamed commente in line but if your goign to add yoru name use one of TODO FIXME or NOTE\n\nthe diffent between FIXME and TODO is we use FIXME when the following code is incorrect and TODO when its correct but not ideal.\n\ni.e. when you are asserting the incorrect beahivor because of a bug we add FIXME\n\nif something can be optimised later we would add a TODO.\n\nyoou could have both of the comment in line as a FIXME or TODO technially but i used FIXME to call out the incorrect assert that is repoducing the bug\nand TODO for the work we shoudl do when its fixed.\n\nwe ideally shoudl not have FIXME comments long term in teh codebase where as TODO commenst are jut possibel improvment and can be there for a protracted peroid of time.","commit_id":"891119470cefd76d2b7f0f9d683eb8e94ff5c8db"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"dc2e8306ab6653f15ddf22518278d60293f6a18b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"765abf4d_509ce342","in_reply_to":"6a17ca3e_9923f555","updated":"2025-05-27 18:33:29.000000000","message":"+1","commit_id":"891119470cefd76d2b7f0f9d683eb8e94ff5c8db"}],"watcher/tests/api/v1/test_audits.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"47f5a0876e8e27b028352f58c5fb45109cce1f7e","unresolved":true,"context_lines":[{"line_number":843,"context_line":"            del audit_dict[k]"},{"line_number":844,"context_line":""},{"line_number":845,"context_line":"        response \u003d self.post_json(\u0027/audits\u0027, audit_dict, expect_errors\u003dTrue)"},{"line_number":846,"context_line":"        # (amoralej) This should return HTTPStatus.BAD_REQUEST, however this"},{"line_number":847,"context_line":"        # review is adding the test to show wrong code is returned. I will"},{"line_number":848,"context_line":"        # switch this to be HTTPStatus.BAD_REQUEST in the fixing review."},{"line_number":849,"context_line":"        self.assertEqual(HTTPStatus.INTERNAL_SERVER_ERROR, response.status_int)"}],"source_content_type":"text/x-python","patch_set":1,"id":"24603b0d_cc73e325","line":846,"range":{"start_line":846,"start_character":7,"end_line":846,"end_character":20},"updated":"2025-05-26 15:56:41.000000000","message":"```suggestion\n        # FIXME(amoralej): This should return HTTPStatus.BAD_REQUEST, however this\n```","commit_id":"891119470cefd76d2b7f0f9d683eb8e94ff5c8db"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"47f5a0876e8e27b028352f58c5fb45109cce1f7e","unresolved":true,"context_lines":[{"line_number":848,"context_line":"        # switch this to be HTTPStatus.BAD_REQUEST in the fixing review."},{"line_number":849,"context_line":"        self.assertEqual(HTTPStatus.INTERNAL_SERVER_ERROR, response.status_int)"},{"line_number":850,"context_line":"        self.assertEqual(\"application/json\", response.content_type)"},{"line_number":851,"context_line":"        # (amoralej) uncomment with the fix"},{"line_number":852,"context_line":"        # expected_error_msg \u003d ("},{"line_number":853,"context_line":"        #    \"Invalid parameters for strategy: \u0027fake1\u0027 is a required property\")"},{"line_number":854,"context_line":"        # self.assertTrue(response.json[\u0027error_message\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"2f0da529_f7252214","line":851,"updated":"2025-05-26 15:56:41.000000000","message":"```suggestion\n        # TODO(amoralej): uncomment with the fix\n```","commit_id":"891119470cefd76d2b7f0f9d683eb8e94ff5c8db"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"c77a572751307757bef02c53ea1036104d1bb7fd","unresolved":true,"context_lines":[{"line_number":865,"context_line":"                    \"maximum\": 10.2,"},{"line_number":866,"context_line":"                }"},{"line_number":867,"context_line":"            },"},{"line_number":868,"context_line":"            \u0027required\u0027: [\u0027fake1\u0027]"},{"line_number":869,"context_line":"        }"},{"line_number":870,"context_line":"        template_uuid \u003d \u0027e74c40e0-d825-11e2-a28f-0800200c9a67\u0027"},{"line_number":871,"context_line":"        strategy_uuid \u003d \u0027e74c40e0-d825-11e2-a28f-0800200c9a68\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"d95dd657_9a833768","line":868,"updated":"2025-05-15 11:13:25.000000000","message":"what is the reason behind this change in this test? Is it because we do not have any test checking a spec with a required field? If so I think it might be better to add a new test for it","commit_id":"891119470cefd76d2b7f0f9d683eb8e94ff5c8db"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"80816876cfe41e670f4f954294a2b39ee73aa4d7","unresolved":true,"context_lines":[{"line_number":865,"context_line":"                    \"maximum\": 10.2,"},{"line_number":866,"context_line":"                }"},{"line_number":867,"context_line":"            },"},{"line_number":868,"context_line":"            \u0027required\u0027: [\u0027fake1\u0027]"},{"line_number":869,"context_line":"        }"},{"line_number":870,"context_line":"        template_uuid \u003d \u0027e74c40e0-d825-11e2-a28f-0800200c9a67\u0027"},{"line_number":871,"context_line":"        strategy_uuid \u003d \u0027e74c40e0-d825-11e2-a28f-0800200c9a68\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"f8f881c1_54d64cc8","line":868,"in_reply_to":"d95dd657_9a833768","updated":"2025-05-16 07:41:17.000000000","message":"Note this is actually not a test, only a helper function used to create a template and audit_template used in other tests.\n\nBefore this patch, we were using this strategy spec to test the case where we use a parameter not allowed (test test_create_audit_with_parameter_not_allowed).\n\nIn this patch i am adding a new test to check the case where a mandatory parameter is not passed. I\u0027m adapting the strategy parameters in this fake strategy to be valid to test both cases.","commit_id":"891119470cefd76d2b7f0f9d683eb8e94ff5c8db"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"099136b1a2dc71dd3e3ab91467e7845fcedc0b94","unresolved":false,"context_lines":[{"line_number":865,"context_line":"                    \"maximum\": 10.2,"},{"line_number":866,"context_line":"                }"},{"line_number":867,"context_line":"            },"},{"line_number":868,"context_line":"            \u0027required\u0027: [\u0027fake1\u0027]"},{"line_number":869,"context_line":"        }"},{"line_number":870,"context_line":"        template_uuid \u003d \u0027e74c40e0-d825-11e2-a28f-0800200c9a67\u0027"},{"line_number":871,"context_line":"        strategy_uuid \u003d \u0027e74c40e0-d825-11e2-a28f-0800200c9a68\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"918c9b0f_32afc176","line":868,"in_reply_to":"f8f881c1_54d64cc8","updated":"2025-05-16 09:08:00.000000000","message":"right, I misread the function name, thanks for the explanation though!","commit_id":"891119470cefd76d2b7f0f9d683eb8e94ff5c8db"}]}