)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"1c46f03ff8cfbfc8d6ca6d7f7aac3e28f379211a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8e0cb4ee_271b297d","updated":"2025-05-27 19:10:08.000000000","message":"+1: waiting for fixes on sean\u0027s comment, otherwise lgtm","commit_id":"f615ccbdeb94b0b9e7fb23a3b9fd3ff922b3fb57"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"408082de0ee31ab4414c1e267791cae802e829a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"16b128ac_daed69d8","updated":"2025-05-28 12:09:35.000000000","message":"LGTM, thanks!","commit_id":"64e9177ef233ed3f6a695da71e31847eb49486d4"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"95d49d182a3defbe3d3cdc8e9680bcb86185d0b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3d6d3ab3_12565fbd","updated":"2025-06-04 05:59:28.000000000","message":"lgtm","commit_id":"64e9177ef233ed3f6a695da71e31847eb49486d4"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"1fcc313fe027b9e5daa52239476c896fa20c532c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f61e7b2e_8e2a3ac2","updated":"2025-05-30 14:41:17.000000000","message":"looks good, just left a nit in the release","commit_id":"64e9177ef233ed3f6a695da71e31847eb49486d4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"183e14e012bad9c06c5499d01c85970480e1c581","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"913816d0_f2dfcd6c","updated":"2025-06-04 12:47:32.000000000","message":"fast approvign since doug was +2 before and this just adress teh release note issues","commit_id":"bf6a28bd1e2d4066f2a736eac065b398f7dd5e09"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"fe64e08007a010428846cc4b5d52e4d54ae79a25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0069f474_c5907b8c","updated":"2025-06-05 11:53:47.000000000","message":"recheck","commit_id":"bf6a28bd1e2d4066f2a736eac065b398f7dd5e09"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"4279c16180dfaced6175e000836e3fb2e8129228","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"06f76587_4e440869","updated":"2025-06-04 13:56:33.000000000","message":"recheck","commit_id":"bf6a28bd1e2d4066f2a736eac065b398f7dd5e09"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"a5514af2b2988c0ca04fe2cba831705877a7b823","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"97ae0742_bed709f2","updated":"2025-06-04 13:50:27.000000000","message":"recheck","commit_id":"bf6a28bd1e2d4066f2a736eac065b398f7dd5e09"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"e31e9fcc4edba98d650d6988f3248957784ec14c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ab853931_3626219d","updated":"2025-06-04 14:59:32.000000000","message":"recheck","commit_id":"bf6a28bd1e2d4066f2a736eac065b398f7dd5e09"}],"releasenotes/notes/bug-2110947.yaml":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"1fcc313fe027b9e5daa52239476c896fa20c532c","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"     Previously, when users attempted to create a new audit without providing"},{"line_number":5,"context_line":"     a name and a goal or an audit template, the API returned error 500 an"},{"line_number":6,"context_line":"     incorrect error message was displayed."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"     Now, Watcher displays a helpful message and returns HTTP error 400."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9d0ab751_a746ae67","line":5,"updated":"2025-05-30 14:41:17.000000000","message":"nit\n```suggestion\n     a name and a goal or an audit template, the API returned error 500 and an\n```","commit_id":"64e9177ef233ed3f6a695da71e31847eb49486d4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"183e14e012bad9c06c5499d01c85970480e1c581","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"     Previously, when users attempted to create a new audit without providing"},{"line_number":5,"context_line":"     a name and a goal or an audit template, the API returned error 500 an"},{"line_number":6,"context_line":"     incorrect error message was displayed."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"     Now, Watcher displays a helpful message and returns HTTP error 400."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"a43ed1c1_74d89d0a","line":5,"in_reply_to":"9d0ab751_a746ae67","updated":"2025-06-04 12:47:32.000000000","message":"Done","commit_id":"64e9177ef233ed3f6a695da71e31847eb49486d4"}],"releasenotes/notes/fix-audit-creation-withoug-goal-and-name-a100be16139c1d07.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8fedef249cafedb21030301dcfed0852dbecf273","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #2110947 \u003chttps://bugs.launchpad.net/watcher/+bug/2110947\u003e`_:"},{"line_number":5,"context_line":"     When users attempted to create a new audit without providing a name and"},{"line_number":6,"context_line":"     goal or selecting an audit template, API returned error 500 and an"},{"line_number":7,"context_line":"     incorrect error message was displayed. Watcher now displays a helpful"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8210acc7_2b442344","line":4,"updated":"2025-05-26 16:12:08.000000000","message":"again a url is fine but you shoudl never lead with it\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references\n\n```\nRelease notes should be written from the perspective of the user and what they should know. Here are a few sample questions to keep in mind when writing them:\n\n    What is particularly relevant from the end-user/deployer’s perspective?\n\n    What changes for them?\n\n    Is there anything they need to do in particular?\n\n    Will the change have an impact on their day-to-day use?\n\nRelease notes are not meant to be a replacement for git commit messages. They should focus on the impact for the user and make that understandable, even for people who don’t know the full technical context for the patch or project.\n```\n\n\nthe project team guide also recommend using bug-XXX \n\nhttps://docs.openstack.org/project-team-guide/release-management.html#how-to-add-new-release-notes\n\nnormally i sumerise the change in the filename as you have but you have a typ in teh file name\n\nreleasenotes/notes/fix-audit-creation-withoug-goal-and-name-a100be16139c1d07.yaml\n\nreleasenotes/notes/fix-audit-creation-without-goal-and-name-a100be16139c1d07.yaml\n\nso i woudl suggest let jsut rename the file to bug-2110947\n\nfor feature i think it is nice ot have a clean name althoguh bp-\u003cblueprint name/spec name) works too.","commit_id":"f615ccbdeb94b0b9e7fb23a3b9fd3ff922b3fb57"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"42f9392d559a61c7aef55e243e58ebaffe15b744","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #2110947 \u003chttps://bugs.launchpad.net/watcher/+bug/2110947\u003e`_:"},{"line_number":5,"context_line":"     When users attempted to create a new audit without providing a name and"},{"line_number":6,"context_line":"     goal or selecting an audit template, API returned error 500 and an"},{"line_number":7,"context_line":"     incorrect error message was displayed. Watcher now displays a helpful"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d94afc71_9be179aa","line":4,"in_reply_to":"8210acc7_2b442344","updated":"2025-05-27 19:38:04.000000000","message":"Thanks. Also moving the reference to the bug url at the end.","commit_id":"f615ccbdeb94b0b9e7fb23a3b9fd3ff922b3fb57"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"51b13d1f9edfd591094f7e6b4c08266fb4a21150","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #2110947 \u003chttps://bugs.launchpad.net/watcher/+bug/2110947\u003e`_:"},{"line_number":5,"context_line":"     When users attempted to create a new audit without providing a name and"},{"line_number":6,"context_line":"     goal or selecting an audit template, API returned error 500 and an"},{"line_number":7,"context_line":"     incorrect error message was displayed. Watcher now displays a helpful"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d1c1ece9_525fb636","line":4,"in_reply_to":"d94afc71_9be179aa","updated":"2025-05-27 20:35:48.000000000","message":"Done","commit_id":"f615ccbdeb94b0b9e7fb23a3b9fd3ff922b3fb57"}],"watcher/api/controllers/v1/audit.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"1c46f03ff8cfbfc8d6ca6d7f7aac3e28f379211a","unresolved":true,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        if not self.audit_template_uuid and not self.goal:"},{"line_number":118,"context_line":"            message \u003d _("},{"line_number":119,"context_line":"                \u0027A valid goal_id or audit_template_id must be provided\u0027)"},{"line_number":120,"context_line":"            raise exception.Invalid(message)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        if (self.audit_type \u003d\u003d objects.audit.AuditType.ONESHOT.value and"}],"source_content_type":"text/x-python","patch_set":3,"id":"77fb3bbe_106fa72e","line":119,"range":{"start_line":119,"start_character":25,"end_line":119,"end_character":32},"updated":"2025-05-27 19:10:08.000000000","message":"I would say \u0027goal\u0027 only,since it can be the name or the uuid, but that\u0027s fine. Up to you","commit_id":"f615ccbdeb94b0b9e7fb23a3b9fd3ff922b3fb57"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"42f9392d559a61c7aef55e243e58ebaffe15b744","unresolved":true,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        if not self.audit_template_uuid and not self.goal:"},{"line_number":118,"context_line":"            message \u003d _("},{"line_number":119,"context_line":"                \u0027A valid goal_id or audit_template_id must be provided\u0027)"},{"line_number":120,"context_line":"            raise exception.Invalid(message)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        if (self.audit_type \u003d\u003d objects.audit.AuditType.ONESHOT.value and"}],"source_content_type":"text/x-python","patch_set":3,"id":"df5ba33f_208f518d","line":119,"range":{"start_line":119,"start_character":25,"end_line":119,"end_character":32},"in_reply_to":"77fb3bbe_106fa72e","updated":"2025-05-27 19:38:04.000000000","message":"Thanks! done","commit_id":"f615ccbdeb94b0b9e7fb23a3b9fd3ff922b3fb57"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"51b13d1f9edfd591094f7e6b4c08266fb4a21150","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        if not self.audit_template_uuid and not self.goal:"},{"line_number":118,"context_line":"            message \u003d _("},{"line_number":119,"context_line":"                \u0027A valid goal_id or audit_template_id must be provided\u0027)"},{"line_number":120,"context_line":"            raise exception.Invalid(message)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        if (self.audit_type \u003d\u003d objects.audit.AuditType.ONESHOT.value and"}],"source_content_type":"text/x-python","patch_set":3,"id":"183d2751_4d728121","line":119,"range":{"start_line":119,"start_character":25,"end_line":119,"end_character":32},"in_reply_to":"df5ba33f_208f518d","updated":"2025-05-27 20:35:48.000000000","message":"Done","commit_id":"f615ccbdeb94b0b9e7fb23a3b9fd3ff922b3fb57"}]}