)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f5f1ccf2926e164100b0adbbcc31da39ec589e41","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This patch is updating the minimal nova microversion to 2.74 in tempest"},{"line_number":10,"context_line":"configuration. This is required to use `host` parameter when creating a"},{"line_number":11,"context_line":"new instance to enforce the compute node where the instance will be"},{"line_number":12,"context_line":"scheduled [1]."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This API version corresponds to OpenStack Train, so there is no risk to"},{"line_number":15,"context_line":"affect any supported version [2]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"21393eb1_bc3a61ce","line":12,"updated":"2025-05-21 01:23:48.000000000","message":"so this is the other large pice of tech debt\n\nwatcher dose not use microverison correctly at all\n\nwe shoudl not have a config option for this at all, the way microversion are ment to work is you are ment to set tehm seperately on each call.\n\nin generaly is nto corect ot use a single microversion to talk to nova as it will not allow you to talks to multipel clouds or have stable behavior oer time.","commit_id":"60866d92c9d228e9aebdc4b07b8ba998e59fb590"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f5f1ccf2926e164100b0adbbcc31da39ec589e41","unresolved":true,"context_lines":[{"line_number":12,"context_line":"scheduled [1]."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This API version corresponds to OpenStack Train, so there is no risk to"},{"line_number":15,"context_line":"affect any supported version [2]."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"A patch in watcher-tempest-plugin will implement this when creating an"},{"line_number":18,"context_line":"instance per host. Note that we will need to backport this to all the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"15374f51_766c69aa","line":15,"updated":"2025-05-21 01:23:48.000000000","message":"ya the version your selecting is fine.\n\nbut as i noted above ^ watcher is not using microversion crrectly at all.\n\nthis was on my orginal ist of tech debth last cycel but we punted on adressing it\n\nwe likely shoudl do that in the next 6-12 months perhaps as part of the swap to the sdk instead of proejct clients.","commit_id":"60866d92c9d228e9aebdc4b07b8ba998e59fb590"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f5f1ccf2926e164100b0adbbcc31da39ec589e41","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"A patch in watcher-tempest-plugin will implement this when creating an"},{"line_number":18,"context_line":"instance per host. Note that we will need to backport this to all the"},{"line_number":19,"context_line":"supported branches."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[1] https://docs.openstack.org/api-ref/compute/#servers-servers"},{"line_number":22,"context_line":"[2] https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id67"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa896ee2_d5bc6d97","line":19,"updated":"2025-05-21 01:23:48.000000000","message":"this is not soemthing im keen to backprot\n\nand honestly, the watcher tempest plugin shoudl be also setting the microverison per call and not relaying on the min_comptue_api config option.\n\nit can check it to skip tests that are not supproted by a cloud but it should not be using it to set the microversion used in calls to nova.","commit_id":"60866d92c9d228e9aebdc4b07b8ba998e59fb590"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"6df361c93c443e65c93aed1e05751acae6dffb46","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"A patch in watcher-tempest-plugin will implement this when creating an"},{"line_number":18,"context_line":"instance per host. Note that we will need to backport this to all the"},{"line_number":19,"context_line":"supported branches."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[1] https://docs.openstack.org/api-ref/compute/#servers-servers"},{"line_number":22,"context_line":"[2] https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id67"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"628ce536_8379f16a","line":19,"in_reply_to":"33424bb2_3469d01b","updated":"2025-05-21 08:23:14.000000000","message":"understood. I will make the tempest plugin to specify the microversion\n\nLast question, given the supported openstack versions and that 2.74 is Train, I\u0027d say we don\u0027t need to provide different implementations based on the available microversion and we can assume we are not supporting testing anything before train, is that acceptable?","commit_id":"60866d92c9d228e9aebdc4b07b8ba998e59fb590"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"95226f87a47205e2659431bb872a9ad01bea5871","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"A patch in watcher-tempest-plugin will implement this when creating an"},{"line_number":18,"context_line":"instance per host. Note that we will need to backport this to all the"},{"line_number":19,"context_line":"supported branches."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[1] https://docs.openstack.org/api-ref/compute/#servers-servers"},{"line_number":22,"context_line":"[2] https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id67"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"33424bb2_3469d01b","line":19,"in_reply_to":"f1c7a562_2dd2982d","updated":"2025-05-21 07:56:02.000000000","message":"No, it is used to limit the range of calls that can be auto-negotiated.\n\nIt is not intended to be the actual value used for all api calls.\n\nits mainly used to skip tests that are not supproted by a cloud as far as i am ware.","commit_id":"60866d92c9d228e9aebdc4b07b8ba998e59fb590"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"c7bb63c9daf7a1d61f2c02a3d424ccfbda6f85a3","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"A patch in watcher-tempest-plugin will implement this when creating an"},{"line_number":18,"context_line":"instance per host. Note that we will need to backport this to all the"},{"line_number":19,"context_line":"supported branches."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[1] https://docs.openstack.org/api-ref/compute/#servers-servers"},{"line_number":22,"context_line":"[2] https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id67"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f1c7a562_2dd2982d","line":19,"in_reply_to":"fa896ee2_d5bc6d97","updated":"2025-05-21 07:19:40.000000000","message":"ok, I will investigate how to do that from the plugin, make sense.\n\nSaid that, my understanding of the parameter I\u0027m modifying was that it only affects to the api call used from the tempest plugin direct calls to nova, not to the watcher server itself, am i wrong?","commit_id":"60866d92c9d228e9aebdc4b07b8ba998e59fb590"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"f8b72b679456946abfcf93a71caed103a3107377","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"589f0f21_c246e5e8","updated":"2025-05-20 14:34:10.000000000","message":"FTR https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/950389 is the review updating the _create_one_instance_per_host_with_statistic method to force the hosts","commit_id":"60866d92c9d228e9aebdc4b07b8ba998e59fb590"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"e95b950701140b0bbba098832629372a6848b631","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"31acf2ab_ca19fe92","updated":"2025-05-20 12:56:21.000000000","message":"forgot to vote","commit_id":"60866d92c9d228e9aebdc4b07b8ba998e59fb590"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"328856a707bebb2bbf1261ce29ceafc9208067aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2765145a_2fcf1ee4","updated":"2025-05-20 12:56:08.000000000","message":"lgtm, existing tests are passing","commit_id":"60866d92c9d228e9aebdc4b07b8ba998e59fb590"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f5f1ccf2926e164100b0adbbcc31da39ec589e41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a82cd83f_dbeec601","updated":"2025-05-21 01:23:48.000000000","message":"we generally dont tend to backprot test changes like this\ninstead we write the tempest plugin to support older branches without requiring changes like this.","commit_id":"60866d92c9d228e9aebdc4b07b8ba998e59fb590"}]}