)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a79fece69f14ab26d3ca7f847ed39a53d9897c4d","unresolved":true,"context_lines":[{"line_number":11,"context_line":" - updating parameter descriptions"},{"line_number":12,"context_line":" - extending the \u0027How to Use\u0027 section"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #2111810"},{"line_number":15,"context_line":"Change-Id: Ifd2876056cd8819c50658fb9f213246dc1546d42"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"a25a7d3f_a1b7ab8f","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":20},"updated":"2025-06-24 16:54:33.000000000","message":"nit:\nwhen fixing buts it prefered to have the gerrit topic set to the bug number.\n\nso since this closes #2111810 the gerrit topic would be bug/211810 in this case.\nim gong ot update it before it megeres.","commit_id":"bfbd136f4b5a80dc45042ac2c27bbebf521afdb8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"bb59e240007c123f8e9191685ca63aac4a32b591","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6b19072c_6b5ca89a","updated":"2025-05-28 06:44:34.000000000","message":"Looks good, left few suggestions!","commit_id":"9f9fe24de682066f3c821f545625cac57298db58"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"8d5832741a12c64b9fbda76807a74b8d2b5160ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9947d303_dfb2c905","updated":"2025-05-28 06:35:27.000000000","message":"Text looks from generated doc: https://b8a1f2f0faf87bf8200d-e8d5eb0c2467c272db52753a13730918.ssl.cf1.rackcdn.com/openstack/958f3833258e4469ad3e2d3e56da625b/docs/strategies/host_maintenance.html","commit_id":"9f9fe24de682066f3c821f545625cac57298db58"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"564295518d53f360553bbb8e8e1c4282a867626e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4e537363_9def65c7","updated":"2025-05-29 05:19:07.000000000","message":"Generated docs looks good https://0c6eceddee3cfc5105b9-48ea8802f13e15aef44645049d82e532.ssl.cf1.rackcdn.com/openstack/1e2a22b8aa194ba39278ad2358fb437e/docs/strategies/host_maintenance.html","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"b42695c37347c03e3a6147d2d0db5b5ba1bd2501","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1900ee09_6a87961e","updated":"2025-06-04 10:51:55.000000000","message":"lgtm","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"10cebeb1aa3e55ef7653cd2d752ef9131878e666","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fcea8214_609e6b56","updated":"2025-06-05 10:59:39.000000000","message":"thanks Ronelle for this doc, I\u0027ve added a few small suggestions for improvements","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"fcc7d370db0352629723a96e877a9d52addc2d25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0ce4b573_669de8a4","updated":"2025-06-06 16:42:48.000000000","message":"LGTM, thanks","commit_id":"530c577904601ed17e55930bbad3a1ee088fe3c1"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"3d35f45d60c4b0790bc1bc73570f9b173e372cf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"524fd3b5_40c355b5","updated":"2025-06-06 12:32:12.000000000","message":"looks much better now!","commit_id":"530c577904601ed17e55930bbad3a1ee088fe3c1"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"62ec61871731485d2ca87cb0fd969c922d87e7c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f8d99a24_9ca7aa1d","updated":"2025-06-06 08:08:24.000000000","message":"thanks for the changes, I think this is good to go now","commit_id":"530c577904601ed17e55930bbad3a1ee088fe3c1"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"cd195b2e1689e79fd083b285e076d273f563e3b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ed245ae8_8cf55320","updated":"2025-06-23 17:09:01.000000000","message":"Thanks for the updates.","commit_id":"bfbd136f4b5a80dc45042ac2c27bbebf521afdb8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a79fece69f14ab26d3ca7f847ed39a53d9897c4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2c49bc82_d02bfb5c","updated":"2025-06-24 16:54:33.000000000","message":"i dont see anything worth holding this for but a couple of nits inline.","commit_id":"bfbd136f4b5a80dc45042ac2c27bbebf521afdb8"}],"doc/source/strategies/host_maintenance.rst":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"bb59e240007c123f8e9191685ca63aac4a32b591","unresolved":true,"context_lines":[{"line_number":79,"context_line":"How to use it ?"},{"line_number":80,"context_line":"---------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":".. code-block:: shell"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    $ openstack optimize audit create \\"},{"line_number":85,"context_line":"      -g cluster_maintaining -s host_maintenance \\"},{"line_number":86,"context_line":"      -p maintenance_node\u003dcompute01"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    $ openstack optimize audit create \\"},{"line_number":89,"context_line":"      -g cluster_maintaining -s host_maintenance \\"},{"line_number":90,"context_line":"      -p maintenance_node\u003dcompute01 \\"},{"line_number":91,"context_line":"      -p backup_node\u003dcompute02"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Note that after executing this strategy, the *maintenance_node* will be"},{"line_number":94,"context_line":"marked as disabled. To enable again:"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"327638e6_26177452","line":92,"range":{"start_line":82,"start_character":0,"end_line":92,"end_character":1},"updated":"2025-05-28 06:44:34.000000000","message":"Can we add a sentence like what these commands are doing?\n\n```suggestion\nRun audit using host_maintenance strategy. It will move the servers from compute01 host by relying on nova scheduler service. \n.. code-block:: shell\n\n    $ openstack optimize audit create \\\n      -g cluster_maintaining -s host_maintenance \\\n      -p maintenance_node\u003dcompute01\n```\n\nRun audit using host_maintenance strategy with backup node. It will move the servers from compute01 host to compute02 host. \n.. code-block:: shell\n\n    $ openstack optimize audit create \\\n      -g cluster_maintaining -s host_maintenance \\\n      -p maintenance_node\u003dcompute01 \\\n      -p backup_node\u003dcompute02\n\n```","commit_id":"9f9fe24de682066f3c821f545625cac57298db58"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"8a97331d24ec95bb4104ab4bc767b01eebd2508b","unresolved":false,"context_lines":[{"line_number":79,"context_line":"How to use it ?"},{"line_number":80,"context_line":"---------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":".. code-block:: shell"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    $ openstack optimize audit create \\"},{"line_number":85,"context_line":"      -g cluster_maintaining -s host_maintenance \\"},{"line_number":86,"context_line":"      -p maintenance_node\u003dcompute01"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    $ openstack optimize audit create \\"},{"line_number":89,"context_line":"      -g cluster_maintaining -s host_maintenance \\"},{"line_number":90,"context_line":"      -p maintenance_node\u003dcompute01 \\"},{"line_number":91,"context_line":"      -p backup_node\u003dcompute02"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Note that after executing this strategy, the *maintenance_node* will be"},{"line_number":94,"context_line":"marked as disabled. To enable again:"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"cbf86e3f_52b24296","line":92,"range":{"start_line":82,"start_character":0,"end_line":92,"end_character":1},"in_reply_to":"327638e6_26177452","updated":"2025-05-28 16:01:27.000000000","message":"Done","commit_id":"9f9fe24de682066f3c821f545625cac57298db58"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"bb59e240007c123f8e9191685ca63aac4a32b591","unresolved":true,"context_lines":[{"line_number":90,"context_line":"      -p maintenance_node\u003dcompute01 \\"},{"line_number":91,"context_line":"      -p backup_node\u003dcompute02"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Note that after executing this strategy, the *maintenance_node* will be"},{"line_number":94,"context_line":"marked as disabled. To enable again:"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":".. code-block:: shell"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fe669d51_8da4007e","line":94,"range":{"start_line":93,"start_character":0,"end_line":94,"end_character":19},"updated":"2025-05-28 06:44:34.000000000","message":"```suggestion\nNote that after executing this strategy, the *maintenance_node* will be\nmarked as disabled with `watcher_maintaining` reason. To enable again:\n```","commit_id":"9f9fe24de682066f3c821f545625cac57298db58"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"8a97331d24ec95bb4104ab4bc767b01eebd2508b","unresolved":false,"context_lines":[{"line_number":90,"context_line":"      -p maintenance_node\u003dcompute01 \\"},{"line_number":91,"context_line":"      -p backup_node\u003dcompute02"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Note that after executing this strategy, the *maintenance_node* will be"},{"line_number":94,"context_line":"marked as disabled. To enable again:"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":".. code-block:: shell"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"df15473c_b58f1b4a","line":94,"range":{"start_line":93,"start_character":0,"end_line":94,"end_character":19},"in_reply_to":"fe669d51_8da4007e","updated":"2025-05-28 16:01:27.000000000","message":"Done","commit_id":"9f9fe24de682066f3c821f545625cac57298db58"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"10cebeb1aa3e55ef7653cd2d752ef9131878e666","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    .. watcher-term:: watcher.decision_engine.strategy.strategies.host_maintenance.HostMaintenance"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Requirements"},{"line_number":15,"context_line":"------------"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"None."}],"source_content_type":"text/x-rst","patch_set":5,"id":"33579b3a_c144fc10","line":14,"updated":"2025-06-05 10:59:39.000000000","message":"this section is empty, but in the docstring we have a `Requirements` section, should we move that here, or remove this one?","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"86f7882b4c249a81639b04bc5e0d08990b6bce80","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    .. watcher-term:: watcher.decision_engine.strategy.strategies.host_maintenance.HostMaintenance"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Requirements"},{"line_number":15,"context_line":"------------"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"None."}],"source_content_type":"text/x-rst","patch_set":5,"id":"56dbcceb_5987ae33","line":14,"in_reply_to":"33579b3a_c144fc10","updated":"2025-06-05 19:07:14.000000000","message":"I copied the same requirements from the code file.","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"62ec61871731485d2ca87cb0fd969c922d87e7c0","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    .. watcher-term:: watcher.decision_engine.strategy.strategies.host_maintenance.HostMaintenance"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Requirements"},{"line_number":15,"context_line":"------------"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"None."}],"source_content_type":"text/x-rst","patch_set":5,"id":"8f96a1b4_989dbf3b","line":14,"in_reply_to":"56dbcceb_5987ae33","updated":"2025-06-06 08:08:24.000000000","message":"Done","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"10cebeb1aa3e55ef7653cd2d752ef9131878e666","unresolved":true,"context_lines":[{"line_number":57,"context_line":"Strategy parameters are:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":60,"context_line":"parameter            type   default Value description            required state"},{"line_number":61,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":62,"context_line":"``maintenance_node`` String The name of the compute node which   Required"},{"line_number":63,"context_line":"                            need maintenance."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7c13964c_4a8f90c9","line":60,"updated":"2025-06-05 10:59:39.000000000","message":"I find the capitalizations in this header odd, with most words lowercase except for `Value`, I see that this is consistent with the rest of the strategies docs, so we might just leave it as is, but I think it would look better with sentence case","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"86f7882b4c249a81639b04bc5e0d08990b6bce80","unresolved":true,"context_lines":[{"line_number":57,"context_line":"Strategy parameters are:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":60,"context_line":"parameter            type   default Value description            required state"},{"line_number":61,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":62,"context_line":"``maintenance_node`` String The name of the compute node which   Required"},{"line_number":63,"context_line":"                            need maintenance."}],"source_content_type":"text/x-rst","patch_set":5,"id":"b1b82744_00c45162","line":60,"in_reply_to":"7c13964c_4a8f90c9","updated":"2025-06-05 19:07:14.000000000","message":"I changed the capitalization of value - agreed","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"62ec61871731485d2ca87cb0fd969c922d87e7c0","unresolved":false,"context_lines":[{"line_number":57,"context_line":"Strategy parameters are:"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":60,"context_line":"parameter            type   default Value description            required state"},{"line_number":61,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":62,"context_line":"``maintenance_node`` String The name of the compute node which   Required"},{"line_number":63,"context_line":"                            need maintenance."}],"source_content_type":"text/x-rst","patch_set":5,"id":"7b6d410e_259f7a52","line":60,"in_reply_to":"b1b82744_00c45162","updated":"2025-06-06 08:08:24.000000000","message":"Done","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"10cebeb1aa3e55ef7653cd2d752ef9131878e666","unresolved":true,"context_lines":[{"line_number":59,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":60,"context_line":"parameter            type   default Value description            required state"},{"line_number":61,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":62,"context_line":"``maintenance_node`` String The name of the compute node which   Required"},{"line_number":63,"context_line":"                            need maintenance."},{"line_number":64,"context_line":"``backup_node``      String The name of the compute node which   Optional"},{"line_number":65,"context_line":"                            will backup the maintenance node."}],"source_content_type":"text/x-rst","patch_set":5,"id":"9b78dc80_26beb867","line":62,"updated":"2025-06-05 10:59:39.000000000","message":"+1 to marking clearly which parameters are required and which are optional, we should adopt the same convention for all strategies","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"cf6cfd21ae310e436b40aab0c2546e5fe1a827f7","unresolved":false,"context_lines":[{"line_number":59,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":60,"context_line":"parameter            type   default Value description            required state"},{"line_number":61,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":62,"context_line":"``maintenance_node`` String The name of the compute node which   Required"},{"line_number":63,"context_line":"                            need maintenance."},{"line_number":64,"context_line":"``backup_node``      String The name of the compute node which   Optional"},{"line_number":65,"context_line":"                            will backup the maintenance node."}],"source_content_type":"text/x-rst","patch_set":5,"id":"630fb180_7e8d5b19","line":62,"in_reply_to":"569aa23b_69687766","updated":"2025-06-20 22:21:55.000000000","message":"Done","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"33f3c51a369d644f570c995816549953c845f105","unresolved":true,"context_lines":[{"line_number":59,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":60,"context_line":"parameter            type   default Value description            required state"},{"line_number":61,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":62,"context_line":"``maintenance_node`` String The name of the compute node which   Required"},{"line_number":63,"context_line":"                            need maintenance."},{"line_number":64,"context_line":"``backup_node``      String The name of the compute node which   Optional"},{"line_number":65,"context_line":"                            will backup the maintenance node."}],"source_content_type":"text/x-rst","patch_set":5,"id":"569aa23b_69687766","line":62,"in_reply_to":"9b78dc80_26beb867","updated":"2025-06-13 10:36:21.000000000","message":"that is an imporment but i personlly disliek the term required state\n\nspecificly the \"state\" part.  i would just call it \"requeire\" or \"opetional\" as the heading for clarity.\n\n\n\"default value description\" is also incorrect\n\nit shoudl just be \"description\"\n\n\nim not sure if we want to fix this now or have a followup ot fix this constiently in all of them at once","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"10cebeb1aa3e55ef7653cd2d752ef9131878e666","unresolved":true,"context_lines":[{"line_number":60,"context_line":"parameter            type   default Value description            required state"},{"line_number":61,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":62,"context_line":"``maintenance_node`` String The name of the compute node which   Required"},{"line_number":63,"context_line":"                            need maintenance."},{"line_number":64,"context_line":"``backup_node``      String The name of the compute node which   Optional"},{"line_number":65,"context_line":"                            will backup the maintenance node."},{"line_number":66,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"2a6f0aae_195c588f","line":63,"updated":"2025-06-05 10:59:39.000000000","message":"```suggestion\n                            needs maintenance.\n```","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"62ec61871731485d2ca87cb0fd969c922d87e7c0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"parameter            type   default Value description            required state"},{"line_number":61,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":62,"context_line":"``maintenance_node`` String The name of the compute node which   Required"},{"line_number":63,"context_line":"                            need maintenance."},{"line_number":64,"context_line":"``backup_node``      String The name of the compute node which   Optional"},{"line_number":65,"context_line":"                            will backup the maintenance node."},{"line_number":66,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"c469169e_e6659e8c","line":63,"in_reply_to":"2a6f0aae_195c588f","updated":"2025-06-06 08:08:24.000000000","message":"Done","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"10cebeb1aa3e55ef7653cd2d752ef9131878e666","unresolved":true,"context_lines":[{"line_number":61,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":62,"context_line":"``maintenance_node`` String The name of the compute node which   Required"},{"line_number":63,"context_line":"                            need maintenance."},{"line_number":64,"context_line":"``backup_node``      String The name of the compute node which   Optional"},{"line_number":65,"context_line":"                            will backup the maintenance node."},{"line_number":66,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"c26a6311_34a26b3b","line":64,"updated":"2025-06-05 10:59:39.000000000","message":"I would like to know other people opinions, but imo the term backup could be a bit confusing here, I think something like `The destination compute node for the instance migrations` might be clearer","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"cf6cfd21ae310e436b40aab0c2546e5fe1a827f7","unresolved":false,"context_lines":[{"line_number":61,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":62,"context_line":"``maintenance_node`` String The name of the compute node which   Required"},{"line_number":63,"context_line":"                            need maintenance."},{"line_number":64,"context_line":"``backup_node``      String The name of the compute node which   Optional"},{"line_number":65,"context_line":"                            will backup the maintenance node."},{"line_number":66,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"400c6307_4cdeb45d","line":64,"in_reply_to":"1fc1a1c0_8bba3154","updated":"2025-06-20 22:21:55.000000000","message":"Acknowledged","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"33f3c51a369d644f570c995816549953c845f105","unresolved":true,"context_lines":[{"line_number":61,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":62,"context_line":"``maintenance_node`` String The name of the compute node which   Required"},{"line_number":63,"context_line":"                            need maintenance."},{"line_number":64,"context_line":"``backup_node``      String The name of the compute node which   Optional"},{"line_number":65,"context_line":"                            will backup the maintenance node."},{"line_number":66,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1fc1a1c0_8bba3154","line":64,"in_reply_to":"74ac4e87_f4c53c54","updated":"2025-06-13 10:36:21.000000000","message":"i thed to a agree that\"The destination compute node for the instance migrations\"\nis clear personally.\n\nbackup int he contenxt of mantiance could be confulst with a location where i save a backup of the service state.\n\ni.e. backup and restore capablity.","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"fcc7d370db0352629723a96e877a9d52addc2d25","unresolved":true,"context_lines":[{"line_number":61,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":62,"context_line":"``maintenance_node`` String The name of the compute node which   Required"},{"line_number":63,"context_line":"                            need maintenance."},{"line_number":64,"context_line":"``backup_node``      String The name of the compute node which   Optional"},{"line_number":65,"context_line":"                            will backup the maintenance node."},{"line_number":66,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"74ac4e87_f4c53c54","line":64,"in_reply_to":"7953264f_d23ac036","updated":"2025-06-06 16:42:48.000000000","message":"I think that backup is more aligned with maintenance, as destination is with source. Not sure which one is the best for an cloud admin.","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"86f7882b4c249a81639b04bc5e0d08990b6bce80","unresolved":true,"context_lines":[{"line_number":61,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":62,"context_line":"``maintenance_node`` String The name of the compute node which   Required"},{"line_number":63,"context_line":"                            need maintenance."},{"line_number":64,"context_line":"``backup_node``      String The name of the compute node which   Optional"},{"line_number":65,"context_line":"                            will backup the maintenance node."},{"line_number":66,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7953264f_d23ac036","line":64,"in_reply_to":"c26a6311_34a26b3b","updated":"2025-06-05 19:07:14.000000000","message":"Chandan also mentioned this. We tried to clarify in the decsription.","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"10cebeb1aa3e55ef7653cd2d752ef9131878e666","unresolved":true,"context_lines":[{"line_number":79,"context_line":"How to use it ?"},{"line_number":80,"context_line":"---------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Run an audit using Host maintenance strategy."},{"line_number":83,"context_line":"Executing the actions will move the servers from compute01 host"},{"line_number":84,"context_line":"to a host determined by the Nova scheduler service."},{"line_number":85,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba0e0e34_e4e6b597","line":82,"updated":"2025-06-05 10:59:39.000000000","message":"```suggestion\nRun an audit using Host Maintenance strategy.\n```","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"86f7882b4c249a81639b04bc5e0d08990b6bce80","unresolved":false,"context_lines":[{"line_number":79,"context_line":"How to use it ?"},{"line_number":80,"context_line":"---------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Run an audit using Host maintenance strategy."},{"line_number":83,"context_line":"Executing the actions will move the servers from compute01 host"},{"line_number":84,"context_line":"to a host determined by the Nova scheduler service."},{"line_number":85,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7b6cfc06_be795f98","line":82,"in_reply_to":"ba0e0e34_e4e6b597","updated":"2025-06-05 19:07:14.000000000","message":"Done","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"10cebeb1aa3e55ef7653cd2d752ef9131878e666","unresolved":true,"context_lines":[{"line_number":86,"context_line":".. code-block:: shell"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    $ openstack optimize audit create \\"},{"line_number":89,"context_line":"      -g cluster_maintaining -s host_maintenance \\"},{"line_number":90,"context_line":"      -p maintenance_node\u003dcompute01"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Run an audit using Host Maintenance strategy with a backup node specified."}],"source_content_type":"text/x-rst","patch_set":5,"id":"339e7c26_1f2583c5","line":89,"updated":"2025-06-05 10:59:39.000000000","message":"I know that the doc previously used the short names for the options, but imo we should use the long names in documentation, I feel like the long names are more helpful for a new user\n \n```suggestion\n      --goal cluster_maintaining --strategy host_maintenance \\\n```","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"62ec61871731485d2ca87cb0fd969c922d87e7c0","unresolved":true,"context_lines":[{"line_number":86,"context_line":".. code-block:: shell"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    $ openstack optimize audit create \\"},{"line_number":89,"context_line":"      -g cluster_maintaining -s host_maintenance \\"},{"line_number":90,"context_line":"      -p maintenance_node\u003dcompute01"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Run an audit using Host Maintenance strategy with a backup node specified."}],"source_content_type":"text/x-rst","patch_set":5,"id":"6443c928_614cc4b6","line":89,"in_reply_to":"1944be3f_2d9376c6","updated":"2025-06-06 08:08:24.000000000","message":"that\u0027s fair, +1 to keep it consistent for now and change all in a follow-up","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"86f7882b4c249a81639b04bc5e0d08990b6bce80","unresolved":true,"context_lines":[{"line_number":86,"context_line":".. code-block:: shell"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    $ openstack optimize audit create \\"},{"line_number":89,"context_line":"      -g cluster_maintaining -s host_maintenance \\"},{"line_number":90,"context_line":"      -p maintenance_node\u003dcompute01"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Run an audit using Host Maintenance strategy with a backup node specified."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1944be3f_2d9376c6","line":89,"in_reply_to":"339e7c26_1f2583c5","updated":"2025-06-05 19:07:14.000000000","message":"OK - but we should change this all over - not in one strategy.","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"33f3c51a369d644f570c995816549953c845f105","unresolved":true,"context_lines":[{"line_number":86,"context_line":".. code-block:: shell"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    $ openstack optimize audit create \\"},{"line_number":89,"context_line":"      -g cluster_maintaining -s host_maintenance \\"},{"line_number":90,"context_line":"      -p maintenance_node\u003dcompute01"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Run an audit using Host Maintenance strategy with a backup node specified."}],"source_content_type":"text/x-rst","patch_set":5,"id":"a6a9300e_d2107f83","line":89,"in_reply_to":"6443c928_614cc4b6","updated":"2025-06-13 10:36:21.000000000","message":"ya im torn i agree the long name is more readable but i suspect the short name is what people actually use mroe often.\n\nwe could alway put a littel tabel or map below of shot opt:long opt:description.\n\nthat proably overkill however so using the long opts will fullfile that role.","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"cf6cfd21ae310e436b40aab0c2546e5fe1a827f7","unresolved":false,"context_lines":[{"line_number":86,"context_line":".. code-block:: shell"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    $ openstack optimize audit create \\"},{"line_number":89,"context_line":"      -g cluster_maintaining -s host_maintenance \\"},{"line_number":90,"context_line":"      -p maintenance_node\u003dcompute01"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"Run an audit using Host Maintenance strategy with a backup node specified."}],"source_content_type":"text/x-rst","patch_set":5,"id":"c7e2b80b_bba8470b","line":89,"in_reply_to":"a6a9300e_d2107f83","updated":"2025-06-20 22:21:55.000000000","message":"Acknowledged","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a79fece69f14ab26d3ca7f847ed39a53d9897c4d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"Synopsis"},{"line_number":6,"context_line":"--------"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"**display name**: ``Host Maintenance Strategy``"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"**goal**: ``cluster_maintaining``"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    .. watcher-term:: watcher.decision_engine.strategy.strategies.host_maintenance.HostMaintenance"}],"source_content_type":"text/x-rst","patch_set":9,"id":"4c0c7526_714fe267","side":"PARENT","line":9,"range":{"start_line":8,"start_character":0,"end_line":9,"end_character":1},"updated":"2025-06-24 16:54:33.000000000","message":"nit: these are two ways of making it bold\n\nIt actually reduced the readability in my opinion, but that is a pre-existing issue.\n\nWe may want to do a pass later to decide what we actually want to highlight and what we don\u0027t.\n\ntaht out of scope of this review its just somethign that i noticed when looking at the render https://520d33605a7837bdb14d-0e7966c6ce169b12e236e1733223c04b.ssl.cf2.rackcdn.com/openstack/57336ab605444e8f85151fa571eb6bc3/docs/strategies/host_maintenance.html#synopsis","commit_id":"fe8d8c88398193b977dcff6d3f1ac7fe72573a09"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a79fece69f14ab26d3ca7f847ed39a53d9897c4d","unresolved":true,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    $ openstack optimize audit create \\"},{"line_number":86,"context_line":"      -g cluster_maintaining -s host_maintenance \\"},{"line_number":87,"context_line":"      -p maintenance_node\u003dcompute01"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Run an audit using Host Maintenance strategy with a backup node specified."},{"line_number":90,"context_line":"Executing the actions will move the servers from compute01 host"}],"source_content_type":"text/x-rst","patch_set":9,"id":"a1bfc549_82b04091","line":87,"updated":"2025-06-24 16:54:33.000000000","message":"As an aside, I think we discussed elsewhere about maybe using the long form\neverywhere in a follow up right.","commit_id":"bfbd136f4b5a80dc45042ac2c27bbebf521afdb8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a79fece69f14ab26d3ca7f847ed39a53d9897c4d","unresolved":true,"context_lines":[{"line_number":97,"context_line":"      -p maintenance_node\u003dcompute01 \\"},{"line_number":98,"context_line":"      -p backup_node\u003dcompute02"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Note that after executing this strategy, the *maintenance_node* will be"},{"line_number":101,"context_line":"marked as disabled, with the reason set to ``watcher_maintaining``."},{"line_number":102,"context_line":"To enable the node again:"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"ec96c597_e1c2f657","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":4},"updated":"2025-06-24 16:54:33.000000000","message":"nit: notes shoudl generally use the actul note syntax\n\n.. note::\n\nhttps://sublime-and-sphinx-guide.readthedocs.io/en/latest/notes_warnings.html#notes\n\nwe can perhaps adress that unifromly in a followup.","commit_id":"bfbd136f4b5a80dc45042ac2c27bbebf521afdb8"}],"watcher/decision_engine/strategy/strategies/host_maintenance.py":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"10cebeb1aa3e55ef7653cd2d752ef9131878e666","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class HostMaintenance(base.HostMaintenanceBaseStrategy):"},{"line_number":30,"context_line":"    \"\"\"[PoC]Host Maintenance"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    *Description*"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"357e1ac9_9f0b231e","line":30,"updated":"2025-06-05 10:59:39.000000000","message":"we should remove this [PoC] tag since we have another review to properly document the support status of the strategies","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"86f7882b4c249a81639b04bc5e0d08990b6bce80","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class HostMaintenance(base.HostMaintenanceBaseStrategy):"},{"line_number":30,"context_line":"    \"\"\"[PoC]Host Maintenance"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    *Description*"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"418a7ba5_bf5205e3","line":30,"in_reply_to":"357e1ac9_9f0b231e","updated":"2025-06-05 19:07:14.000000000","message":"Done","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"10cebeb1aa3e55ef7653cd2d752ef9131878e666","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    *Description*"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        It is a migration strategy for one compute node maintenance,"},{"line_number":35,"context_line":"        without having the user\u0027s application been interrupted."},{"line_number":36,"context_line":"        If given one backup node (where backup node is the"},{"line_number":37,"context_line":"        destination node for migration), the strategy will firstly"},{"line_number":38,"context_line":"        migrate all instances from the maintenance node to"}],"source_content_type":"text/x-python","patch_set":5,"id":"096fbdb3_99f8cb65","line":35,"updated":"2025-06-05 10:59:39.000000000","message":"```suggestion\n        without interrupting the node workloads.\n```\nIMO this sentence could be improved, I left a suggestion","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"86f7882b4c249a81639b04bc5e0d08990b6bce80","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    *Description*"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        It is a migration strategy for one compute node maintenance,"},{"line_number":35,"context_line":"        without having the user\u0027s application been interrupted."},{"line_number":36,"context_line":"        If given one backup node (where backup node is the"},{"line_number":37,"context_line":"        destination node for migration), the strategy will firstly"},{"line_number":38,"context_line":"        migrate all instances from the maintenance node to"}],"source_content_type":"text/x-python","patch_set":5,"id":"879ab0b9_2b7a6dd8","line":35,"in_reply_to":"096fbdb3_99f8cb65","updated":"2025-06-05 19:07:14.000000000","message":"Done","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"10cebeb1aa3e55ef7653cd2d752ef9131878e666","unresolved":true,"context_lines":[{"line_number":37,"context_line":"        destination node for migration), the strategy will firstly"},{"line_number":38,"context_line":"        migrate all instances from the maintenance node to"},{"line_number":39,"context_line":"        the backup node. If the backup node is not provided,"},{"line_number":40,"context_line":"        it will migrate all instances, relying on nova-scheduler."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    *Requirements*"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"a043dd24_da6c9dad","line":40,"updated":"2025-06-05 10:59:39.000000000","message":"```suggestion\n        it will migrate all instances, relying on nova-scheduler to choose a destination.\n```\nI think it\u0027s clear from context, but worth it to mention it explicetly","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"10cebeb1aa3e55ef7653cd2d752ef9131878e666","unresolved":true,"context_lines":[{"line_number":37,"context_line":"        destination node for migration), the strategy will firstly"},{"line_number":38,"context_line":"        migrate all instances from the maintenance node to"},{"line_number":39,"context_line":"        the backup node. If the backup node is not provided,"},{"line_number":40,"context_line":"        it will migrate all instances, relying on nova-scheduler."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    *Requirements*"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"05ce795b_98d587ed","line":40,"updated":"2025-06-05 10:59:39.000000000","message":"maybe I missed it, but I think we should mention here that the strategy will disable the node","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"86f7882b4c249a81639b04bc5e0d08990b6bce80","unresolved":true,"context_lines":[{"line_number":37,"context_line":"        destination node for migration), the strategy will firstly"},{"line_number":38,"context_line":"        migrate all instances from the maintenance node to"},{"line_number":39,"context_line":"        the backup node. If the backup node is not provided,"},{"line_number":40,"context_line":"        it will migrate all instances, relying on nova-scheduler."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    *Requirements*"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"e7abdb48_9d358ddb","line":40,"in_reply_to":"05ce795b_98d587ed","updated":"2025-06-05 19:07:14.000000000","message":"Added","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"86f7882b4c249a81639b04bc5e0d08990b6bce80","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        destination node for migration), the strategy will firstly"},{"line_number":38,"context_line":"        migrate all instances from the maintenance node to"},{"line_number":39,"context_line":"        the backup node. If the backup node is not provided,"},{"line_number":40,"context_line":"        it will migrate all instances, relying on nova-scheduler."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    *Requirements*"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"e17816f8_de45f793","line":40,"in_reply_to":"a043dd24_da6c9dad","updated":"2025-06-05 19:07:14.000000000","message":"Done","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"62ec61871731485d2ca87cb0fd969c922d87e7c0","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        destination node for migration), the strategy will firstly"},{"line_number":38,"context_line":"        migrate all instances from the maintenance node to"},{"line_number":39,"context_line":"        the backup node. If the backup node is not provided,"},{"line_number":40,"context_line":"        it will migrate all instances, relying on nova-scheduler."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    *Requirements*"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"f19626f4_9e23dc16","line":40,"in_reply_to":"e7abdb48_9d358ddb","updated":"2025-06-06 08:08:24.000000000","message":"Done","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"10cebeb1aa3e55ef7653cd2d752ef9131878e666","unresolved":true,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    *Limitations*"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"       - This is a proof of concept that is not meant to be used in production"},{"line_number":49,"context_line":"       - It migrates all instances from one host to other hosts. It\u0027s better to"},{"line_number":50,"context_line":"         execute such strategy when load is not heavy, and use this algorithm"},{"line_number":51,"context_line":"         with `ONESHOT` audit."}],"source_content_type":"text/x-python","patch_set":5,"id":"347426ab_df62944f","line":48,"updated":"2025-06-05 10:59:39.000000000","message":"we should also remove this disclaimer","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"86f7882b4c249a81639b04bc5e0d08990b6bce80","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    *Limitations*"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"       - This is a proof of concept that is not meant to be used in production"},{"line_number":49,"context_line":"       - It migrates all instances from one host to other hosts. It\u0027s better to"},{"line_number":50,"context_line":"         execute such strategy when load is not heavy, and use this algorithm"},{"line_number":51,"context_line":"         with `ONESHOT` audit."}],"source_content_type":"text/x-python","patch_set":5,"id":"f4191c7e_293a8654","line":48,"in_reply_to":"347426ab_df62944f","updated":"2025-06-05 19:07:14.000000000","message":"Done","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"10cebeb1aa3e55ef7653cd2d752ef9131878e666","unresolved":true,"context_lines":[{"line_number":46,"context_line":"    *Limitations*"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"       - This is a proof of concept that is not meant to be used in production"},{"line_number":49,"context_line":"       - It migrates all instances from one host to other hosts. It\u0027s better to"},{"line_number":50,"context_line":"         execute such strategy when load is not heavy, and use this algorithm"},{"line_number":51,"context_line":"         with `ONESHOT` audit."},{"line_number":52,"context_line":"       - It assumes that cold and live migrations are possible."}],"source_content_type":"text/x-python","patch_set":5,"id":"0d4d21fd_c2e011fc","line":49,"updated":"2025-06-05 10:59:39.000000000","message":"I think we should have this sentence in a `note` like in https://github.com/openstack/watcher/blob/59757249bbbbb45bead28bfb2899242aea97dfc1/watcher/applier/actions/migration.py#L52 to make it more visible","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"33f3c51a369d644f570c995816549953c845f105","unresolved":true,"context_lines":[{"line_number":46,"context_line":"    *Limitations*"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"       - This is a proof of concept that is not meant to be used in production"},{"line_number":49,"context_line":"       - It migrates all instances from one host to other hosts. It\u0027s better to"},{"line_number":50,"context_line":"         execute such strategy when load is not heavy, and use this algorithm"},{"line_number":51,"context_line":"         with `ONESHOT` audit."},{"line_number":52,"context_line":"       - It assumes that cold and live migrations are possible."}],"source_content_type":"text/x-python","patch_set":5,"id":"a1de2741_43fd9255","line":49,"in_reply_to":"0d4d21fd_c2e011fc","updated":"2025-06-13 10:36:21.000000000","message":"ya, this is not a limitation, it\u0027s the goal of the strategy.\n\nso the first sentance i woudl remove and then secion sentiosn\n\nIt\u0027s better to ... \n\ni would pull out into a note and strengthen the wording.\n\n\"It\u0027s recommended to use this strategy in a planned maintenance window where lthe oad is low to minimize impact on the workloads.\"\n\nsomething liek that.","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"cf6cfd21ae310e436b40aab0c2546e5fe1a827f7","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    *Limitations*"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"       - This is a proof of concept that is not meant to be used in production"},{"line_number":49,"context_line":"       - It migrates all instances from one host to other hosts. It\u0027s better to"},{"line_number":50,"context_line":"         execute such strategy when load is not heavy, and use this algorithm"},{"line_number":51,"context_line":"         with `ONESHOT` audit."},{"line_number":52,"context_line":"       - It assumes that cold and live migrations are possible."}],"source_content_type":"text/x-python","patch_set":5,"id":"ff48f972_1a6cba22","line":49,"in_reply_to":"a1de2741_43fd9255","updated":"2025-06-20 22:21:55.000000000","message":"Done","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"10cebeb1aa3e55ef7653cd2d752ef9131878e666","unresolved":true,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"       - This is a proof of concept that is not meant to be used in production"},{"line_number":49,"context_line":"       - It migrates all instances from one host to other hosts. It\u0027s better to"},{"line_number":50,"context_line":"         execute such strategy when load is not heavy, and use this algorithm"},{"line_number":51,"context_line":"         with `ONESHOT` audit."},{"line_number":52,"context_line":"       - It assumes that cold and live migrations are possible."},{"line_number":53,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"746e611a_3da35a03","line":50,"updated":"2025-06-05 10:59:39.000000000","message":"```suggestion\n         execute this strategy when load is not heavy, with a `ONEHSHOT` audit.\n```","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"86f7882b4c249a81639b04bc5e0d08990b6bce80","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"       - This is a proof of concept that is not meant to be used in production"},{"line_number":49,"context_line":"       - It migrates all instances from one host to other hosts. It\u0027s better to"},{"line_number":50,"context_line":"         execute such strategy when load is not heavy, and use this algorithm"},{"line_number":51,"context_line":"         with `ONESHOT` audit."},{"line_number":52,"context_line":"       - It assumes that cold and live migrations are possible."},{"line_number":53,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"5af7cac9_c34f72dd","line":50,"in_reply_to":"746e611a_3da35a03","updated":"2025-06-05 19:07:14.000000000","message":"Done","commit_id":"fef8974034174dae12e9ae6447f8bd760cb13edb"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"cf6cfd21ae310e436b40aab0c2546e5fe1a827f7","unresolved":true,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    *Limitations*"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"       - This is a proof of concept that is not meant to be used in production"},{"line_number":50,"context_line":"       - It migrates all instances from one host to other hosts. It\u0027s better to"},{"line_number":51,"context_line":"         execute such strategy when load is not heavy, and use this algorithm"},{"line_number":52,"context_line":"         with `ONESHOT` audit."}],"source_content_type":"text/x-python","patch_set":7,"id":"bb7d7baa_4f84db8a","line":49,"updated":"2025-06-20 22:21:55.000000000","message":"Removing this","commit_id":"530c577904601ed17e55930bbad3a1ee088fe3c1"},{"author":{"_account_id":37591,"name":"Malinga Tembo","display_name":"Malinga","email":"mtembo@redhat.com","username":"malinga_tee"},"change_message_id":"a3d99665e44e4eea3465b29ee837893c64fe9d21","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    *Limitations*"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"       - This is a proof of concept that is not meant to be used in production"},{"line_number":50,"context_line":"       - It migrates all instances from one host to other hosts. It\u0027s better to"},{"line_number":51,"context_line":"         execute such strategy when load is not heavy, and use this algorithm"},{"line_number":52,"context_line":"         with `ONESHOT` audit."}],"source_content_type":"text/x-python","patch_set":7,"id":"5c69e787_5d50cf39","line":49,"in_reply_to":"bb7d7baa_4f84db8a","updated":"2025-06-24 14:23:39.000000000","message":"Done","commit_id":"530c577904601ed17e55930bbad3a1ee088fe3c1"},{"author":{"_account_id":37591,"name":"Malinga Tembo","display_name":"Malinga","email":"mtembo@redhat.com","username":"malinga_tee"},"change_message_id":"a3d99665e44e4eea3465b29ee837893c64fe9d21","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    *Description*"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        It is a migration strategy for one compute node maintenance,"},{"line_number":35,"context_line":"        without having the user\u0027s application been interrupted."},{"line_number":36,"context_line":"        If given one backup node (where backup node is the"},{"line_number":37,"context_line":"        destination node for migration), the strategy will firstly"},{"line_number":38,"context_line":"        migrate all instances from the maintenance node to"}],"source_content_type":"text/x-python","patch_set":9,"id":"03989d53_8ae1ac0e","line":35,"range":{"start_line":35,"start_character":45,"end_line":35,"end_character":50},"updated":"2025-06-24 14:23:39.000000000","message":"we can remove the word been\n```suggestion\n        without having the user\u0027s application interrupted.\n```","commit_id":"bfbd136f4b5a80dc45042ac2c27bbebf521afdb8"}]}