)]}'
{"id":"openstack%2Fwatcher~951767","triplet_id":"openstack%2Fwatcher~stable%2F2025.1~I6f3d73b035e8081e86ce82c205498432f0e0fc33","project":"openstack/watcher","branch":"stable/2025.1","topic":"fix-no-goal-no-name-stable/2025.1","attention_set":{},"removed_from_attention_set":{"11604":{"account":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"last_update":"2025-07-08 11:57:08.000000000","reason":"\u003cGERRIT_ACCOUNT_11604\u003e replied on the change","reason_account":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}},"16312":{"account":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"last_update":"2025-07-21 19:28:43.000000000","reason":"Change was submitted"},"12393":{"account":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"last_update":"2025-07-21 19:28:43.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I6f3d73b035e8081e86ce82c205498432f0e0fc33","subject":"Fix audit creation with no name and no goal or audit_template","status":"MERGED","created":"2025-06-04 13:15:55.000000000","updated":"2025-07-21 19:29:52.000000000","submitted":"2025-07-21 19:28:43.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"951767-fix-no-goal-no-name-stable/2025.1","cherry_pick_of_change":949977,"cherry_pick_of_patch_set":5,"meta_rev_id":"674d88aac04d8aac3b6a6ebcb1050c0c451898d5","_number":951767,"virtual_id_number":951767,"owner":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-07-21 19:28:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":2,"date":"2025-07-08 11:57:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":1,"date":"2025-07-21 18:38:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Standard Change","+1":"Important Change","+2":"High Priority Change"},"default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"}],"reviewers":{"REVIEWER":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-06-04 13:15:55.000000000","updated_by":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"reviewer":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"state":"CC"},{"updated":"2025-06-04 15:58:41.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-07-01 15:46:06.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2025-07-02 06:16:50.000000000","updated_by":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"reviewer":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"state":"REVIEWER"}],"messages":[{"id":"cd465828dfc8037d54cacfe1b6d65193fb98bb70","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"date":"2025-06-04 13:15:55.000000000","message":"Patch Set 1: Cherry Picked from branch master.\n\nThe following files contain Git conflicts:\n* watcher/tests/api/v1/test_audits.py","accounts_in_message":[],"_revision_number":1},{"id":"40fa2470b376818492b48eefbd9fe2c3ef0ac5c3","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"date":"2025-06-04 13:17:45.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f0aa9346d59dfad5a73e4de53cb0b5089fb4a4a8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-06-04 15:58:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/cc27cda52768469a9f7f5df87d366762\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/22bd940ed4a1456db62be480eb8b3b83 : SUCCESS in 4m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a071c377bb494db2a02ffec3ad6b7731 : SUCCESS in 3m 51s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/8934248276ba4056b7ceab251ac51f8f : SUCCESS in 4m 04s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/ed20d6231347475b8324950564da9308 : SUCCESS in 5m 36s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7110889f0711424493cea05d05fa71bb : SUCCESS in 11m 26s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/3bcacb0692a148639e19cc2a70a32a4e : SUCCESS in 3m 03s\n- watcher-tempest-functional https://zuul.opendev.org/t/openstack/build/cd879e93e64d4d109bf5dd084673957f : SUCCESS in 31m 36s\n- watcher-tempest-functional-jammy https://zuul.opendev.org/t/openstack/build/642e3889b7ea42a89055dc0997b88a15 : SUCCESS in 29m 38s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/b5259fb8d8dd45f093d0a6872aea4976 : SUCCESS in 45m 38s\n- watcher-tempest-strategies https://zuul.opendev.org/t/openstack/build/0a3f284d4b244c70af48acecf029ed5f : SUCCESS in 50m 56s\n- watcher-tempest-actuator https://zuul.opendev.org/t/openstack/build/78915fc97b7a47339d3e8910dc7b2057 : SUCCESS in 47m 09s\n- watcherclient-tempest-functional https://zuul.opendev.org/t/openstack/build/ef751147b9414148846bdbb818379ae7 : SUCCESS in 33m 44s\n- watcher-tempest-functional-ipv6-only https://zuul.opendev.org/t/openstack/build/6d8f8917cca746fcb255e83d09d03d41 : SUCCESS in 33m 12s\n- watcher-prometheus-integration https://zuul.opendev.org/t/openstack/build/062d3b1403ab4444a8c8426c4d43f445 : SUCCESS in 1h 00m 10s","accounts_in_message":[],"_revision_number":2},{"id":"8019df9be07c1ce5c04577242790a8e29a4cdc74","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2025-07-01 15:46:06.000000000","message":"Patch Set 2: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"a7c241826e3f4aa7bc3f8bc87a4ae8ecca0a7fe1","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2025-07-01 15:54:46.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"fc2ccfc912b26889374af6c7251bf6b6d7aa94ad","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"date":"2025-07-02 06:16:50.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:TRIVIAL_REBASE OR is:MIN\")\n* Verified+1\n","accounts_in_message":[],"_revision_number":3},{"id":"ccd8f404fdfb2630304525551a9e5733d8f53995","tag":"autogenerated:gerrit:setReadyForReview","author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"date":"2025-07-02 06:36:12.000000000","message":"Set Ready For Review","accounts_in_message":[],"_revision_number":3},{"id":"a8c1f486fba668d7243e7b72359001e412a798e6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-07-02 07:29:36.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/4e65193a8a8247729d568e8b5764c9bf\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/44e4ebf807294b0eb09fd6175d051634 : SUCCESS in 5m 42s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2fee3d7ff1e44645ac0ef27c0d6b49ab : SUCCESS in 3m 57s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/a4b3a5582781480b8e332171a994dad3 : SUCCESS in 3m 56s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/431df5538a7147fc9f72b42358edf0f8 : SUCCESS in 6m 03s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2e37e8c7881540b1ae2e0d83f48734ab : SUCCESS in 6m 28s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/e18c32f36e71461bb3d9d6323eed5779 : SUCCESS in 3m 17s\n- watcher-tempest-functional https://zuul.opendev.org/t/openstack/build/20c5c4a40ac2416fb3620371f3c23cce : SUCCESS in 27m 10s\n- watcher-tempest-functional-jammy https://zuul.opendev.org/t/openstack/build/086b5493c7644d9a998cbebf96851cdb : SUCCESS in 26m 39s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/b7c7552bc8f74688a89b81ac531d63e1 : SUCCESS in 43m 02s\n- watcher-tempest-strategies https://zuul.opendev.org/t/openstack/build/ee6727fb1d1243e385135e81db6cdc62 : SUCCESS in 43m 01s\n- watcher-tempest-actuator https://zuul.opendev.org/t/openstack/build/d850c70bb5ed475687424f97429198d0 : SUCCESS in 37m 15s\n- watcherclient-tempest-functional https://zuul.opendev.org/t/openstack/build/8a7d5c9ed381426d9e45049a2624260b : SUCCESS in 35m 50s\n- watcher-tempest-functional-ipv6-only https://zuul.opendev.org/t/openstack/build/58f30f3dd0344248a7065fce3c496fff : SUCCESS in 20m 35s\n- watcher-prometheus-integration https://zuul.opendev.org/t/openstack/build/a6f03076d5674c7aaf27662e30a3ee5b : SUCCESS in 1h 05m 16s","accounts_in_message":[],"_revision_number":3},{"id":"581d06574d9c2f99c948a7ec579a3f0fdee0d57b","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2025-07-08 11:57:08.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"29036a7b07d79a801ac40a262e808d5f76891191","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2025-07-21 18:38:13.000000000","message":"Patch Set 3: Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"6469cfc95a0999349d9a3060c7e5d0cec93e081d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-07-21 18:38:57.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"a8ed7ed9f9e6a6a1f33a1f3eafcb075bcfc9f14a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-07-21 19:28:43.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/12989b55280a49508744570a88d40b76\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/11d9200c597d4513bfe6104ba417169e : SUCCESS in 3m 56s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/78ffbcc352c54b5ab3c054b6163033bc : SUCCESS in 4m 13s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/852208c85f2a4342bf5b575eea88ede1 : SUCCESS in 4m 39s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/725d1cb824a245ad922950d494d1d234 : SUCCESS in 8m 12s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/6f5fad68e9904ccaa697435ceefbc198 : SUCCESS in 3m 53s\n- watcher-tempest-functional https://zuul.opendev.org/t/openstack/build/6678991a02034ecd99119d060b3861c1 : SUCCESS in 36m 34s\n- watcher-tempest-functional-jammy https://zuul.opendev.org/t/openstack/build/d2677e95bca8446ab9e97713257960df : SUCCESS in 26m 46s\n- watcher-tempest-functional-ipv6-only https://zuul.opendev.org/t/openstack/build/e742ea6bf3304cd2a247d15c02adc50d : SUCCESS in 32m 08s","accounts_in_message":[],"_revision_number":3},{"id":"f6c60a88a90c80763ba78e5408f0dc6786484462","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-07-21 19:28:43.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":3},{"id":"674d88aac04d8aac3b6a6ebcb1050c0c451898d5","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-07-21 19:29:52.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/7cb5a0840f184e4b8f57ea28d3ad33a5\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/dd5a6b7f880449a4b5401abdcac22a07 : SUCCESS in 44s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/57bb3dbbe69047c39910a64f7a3dcbd1 : SUCCESS in 43s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"ba417b38bfd60bf6aec8c693682b2bdca1bde943","revisions":{"b6e17fcf78501048985e18e7d1eab11a8870166c":{"kind":"REWORK","_number":1,"created":"2025-06-04 13:15:55.000000000","uploader":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"ref":"refs/changes/67/951767/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/67/951767/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/67/951767/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/67/951767/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/67/951767/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/67/951767/1"}}},"commit":{"parents":[{"commit":"f4bfb105252fe674562ecc4a4c138603d60dd72d","subject":"[host_maintenance] Pass des hostname in add_action solution","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/f4bfb105252fe674562ecc4a4c138603d60dd72d"}]}],"author":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2025-05-14 14:18:56.000000000","tz":120},"committer":{"name":"chandan kumar","email":"chkumar@redhat.com","date":"2025-06-04 13:15:55.000000000","tz":0},"subject":"Fix audit creation with no name and no goal or audit_template","message":"Fix audit creation with no name and no goal or audit_template\n\nCurrently, in that case it was failing because watcher tried to create a\nname based on a goal automatically and the goal is not defined.\n\nThis patch is moving the check for goal specification in the audit\ncreation call earlier, and if there is not goal defined, it returns an\ninvalid call error.\n\nThis patch is also modifying the existing error for this case to check\nthe expected behavior.\n\nCloses-Bug: #2110947\n\nChange-Id: I6f3d73b035e8081e86ce82c205498432f0e0fc33\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/b6e17fcf78501048985e18e7d1eab11a8870166c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/b6e17fcf78501048985e18e7d1eab11a8870166c"}]},"branch":"refs/heads/stable/2025.1"},"6c38cba0ee2d981a8c4faf6769ac0ac7d8db48a4":{"kind":"REWORK","_number":2,"created":"2025-06-04 13:17:45.000000000","uploader":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"ref":"refs/changes/67/951767/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/67/951767/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/67/951767/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/67/951767/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/67/951767/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/67/951767/2"}}},"commit":{"parents":[{"commit":"f4bfb105252fe674562ecc4a4c138603d60dd72d","subject":"[host_maintenance] Pass des hostname in add_action solution","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/f4bfb105252fe674562ecc4a4c138603d60dd72d"}]}],"author":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2025-05-14 14:18:56.000000000","tz":120},"committer":{"name":"Chandan Kumar (raukadah)","email":"chkumar@redhat.com","date":"2025-06-04 13:17:32.000000000","tz":330},"subject":"Fix audit creation with no name and no goal or audit_template","message":"Fix audit creation with no name and no goal or audit_template\n\nCurrently, in that case it was failing because watcher tried to create a\nname based on a goal automatically and the goal is not defined.\n\nThis patch is moving the check for goal specification in the audit\ncreation call earlier, and if there is not goal defined, it returns an\ninvalid call error.\n\nThis patch is also modifying the existing error for this case to check\nthe expected behavior.\n\nCloses-Bug: #2110947\n\nChange-Id: I6f3d73b035e8081e86ce82c205498432f0e0fc33\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/6c38cba0ee2d981a8c4faf6769ac0ac7d8db48a4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/6c38cba0ee2d981a8c4faf6769ac0ac7d8db48a4"}]},"branch":"refs/heads/stable/2025.1"},"ba417b38bfd60bf6aec8c693682b2bdca1bde943":{"kind":"REWORK","_number":3,"created":"2025-07-02 06:16:50.000000000","uploader":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"ref":"refs/changes/67/951767/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/67/951767/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/67/951767/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/67/951767/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/67/951767/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/67/951767/3"}}},"commit":{"parents":[{"commit":"1d7f1636510c5a718e2e8335f2404a41c1640d9c","subject":"Added unit test to validate audit creation with no goal and no name","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/1d7f1636510c5a718e2e8335f2404a41c1640d9c"}]}],"author":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2025-05-14 14:18:56.000000000","tz":120},"committer":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2025-07-02 06:16:12.000000000","tz":120},"subject":"Fix audit creation with no name and no goal or audit_template","message":"Fix audit creation with no name and no goal or audit_template\n\nCurrently, in that case it was failing because watcher tried to create a\nname based on a goal automatically and the goal is not defined.\n\nThis patch is moving the check for goal specification in the audit\ncreation call earlier, and if there is not goal defined, it returns an\ninvalid call error.\n\nThis patch is also modifying the existing error for this case to check\nthe expected behavior.\n\nCloses-Bug: #2110947\n\nChange-Id: I6f3d73b035e8081e86ce82c205498432f0e0fc33\n(cherry picked from commit bf6a28bd1e2d4066f2a736eac065b398f7dd5e09)\nSigned-off-by: Alfredo Moralejo \u003camoralej@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/ba417b38bfd60bf6aec8c693682b2bdca1bde943"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/ba417b38bfd60bf6aec8c693682b2bdca1bde943"}]},"branch":"refs/heads/stable/2025.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}