)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1777881232a9f984c72f05ea6857e2a99b5c041c","unresolved":true,"context_lines":[{"line_number":10,"context_line":"reported in Kb, so it applies conversion from Ki to Mi which is the"},{"line_number":11,"context_line":"unit it operates with in the strategy."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"However, the datasource drivers report host_ram_usage in MB [1], so that"},{"line_number":14,"context_line":"conversion is actually leading to wrong calculations."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch is removing the conversion KB-\u003eMB when getting the host load."},{"line_number":17,"context_line":"It is also fixing the mocked memory usage data to report it in MB and"},{"line_number":18,"context_line":"adding more unit tests for the check_threshold method so that it covers"},{"line_number":19,"context_line":"the memory based strategy execution, validates the calculated sd  and"},{"line_number":20,"context_line":"adds the cases where it is below the threshold."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1] https://github.com/openstack/watcher/blob/15981117ee28627f235264e505e1e0d5956cf4e4/watcher/decision_engine/datasources/base.py#L177-L183"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"cef4dc7e_18f1d507","line":20,"range":{"start_line":13,"start_character":0,"end_line":20,"end_character":47},"updated":"2025-06-19 11:54:11.000000000","message":"so we need to update this to refelct what the patch now does","commit_id":"71b23d50fb71b086256f76927675d6cd3b120b61"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"00ed69ed09bc75571a9e0d2049f217980a226513","unresolved":false,"context_lines":[{"line_number":10,"context_line":"reported in Kb, so it applies conversion from Ki to Mi which is the"},{"line_number":11,"context_line":"unit it operates with in the strategy."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"However, the datasource drivers report host_ram_usage in MB [1], so that"},{"line_number":14,"context_line":"conversion is actually leading to wrong calculations."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch is removing the conversion KB-\u003eMB when getting the host load."},{"line_number":17,"context_line":"It is also fixing the mocked memory usage data to report it in MB and"},{"line_number":18,"context_line":"adding more unit tests for the check_threshold method so that it covers"},{"line_number":19,"context_line":"the memory based strategy execution, validates the calculated sd  and"},{"line_number":20,"context_line":"adds the cases where it is below the threshold."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1] https://github.com/openstack/watcher/blob/15981117ee28627f235264e505e1e0d5956cf4e4/watcher/decision_engine/datasources/base.py#L177-L183"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"12c1e49c_f5ebe3e2","line":20,"range":{"start_line":13,"start_character":0,"end_line":20,"end_character":47},"in_reply_to":"1bb423f2_faac99f1","updated":"2025-06-20 11:02:10.000000000","message":"Done","commit_id":"71b23d50fb71b086256f76927675d6cd3b120b61"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"6868d3e7688778886707deb8c5bff43a04c4b5d7","unresolved":true,"context_lines":[{"line_number":10,"context_line":"reported in Kb, so it applies conversion from Ki to Mi which is the"},{"line_number":11,"context_line":"unit it operates with in the strategy."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"However, the datasource drivers report host_ram_usage in MB [1], so that"},{"line_number":14,"context_line":"conversion is actually leading to wrong calculations."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch is removing the conversion KB-\u003eMB when getting the host load."},{"line_number":17,"context_line":"It is also fixing the mocked memory usage data to report it in MB and"},{"line_number":18,"context_line":"adding more unit tests for the check_threshold method so that it covers"},{"line_number":19,"context_line":"the memory based strategy execution, validates the calculated sd  and"},{"line_number":20,"context_line":"adds the cases where it is below the threshold."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1] https://github.com/openstack/watcher/blob/15981117ee28627f235264e505e1e0d5956cf4e4/watcher/decision_engine/datasources/base.py#L177-L183"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1bb423f2_faac99f1","line":20,"range":{"start_line":13,"start_character":0,"end_line":20,"end_character":47},"in_reply_to":"cef4dc7e_18f1d507","updated":"2025-06-19 14:06:43.000000000","message":"damn, thanks","commit_id":"71b23d50fb71b086256f76927675d6cd3b120b61"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"2615aa13d3e16ed8ade969841743f084988fdacd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7ecd0863_16c8db13","updated":"2025-06-10 15:10:08.000000000","message":"Bug reproduced both for gnocchi and prometheus store backends in https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/952225 .\n\nExecutions without the patch:\n\n- https://zuul.opendev.org/t/openstack/build/259d3f425f51409aa80e489e7b6e9393\n\nLog in https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_259/openstack/259d3f425f51409aa80e489e7b6e9393/controller/logs/screen-watcher-decision-engine.txt\n\nJun 10 12:31:54.339903 np0041075663 watcher-decision-engine[93432]: INFO watcher.decision_engine.strategy.strategies.workload_stabilization [None req-791f0bca-e850-4145-b149-ec2696aed04a None None] Standard deviation for instance_ram_usage is 0.0002882587205641607.\n\n- https://zuul.opendev.org/t/openstack/build/58cdc47f992944adbd789bd9ef728b84\n\nLog in https://48f2879a4f28ca42458a-5e9e014bbb914c03e8d5277ea7a5cf3c.ssl.cf5.rackcdn.com/openstack/58cdc47f992944adbd789bd9ef728b84/controller/logs/screen-watcher-decision-engine.txt\n\nJun 10 13:13:44.449709 np0041075664 watcher-decision-engine[101595]: INFO watcher.decision_engine.strategy.strategies.workload_stabilization [None req-2e8c79c9-b077-48a5-8c0c-443460c995a6 None None] Standard deviation for instance_ram_usage is 0.00028210449250807624.\n\n\nExecutions with the patch:\n\n- https://zuul.opendev.org/t/openstack/build/7552d1e141704a8491022c190de4e591\n\nLog in https://baa5f416f17928133dde-d871ad76f4880f7f2af489fae47ba763.ssl.cf1.rackcdn.com/openstack/7552d1e141704a8491022c190de4e591/controller/logs/screen-watcher-decision-engine.txt\n\nJun 10 14:15:13.448559 np0041076822 watcher-decision-engine[93927]: INFO watcher.decision_engine.strategy.strategies.workload_stabilization [None req-9683738d-16bc-469d-baf9-4b68f559c00d None None] Standard deviation for instance_ram_usage is 0.30031070243943403.\n\n- https://zuul.opendev.org/t/openstack/build/ff6d1e4335bf4bf19d8101ad72dbd73a\n\n\nLog in https://6ec4538e5bbf5420350f-e44509a4e2cdd0df87d44b1b5e050fc0.ssl.cf5.rackcdn.com/openstack/ff6d1e4335bf4bf19d8101ad72dbd73a/controller/logs/screen-watcher-decision-engine.txt\n\nJun 10 14:39:24.641125 np0041076824 watcher-decision-engine[101108]: INFO watcher.decision_engine.strategy.strategies.workload_stabilization [None req-bd1afcf8-568f-487e-a12a-577fb967b064 None None] Standard deviation for instance_ram_usage is 0.29022851906966496.","commit_id":"71b23d50fb71b086256f76927675d6cd3b120b61"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"b80f9fb81e01ed56c5a5364b0b0ea98feee69761","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ff6926bf_fdff4cf4","updated":"2025-06-13 07:18:11.000000000","message":"lgtm","commit_id":"71b23d50fb71b086256f76927675d6cd3b120b61"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"97e988bb2053bad8aebea76c7c9d5f4d4aa1989f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8e1b7c67_3795ae41","updated":"2025-06-12 12:41:19.000000000","message":"lgtm, just left a question for clarification","commit_id":"71b23d50fb71b086256f76927675d6cd3b120b61"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1777881232a9f984c72f05ea6857e2a99b5c041c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"16f60511_19efeb98","updated":"2025-06-19 11:54:11.000000000","message":"-1 is mainly for the commit message the rest are just nits","commit_id":"68f11c21f4bfe6fc8a1ae8bb9f842b276a063a6d"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6396f4921c26c1d0156fdf403e067bc0aac0b418","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ad14fb0a_e8905cb9","updated":"2025-06-20 15:30:45.000000000","message":"LGTM, thanks for adding more unit tests to the strategy.","commit_id":"6ea362da0ba49dc58ded46647fc9a4d1befe7de0"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"bb50f43573bcb0dfed76c1781e9c8a71ee1abde4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"62b9aa67_f675c1d0","updated":"2025-06-19 15:55:50.000000000","message":"Tested in https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/952807 wich includes https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/952897","commit_id":"6ea362da0ba49dc58ded46647fc9a4d1befe7de0"}],"releasenotes/notes/bug-2113776-4bd314fb46623fbc.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1777881232a9f984c72f05ea6857e2a99b5c041c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When using the `workload_stabilization` strategy with `instance_ram_usage`"},{"line_number":5,"context_line":"    metric, the host metric for the ram usage was wrongly reported which lead"},{"line_number":6,"context_line":"    to incorrect standard deviation and action plans."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    The host ram usage metric is now properly reported and the strategy"},{"line_number":9,"context_line":"    `workload_stabilization` calculates the standard deviation properly."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"92eea9fc_a0b56689","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":53},"updated":"2025-06-19 11:54:11.000000000","message":"this is fin as it is but you could give lightly more context\n\nspecificly you could jsut say\n\n\n```suggestion\n    When using the `workload_stabilization` strategy with `instance_ram_usage`\n    metric, the host metric for the ram usage was wrongly reported with the incorrect uni which lead\n    to incorrect standard deviation and action plans due to the application of the wrong scale factor in the algorithm.\n```\n\nbut its ok  as is too","commit_id":"71b23d50fb71b086256f76927675d6cd3b120b61"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"00ed69ed09bc75571a9e0d2049f217980a226513","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When using the `workload_stabilization` strategy with `instance_ram_usage`"},{"line_number":5,"context_line":"    metric, the host metric for the ram usage was wrongly reported which lead"},{"line_number":6,"context_line":"    to incorrect standard deviation and action plans."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    The host ram usage metric is now properly reported and the strategy"},{"line_number":9,"context_line":"    `workload_stabilization` calculates the standard deviation properly."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5b6f13a4_eb619b30","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":53},"in_reply_to":"92eea9fc_a0b56689","updated":"2025-06-20 11:02:10.000000000","message":"Done","commit_id":"71b23d50fb71b086256f76927675d6cd3b120b61"}],"watcher/decision_engine/strategy/strategies/workload_stabilization.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"675bbca58a0ccb76eb87a46ee04499e3454d32dd","unresolved":true,"context_lines":[{"line_number":323,"context_line":"                    break"},{"line_number":324,"context_line":"                else:"},{"line_number":325,"context_line":"                    if meter_name \u003d\u003d \u0027host_ram_usage\u0027:"},{"line_number":326,"context_line":"                        avg_meter /\u003d oslo_utils.units.Ki"},{"line_number":327,"context_line":"                    if meter_name \u003d\u003d \u0027host_cpu_usage\u0027:"},{"line_number":328,"context_line":"                        avg_meter /\u003d 100"},{"line_number":329,"context_line":"                LOG.debug(\u0027Load of %(metric)s for %(node)s is %(value)s\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bcce7232_a79ee021","side":"PARENT","line":326,"updated":"2025-06-18 17:20:12.000000000","message":"to do this change here you need to prove that all data soruces report in MB.\nhave you review them?","commit_id":"15981117ee28627f235264e505e1e0d5956cf4e4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1777881232a9f984c72f05ea6857e2a99b5c041c","unresolved":true,"context_lines":[{"line_number":323,"context_line":"                    break"},{"line_number":324,"context_line":"                else:"},{"line_number":325,"context_line":"                    if meter_name \u003d\u003d \u0027host_ram_usage\u0027:"},{"line_number":326,"context_line":"                        avg_meter /\u003d oslo_utils.units.Ki"},{"line_number":327,"context_line":"                    if meter_name \u003d\u003d \u0027host_cpu_usage\u0027:"},{"line_number":328,"context_line":"                        avg_meter /\u003d 100"},{"line_number":329,"context_line":"                LOG.debug(\u0027Load of %(metric)s for %(node)s is %(value)s\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"a1d6a7eb_1b976988","side":"PARENT","line":326,"in_reply_to":"84010254_6f14ce9d","updated":"2025-06-19 11:54:11.000000000","message":"the other option is to normalise all the data soruce to MB and audit the usage. \ni suggeste updating the doc string and revertign to KB becuase it feel less error prone then makeing sure we have update all the usages properly.\n\n\nits less of a code change to change the new prometheus driver to align to what gnocci did.\n\nack on the temepst changes too. medium term i think we shoudl change the interface away form float to towards a value type that hold a metric name/descriptoiin, the raw value and the unit so that we can safely convert ectra without loosing track of the size of the data.","commit_id":"15981117ee28627f235264e505e1e0d5956cf4e4"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"00ed69ed09bc75571a9e0d2049f217980a226513","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                    break"},{"line_number":324,"context_line":"                else:"},{"line_number":325,"context_line":"                    if meter_name \u003d\u003d \u0027host_ram_usage\u0027:"},{"line_number":326,"context_line":"                        avg_meter /\u003d oslo_utils.units.Ki"},{"line_number":327,"context_line":"                    if meter_name \u003d\u003d \u0027host_cpu_usage\u0027:"},{"line_number":328,"context_line":"                        avg_meter /\u003d 100"},{"line_number":329,"context_line":"                LOG.debug(\u0027Load of %(metric)s for %(node)s is %(value)s\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fc3d8c54_f0bd163b","side":"PARENT","line":326,"in_reply_to":"a1d6a7eb_1b976988","updated":"2025-06-20 11:02:10.000000000","message":"Done","commit_id":"15981117ee28627f235264e505e1e0d5956cf4e4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dd64bb66be1267675ddcef2547890f5161154e32","unresolved":true,"context_lines":[{"line_number":323,"context_line":"                    break"},{"line_number":324,"context_line":"                else:"},{"line_number":325,"context_line":"                    if meter_name \u003d\u003d \u0027host_ram_usage\u0027:"},{"line_number":326,"context_line":"                        avg_meter /\u003d oslo_utils.units.Ki"},{"line_number":327,"context_line":"                    if meter_name \u003d\u003d \u0027host_cpu_usage\u0027:"},{"line_number":328,"context_line":"                        avg_meter /\u003d 100"},{"line_number":329,"context_line":"                LOG.debug(\u0027Load of %(metric)s for %(node)s is %(value)s\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bcdc1530_a4d3ba32","side":"PARENT","line":326,"in_reply_to":"bcce7232_a79ee021","updated":"2025-06-18 17:35:00.000000000","message":"ok this is wrong\n\nwatcher get_host_ram_usage in the gnocci datasouce\n\nhttps://github.com/openstack/watcher/blob/master/watcher/decision_engine/datasources/gnocchi.py#L215-L220\n\nuses the hardware.memory.used metric form gnocci\n\nhttps://github.com/openstack/watcher/blob/master/watcher/decision_engine/datasources/gnocchi.py#L37\n\nwhich is generate by celimeter \nhttps://github.com/openstack/ceilometer/blob/024ace9916d328b9797b8ec06000e0ec00d5b211/ceilometer/hardware/pollsters/memory.py#L26-L39\n\nand as we can see in https://github.com/openstack/ceilometer/commit/024ace9916d328b9797b8ec06000e0ec00d5b211\n\nand in the link code the unit is KB which si really KiB\n\nthat means we have to modify the promethous data souce to also report in KiB even if we will undo that again here.\n\nso once again we cannot trust the doc string in \n\nhttps://github.com/openstack/watcher/blob/master/watcher/decision_engine/datasources/base.py#L176-L183\n\nas almost every one is incorrect.\n\nso you should instead fix it here\n\nhttps://github.com/openstack/watcher/blob/master/watcher/decision_engine/datasources/prometheus.py#L477-L484","commit_id":"15981117ee28627f235264e505e1e0d5956cf4e4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"63bf3fdd80b6cefdb46ce0dffbc828c6c1c80a21","unresolved":true,"context_lines":[{"line_number":323,"context_line":"                    break"},{"line_number":324,"context_line":"                else:"},{"line_number":325,"context_line":"                    if meter_name \u003d\u003d \u0027host_ram_usage\u0027:"},{"line_number":326,"context_line":"                        avg_meter /\u003d oslo_utils.units.Ki"},{"line_number":327,"context_line":"                    if meter_name \u003d\u003d \u0027host_cpu_usage\u0027:"},{"line_number":328,"context_line":"                        avg_meter /\u003d 100"},{"line_number":329,"context_line":"                LOG.debug(\u0027Load of %(metric)s for %(node)s is %(value)s\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"d24926d8_5d3dd17e","side":"PARENT","line":326,"in_reply_to":"bcdc1530_a4d3ba32","updated":"2025-06-18 17:48:41.000000000","message":"ths was originally added in \n\nhttps://github.com/openstack/watcher/commit/ef0d133ba83005a69b31055ab4e6e11716a9f8fe\n\nmay have been related to https://bugs.launchpad.net/ceilometer/+bug/1479491\n\nhttps://github.com/openstack/ceilometer/commit/024ace9916d328b9797b8ec06000e0ec00d5b211\n\nin anycase i think its cear tha tthe metric use by ceimpoent and ghonic were in KB and this conversion here was and is still valid.","commit_id":"15981117ee28627f235264e505e1e0d5956cf4e4"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"74cc35bda0c3e6895d3c62dd7969418e40e49ef2","unresolved":true,"context_lines":[{"line_number":323,"context_line":"                    break"},{"line_number":324,"context_line":"                else:"},{"line_number":325,"context_line":"                    if meter_name \u003d\u003d \u0027host_ram_usage\u0027:"},{"line_number":326,"context_line":"                        avg_meter /\u003d oslo_utils.units.Ki"},{"line_number":327,"context_line":"                    if meter_name \u003d\u003d \u0027host_cpu_usage\u0027:"},{"line_number":328,"context_line":"                        avg_meter /\u003d 100"},{"line_number":329,"context_line":"                LOG.debug(\u0027Load of %(metric)s for %(node)s is %(value)s\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"84010254_6f14ce9d","side":"PARENT","line":326,"in_reply_to":"d24926d8_5d3dd17e","updated":"2025-06-19 09:25:15.000000000","message":"Actually, vm_workload_consolidation strategy is also assuming it in kb https://github.com/openstack/watcher/blob/master/watcher/decision_engine/strategy/strategies/vm_workload_consolidation.py#L357 so, yes, i think it\u0027s probably better to move it to kb in prometheus and update docstring. We also need to fix the host ram metrics we are injecting in the tempest plugin for gnocchi, which currently is in mb.","commit_id":"15981117ee28627f235264e505e1e0d5956cf4e4"}],"watcher/tests/decision_engine/model/gnocchi_metrics.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"675bbca58a0ccb76eb87a46ee04499e3454d32dd","unresolved":true,"context_lines":[{"line_number":120,"context_line":"        uuid \u003d resource.uuid"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        mock \u003d {}"},{"line_number":123,"context_line":"        # Gnocchi returns hardware.memory.used samples in KB."},{"line_number":124,"context_line":"        mock[\u0027Node_0\u0027] \u003d 7 * oslo_utils.units.Ki"},{"line_number":125,"context_line":"        mock[\u0027Node_1\u0027] \u003d 5 * oslo_utils.units.Ki"},{"line_number":126,"context_line":"        mock[\u0027Node_2\u0027] \u003d 29 * oslo_utils.units.Ki"}],"source_content_type":"text/x-python","patch_set":2,"id":"b708f076_6d117bb9","side":"PARENT","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":61},"updated":"2025-06-18 17:20:12.000000000","message":"i woudl need to check but if this comemnt was/is corect then we can change this","commit_id":"15981117ee28627f235264e505e1e0d5956cf4e4"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"00ed69ed09bc75571a9e0d2049f217980a226513","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        uuid \u003d resource.uuid"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        mock \u003d {}"},{"line_number":123,"context_line":"        # Gnocchi returns hardware.memory.used samples in KB."},{"line_number":124,"context_line":"        mock[\u0027Node_0\u0027] \u003d 7 * oslo_utils.units.Ki"},{"line_number":125,"context_line":"        mock[\u0027Node_1\u0027] \u003d 5 * oslo_utils.units.Ki"},{"line_number":126,"context_line":"        mock[\u0027Node_2\u0027] \u003d 29 * oslo_utils.units.Ki"}],"source_content_type":"text/x-python","patch_set":2,"id":"a5048229_f8f68f6f","side":"PARENT","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":61},"in_reply_to":"53db24fb_b69a9e36","updated":"2025-06-20 11:02:10.000000000","message":"Done","commit_id":"15981117ee28627f235264e505e1e0d5956cf4e4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"63bf3fdd80b6cefdb46ce0dffbc828c6c1c80a21","unresolved":true,"context_lines":[{"line_number":120,"context_line":"        uuid \u003d resource.uuid"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        mock \u003d {}"},{"line_number":123,"context_line":"        # Gnocchi returns hardware.memory.used samples in KB."},{"line_number":124,"context_line":"        mock[\u0027Node_0\u0027] \u003d 7 * oslo_utils.units.Ki"},{"line_number":125,"context_line":"        mock[\u0027Node_1\u0027] \u003d 5 * oslo_utils.units.Ki"},{"line_number":126,"context_line":"        mock[\u0027Node_2\u0027] \u003d 29 * oslo_utils.units.Ki"}],"source_content_type":"text/x-python","patch_set":2,"id":"53db24fb_b69a9e36","side":"PARENT","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":61},"in_reply_to":"b708f076_6d117bb9","updated":"2025-06-18 17:48:41.000000000","message":"Changing a unit test like this that explicitly has a comment to describe the behavior should almost always be a red flag that your breaking something.\n\ni know we have littel trust in the current test quite butwe should still pause if we find our sleve modifyitng somethign liek this and dig deeper before proceeding.","commit_id":"15981117ee28627f235264e505e1e0d5956cf4e4"}],"watcher/tests/decision_engine/strategy/strategies/test_workload_stabilization.py":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"97e988bb2053bad8aebea76c7c9d5f4d4aa1989f","unresolved":true,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def test_check_threshold(self):"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        # sd for 0.05, 0.05, 0.07, 0.07, 0.8"},{"line_number":217,"context_line":"        test_cpu_sd \u003d 0.296"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        self.m_c_model.return_value \u003d self.fake_c_cluster.generate_scenario_1()"}],"source_content_type":"text/x-python","patch_set":2,"id":"97cc8ef7_07e5bf58","line":216,"updated":"2025-06-12 12:41:19.000000000","message":"are these numbers the loads of the nodes in the fake cluster?","commit_id":"71b23d50fb71b086256f76927675d6cd3b120b61"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"c4a3afae24c142b3bf95746d545ace1705cea13f","unresolved":true,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def test_check_threshold(self):"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        # sd for 0.05, 0.05, 0.07, 0.07, 0.8"},{"line_number":217,"context_line":"        test_cpu_sd \u003d 0.296"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        self.m_c_model.return_value \u003d self.fake_c_cluster.generate_scenario_1()"}],"source_content_type":"text/x-python","patch_set":2,"id":"99862ba7_6eaa0139","line":216,"in_reply_to":"97cc8ef7_07e5bf58","updated":"2025-06-12 12:53:51.000000000","message":"exactly","commit_id":"71b23d50fb71b086256f76927675d6cd3b120b61"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"31a023746212b2d1d0c7e4ad25823793b75328c2","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    def test_check_threshold(self):"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        # sd for 0.05, 0.05, 0.07, 0.07, 0.8"},{"line_number":217,"context_line":"        test_cpu_sd \u003d 0.296"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        self.m_c_model.return_value \u003d self.fake_c_cluster.generate_scenario_1()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da364c2a_a447c6a0","line":216,"in_reply_to":"99862ba7_6eaa0139","updated":"2025-06-13 07:18:20.000000000","message":"Acknowledged","commit_id":"71b23d50fb71b086256f76927675d6cd3b120b61"}]}