)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28647,"name":"David","display_name":"morenod","email":"dsanzmor@redhat.com","username":"morenod"},"change_message_id":"d70e8a2ea7030213aab1aee5cbff6e46cef1470c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1c922a70_71803341","updated":"2025-06-11 15:51:37.000000000","message":"Guys please, this is important for the workload_balance tests","commit_id":"3860de0b1efba2101615ae782ba6aab3de0964e0"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8db0a5ecd6ae3e5f74ecb1c6614e903e7c136747","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8aaa9e97_d877b324","updated":"2025-06-16 14:40:50.000000000","message":"lgtm, comparing previous query(1) vs new one now(2), makes more sense to agreggate by the label.\n1:\nclamp_max((avg by (instance)(rate(ceilometer_cpu{resource\u003d\u0027a3e2a454-0dff-46ce-8379-44c527d90166\u0027}[300s]))/10e+8) *(100/1), 100)\n2:\nclamp_max((avg by (resource)(rate(ceilometer_cpu{resource\u003d\u00272ad741e8-bfe2-4261-936b-3982b1256139\u0027}[300s]))/10e+8)*(100/1), 100)","commit_id":"3860de0b1efba2101615ae782ba6aab3de0964e0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ceacc964fafd4c7b464bc0bf2b1a7d1e68191553","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c3307aac_78d0b94c","updated":"2025-06-19 14:05:13.000000000","message":"thanks this should be back-ported to 2025.1","commit_id":"3860de0b1efba2101615ae782ba6aab3de0964e0"}],"watcher/decision_engine/datasources/prometheus.py":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"a7a3aa72c9f8e72319e5d1a940d003b18cece435","unresolved":true,"context_lines":[{"line_number":343,"context_line":"                vcpus \u003d 1"},{"line_number":344,"context_line":"            query_args \u003d ("},{"line_number":345,"context_line":"                \"clamp_max((%(agg)s by (%(label)s)\""},{"line_number":346,"context_line":"                \"(rate(%(meter)s{%(label)s\u003d\u0027%(label_value)s\u0027}[%(period)ss]))\""},{"line_number":347,"context_line":"                \"/10e+8) *(100/%(vcpus)s), 100)\""},{"line_number":348,"context_line":"                % {\u0027label\u0027: uuid_label_key, \u0027label_value\u0027: instance_label,"},{"line_number":349,"context_line":"                   \u0027agg\u0027: aggregate, \u0027meter\u0027: meter, \u0027period\u0027: period,"}],"source_content_type":"text/x-python","patch_set":1,"id":"eacf1fff_f073171d","line":346,"updated":"2025-06-12 12:44:06.000000000","message":"is the `ss` after `period` correct, or is it a typo?","commit_id":"3860de0b1efba2101615ae782ba6aab3de0964e0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4cf351f75db41cb3fd86bfd878e0d4a7f7fa8c10","unresolved":false,"context_lines":[{"line_number":343,"context_line":"                vcpus \u003d 1"},{"line_number":344,"context_line":"            query_args \u003d ("},{"line_number":345,"context_line":"                \"clamp_max((%(agg)s by (%(label)s)\""},{"line_number":346,"context_line":"                \"(rate(%(meter)s{%(label)s\u003d\u0027%(label_value)s\u0027}[%(period)ss]))\""},{"line_number":347,"context_line":"                \"/10e+8) *(100/%(vcpus)s), 100)\""},{"line_number":348,"context_line":"                % {\u0027label\u0027: uuid_label_key, \u0027label_value\u0027: instance_label,"},{"line_number":349,"context_line":"                   \u0027agg\u0027: aggregate, \u0027meter\u0027: meter, \u0027period\u0027: period,"}],"source_content_type":"text/x-python","patch_set":1,"id":"0dac0af1_82532e27","line":346,"in_reply_to":"069dfdd2_d83e6b68","updated":"2025-06-13 10:20:50.000000000","message":"so this is one of the reason i prefer to use f strings\n\nyou do not need to specify the type.\n\n\nif we proceed with usign ruff for this repo i belive cofnvertion to f string is one of hte py upgrade capabliteis tehy built in.\n\nwe shoudl prefer them in general but ys the code is correct\n\nfirst s is to say its a string the second s is just an s for seconds.","commit_id":"3860de0b1efba2101615ae782ba6aab3de0964e0"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"e2e153715a7f653589aaaf2b6590e2c1d2aa16f6","unresolved":false,"context_lines":[{"line_number":343,"context_line":"                vcpus \u003d 1"},{"line_number":344,"context_line":"            query_args \u003d ("},{"line_number":345,"context_line":"                \"clamp_max((%(agg)s by (%(label)s)\""},{"line_number":346,"context_line":"                \"(rate(%(meter)s{%(label)s\u003d\u0027%(label_value)s\u0027}[%(period)ss]))\""},{"line_number":347,"context_line":"                \"/10e+8) *(100/%(vcpus)s), 100)\""},{"line_number":348,"context_line":"                % {\u0027label\u0027: uuid_label_key, \u0027label_value\u0027: instance_label,"},{"line_number":349,"context_line":"                   \u0027agg\u0027: aggregate, \u0027meter\u0027: meter, \u0027period\u0027: period,"}],"source_content_type":"text/x-python","patch_set":1,"id":"069dfdd2_d83e6b68","line":346,"in_reply_to":"af12dc4b_f930bc6b","updated":"2025-06-12 14:57:50.000000000","message":"yes, variable replacement is done with `%(variable_name)s` including the ending s, i.e. `%(period)s` , then we need to add the s that we want it to add as time unit is seconds, being i.e. [300s].","commit_id":"3860de0b1efba2101615ae782ba6aab3de0964e0"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"fdb9b65ae27eed861d7be1599af9f0f9d954e9a6","unresolved":true,"context_lines":[{"line_number":343,"context_line":"                vcpus \u003d 1"},{"line_number":344,"context_line":"            query_args \u003d ("},{"line_number":345,"context_line":"                \"clamp_max((%(agg)s by (%(label)s)\""},{"line_number":346,"context_line":"                \"(rate(%(meter)s{%(label)s\u003d\u0027%(label_value)s\u0027}[%(period)ss]))\""},{"line_number":347,"context_line":"                \"/10e+8) *(100/%(vcpus)s), 100)\""},{"line_number":348,"context_line":"                % {\u0027label\u0027: uuid_label_key, \u0027label_value\u0027: instance_label,"},{"line_number":349,"context_line":"                   \u0027agg\u0027: aggregate, \u0027meter\u0027: meter, \u0027period\u0027: period,"}],"source_content_type":"text/x-python","patch_set":1,"id":"af12dc4b_f930bc6b","line":346,"in_reply_to":"eacf1fff_f073171d","updated":"2025-06-12 13:00:12.000000000","message":"ok, after a closer look it looks correct, the first s is part of the `period` formatting and the second s is for prometheus right? Using newer syntax like f-strings might help with clarity here imo","commit_id":"3860de0b1efba2101615ae782ba6aab3de0964e0"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"bfa19309c7d3898016ee6a1bad0f7b70f4e9ca40","unresolved":true,"context_lines":[{"line_number":343,"context_line":"                vcpus \u003d 1"},{"line_number":344,"context_line":"            query_args \u003d ("},{"line_number":345,"context_line":"                \"clamp_max((%(agg)s by (%(label)s)\""},{"line_number":346,"context_line":"                \"(rate(%(meter)s{%(label)s\u003d\u0027%(label_value)s\u0027}[%(period)ss]))\""},{"line_number":347,"context_line":"                \"/10e+8) *(100/%(vcpus)s), 100)\""},{"line_number":348,"context_line":"                % {\u0027label\u0027: uuid_label_key, \u0027label_value\u0027: instance_label,"},{"line_number":349,"context_line":"                   \u0027agg\u0027: aggregate, \u0027meter\u0027: meter, \u0027period\u0027: period,"}],"source_content_type":"text/x-python","patch_set":1,"id":"c63c339c_b6023876","line":346,"in_reply_to":"eacf1fff_f073171d","updated":"2025-06-12 12:55:44.000000000","message":"second s is from seconds, see previously it was %ss","commit_id":"3860de0b1efba2101615ae782ba6aab3de0964e0"}]}