)]}'
{"id":"openstack%2Fwatcher~952999","triplet_id":"openstack%2Fwatcher~stable%2F2025.1~Idc060d1e709c0265c64ada16062c3a206c6b04fa","project":"openstack/watcher","branch":"stable/2025.1","topic":"bug2113776-stable/2025.1","attention_set":{},"removed_from_attention_set":{"16312":{"account":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"last_update":"2025-06-27 16:59:14.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Idc060d1e709c0265c64ada16062c3a206c6b04fa","subject":"Use KiB as unit for host_ram_usage when using prometheus datasource","status":"MERGED","created":"2025-06-20 16:35:40.000000000","updated":"2025-06-27 17:00:09.000000000","submitted":"2025-06-27 16:59:14.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"952999-bug2113776-stable/2025.1","cherry_pick_of_change":952212,"cherry_pick_of_patch_set":4,"meta_rev_id":"bdbe2a1b1bda67507e138e38cc7f4b695827e6db","_number":952999,"virtual_id_number":952999,"owner":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2025-06-27 16:59:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"recommended":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2025-06-24 04:08:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},{"value":2,"date":"2025-06-27 16:21:13.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":2,"date":"2025-06-20 21:13:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},{"value":1,"date":"2025-06-27 16:21:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-06-20 17:33:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-06-20 21:13:55.000000000","updated_by":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"reviewer":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"state":"REVIEWER"},{"updated":"2025-06-24 04:08:49.000000000","updated_by":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"reviewer":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"state":"REVIEWER"},{"updated":"2025-06-27 16:21:13.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"}],"messages":[{"id":"684042dddba0d992ccf6f798722c9f1856ac15d9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"date":"2025-06-20 16:35:40.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"dc212ccf5a5eb7c402e1b27d36d6db5b65fc2d1a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-06-20 17:33:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1959a5539c8b4555a283c6892c5b0a44\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d40cf6c4418347738106f8d45b585a3d : SUCCESS in 5m 10s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1ab79b7808ee4310975240b60d09d340 : SUCCESS in 4m 17s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/9424399051ca40018aae13a65343231a : SUCCESS in 3m 53s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/1ca9a763e10b408c8a097ba2153de14a : SUCCESS in 6m 27s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b2e75ef92b8942989f4c9e8bc65e3d06 : SUCCESS in 7m 24s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/47d8b72296ca447c8a0ca6cbaf48ab85 : SUCCESS in 3m 19s\n- watcher-tempest-functional https://zuul.opendev.org/t/openstack/build/4b91b70d783b4f0782bc79f145027aa5 : SUCCESS in 23m 58s\n- watcher-tempest-functional-jammy https://zuul.opendev.org/t/openstack/build/0a6e042e4dc8453180dc6753a6692c43 : SUCCESS in 22m 34s\n- watcher-grenade https://zuul.opendev.org/t/openstack/build/275c8550b1b1407fb61083aed881a1e4 : SUCCESS in 48m 04s\n- watcher-tempest-strategies https://zuul.opendev.org/t/openstack/build/8227885f4c1149228af6ede4cf11310d : SUCCESS in 43m 37s\n- watcher-tempest-actuator https://zuul.opendev.org/t/openstack/build/b04520c07b6148a2b75ceebb3ef25009 : SUCCESS in 37m 37s\n- watcherclient-tempest-functional https://zuul.opendev.org/t/openstack/build/7a7b772c35e14d2aab2057dfbac30618 : SUCCESS in 25m 41s\n- watcher-tempest-functional-ipv6-only https://zuul.opendev.org/t/openstack/build/6a174ef2837145d38c7aea75523810af : SUCCESS in 25m 47s\n- watcher-prometheus-integration https://zuul.opendev.org/t/openstack/build/48c327a1fb5b467cbbd195999164c350 : SUCCESS in 51m 47s","accounts_in_message":[],"_revision_number":1},{"id":"3321a488bf0e5e3a0cfe34fe01e2107868cb9656","author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"date":"2025-06-20 21:13:55.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2e809a77f0e69abf6762b42a2bd997a156847d42","author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"date":"2025-06-24 04:08:49.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"ac0b2366842299adc5e3235ffa935528a541c387","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2025-06-27 16:21:13.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e5a962cff8f40f8632fb1528b7b17328d3b9364a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-06-27 16:21:34.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"8a7ebbf0fb0a2c8acc01187c064e6f5576095e05","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2025-06-27 16:23:18.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8151e568ee5f272063d8d15ca216b63925c246d2","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-06-27 16:59:14.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c2e9fa476cb84766b689cf54b3197e8c\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/60f6689fb60c467fb4eab5ac366848fd : SUCCESS in 4m 27s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/38c595c06db94c1eaf74a874daa8cafe : SUCCESS in 5m 34s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/dc89b846023741ee842286dc51f4bbef : SUCCESS in 5m 53s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b69cda6e6aa3414da45d87c581e69636 : SUCCESS in 9m 06s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/43cbe1fe38804050a41be1353bee5e6c : SUCCESS in 3m 22s\n- watcher-tempest-functional https://zuul.opendev.org/t/openstack/build/be1616eaa7b84d79805b69125510704c : SUCCESS in 33m 01s\n- watcher-tempest-functional-jammy https://zuul.opendev.org/t/openstack/build/15f42dff546345bbbe66089ab382299e : SUCCESS in 28m 17s\n- watcher-tempest-functional-ipv6-only https://zuul.opendev.org/t/openstack/build/f2ee653960e44daf9c0666760e26ca87 : SUCCESS in 30m 40s","accounts_in_message":[],"_revision_number":1},{"id":"6504d9f6dc4dd2d05e4b0e8e54935c464696b124","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-06-27 16:59:14.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"bdbe2a1b1bda67507e138e38cc7f4b695827e6db","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-06-27 17:00:09.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/6d86f83cb13544c99b8cdf4ba2ec069b\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e26efe14ce00463b96f871d590d0cd29 : SUCCESS in 41s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/d0bfb5704ea6490c883dd4811f149af5 : SUCCESS in 45s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"fb85b27ae3c60f414bd6fba59a1de88a61050b24","revisions":{"fb85b27ae3c60f414bd6fba59a1de88a61050b24":{"kind":"REWORK","_number":1,"created":"2025-06-20 16:35:40.000000000","uploader":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"ref":"refs/changes/99/952999/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/watcher","ref":"refs/changes/99/952999/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/watcher refs/changes/99/952999/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/watcher refs/changes/99/952999/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/watcher refs/changes/99/952999/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/watcher refs/changes/99/952999/1"}}},"commit":{"parents":[{"commit":"f4bfb105252fe674562ecc4a4c138603d60dd72d","subject":"[host_maintenance] Pass des hostname in add_action solution","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/f4bfb105252fe674562ecc4a4c138603d60dd72d"}]}],"author":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2025-06-10 09:25:31.000000000","tz":120},"committer":{"name":"Alfredo Moralejo","email":"amoralej@redhat.com","date":"2025-06-20 16:35:40.000000000","tz":0},"subject":"Use KiB as unit for host_ram_usage when using prometheus datasource","message":"Use KiB as unit for host_ram_usage when using prometheus datasource\n\nThe prometheus datasource was reporting host_ram_usage in MiB as\ndescribed in the docstring for the base datasource interface\ndefinition [1].\n\nHowever, the gnocchi datasource is reporting it in KiB following\nceilometer metric `hardware.memory.used` [2] and the strategies\nusing that metric expect it to be in KiB so the best approach is\nto change the unit in the prometheus datasource and update the\ndocstring to avoid missunderstandings in future. So, this patch\nis fixing the prometheus datasource to return host_ram_usage\nin KiB instead of MiB.\n\nAdditionally, it is adding more unit tests for the check_threshold\nmethod so that it covers the memory based strategy execution, validates\nthe calculated standard deviation and adds the cases where it is below\nthe threshold.\n\n[1] https://github.com/openstack/watcher/blob/15981117ee28627f235264e505e1e0d5956cf4e4/watcher/decision_engine/datasources/base.py#L177-L183\n[2] https://docs.openstack.org/ceilometer/train/admin/telemetry-measurements.html#snmp-based-meters\n\nCloses-Bug: #2113776\nChange-Id: Idc060d1e709c0265c64ada16062c3a206c6b04fa\n(cherry picked from commit 6ea362da0ba49dc58ded46647fc9a4d1befe7de0)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/fb85b27ae3c60f414bd6fba59a1de88a61050b24"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/watcher/commit/fb85b27ae3c60f414bd6fba59a1de88a61050b24"}]},"branch":"refs/heads/stable/2025.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}