)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"59ea5d0a249ae98d77844f42a57250820809ac9a","unresolved":true,"context_lines":[{"line_number":12,"context_line":"It just adds a new nullable column to the required tables and add tests"},{"line_number":13,"context_line":"for it."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Note that I am  also introducing a fix in a previous tables tests which"},{"line_number":16,"context_line":"will be affected by the changes in the objects."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint add-skip-actions"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1b92ffce_28f5391b","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":47},"updated":"2025-08-18 18:05:54.000000000","message":"something that we need to worry about backporting?","commit_id":"e3533162150088c44aa003dadefe5997c61bb006"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"15ffe04548cb94c0a7f3f628c406629113142b35","unresolved":true,"context_lines":[{"line_number":12,"context_line":"It just adds a new nullable column to the required tables and add tests"},{"line_number":13,"context_line":"for it."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Note that I am  also introducing a fix in a previous tables tests which"},{"line_number":16,"context_line":"will be affected by the changes in the objects."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint add-skip-actions"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"93b61490_3717ed17","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":47},"in_reply_to":"1b92ffce_28f5391b","updated":"2025-08-19 08:01:50.000000000","message":"the issue only affects for changes introducing new fields in the actionplan object which is not something i expect to backport, so, I\u0027d say we will not need to backport it.","commit_id":"e3533162150088c44aa003dadefe5997c61bb006"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"6fab8cfa002a9de80a2999e44ad1de4e026b5640","unresolved":true,"context_lines":[{"line_number":12,"context_line":"It just adds a new nullable column to the required tables and add tests"},{"line_number":13,"context_line":"for it."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Note that I am  also introducing a fix in a previous tables tests which"},{"line_number":16,"context_line":"will be affected by the changes in the objects."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements: blueprint add-skip-actions"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"15c1abbe_be22d971","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":47},"in_reply_to":"93b61490_3717ed17","updated":"2025-08-19 11:14:19.000000000","message":"ack, thanks","commit_id":"e3533162150088c44aa003dadefe5997c61bb006"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"945c75c43ec05f7fb82e0f006556d3bbae995125","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7eb9ba03_f503fa4b","updated":"2025-07-17 08:54:07.000000000","message":"Over all looks good. But found some issues with Action Respons.\nBelow is my analysis.\nstatus_message can be seen in response table and json schema\n- https://1bcba0107328c2231f4f-454ae315be67c120ece17a0c344becbf.ssl.cf1.rackcdn.com/openstack/c0dc732cd4bc46d58d316de6e5ca847f/docs/index.html#list-action-plan-detailed\n- https://1bcba0107328c2231f4f-454ae315be67c120ece17a0c344becbf.ssl.cf1.rackcdn.com/openstack/c0dc732cd4bc46d58d316de6e5ca847f/docs/index.html#show-action-plan\n- https://1bcba0107328c2231f4f-454ae315be67c120ece17a0c344becbf.ssl.cf1.rackcdn.com/openstack/c0dc732cd4bc46d58d316de6e5ca847f/docs/index.html#create-audit\n- https://1bcba0107328c2231f4f-454ae315be67c120ece17a0c344becbf.ssl.cf1.rackcdn.com/openstack/c0dc732cd4bc46d58d316de6e5ca847f/docs/index.html#list-audit-detailed\n- https://1bcba0107328c2231f4f-454ae315be67c120ece17a0c344becbf.ssl.cf1.rackcdn.com/openstack/c0dc732cd4bc46d58d316de6e5ca847f/docs/index.html#show-audit\n\nStatus message missing(Not seen in response table but seen in json schema)\n- https://1bcba0107328c2231f4f-454ae315be67c120ece17a0c344becbf.ssl.cf1.rackcdn.com/openstack/c0dc732cd4bc46d58d316de6e5ca847f/docs/index.html#list-action-detailed (Not seen in response table but seen in json schema)\n- https://1bcba0107328c2231f4f-454ae315be67c120ece17a0c344becbf.ssl.cf1.rackcdn.com/openstack/c0dc732cd4bc46d58d316de6e5ca847f/docs/index.html#show-action\n\nI think we need to add similar change like https://review.opendev.org/c/openstack/watcher/+/954745/1/api-ref/source/watcher-api-v1-actionplans.inc in https://github.com/openstack/watcher/blob/master/api-ref/source/watcher-api-v1-actions.inc.\n\nDue to that, I am setting -1.","commit_id":"89c0e2a600ae39e02b68dc291e35b0cf1726cf50"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"1823f403211f920545ac1e9946ee8ba5f9387c0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8c206f26_ca2d63de","in_reply_to":"7eb9ba03_f503fa4b","updated":"2025-07-17 12:41:10.000000000","message":"You are correct, i will fix it.\n\nThanks!","commit_id":"89c0e2a600ae39e02b68dc291e35b0cf1726cf50"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"b72ba7ee7811e4e17c4b90634c9d4528c4d36d66","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b5ff22af_16e1b89b","updated":"2025-07-18 06:11:55.000000000","message":"recheck after skipping tempest tests https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/955302","commit_id":"adea5d6073f376573a36ab13017bc7744d0bdfaf"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"ac5d56ae2278531cb137d28e0a982d8f8d75c76e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"43be2687_173b64a7","in_reply_to":"b5ff22af_16e1b89b","updated":"2025-07-22 06:41:35.000000000","message":"Done","commit_id":"adea5d6073f376573a36ab13017bc7744d0bdfaf"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"c691f33a8422c66dea362616418206b239dffdda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"595179c2_8319c9da","updated":"2025-07-23 05:03:31.000000000","message":"Thank you @amoralej@redhat.com for addressing all the concerns. Much better now.","commit_id":"e9235fd33d1267565a7d3e385844f470d8d8009e"}],"watcher/db/sqlalchemy/alembic/versions/7150a7d8f228_add_status_message_to_actionplan.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a3a074bb30a4310d215d3a992ad6e38d6a96df8a","unresolved":true,"context_lines":[{"line_number":8,"context_line":"down_revision \u003d \u002715f7375ca737\u0027"},{"line_number":9,"context_line":"from alembic import op"},{"line_number":10,"context_line":"import sqlalchemy as sa"},{"line_number":11,"context_line":"def upgrade():"},{"line_number":12,"context_line":"    op.add_column(\u0027action_plans\u0027,"},{"line_number":13,"context_line":"        sa.Column(\u0027status_message\u0027, sa.String(length\u003d255), nullable\u003dTrue)"},{"line_number":14,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":6,"id":"0a99fabf_0fc4f2ff","line":11,"updated":"2025-08-21 14:05:51.000000000","message":"hum im surpsied this passed our linitng rules since your meant to have 2 empty lines proceeding a function or class defined at module scope\n\nwe may not be enforcing that for the alembic migration but we should look into this in the future and fix this.\n\nalso imports shoudl be before the revison and down revesiosn constants.\n\nit should look like this\n\nhttps://github.com/openstack/watcher/blob/master/watcher/db/sqlalchemy/alembic/versions/15f7375ca737_change_efficiacy_indicator_decimals.py\n\nalthough that only has one space so obviously we are not properly enforcign the rule \nbut we do follow that convetion elsewhere\n\nhttps://github.com/openstack/watcher/blob/master/watcher/db/sqlalchemy/alembic/versions/3cfc94cecf4e_add_name_for_audit.py\n\n\nlet add that to the list of cleanups fo rthie feature but its not enough to block on in my opinion.","commit_id":"84742be8c25c32a06e35bcaa584c4f4a44999276"}],"watcher/tests/db/test_migrations.py":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"eb04ee5783eefa471872f03c644a095e56d77efd","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        self.engine \u003d enginefacade.writer.get_engine()"},{"line_number":57,"context_line":"        self.dbapi \u003d dbapi.get_instance()"},{"line_number":58,"context_line":"        self.alembic_config \u003d migration._alembic_config()"},{"line_number":59,"context_line":"        self.revisions_tested \u003d set([\"7150a7d8f228\"])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def _apply_migration(self, connection, revision):"},{"line_number":62,"context_line":"        if revision not in self.revisions_tested:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ba1d920_800c6f46","line":59,"updated":"2025-07-16 10:55:14.000000000","message":"this variable should contain all the alembic revisions that have testing, so add the new one instead of replacing the existing","commit_id":"89c0e2a600ae39e02b68dc291e35b0cf1726cf50"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"c818a1c482143fb7a9cf619cec3ac44c1ecc0418","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        self.engine \u003d enginefacade.writer.get_engine()"},{"line_number":57,"context_line":"        self.dbapi \u003d dbapi.get_instance()"},{"line_number":58,"context_line":"        self.alembic_config \u003d migration._alembic_config()"},{"line_number":59,"context_line":"        self.revisions_tested \u003d set([\"7150a7d8f228\"])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def _apply_migration(self, connection, revision):"},{"line_number":62,"context_line":"        if revision not in self.revisions_tested:"}],"source_content_type":"text/x-python","patch_set":1,"id":"f76768ca_2a83ec36","line":59,"in_reply_to":"9ba1d920_800c6f46","updated":"2025-07-17 12:47:11.000000000","message":"Thanks!","commit_id":"89c0e2a600ae39e02b68dc291e35b0cf1726cf50"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"ac5d56ae2278531cb137d28e0a982d8f8d75c76e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.engine \u003d enginefacade.writer.get_engine()"},{"line_number":57,"context_line":"        self.dbapi \u003d dbapi.get_instance()"},{"line_number":58,"context_line":"        self.alembic_config \u003d migration._alembic_config()"},{"line_number":59,"context_line":"        self.revisions_tested \u003d set([\"7150a7d8f228\"])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def _apply_migration(self, connection, revision):"},{"line_number":62,"context_line":"        if revision not in self.revisions_tested:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad52dc0_9ffddb84","line":59,"in_reply_to":"f76768ca_2a83ec36","updated":"2025-07-22 06:41:35.000000000","message":"Done","commit_id":"89c0e2a600ae39e02b68dc291e35b0cf1726cf50"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"3a6cbe78240881b0ff94901b9c1185ef991da88a","unresolved":true,"context_lines":[{"line_number":135,"context_line":"                    )"},{"line_number":136,"context_line":"                ).one()"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def _pre_upgrade_15f7375ca737(self, connection):"},{"line_number":139,"context_line":"        \"\"\"Add data to the database before applying the 15f7375ca737 revision."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        This data will then be checked after applying the revision to ensure it"}],"source_content_type":"text/x-python","patch_set":2,"id":"bb2cd741_08086044","line":138,"updated":"2025-07-18 11:39:32.000000000","message":"The tests are failing here. \n```\n  File \"/home/zuul/src/opendev.org/openstack/watcher/watcher/tests/db/test_migrations.py\", line 258, in test_migration_revisions\n    self._apply_migration(connection, revision)\n  File \"/home/zuul/src/opendev.org/openstack/watcher/watcher/tests/db/test_migrations.py\", line 69, in _apply_migration\n    pre_upgrade(connection)\n  File \"/home/zuul/src/opendev.org/openstack/watcher/watcher/tests/db/test_migrations.py\", line 153, in _pre_upgrade_15f7375ca737\n    self.audit \u003d utils.create_test_audit(\n    \n pymysql.err.OperationalError: (1054, \"Unknown column \u0027audits.status_message\u0027 in \u0027field list\u0027\")\n```\nDo We need to drop status_message from audit here?\nfor this one https://review.opendev.org/c/openstack/watcher/+/954745/2/watcher/db/sqlalchemy/alembic/versions/7150a7d8f228_add_status_message_to_actionplan.py#11 \n\ndown_revision \u003d \u002715f7375ca737\u0027, Do we also need a downgrade method to drop status_message field?","commit_id":"adea5d6073f376573a36ab13017bc7744d0bdfaf"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"ac5d56ae2278531cb137d28e0a982d8f8d75c76e","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                    )"},{"line_number":136,"context_line":"                ).one()"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def _pre_upgrade_15f7375ca737(self, connection):"},{"line_number":139,"context_line":"        \"\"\"Add data to the database before applying the 15f7375ca737 revision."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        This data will then be checked after applying the revision to ensure it"}],"source_content_type":"text/x-python","patch_set":2,"id":"33eb9b5e_3038aa2c","line":138,"in_reply_to":"6488bff0_b24749f9","updated":"2025-07-22 06:41:35.000000000","message":"Done","commit_id":"adea5d6073f376573a36ab13017bc7744d0bdfaf"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"f672f8bbbf5f0fb0e09a0a52ef817246edac6714","unresolved":true,"context_lines":[{"line_number":135,"context_line":"                    )"},{"line_number":136,"context_line":"                ).one()"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def _pre_upgrade_15f7375ca737(self, connection):"},{"line_number":139,"context_line":"        \"\"\"Add data to the database before applying the 15f7375ca737 revision."},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        This data will then be checked after applying the revision to ensure it"}],"source_content_type":"text/x-python","patch_set":2,"id":"6488bff0_b24749f9","line":138,"in_reply_to":"bb2cd741_08086044","updated":"2025-07-18 11:55:37.000000000","message":"wrt the downgrade, iiuc openstack does not support downgrading and the consensus is not to provide downgrade method in the alembic migrations.\n\nwrt the testing, we have been discusing in irc, see https://meetings.opendev.org/irclogs/%23openstack-watcher/%23openstack-watcher.2025-07-18.log.html#openstack-watcher.2025-07-18.log.html#t2025-07-18T08:20:03","commit_id":"adea5d6073f376573a36ab13017bc7744d0bdfaf"}]}