)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"095ef4b5a9baa78ff490958747945004fd5d54c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f441342d_9f8d5527","updated":"2025-08-07 20:25:10.000000000","message":"LGTM","commit_id":"cb12d246af8dfa6ea6804e42c247a3be9bc90582"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"227949baa08014053ecc64e2800d041a8fa0dfe2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f45d6340_37e4934a","updated":"2025-08-21 13:54:05.000000000","message":"i think this is also ok but we shoudl clean up the debug_message fucntion later","commit_id":"1fb89aeac3deb2b8a0cb33f20a965535267e68ac"}],"watcher/applier/actions/nop.py":[{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"166cef1e9837687e29d96c92ab128c84ceb1ccfb","unresolved":true,"context_lines":[{"line_number":74,"context_line":"    def execute(self):"},{"line_number":75,"context_line":"        LOG.debug(self.debug_message(self.message))"},{"line_number":76,"context_line":"        if self.input_parameters.get(\u0027fail_execute\u0027):"},{"line_number":77,"context_line":"            return None"},{"line_number":78,"context_line":"        return True"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def revert(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ac0df61_b46d4017","line":77,"updated":"2025-08-14 15:04:22.000000000","message":"why return `None` and not `False`?","commit_id":"cb12d246af8dfa6ea6804e42c247a3be9bc90582"},{"author":{"_account_id":34452,"name":"Joan Gilabert","display_name":"jgilaber","email":"jgilaber@redhat.com","username":"jgilaber"},"change_message_id":"1c0ab77aa7654d5cb018f3dd3e65f37ab13c5aed","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    def execute(self):"},{"line_number":75,"context_line":"        LOG.debug(self.debug_message(self.message))"},{"line_number":76,"context_line":"        if self.input_parameters.get(\u0027fail_execute\u0027):"},{"line_number":77,"context_line":"            return None"},{"line_number":78,"context_line":"        return True"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def revert(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"eb5d6c8f_10efd174","line":77,"in_reply_to":"3f2d804e_fe9481a2","updated":"2025-08-19 11:19:01.000000000","message":"Done","commit_id":"cb12d246af8dfa6ea6804e42c247a3be9bc90582"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"49d94db2b2400cd2cad25454c637c8f16f971bb4","unresolved":true,"context_lines":[{"line_number":74,"context_line":"    def execute(self):"},{"line_number":75,"context_line":"        LOG.debug(self.debug_message(self.message))"},{"line_number":76,"context_line":"        if self.input_parameters.get(\u0027fail_execute\u0027):"},{"line_number":77,"context_line":"            return None"},{"line_number":78,"context_line":"        return True"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def revert(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f2d804e_fe9481a2","line":77,"in_reply_to":"7ac0df61_b46d4017","updated":"2025-08-18 07:35:15.000000000","message":"Actually, watcher only check if it\u0027s True https://github.com/openstack/watcher/blob/master/watcher/applier/workflow_engine/default.py#L152 but you are right, returning False would be more consistent","commit_id":"cb12d246af8dfa6ea6804e42c247a3be9bc90582"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"227949baa08014053ecc64e2800d041a8fa0dfe2","unresolved":true,"context_lines":[{"line_number":69,"context_line":"        return self.input_parameters.get(self.MESSAGE)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def debug_message(self, message):"},{"line_number":72,"context_line":"        return (\"Executing action NOP message: %s \", message)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def execute(self):"},{"line_number":75,"context_line":"        LOG.debug(self.debug_message(self.message))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a1f0e8b_a89391bb","line":72,"updated":"2025-08-21 13:54:05.000000000","message":"this is probably over engineered.\n\nso i would personally remove this in a followup.\n\nat most the message shoudl be a constant IMO but i would defien it inline in execute instead of creating this function.","commit_id":"1fb89aeac3deb2b8a0cb33f20a965535267e68ac"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"92c65fc6b1dd8347e85562dc9fc4250a61d5a39f","unresolved":true,"context_lines":[{"line_number":69,"context_line":"        return self.input_parameters.get(self.MESSAGE)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def debug_message(self, message):"},{"line_number":72,"context_line":"        return (\"Executing action NOP message: %s \", message)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def execute(self):"},{"line_number":75,"context_line":"        LOG.debug(self.debug_message(self.message))"}],"source_content_type":"text/x-python","patch_set":3,"id":"38903cd4_67093ac4","line":72,"in_reply_to":"5a1f0e8b_a89391bb","updated":"2025-08-21 14:20:53.000000000","message":"I did that on purpose so that i can mock it in unit tests and assert it\u0027s called with the messages i expect. there may be a better way of doing it.","commit_id":"1fb89aeac3deb2b8a0cb33f20a965535267e68ac"}]}