)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a48f9331dfc01abceacebe6c353403b89acd7b3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4b78d988_c3e86a1c","updated":"2025-08-01 20:15:45.000000000","message":"W-1: we will probably move the discovery mode to a hardcoded max/min microversion method.","commit_id":"bba89f13cb6488d7b116b2efe88d453128d93165"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"44c599e088df564562abae0853326fcb4078f18b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a4d8865_fd13e55b","updated":"2025-08-05 04:29:18.000000000","message":"lgtm, thank you!","commit_id":"adfe3858aa700751cc5a7812125fca9839395ffb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"87c8b25ebcde6cae59af2b6b22c71dd3c72c964f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b553bd7d_ed00aa01","updated":"2025-08-01 22:26:12.000000000","message":"we can backport this if needed to stable branches before fixing the tempest plugin","commit_id":"adfe3858aa700751cc5a7812125fca9839395ffb"}],"devstack/lib/watcher":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8732f3c83791a6ca8a9e4ea5e6f5ae47c17fcdcb","unresolved":true,"context_lines":[{"line_number":265,"context_line":"# configure_tempest_for_watcher() - Configure Tempest for watcher"},{"line_number":266,"context_line":"function configure_tempest_for_watcher {"},{"line_number":267,"context_line":"    # Grab the supported API micro-versions from the code"},{"line_number":268,"context_line":"    _MIN_MICROVERSION\u003d$(openstack --os-cloud devstack versions show --service resource-optimization -c \u0027Min Microversion\u0027 --status CURRENT -f value)"},{"line_number":269,"context_line":"    _MAX_MICROVERSION\u003d$(openstack --os-cloud devstack versions show --service resource-optimization -c \u0027Max Microversion\u0027 --status CURRENT -f value)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    WATCHER_TEMPEST_MIN_MICROVERSION\u003d${WATCHER_TEMPEST_MIN_MICROVERSION:-$_MIN_MICROVERSION}"},{"line_number":272,"context_line":"    WATCHER_TEMPEST_MAX_MICROVERSION\u003d${WATCHER_TEMPEST_MAX_MICROVERSION:-$_MAX_MICROVERSION}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"96bed112_3b5c69bb","line":269,"range":{"start_line":268,"start_character":0,"end_line":269,"end_character":148},"updated":"2025-08-01 18:19:22.000000000","message":"discovery is ok to avoid changing it everytime stable branch are created but with my qa hats on, I prefer it to be manually update so that we know \u0027what we want to test from service and configured the same manually\u0027. But it is up to you.","commit_id":"bba89f13cb6488d7b116b2efe88d453128d93165"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9e7f1b39ca771709cb35be972f0c7bed85f3cdaf","unresolved":true,"context_lines":[{"line_number":265,"context_line":"# configure_tempest_for_watcher() - Configure Tempest for watcher"},{"line_number":266,"context_line":"function configure_tempest_for_watcher {"},{"line_number":267,"context_line":"    # Grab the supported API micro-versions from the code"},{"line_number":268,"context_line":"    _MIN_MICROVERSION\u003d$(openstack --os-cloud devstack versions show --service resource-optimization -c \u0027Min Microversion\u0027 --status CURRENT -f value)"},{"line_number":269,"context_line":"    _MAX_MICROVERSION\u003d$(openstack --os-cloud devstack versions show --service resource-optimization -c \u0027Max Microversion\u0027 --status CURRENT -f value)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    WATCHER_TEMPEST_MIN_MICROVERSION\u003d${WATCHER_TEMPEST_MIN_MICROVERSION:-$_MIN_MICROVERSION}"},{"line_number":272,"context_line":"    WATCHER_TEMPEST_MAX_MICROVERSION\u003d${WATCHER_TEMPEST_MAX_MICROVERSION:-$_MAX_MICROVERSION}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"a1c4d990_75fec4fa","line":269,"range":{"start_line":268,"start_character":0,"end_line":269,"end_character":148},"in_reply_to":"3d8df985_e3a556e3","updated":"2025-08-01 18:23:33.000000000","message":"ah yeah, its same repo so it is easy to do.","commit_id":"bba89f13cb6488d7b116b2efe88d453128d93165"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a5cb2fdb490bdd1357148ae44b2f5e906c8c2938","unresolved":true,"context_lines":[{"line_number":265,"context_line":"# configure_tempest_for_watcher() - Configure Tempest for watcher"},{"line_number":266,"context_line":"function configure_tempest_for_watcher {"},{"line_number":267,"context_line":"    # Grab the supported API micro-versions from the code"},{"line_number":268,"context_line":"    _MIN_MICROVERSION\u003d$(openstack --os-cloud devstack versions show --service resource-optimization -c \u0027Min Microversion\u0027 --status CURRENT -f value)"},{"line_number":269,"context_line":"    _MAX_MICROVERSION\u003d$(openstack --os-cloud devstack versions show --service resource-optimization -c \u0027Max Microversion\u0027 --status CURRENT -f value)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    WATCHER_TEMPEST_MIN_MICROVERSION\u003d${WATCHER_TEMPEST_MIN_MICROVERSION:-$_MIN_MICROVERSION}"},{"line_number":272,"context_line":"    WATCHER_TEMPEST_MAX_MICROVERSION\u003d${WATCHER_TEMPEST_MAX_MICROVERSION:-$_MAX_MICROVERSION}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3d8df985_e3a556e3","line":269,"range":{"start_line":268,"start_character":0,"end_line":269,"end_character":148},"in_reply_to":"96bed112_3b5c69bb","updated":"2025-08-01 18:21:18.000000000","message":"so we dont have to change it every time the sable branch is created.\n\nwe can bump it in the patch that add the new microverison because the devstack plugin is in the same repo.","commit_id":"bba89f13cb6488d7b116b2efe88d453128d93165"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"a48f9331dfc01abceacebe6c353403b89acd7b3a","unresolved":true,"context_lines":[{"line_number":265,"context_line":"# configure_tempest_for_watcher() - Configure Tempest for watcher"},{"line_number":266,"context_line":"function configure_tempest_for_watcher {"},{"line_number":267,"context_line":"    # Grab the supported API micro-versions from the code"},{"line_number":268,"context_line":"    _MIN_MICROVERSION\u003d$(openstack --os-cloud devstack versions show --service resource-optimization -c \u0027Min Microversion\u0027 --status CURRENT -f value)"},{"line_number":269,"context_line":"    _MAX_MICROVERSION\u003d$(openstack --os-cloud devstack versions show --service resource-optimization -c \u0027Max Microversion\u0027 --status CURRENT -f value)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    WATCHER_TEMPEST_MIN_MICROVERSION\u003d${WATCHER_TEMPEST_MIN_MICROVERSION:-$_MIN_MICROVERSION}"},{"line_number":272,"context_line":"    WATCHER_TEMPEST_MAX_MICROVERSION\u003d${WATCHER_TEMPEST_MAX_MICROVERSION:-$_MAX_MICROVERSION}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ee8d2fa6_11c6eaa8","line":269,"range":{"start_line":268,"start_character":0,"end_line":269,"end_character":148},"in_reply_to":"a1c4d990_75fec4fa","updated":"2025-08-01 20:15:45.000000000","message":"Thanks for the inputs here, answering both threads here:\nRight, this is valid imo. What about keeping the max_microversion hardcoded to \"1.4\" instead of \u0027latest\u0027, as Sean suggested?\nWe just need to guarantee that every new microversion also bump this value. It will be kind of mandatory if the contributor also plan to test its changes with new watcher-tempest-plugin tests (and setting the correct min_microversion in the test class).\nWe will still need to provide this change to stable branches too, since Flamingo will probably get a new microversion.","commit_id":"bba89f13cb6488d7b116b2efe88d453128d93165"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"87c8b25ebcde6cae59af2b6b22c71dd3c72c964f","unresolved":false,"context_lines":[{"line_number":265,"context_line":"# configure_tempest_for_watcher() - Configure Tempest for watcher"},{"line_number":266,"context_line":"function configure_tempest_for_watcher {"},{"line_number":267,"context_line":"    # Grab the supported API micro-versions from the code"},{"line_number":268,"context_line":"    _MIN_MICROVERSION\u003d$(openstack --os-cloud devstack versions show --service resource-optimization -c \u0027Min Microversion\u0027 --status CURRENT -f value)"},{"line_number":269,"context_line":"    _MAX_MICROVERSION\u003d$(openstack --os-cloud devstack versions show --service resource-optimization -c \u0027Max Microversion\u0027 --status CURRENT -f value)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    WATCHER_TEMPEST_MIN_MICROVERSION\u003d${WATCHER_TEMPEST_MIN_MICROVERSION:-$_MIN_MICROVERSION}"},{"line_number":272,"context_line":"    WATCHER_TEMPEST_MAX_MICROVERSION\u003d${WATCHER_TEMPEST_MAX_MICROVERSION:-$_MAX_MICROVERSION}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"4b3519ab_8bb0c3ef","line":269,"range":{"start_line":268,"start_character":0,"end_line":269,"end_character":148},"in_reply_to":"e34a4920_242ad7a2","updated":"2025-08-01 22:26:12.000000000","message":"Acknowledged","commit_id":"bba89f13cb6488d7b116b2efe88d453128d93165"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"5685162a136328cd1f9afc8d2490382f41c25670","unresolved":true,"context_lines":[{"line_number":265,"context_line":"# configure_tempest_for_watcher() - Configure Tempest for watcher"},{"line_number":266,"context_line":"function configure_tempest_for_watcher {"},{"line_number":267,"context_line":"    # Grab the supported API micro-versions from the code"},{"line_number":268,"context_line":"    _MIN_MICROVERSION\u003d$(openstack --os-cloud devstack versions show --service resource-optimization -c \u0027Min Microversion\u0027 --status CURRENT -f value)"},{"line_number":269,"context_line":"    _MAX_MICROVERSION\u003d$(openstack --os-cloud devstack versions show --service resource-optimization -c \u0027Max Microversion\u0027 --status CURRENT -f value)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    WATCHER_TEMPEST_MIN_MICROVERSION\u003d${WATCHER_TEMPEST_MIN_MICROVERSION:-$_MIN_MICROVERSION}"},{"line_number":272,"context_line":"    WATCHER_TEMPEST_MAX_MICROVERSION\u003d${WATCHER_TEMPEST_MAX_MICROVERSION:-$_MAX_MICROVERSION}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"e34a4920_242ad7a2","line":269,"range":{"start_line":268,"start_character":0,"end_line":269,"end_character":148},"in_reply_to":"ee8d2fa6_11c6eaa8","updated":"2025-08-01 20:38:55.000000000","message":"Patch updated with hardcoded max_microversion to \"1.4\"\nAlso removed the depends-on of the plugin change[1], I will put the dependency there instead, so we can merge watcher changes first. And I will set the default values there to \u0027None\u0027.\n\n[1] https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/956306","commit_id":"bba89f13cb6488d7b116b2efe88d453128d93165"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2ad7b439cdd3ad997234452113d2dc783f071152","unresolved":true,"context_lines":[{"line_number":274,"context_line":"    # Set microversion options in tempest.conf"},{"line_number":275,"context_line":"    iniset $TEMPEST_CONFIG optimize min_microversion $WATCHER_TEMPEST_MIN_MICROVERSION"},{"line_number":276,"context_line":"    iniset $TEMPEST_CONFIG optimize max_microversion $WATCHER_TEMPEST_MAX_MICROVERSION"},{"line_number":277,"context_line":"}"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"# Restore xtrace"},{"line_number":280,"context_line":"$_XTRACE_WATCHER"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3614ac2f_3a8bb840","line":277,"updated":"2025-08-01 15:18:35.000000000","message":"why are you doing this dynmicly?\n\nmax does not need to be set and min can be set unset or hard-coded to 1.0 once tests are fixed","commit_id":"bba89f13cb6488d7b116b2efe88d453128d93165"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"fc7742a6f4cf6e5be8adeaa1c740046a1ad04686","unresolved":true,"context_lines":[{"line_number":274,"context_line":"    # Set microversion options in tempest.conf"},{"line_number":275,"context_line":"    iniset $TEMPEST_CONFIG optimize min_microversion $WATCHER_TEMPEST_MIN_MICROVERSION"},{"line_number":276,"context_line":"    iniset $TEMPEST_CONFIG optimize max_microversion $WATCHER_TEMPEST_MAX_MICROVERSION"},{"line_number":277,"context_line":"}"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"# Restore xtrace"},{"line_number":280,"context_line":"$_XTRACE_WATCHER"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"74f0e919_995c15fa","line":277,"in_reply_to":"3614ac2f_3a8bb840","updated":"2025-08-01 16:56:17.000000000","message":"to set the correct max microversion in stable jobs/deploys\nand yes, the min could be hardcoded for now","commit_id":"bba89f13cb6488d7b116b2efe88d453128d93165"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"36a682f551f9504cdcf21c89362340037ca10b1d","unresolved":true,"context_lines":[{"line_number":274,"context_line":"    # Set microversion options in tempest.conf"},{"line_number":275,"context_line":"    iniset $TEMPEST_CONFIG optimize min_microversion $WATCHER_TEMPEST_MIN_MICROVERSION"},{"line_number":276,"context_line":"    iniset $TEMPEST_CONFIG optimize max_microversion $WATCHER_TEMPEST_MAX_MICROVERSION"},{"line_number":277,"context_line":"}"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"# Restore xtrace"},{"line_number":280,"context_line":"$_XTRACE_WATCHER"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"8c9c80b0_157cc1ab","line":277,"in_reply_to":"74f0e919_995c15fa","updated":"2025-08-01 17:35:26.000000000","message":"maybe we could do that directly in the watcher-tempest-plugin, when min or max is set to None.","commit_id":"bba89f13cb6488d7b116b2efe88d453128d93165"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"31a9b013230e81576cd66667998787b04699db9a","unresolved":true,"context_lines":[{"line_number":274,"context_line":"    # Set microversion options in tempest.conf"},{"line_number":275,"context_line":"    iniset $TEMPEST_CONFIG optimize min_microversion $WATCHER_TEMPEST_MIN_MICROVERSION"},{"line_number":276,"context_line":"    iniset $TEMPEST_CONFIG optimize max_microversion $WATCHER_TEMPEST_MAX_MICROVERSION"},{"line_number":277,"context_line":"}"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"# Restore xtrace"},{"line_number":280,"context_line":"$_XTRACE_WATCHER"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"2d5c863c_d5c777eb","line":277,"in_reply_to":"8c9c80b0_157cc1ab","updated":"2025-08-01 18:18:52.000000000","message":"ok spoke to gmann \n\nthe bit that i was missing is that for core service this is manage for us in devstack and set automaticlly in the relevent branch before release.\n\nso we can do the same\n\nfor master it can default to the lates microversion and on stable we can hardcode it in the stabel version fo the devstack plugin.\n\nwhat i woudl suggest is just setting this to 1.4 for now\n\nand when we increase teh microversion for a new api we can also increase it in the devstack plugin in the same pathc\n\nthat way each stable branch will naturally track the corect max version for that release\n\nthat is basiclly following what they do in devstack\nhttps://review.opendev.org/c/openstack/devstack/+/945240","commit_id":"bba89f13cb6488d7b116b2efe88d453128d93165"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8732f3c83791a6ca8a9e4ea5e6f5ae47c17fcdcb","unresolved":true,"context_lines":[{"line_number":274,"context_line":"    # Set microversion options in tempest.conf"},{"line_number":275,"context_line":"    iniset $TEMPEST_CONFIG optimize min_microversion $WATCHER_TEMPEST_MIN_MICROVERSION"},{"line_number":276,"context_line":"    iniset $TEMPEST_CONFIG optimize max_microversion $WATCHER_TEMPEST_MAX_MICROVERSION"},{"line_number":277,"context_line":"}"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"# Restore xtrace"},{"line_number":280,"context_line":"$_XTRACE_WATCHER"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"b331eff1_51732bb0","line":277,"in_reply_to":"8c9c80b0_157cc1ab","updated":"2025-08-01 18:19:22.000000000","message":"we need to set those to decide Tempest to run or skip the test which are capped with the min and max microversion. We do the same for devsdtack own services in devstack where \n\n- Master: we set min_microversion as None and max_microversion as \u0027latest\u0027 - so that all the tests can be run - https://github.com/openstack/devstack/blob/94d036ff8090fef0998315367cb6a8c233e5ed09/lib/tempest#L489-L490\n\n- Stable: Cap max_microversion to max available micrversion of that release: example: https://review.opendev.org/c/openstack/devstack/+/945240","commit_id":"bba89f13cb6488d7b116b2efe88d453128d93165"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"87c8b25ebcde6cae59af2b6b22c71dd3c72c964f","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    # Set microversion options in tempest.conf"},{"line_number":275,"context_line":"    iniset $TEMPEST_CONFIG optimize min_microversion $WATCHER_TEMPEST_MIN_MICROVERSION"},{"line_number":276,"context_line":"    iniset $TEMPEST_CONFIG optimize max_microversion $WATCHER_TEMPEST_MAX_MICROVERSION"},{"line_number":277,"context_line":"}"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"# Restore xtrace"},{"line_number":280,"context_line":"$_XTRACE_WATCHER"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"dd1f8eb2_455b1f5a","line":277,"in_reply_to":"b331eff1_51732bb0","updated":"2025-08-01 22:26:12.000000000","message":"Acknowledged","commit_id":"bba89f13cb6488d7b116b2efe88d453128d93165"}]}
